usb: dwc3: qcom: Honor wakeup enabled/disabled state
The dwc3-qcom currently enables wakeup interrupts unconditionally
when suspending, however this should not be done when wakeup is
disabled (e.g. through the sysfs attribute power/wakeup). Only
enable wakeup interrupts when device_may_wakeup() returns true.
Fixes: a4333c3a6b ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210302103659.v2.1.I44954d9e1169f2cf5c44e6454d357c75ddfa99a2@changeid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
			
			
This commit is contained in:
		
							parent
							
								
									cc2ac63d4c
								
							
						
					
					
						commit
						2664deb093
					
				| @ -358,8 +358,10 @@ static int dwc3_qcom_suspend(struct dwc3_qcom *qcom) | ||||
| 	if (ret) | ||||
| 		dev_warn(qcom->dev, "failed to disable interconnect: %d\n", ret); | ||||
| 
 | ||||
| 	if (device_may_wakeup(qcom->dev)) | ||||
| 		dwc3_qcom_enable_interrupts(qcom); | ||||
| 
 | ||||
| 	qcom->is_suspended = true; | ||||
| 	dwc3_qcom_enable_interrupts(qcom); | ||||
| 
 | ||||
| 	return 0; | ||||
| } | ||||
| @ -372,7 +374,8 @@ static int dwc3_qcom_resume(struct dwc3_qcom *qcom) | ||||
| 	if (!qcom->is_suspended) | ||||
| 		return 0; | ||||
| 
 | ||||
| 	dwc3_qcom_disable_interrupts(qcom); | ||||
| 	if (device_may_wakeup(qcom->dev)) | ||||
| 		dwc3_qcom_disable_interrupts(qcom); | ||||
| 
 | ||||
| 	for (i = 0; i < qcom->num_clocks; i++) { | ||||
| 		ret = clk_prepare_enable(qcom->clks[i]); | ||||
|  | ||||
		Loading…
	
		Reference in New Issue
	
	Block a user