leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hwrng: mxc-rnga - Use devm_ioremap_resource()

Browse Source 
Using devm_ioremap_resource() can make the code cleaner and simpler.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Fabio Estevam 2013-03-13 00:57:27 -03:00 committed by Herbert Xu
parent cb7d5662d7
commit 264878e6a7
1 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/char/hw_random/mxc-rnga.c
View File

@ -142,7 +142,7 @@ static void mxc_rnga_cleanup(struct hwrng *rng)
static int __init mxc_rnga_probe(struct platform_device *pdev) static int __init mxc_rnga_probe(struct platform_device *pdev)
{ {
int err = -ENODEV; int err = -ENODEV;
struct resource *res, *mem; struct resource *res;
struct mxc_rng *mxc_rng; struct mxc_rng *mxc_rng;
mxc_rng = devm_kzalloc(&pdev->dev, sizeof(struct mxc_rng), mxc_rng = devm_kzalloc(&pdev->dev, sizeof(struct mxc_rng),
@ -172,15 +172,9 @@ static int __init mxc_rnga_probe(struct platform_device *pdev)
goto err_region; goto err_region;
} }
mem = request_mem_region(res->start, resource_size(res), pdev->name); mxc_rng->mem = devm_ioremap_resource(&pdev->dev, res);
if (mem == NULL) { if (IS_ERR(mxc_rng->mem)) {
err = -EBUSY; err = PTR_ERR(mxc_rng->mem);
goto err_region;
}
mxc_rng->mem = ioremap(res->start, resource_size(res));
if (!mxc_rng->mem) {
err = -ENOMEM;
goto err_ioremap; goto err_ioremap;
} }
@ -195,8 +189,6 @@ static int __init mxc_rnga_probe(struct platform_device *pdev)
return 0; return 0;
err_ioremap: err_ioremap:
release_mem_region(res->start, resource_size(res));
err_region: err_region:
clk_disable_unprepare(mxc_rng->clk); clk_disable_unprepare(mxc_rng->clk);
@ -206,15 +198,10 @@ out:
static int __exit mxc_rnga_remove(struct platform_device *pdev) static int __exit mxc_rnga_remove(struct platform_device *pdev)
{ {
struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
struct mxc_rng *mxc_rng = platform_get_drvdata(pdev); struct mxc_rng *mxc_rng = platform_get_drvdata(pdev);
hwrng_unregister(&mxc_rng->rng); hwrng_unregister(&mxc_rng->rng);
iounmap(mxc_rng->mem);
release_mem_region(res->start, resource_size(res));
clk_disable_unprepare(mxc_rng->clk); clk_disable_unprepare(mxc_rng->clk);
return 0; return 0;