leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

infiniband: hfi1: fix memory leaks

Browse Source 
In fault_opcodes_write(), 'data' is allocated through kcalloc(). However,
it is not deallocated in the following execution if an error occurs,
leading to memory leaks. To fix this issue, introduce the 'free_data' label
to free 'data' before returning the error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Link: https://lore.kernel.org/r/1566154486-3713-1-git-send-email-wenwen@cs.uga.edu
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Wenwen Wang
2019-08-18 13:54:46 -05:00
committed by Doug Ledford
parent b08afa064c
commit 2323d7baab
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/infiniband/hw/hfi1/fault.c
View File

@@ -141,12 +141,14 @@ static ssize_t fault_opcodes_write(struct file *file, const char __user *buf,
if (!data) if (!data)
return -ENOMEM; return -ENOMEM;
copy = min(len, datalen - 1); copy = min(len, datalen - 1);
if (copy_from_user(data, buf, copy)) if (copy_from_user(data, buf, copy)) {
return -EFAULT; ret = -EFAULT;
goto free_data;
}
ret = debugfs_file_get(file->f_path.dentry); ret = debugfs_file_get(file->f_path.dentry);
if (unlikely(ret)) if (unlikely(ret))
return ret; goto free_data;
ptr = data; ptr = data;
token = ptr; token = ptr;
for (ptr = data; *ptr; ptr = end + 1, token = ptr) { for (ptr = data; *ptr; ptr = end + 1, token = ptr) {
@@ -195,6 +197,7 @@ static ssize_t fault_opcodes_write(struct file *file, const char __user *buf,
ret = len; ret = len;
debugfs_file_put(file->f_path.dentry); debugfs_file_put(file->f_path.dentry);
free_data:
kfree(data); kfree(data);
return ret; return ret;
} }