forked from Minki/linux
pinctrl-tegra: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a return from the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ local idexpression n; expression e,e1; @@ for_each_child_of_node(e1,n) { ... ( of_node_put(n); | e = n | return n; | + of_node_put(n); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
0eccc9cb4c
commit
21a8fe8863
@ -253,8 +253,10 @@ static int tegra_xusb_padctl_dt_node_to_map(struct pinctrl_dev *pinctrl,
|
|||||||
err = tegra_xusb_padctl_parse_subnode(padctl, np, maps,
|
err = tegra_xusb_padctl_parse_subnode(padctl, np, maps,
|
||||||
&reserved_maps,
|
&reserved_maps,
|
||||||
num_maps);
|
num_maps);
|
||||||
if (err < 0)
|
if (err < 0) {
|
||||||
|
of_node_put(np);
|
||||||
return err;
|
return err;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
|
@ -217,6 +217,7 @@ static int tegra_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
|
|||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
pinctrl_utils_dt_free_map(pctldev, *map,
|
pinctrl_utils_dt_free_map(pctldev, *map,
|
||||||
*num_maps);
|
*num_maps);
|
||||||
|
of_node_put(np);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user