leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

powerpc/eeh: powerpc/eeh: Fix undefined variable

Browse Source 
changes for V4:
	- changes the type of frozen_pe_no from %d to %llu
	  in pr_devel()

'pe_no' hasn't been defined, it should be an typo error,
it should be 'frozen_pe_no'.

Also '__func__' has missed in IODA_EEH_DBG(),

For safety reasons, use pr_devel() directly, instead
of use IODA_EEH_DBG()

Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
Mike Qiu 2013-08-12 02:15:36 -04:00 committed by Benjamin Herrenschmidt
parent 5ba840ec54
commit 202127031a
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
arch/powerpc/platforms/powernv/eeh-ioda.c
View File

@ -36,13 +36,6 @@
#include "powernv.h" #include "powernv.h"
#include "pci.h" #include "pci.h"
/* Debugging option */
#ifdef IODA_EEH_DBG_ON
#define IODA_EEH_DBG(args...) pr_info(args)
#else
#define IODA_EEH_DBG(args...)
#endif
static char *hub_diag = NULL; static char *hub_diag = NULL;
static int ioda_eeh_nb_init = 0; static int ioda_eeh_nb_init = 0;
@ -823,17 +816,17 @@ static int ioda_eeh_next_error(struct eeh_pe **pe)
/* If OPAL API returns error, we needn't proceed */ /* If OPAL API returns error, we needn't proceed */
if (rc != OPAL_SUCCESS) { if (rc != OPAL_SUCCESS) {
IODA_EEH_DBG("%s: Invalid return value on " pr_devel("%s: Invalid return value on "
"PHB#%x (0x%lx) from opal_pci_next_error", "PHB#%x (0x%lx) from opal_pci_next_error",
__func__, hose->global_number, rc); __func__, hose->global_number, rc);
continue; continue;
} }
/* If the PHB doesn't have error, stop processing */ /* If the PHB doesn't have error, stop processing */
if (err_type == OPAL_EEH_NO_ERROR || if (err_type == OPAL_EEH_NO_ERROR ||
severity == OPAL_EEH_SEV_NO_ERROR) { severity == OPAL_EEH_SEV_NO_ERROR) {
IODA_EEH_DBG("%s: No error found on PHB#%x\n", pr_devel("%s: No error found on PHB#%x\n",
__func__, hose->global_number); __func__, hose->global_number);
continue; continue;
} }
@ -842,8 +835,9 @@ static int ioda_eeh_next_error(struct eeh_pe **pe)
* highest priority reported upon multiple errors on the * highest priority reported upon multiple errors on the
* specific PHB. * specific PHB.
*/ */
IODA_EEH_DBG("%s: Error (%d, %d, %d) on PHB#%x\n", pr_devel("%s: Error (%d, %d, %llu) on PHB#%x\n",
err_type, severity, pe_no, hose->global_number); __func__, err_type, severity,
frozen_pe_no, hose->global_number);
switch (err_type) { switch (err_type) {
case OPAL_EEH_IOC_ERROR: case OPAL_EEH_IOC_ERROR:
if (severity == OPAL_EEH_SEV_IOC_DEAD) { if (severity == OPAL_EEH_SEV_IOC_DEAD) {