leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bnx2x: Fix static checker warning regarding `txdata_ptr'

Browse Source 
Incorrect checking of array instead of array contents in panic_dump
flow - results of commit e261199872 ("bnx2x: Safe bnx2x_panic_dump()").

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Yuval Mintz
2014-08-26 10:24:41 +03:00
committed by David S. Miller
parent b0b46c7766
commit 1fc3de9407
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
View File

@@ -985,7 +985,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
/* Tx */ /* Tx */
for_each_cos_in_tx_queue(fp, cos) for_each_cos_in_tx_queue(fp, cos)
{ {
if (!fp->txdata_ptr) if (!fp->txdata_ptr[cos])
break; break;
txdata = *fp->txdata_ptr[cos]; txdata = *fp->txdata_ptr[cos];
@@ -1140,7 +1140,7 @@ void bnx2x_panic_dump(struct bnx2x *bp, bool disable_int)
for_each_cos_in_tx_queue(fp, cos) { for_each_cos_in_tx_queue(fp, cos) {
struct bnx2x_fp_txdata *txdata = fp->txdata_ptr[cos]; struct bnx2x_fp_txdata *txdata = fp->txdata_ptr[cos];
if (!fp->txdata_ptr) if (!fp->txdata_ptr[cos])
break; break;
if (!txdata->tx_cons_sb) if (!txdata->tx_cons_sb)