leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

btrfs: drop useless goto in open_fs_devices

Browse Source 
There is no need of goto out in open_fs_devices() as there is nothing
special done there.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Anand Jain 2020-04-28 23:22:25 +08:00 committed by David Sterba
parent 0bc2d3c08e
commit 1ed802c972
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/btrfs/volumes.c
View File

@ -1185,7 +1185,6 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices,
{ {
struct btrfs_device *device; struct btrfs_device *device;
struct btrfs_device *latest_dev = NULL; struct btrfs_device *latest_dev = NULL;
int ret = 0;
flags |= FMODE_EXCL; flags |= FMODE_EXCL;
@ -1198,16 +1197,15 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices,
device->generation > latest_dev->generation) device->generation > latest_dev->generation)
latest_dev = device; latest_dev = device;
} }
if (fs_devices->open_devices == 0) { if (fs_devices->open_devices == 0)
ret = -EINVAL; return -EINVAL;
goto out;
}
fs_devices->opened = 1; fs_devices->opened = 1;
fs_devices->latest_bdev = latest_dev->bdev; fs_devices->latest_bdev = latest_dev->bdev;
fs_devices->total_rw_bytes = 0; fs_devices->total_rw_bytes = 0;
fs_devices->chunk_alloc_policy = BTRFS_CHUNK_ALLOC_REGULAR; fs_devices->chunk_alloc_policy = BTRFS_CHUNK_ALLOC_REGULAR;
out:
return ret; return 0;
} }
static int devid_cmp(void *priv, struct list_head *a, struct list_head *b) static int devid_cmp(void *priv, struct list_head *a, struct list_head *b)