leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

crypto: amcc - remove incorrect __init/__exit markups

Browse Source 
Even if bus is not hot-pluggable, the devices can be bound and unbound
from the driver via sysfs, so we should not be using __init/__exit
annotations on probe() and remove() methods. The only exception is
drivers registered with platform_driver_probe() which specifically
disables sysfs bind/unbind attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Dmitry Torokhov 2015-03-09 13:35:39 -07:00 committed by Herbert Xu
parent 83ce01d24a
commit 1eb8a1b340
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/crypto/amcc/crypto4xx_core.c
View File

@ -1155,7 +1155,7 @@ struct crypto4xx_alg_common crypto4xx_alg[] = {
/** /**
* Module Initialization Routine * Module Initialization Routine
*/ */
static int __init crypto4xx_probe(struct platform_device *ofdev) static int crypto4xx_probe(struct platform_device *ofdev)
{ {
int rc; int rc;
struct resource res; struct resource res;
@ -1263,7 +1263,7 @@ err_alloc_dev:
return rc; return rc;
} }
static int __exit crypto4xx_remove(struct platform_device *ofdev) static int crypto4xx_remove(struct platform_device *ofdev)
{ {
struct device *dev = &ofdev->dev; struct device *dev = &ofdev->dev;
struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev); struct crypto4xx_core_device *core_dev = dev_get_drvdata(dev);
@ -1291,7 +1291,7 @@ static struct platform_driver crypto4xx_driver = {
.of_match_table = crypto4xx_match, .of_match_table = crypto4xx_match,
}, },
.probe = crypto4xx_probe, .probe = crypto4xx_probe,
.remove = __exit_p(crypto4xx_remove), .remove = crypto4xx_remove,
}; };
module_platform_driver(crypto4xx_driver); module_platform_driver(crypto4xx_driver);