leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dmaengine: mmp_tdma: Let the core do the device node validation

Browse Source 
Let the DMA engine core do the device node validation instead of drivers.

Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Baolin Wang 2019-05-20 19:32:18 +08:00 committed by Vinod Koul
parent c88ba7b940
commit 1d967195fd
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/dma/mmp_tdma.c
View File

@ -586,18 +586,12 @@ static int mmp_tdma_chan_init(struct mmp_tdma_device *tdev,
} }
struct mmp_tdma_filter_param { struct mmp_tdma_filter_param {
struct device_node *of_node;
unsigned int chan_id; unsigned int chan_id;
}; };
static bool mmp_tdma_filter_fn(struct dma_chan *chan, void *fn_param) static bool mmp_tdma_filter_fn(struct dma_chan *chan, void *fn_param)
{ {
struct mmp_tdma_filter_param *param = fn_param; struct mmp_tdma_filter_param *param = fn_param;
struct mmp_tdma_chan *tdmac = to_mmp_tdma_chan(chan);
struct dma_device *pdma_device = tdmac->chan.device;
if (pdma_device->dev->of_node != param->of_node)
return false;
if (chan->chan_id != param->chan_id) if (chan->chan_id != param->chan_id)
return false; return false;
@ -615,13 +609,13 @@ static struct dma_chan *mmp_tdma_xlate(struct of_phandle_args *dma_spec,
if (dma_spec->args_count != 1) if (dma_spec->args_count != 1)
return NULL; return NULL;
param.of_node = ofdma->of_node;
param.chan_id = dma_spec->args[0]; param.chan_id = dma_spec->args[0];
if (param.chan_id >= TDMA_CHANNEL_NUM) if (param.chan_id >= TDMA_CHANNEL_NUM)
return NULL; return NULL;
return dma_request_channel(mask, mmp_tdma_filter_fn, &param); return __dma_request_channel(&mask, mmp_tdma_filter_fn, &param,
ofdma->of_node);
} }
static const struct of_device_id mmp_tdma_dt_ids[] = { static const struct of_device_id mmp_tdma_dt_ids[] = {