leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

media: radio: si476x: no need to check return value of debugfs_create functions

Browse Source 
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Greg Kroah-Hartman 2020-08-18 15:36:07 +02:00 committed by Mauro Carvalho Chehab
parent 8c23f41129
commit 1d8f95c497
1 changed files with 13 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
drivers/media/radio/radio-si476x.c
View File

@ -1344,60 +1344,24 @@ static const struct file_operations radio_rsq_primary_fops = {
};
static int si476x_radio_init_debugfs(struct si476x_radio *radio)
static void si476x_radio_init_debugfs(struct si476x_radio *radio)
{
struct dentry *dentry;
int ret;
radio->debugfs = debugfs_create_dir(dev_name(radio->v4l2dev.dev), NULL);
dentry = debugfs_create_dir(dev_name(radio->v4l2dev.dev), NULL);
if (IS_ERR(dentry)) {
ret = PTR_ERR(dentry);
goto exit;
}
radio->debugfs = dentry;
debugfs_create_file("acf", S_IRUGO, radio->debugfs, radio,
&radio_acf_fops);
dentry = debugfs_create_file("acf", S_IRUGO,
radio->debugfs, radio, &radio_acf_fops);
if (IS_ERR(dentry)) {
ret = PTR_ERR(dentry);
goto cleanup;
}
debugfs_create_file("rds_blckcnt", S_IRUGO, radio->debugfs, radio,
&radio_rds_blckcnt_fops);
dentry = debugfs_create_file("rds_blckcnt", S_IRUGO,
radio->debugfs, radio,
&radio_rds_blckcnt_fops);
if (IS_ERR(dentry)) {
ret = PTR_ERR(dentry);
goto cleanup;
}
debugfs_create_file("agc", S_IRUGO, radio->debugfs, radio,
&radio_agc_fops);
dentry = debugfs_create_file("agc", S_IRUGO,
radio->debugfs, radio, &radio_agc_fops);
if (IS_ERR(dentry)) {
ret = PTR_ERR(dentry);
goto cleanup;
}
debugfs_create_file("rsq", S_IRUGO, radio->debugfs, radio,
&radio_rsq_fops);
dentry = debugfs_create_file("rsq", S_IRUGO,
radio->debugfs, radio, &radio_rsq_fops);
if (IS_ERR(dentry)) {
ret = PTR_ERR(dentry);
goto cleanup;
}
dentry = debugfs_create_file("rsq_primary", S_IRUGO,
radio->debugfs, radio,
&radio_rsq_primary_fops);
if (IS_ERR(dentry)) {
ret = PTR_ERR(dentry);
goto cleanup;
}
return 0;
cleanup:
debugfs_remove_recursive(radio->debugfs);
exit:
return ret;
debugfs_create_file("rsq_primary", S_IRUGO, radio->debugfs, radio,
&radio_rsq_primary_fops);
}
@ -1534,11 +1498,7 @@ static int si476x_radio_probe(struct platform_device *pdev)
goto exit;
}
rval = si476x_radio_init_debugfs(radio);
if (rval < 0) {
dev_err(&pdev->dev, "Could not create debugfs interface\n");
goto exit;
}
si476x_radio_init_debugfs(radio);
return 0;
exit: