leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fat: Kill d_invalidate() in vfat_lookup()

Browse Source 
d_invalidate() for positive dentry doesn't work in some cases
(vfsmount, nfsd, and maybe others). shrink_dcache_parent() by
d_invalidate() is pointless for vfat usage at all.

So, this kills it, and intead of it uses d_move().

To save old behavior, this returns alias simply for directory (don't
change pwd, etc..). the directory lookup shouldn't be important for
performance.

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
OGAWA Hirofumi 2008-11-06 12:53:52 -08:00 committed by Linus Torvalds
parent 1b52467243
commit 1c13a243a4
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
fs/fat/namei_vfat.c
View File

@ -745,13 +745,12 @@ static struct dentry *vfat_lookup(struct inode *dir, struct dentry *dentry,
* *
* Switch to new one for reason of locality if possible. * Switch to new one for reason of locality if possible.
*/ */
if (d_invalidate(alias) == 0) BUG_ON(d_unhashed(alias));
dput(alias); if (!S_ISDIR(inode->i_mode))
else { d_move(alias, dentry);
iput(inode); iput(inode);
unlock_super(sb); unlock_super(sb);
return alias; return alias;
}
} }
out: out:
unlock_super(sb); unlock_super(sb);