leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "dma-mapping: clear dev->dma_ops in arch_teardown_dma_ops"

Browse Source 
This reverts commit 46053c7368.

This change breaks architectures setting up dma_ops in their own magic
way and not using arch_setup_dma_ops, so revert it.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Christoph Hellwig 2018-09-25 13:16:55 -07:00
parent 9406a49fd1
commit 1a0afc14b5
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
arch/arm64/include/asm/dma-mapping.h
View File

@ -39,6 +39,11 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
const struct iommu_ops *iommu, bool coherent); const struct iommu_ops *iommu, bool coherent);
#define arch_setup_dma_ops arch_setup_dma_ops #define arch_setup_dma_ops arch_setup_dma_ops
#ifdef CONFIG_IOMMU_DMA
void arch_teardown_dma_ops(struct device *dev);
#define arch_teardown_dma_ops arch_teardown_dma_ops
#endif
/* do not use this function in a driver */ /* do not use this function in a driver */
static inline bool is_device_dma_coherent(struct device *dev) static inline bool is_device_dma_coherent(struct device *dev)
{ {

5
arch/arm64/mm/dma-mapping.c
View File

@ -862,6 +862,11 @@ out_err:
dev_name(dev)); dev_name(dev));
} }
void arch_teardown_dma_ops(struct device *dev)
{
dev->dma_ops = NULL;
}
#else #else
static void __iommu_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, static void __iommu_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,

5
include/linux/dma-mapping.h
View File

@ -665,10 +665,7 @@ static inline void arch_setup_dma_ops(struct device *dev, u64 dma_base,
#endif #endif
#ifndef arch_teardown_dma_ops #ifndef arch_teardown_dma_ops
static inline void arch_teardown_dma_ops(struct device *dev) static inline void arch_teardown_dma_ops(struct device *dev) { }
{
dev->dma_ops = NULL;
}
#endif #endif
static inline unsigned int dma_get_max_seg_size(struct device *dev) static inline unsigned int dma_get_max_seg_size(struct device *dev)