forked from Minki/linux
nl80211: relax ht operation checks for mesh
Commit9757235f45
, "nl80211: correct checks for NL80211_MESHCONF_HT_OPMODE value") relaxed the range for the HT operation field in meshconf, while also adding checks requiring the non-greenfield and non-ht-sta bits to be set in certain circumstances. The latter bit is actually reserved for mesh BSSes according to Table 9-168 in 802.11-2016, so in fact it should not be set. wpa_supplicant sets these bits because the mesh and AP code share the same implementation, but authsae does not. As a result, some meshconf updates from authsae which set only the NONHT_MIXED protection bits were being rejected. In order to avoid breaking userspace by changing the rules again, simply accept the values with or without the bits set, and mask off the reserved bit to match the spec. While in here, update the 802.11-2012 reference to 802.11-2016. Fixes:9757235f45
("nl80211: correct checks for NL80211_MESHCONF_HT_OPMODE value") Cc: Masashi Honma <masashi.honma@gmail.com> Signed-off-by: Bob Copeland <bobcopeland@fb.com> Reviewed-by: Masashi Honma <masashi.honma@gmail.com> Reviewed-by: Masashi Honma <masashi.honma@gmail.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
parent
e7441c9274
commit
188f60ab8e
@ -6231,7 +6231,7 @@ do { \
|
|||||||
nl80211_check_s32);
|
nl80211_check_s32);
|
||||||
/*
|
/*
|
||||||
* Check HT operation mode based on
|
* Check HT operation mode based on
|
||||||
* IEEE 802.11 2012 8.4.2.59 HT Operation element.
|
* IEEE 802.11-2016 9.4.2.57 HT Operation element.
|
||||||
*/
|
*/
|
||||||
if (tb[NL80211_MESHCONF_HT_OPMODE]) {
|
if (tb[NL80211_MESHCONF_HT_OPMODE]) {
|
||||||
ht_opmode = nla_get_u16(tb[NL80211_MESHCONF_HT_OPMODE]);
|
ht_opmode = nla_get_u16(tb[NL80211_MESHCONF_HT_OPMODE]);
|
||||||
@ -6241,22 +6241,9 @@ do { \
|
|||||||
IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT))
|
IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT))
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
if ((ht_opmode & IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT) &&
|
/* NON_HT_STA bit is reserved, but some programs set it */
|
||||||
(ht_opmode & IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT))
|
ht_opmode &= ~IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT;
|
||||||
return -EINVAL;
|
|
||||||
|
|
||||||
switch (ht_opmode & IEEE80211_HT_OP_MODE_PROTECTION) {
|
|
||||||
case IEEE80211_HT_OP_MODE_PROTECTION_NONE:
|
|
||||||
case IEEE80211_HT_OP_MODE_PROTECTION_20MHZ:
|
|
||||||
if (ht_opmode & IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT)
|
|
||||||
return -EINVAL;
|
|
||||||
break;
|
|
||||||
case IEEE80211_HT_OP_MODE_PROTECTION_NONMEMBER:
|
|
||||||
case IEEE80211_HT_OP_MODE_PROTECTION_NONHT_MIXED:
|
|
||||||
if (!(ht_opmode & IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT))
|
|
||||||
return -EINVAL;
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
cfg->ht_opmode = ht_opmode;
|
cfg->ht_opmode = ht_opmode;
|
||||||
mask |= (1 << (NL80211_MESHCONF_HT_OPMODE - 1));
|
mask |= (1 << (NL80211_MESHCONF_HT_OPMODE - 1));
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user