leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hwrng: bcm2835 - Use device managed helpers

Browse Source 
Now that we have moved the RNG disabling into a hwrng::cleanup callback,
we can use the device managed registration operation and remove our
remove callback since it won't do anything necessary.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Florian Fainelli 2017-11-07 16:44:42 -08:00 committed by Herbert Xu
parent ec94bca7be
commit 16a4c04b37
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/char/hw_random/bcm2835-rng.c
View File

@ -138,7 +138,7 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
rng_setup(priv->base); rng_setup(priv->base);
/* register driver */ /* register driver */
err = hwrng_register(&priv->rng); err = devm_hwrng_register(dev, &priv->rng);
if (err) if (err)
dev_err(dev, "hwrng registration failed\n"); dev_err(dev, "hwrng registration failed\n");
else else
@ -147,16 +147,6 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
return err; return err;
} }
static int bcm2835_rng_remove(struct platform_device *pdev)
{
struct bcm2835_rng_priv *priv = platform_get_drvdata(pdev);
/* unregister driver */
hwrng_unregister(&priv->rng);
return 0;
}
MODULE_DEVICE_TABLE(of, bcm2835_rng_of_match); MODULE_DEVICE_TABLE(of, bcm2835_rng_of_match);
static struct platform_driver bcm2835_rng_driver = { static struct platform_driver bcm2835_rng_driver = {
@ -165,7 +155,6 @@ static struct platform_driver bcm2835_rng_driver = {
.of_match_table = bcm2835_rng_of_match, .of_match_table = bcm2835_rng_of_match,
}, },
.probe = bcm2835_rng_probe, .probe = bcm2835_rng_probe,
.remove = bcm2835_rng_remove,
}; };
module_platform_driver(bcm2835_rng_driver); module_platform_driver(bcm2835_rng_driver);