leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ice: Reduce scope of variable in ice_vsi_cfg_rxqs

Browse Source 
Reduce scope of the variable 'err' to inside the for loop instead
of using it as a second looping conditional. Also while here,
improve the debug message if we fail to configure a Rx queue.

Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
Brett Creeley 2019-02-28 15:25:51 -08:00 committed by Jeff Kirsher
parent fe7219fa7c
commit 1553f4f77a
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/net/ethernet/intel/ice/ice_lib.c
View File

@ -1641,7 +1641,6 @@ int ice_vsi_kill_vlan(struct ice_vsi *vsi, u16 vid)
*/ */
int ice_vsi_cfg_rxqs(struct ice_vsi *vsi) int ice_vsi_cfg_rxqs(struct ice_vsi *vsi)
{ {
int err = 0;
u16 i; u16 i;
if (vsi->type == ICE_VSI_VF) if (vsi->type == ICE_VSI_VF)
@ -1656,14 +1655,19 @@ int ice_vsi_cfg_rxqs(struct ice_vsi *vsi)
vsi->rx_buf_len = ICE_RXBUF_2048; vsi->rx_buf_len = ICE_RXBUF_2048;
setup_rings: setup_rings:
/* set up individual rings */ /* set up individual rings */
for (i = 0; i < vsi->num_rxq && !err; i++) for (i = 0; i < vsi->num_rxq; i++) {
err = ice_setup_rx_ctx(vsi->rx_rings[i]); int err;
if (err) { err = ice_setup_rx_ctx(vsi->rx_rings[i]);
dev_err(&vsi->back->pdev->dev, "ice_setup_rx_ctx failed\n"); if (err) {
return -EIO; dev_err(&vsi->back->pdev->dev,
"ice_setup_rx_ctx failed for RxQ %d, err %d\n",
i, err);
return err;
}
} }
return err;
return 0;
} }
/** /**