leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/nouveau/mmu: qualify vmm during dtor

Browse Source 
If the BAR initialization failed it may leave the vmm structure in an
unitialized state, leading to a null-pointer-dereference when the vmm is
dereferenced during teardown.

Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
This commit is contained in:
Jon Derrick 2019-03-15 18:05:18 -06:00 committed by Ben Skeggs
parent 12e08beb32
commit 15516bf9ab
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmm.c
View File

@ -1783,7 +1783,7 @@ nvkm_vmm_get(struct nvkm_vmm *vmm, u8 page, u64 size, struct nvkm_vma **pvma)
void void
nvkm_vmm_part(struct nvkm_vmm *vmm, struct nvkm_memory *inst) nvkm_vmm_part(struct nvkm_vmm *vmm, struct nvkm_memory *inst)
{ {
if (inst && vmm->func->part) { if (inst && vmm && vmm->func->part) {
mutex_lock(&vmm->mutex); mutex_lock(&vmm->mutex);
vmm->func->part(vmm, inst); vmm->func->part(vmm, inst);
mutex_unlock(&vmm->mutex); mutex_unlock(&vmm->mutex);