leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

swsusp: fix error paths in snapshot_open

Browse Source 
We forget to increase device_available if there's an error in snapshot_open(),
so the snapshot device cannot be open at all after snapshot_open() has
returned an error.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Rafael J. Wysocki 2007-05-06 14:50:44 -07:00 committed by Linus Torvalds
parent 04293355ac
commit 1525a2ad76
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/power/user.c
View File

@ -49,12 +49,14 @@ static int snapshot_open(struct inode *inode, struct file *filp)
if (!atomic_add_unless(&device_available, -1, 0))
return -EBUSY;
if ((filp->f_flags & O_ACCMODE) == O_RDWR)
if ((filp->f_flags & O_ACCMODE) == O_RDWR) {
atomic_inc(&device_available);
return -ENOSYS;
if(create_basic_memory_bitmaps())
}
if(create_basic_memory_bitmaps()) {
atomic_inc(&device_available);
return -ENOMEM;
}
nonseekable_open(inode, filp);
data = &snapshot_state;
filp->private_data = data;