leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

firewire: core: fix an information leak

Browse Source 
If a device exposes a sparsely populated configuration ROM,
firewire-core's sysfs interface and character device file interface
showed random data in the gaps between config ROM blocks.  Fix this by
zero-initialization of the config ROM reader's scratch buffer.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
Stefan Richter 2010-02-19 21:00:02 +01:00
parent 58aaa54276
commit 137d9ebfdb
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/firewire/core-device.c
View File

@ -514,6 +514,7 @@ static int read_bus_info_block(struct fw_device *device, int generation)
return -ENOMEM; return -ENOMEM;
stack = &rom[READ_BIB_ROM_SIZE]; stack = &rom[READ_BIB_ROM_SIZE];
memset(rom, 0, sizeof(*rom) * READ_BIB_ROM_SIZE);
device->max_speed = SCODE_100; device->max_speed = SCODE_100;