leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hv_netvsc: Reset the RSC count if NVSP_STAT_FAIL in netvsc_receive()

Browse Source 
Commit 4414418595 ("hv_netvsc: Add validation for untrusted Hyper-V
values") added validation to rndis_filter_receive_data() (and
rndis_filter_receive()) which introduced NVSP_STAT_FAIL-scenarios where
the count is not updated/reset.  Fix this omission, and prevent similar
scenarios from occurring in the future.

Reported-by: Juan Vazquez <juvazq@microsoft.com>
Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Fixes: 4414418595 ("hv_netvsc: Add validation for untrusted Hyper-V values")
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Link: https://lore.kernel.org/r/20210203113602.558916-1-parri.andrea@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Andrea Parri (Microsoft) 2021-02-03 12:36:02 +01:00 committed by Jakub Kicinski
parent 52cbd23a11
commit 12bc8dfb83
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/hyperv/netvsc.c
View File

@ -1262,8 +1262,11 @@ static int netvsc_receive(struct net_device *ndev,
ret = rndis_filter_receive(ndev, net_device, ret = rndis_filter_receive(ndev, net_device,
nvchan, data, buflen); nvchan, data, buflen);
if (unlikely(ret != NVSP_STAT_SUCCESS)) if (unlikely(ret != NVSP_STAT_SUCCESS)) {
/* Drop incomplete packet */
nvchan->rsc.cnt = 0;
status = NVSP_STAT_FAIL; status = NVSP_STAT_FAIL;
}
} }
enq_receive_complete(ndev, net_device, q_idx, enq_receive_complete(ndev, net_device, q_idx,

2
drivers/net/hyperv/rndis_filter.c
View File

@ -509,8 +509,6 @@ static int rndis_filter_receive_data(struct net_device *ndev,
return ret; return ret;
drop: drop:
/* Drop incomplete packet */
nvchan->rsc.cnt = 0;
return NVSP_STAT_FAIL; return NVSP_STAT_FAIL;
} }