forked from Minki/linux
V4L/DVB: video/saa7134: change dprintk() to i2cdprintk()
The problem is that dprintk() dereferences "dev" which is null here. The i2cdprintk() uses "ir" so that's OK. Also Jean Delvare pointed out a typo in the comment so we may as well fix that. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
f0e5481f2f
commit
129c34d8fc
@ -141,8 +141,8 @@ static int get_key_flydvb_trio(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
|
||||
struct saa7134_dev *dev = ir->c->adapter->algo_data;
|
||||
|
||||
if (dev == NULL) {
|
||||
dprintk("get_key_flydvb_trio: "
|
||||
"gir->c->adapter->algo_data is NULL!\n");
|
||||
i2cdprintk("get_key_flydvb_trio: "
|
||||
"ir->c->adapter->algo_data is NULL!\n");
|
||||
return -EIO;
|
||||
}
|
||||
|
||||
@ -195,8 +195,8 @@ static int get_key_msi_tvanywhere_plus(struct IR_i2c *ir, u32 *ir_key,
|
||||
/* <dev> is needed to access GPIO. Used by the saa_readl macro. */
|
||||
struct saa7134_dev *dev = ir->c->adapter->algo_data;
|
||||
if (dev == NULL) {
|
||||
dprintk("get_key_msi_tvanywhere_plus: "
|
||||
"gir->c->adapter->algo_data is NULL!\n");
|
||||
i2cdprintk("get_key_msi_tvanywhere_plus: "
|
||||
"ir->c->adapter->algo_data is NULL!\n");
|
||||
return -EIO;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user