leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

iio: dummy_evgen: Fix use after free on error in iio_dummy_evgen_create()

Browse Source 
We need to preserve the "iio_evgen->irq_sim_domain" error code before
we free "iio_evgen" otherwise it leads to a use after free.

Fixes: 337cbeb2c1 ("genirq/irq_sim: Simplify the API")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
This commit is contained in:
Dan Carpenter 2020-05-20 15:03:06 +03:00 committed by Marc Zyngier
parent c5d6082d35
commit 128516e49d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/iio/dummy/iio_dummy_evgen.c
View File

@ -45,6 +45,8 @@ static struct iio_dummy_eventgen *iio_evgen;
static int iio_dummy_evgen_create(void) static int iio_dummy_evgen_create(void)
{ {
int ret;
iio_evgen = kzalloc(sizeof(*iio_evgen), GFP_KERNEL); iio_evgen = kzalloc(sizeof(*iio_evgen), GFP_KERNEL);
if (!iio_evgen) if (!iio_evgen)
return -ENOMEM; return -ENOMEM;
@ -52,8 +54,9 @@ static int iio_dummy_evgen_create(void)
iio_evgen->irq_sim_domain = irq_domain_create_sim(NULL, iio_evgen->irq_sim_domain = irq_domain_create_sim(NULL,
IIO_EVENTGEN_NO); IIO_EVENTGEN_NO);
if (IS_ERR(iio_evgen->irq_sim_domain)) { if (IS_ERR(iio_evgen->irq_sim_domain)) {
ret = PTR_ERR(iio_evgen->irq_sim_domain);
kfree(iio_evgen); kfree(iio_evgen);
return PTR_ERR(iio_evgen->irq_sim_domain); return ret;
} }
mutex_init(&iio_evgen->lock); mutex_init(&iio_evgen->lock);