leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arm64: add missing printk newlines

Browse Source 
A few printk calls in arm64 omit a trailing newline, even though there
is no subsequent KERN_CONT printk associated with them, and we actually
want a newline.

This can result in unrelated lines being appended, rather than appearing
on a new line. Additionally, timestamp prefixes may appear in-line. This
makes the logs harder to read than necessary.

Avoid this by adding a trailing newline.

These were found with a shortlist generated by:

$ git grep 'pr\(intk\|_.*\)(.*)' -- arch/arm64 | grep -v pr_fmt | grep -v '\\n"'

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
CC: James Morse <james.morse@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
This commit is contained in:
Mark Rutland 2017-01-09 14:13:36 +00:00 committed by Will Deacon
parent 8f4b326d66
commit 117f5727ae
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/arm64/kernel/armv8_deprecated.c
View File

@ -636,7 +636,7 @@ static int __init armv8_deprecated_init(void)
if(system_supports_mixed_endian_el0()) if(system_supports_mixed_endian_el0())
register_insn_emulation(&setend_ops); register_insn_emulation(&setend_ops);
else else
pr_info("setend instruction emulation is not supported on the system"); pr_info("setend instruction emulation is not supported on this system\n");
} }
cpuhp_setup_state_nocalls(CPUHP_AP_ARM64_ISNDEP_STARTING, cpuhp_setup_state_nocalls(CPUHP_AP_ARM64_ISNDEP_STARTING,

6
arch/arm64/kernel/hibernate.c
View File

@ -472,7 +472,7 @@ int swsusp_arch_resume(void)
*/ */
tmp_pg_dir = (pgd_t *)get_safe_page(GFP_ATOMIC); tmp_pg_dir = (pgd_t *)get_safe_page(GFP_ATOMIC);
if (!tmp_pg_dir) { if (!tmp_pg_dir) {
pr_err("Failed to allocate memory for temporary page tables."); pr_err("Failed to allocate memory for temporary page tables.\n");
rc = -ENOMEM; rc = -ENOMEM;
goto out; goto out;
} }
@ -492,7 +492,7 @@ int swsusp_arch_resume(void)
*/ */
zero_page = (void *)get_safe_page(GFP_ATOMIC); zero_page = (void *)get_safe_page(GFP_ATOMIC);
if (!zero_page) { if (!zero_page) {
pr_err("Failed to allocate zero page."); pr_err("Failed to allocate zero page.\n");
rc = -ENOMEM; rc = -ENOMEM;
goto out; goto out;
} }
@ -512,7 +512,7 @@ int swsusp_arch_resume(void)
&phys_hibernate_exit, &phys_hibernate_exit,
(void *)get_safe_page, GFP_ATOMIC); (void *)get_safe_page, GFP_ATOMIC);
if (rc) { if (rc) {
pr_err("Failed to create safe executable page for hibernate_exit code."); pr_err("Failed to create safe executable page for hibernate_exit code.\n");
goto out; goto out;
} }