leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i7300_edac: Add a FIXME note about the error correction type

Browse Source 
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mauro Carvalho Chehab
2010-08-26 23:19:54 -03:00
parent c3af2eaf7a
commit 116389ed21
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/edac/i7300_edac.c
View File

@@ -841,6 +841,15 @@ static int decode_mtr(struct i7300_pvt *pvt,
p_csrow->grain = 8; p_csrow->grain = 8;
p_csrow->nr_pages = dinfo->megabytes << 8; p_csrow->nr_pages = dinfo->megabytes << 8;
p_csrow->mtype = MEM_FB_DDR2; p_csrow->mtype = MEM_FB_DDR2;
/*
* FIXME: the type of error detection actually depends of the
* mode of operation. When it is just one single memory chip, at
* socket 0, channel 0, it uses 8-byte-over-32-byte SECDED+ code.
* In normal or mirrored mode, it uses Single Device Data correction,
* with the possibility of using an extended algorithm for x8 memories
* See datasheet Sections 7.3.6 to 7.3.8
*/
p_csrow->edac_mode = EDAC_S8ECD8ED; p_csrow->edac_mode = EDAC_S8ECD8ED;
/* ask what device type on this row */ /* ask what device type on this row */