leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ecryptfs: ecryptfs_msg_ctx_alloc_to_free(): remove kfree() redundant null check

Browse Source 
smatch analysis:

fs/ecryptfs/messaging.c:101 ecryptfs_msg_ctx_alloc_to_free() info:
 redundant null check on msg_ctx->msg calling kfree()

Cc: Dustin Kirkland <dustin.kirkland@gazzang.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
This commit is contained in:
Tim Gardner
2013-02-12 11:03:49 -07:00
committed by Tyler Hicks
parent 3a46741804
commit 1101d58669
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fs/ecryptfs/messaging.c
View File

@@ -97,8 +97,7 @@ static void ecryptfs_msg_ctx_free_to_alloc(struct ecryptfs_msg_ctx *msg_ctx)
void ecryptfs_msg_ctx_alloc_to_free(struct ecryptfs_msg_ctx *msg_ctx) void ecryptfs_msg_ctx_alloc_to_free(struct ecryptfs_msg_ctx *msg_ctx)
{ {
list_move(&(msg_ctx->node), &ecryptfs_msg_ctx_free_list); list_move(&(msg_ctx->node), &ecryptfs_msg_ctx_free_list);
if (msg_ctx->msg) kfree(msg_ctx->msg);
kfree(msg_ctx->msg);
msg_ctx->msg = NULL; msg_ctx->msg = NULL;
msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_FREE; msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_FREE;
} }