leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/message/i2o/driver.c: add missing destroy_workqueue() on error in i2o_driver_register()

Browse Source 
Add the missing destroy_workqueue() before return from
i2o_driver_register() in the error handling case.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Wei Yongjun 2013-11-12 15:10:24 -08:00 committed by Linus Torvalds
parent ab76786561
commit 10992435b3
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/message/i2o/driver.c
View File

@ -105,7 +105,8 @@ int i2o_driver_register(struct i2o_driver *drv)
osm_err("too many drivers registered, increase " osm_err("too many drivers registered, increase "
"max_drivers\n"); "max_drivers\n");
spin_unlock_irqrestore(&i2o_drivers_lock, flags); spin_unlock_irqrestore(&i2o_drivers_lock, flags);
return -EFAULT; rc = -EFAULT;
goto out;
} }
drv->context = i; drv->context = i;
@ -124,11 +125,14 @@ int i2o_driver_register(struct i2o_driver *drv)
} }
rc = driver_register(&drv->driver); rc = driver_register(&drv->driver);
if (rc) { if (rc)
if (drv->event) { goto out;
destroy_workqueue(drv->event_queue);
drv->event_queue = NULL; return 0;
} out:
if (drv->event_queue) {
destroy_workqueue(drv->event_queue);
drv->event_queue = NULL;
} }
return rc; return rc;