leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

greybus: minor tweak in gb_connection_recv_response()

Browse Source 
Any time we queue work on the operation work queue we need to have
set the operation errno first.

This patch moves the assignment of that field to be immediately
prior to the queue_work() call in gb_connection_recv_response(),
so it is easier to see at a glance that this has been done.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Alex Elder 2014-11-21 19:29:16 -06:00 committed by Greg Kroah-Hartman
parent deb4b9efb3
commit 0e3d0e8fad
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/greybus/operation.c
View File

@ -563,6 +563,7 @@ static void gb_connection_recv_response(struct gb_connection *connection,
struct gb_operation *operation;
struct gb_message *message;
struct gb_operation_msg_hdr *header;
int result;
operation = gb_pending_operation_find(connection, operation_id);
if (!operation) {
@ -577,17 +578,18 @@ static void gb_connection_recv_response(struct gb_connection *connection,
if (size <= message->size) {
/* Transfer the operation result from the response header */
header = message->header;
operation->errno = gb_operation_status_map(header->result);
result = gb_operation_status_map(header->result);
} else {
gb_connection_err(connection, "recv buffer too small");
operation->errno = -E2BIG;
result = -E2BIG;
}
/* We must ignore the payload if a bad status is returned */
if (!operation->errno)
if (!result)
memcpy(message->header, data, size);
/* The rest will be handled in work queue context */
operation->errno = result;
queue_work(gb_operation_workqueue, &operation->work);
}