leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pinctrl/pinctrl-u300: remove unneeded devm_kfree call

Browse Source 
the allocated memory will be destroyed at the driver unload time,
automatically if driver uses the devm_ functions, so no need of
doing devm_kfree at the error path

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Devendra Naga 2012-07-21 14:22:58 +05:45 committed by Linus Walleij
parent c43ba80082
commit 0e3ac20d9f
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/pinctrl/pinctrl-u300.c
View File

@ -1121,10 +1121,8 @@ static int __devinit u300_pmx_probe(struct platform_device *pdev)
upmx->dev = &pdev->dev; upmx->dev = &pdev->dev;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) { if (!res)
ret = -ENOENT; return -ENOENT;
goto out_no_resource;
}
upmx->phybase = res->start; upmx->phybase = res->start;
upmx->physize = resource_size(res); upmx->physize = resource_size(res);
@ -1165,8 +1163,6 @@ out_no_remap:
platform_set_drvdata(pdev, NULL); platform_set_drvdata(pdev, NULL);
out_no_memregion: out_no_memregion:
release_mem_region(upmx->phybase, upmx->physize); release_mem_region(upmx->phybase, upmx->physize);
out_no_resource:
devm_kfree(&pdev->dev, upmx);
return ret; return ret;
} }