leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

slcan: fix ldisc->open retval

Browse Source 
TTY layer expects 0 if the ldisc->open operation succeeded.

Reported-by: Matvejchikov Ilya <matvejchikov@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Oliver Hartkopp 2011-05-10 13:12:30 -07:00 committed by David S. Miller
parent aae1e743fe
commit 0d4420a90b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/can/slcan.c
View File

@ -583,7 +583,9 @@ static int slcan_open(struct tty_struct *tty)
/* Done. We have linked the TTY line to a channel. */ /* Done. We have linked the TTY line to a channel. */
rtnl_unlock(); rtnl_unlock();
tty->receive_room = 65536; /* We don't flow control */ tty->receive_room = 65536; /* We don't flow control */
return sl->dev->base_addr;
/* TTY layer expects 0 on success */
return 0;
err_free_chan: err_free_chan:
sl->tty = NULL; sl->tty = NULL;