leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: qedf: Cleanup the type of io_log->op

Browse Source 
We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so
this should also be unsigned char.  The other thing is that this is
displayed in the debugfs:

	seq_printf(s, "0x%02x:", io_log->op);

Smatch complains that the formatting won't work for negative values so
changing it to unsigned silences that warning as well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Chad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Dan Carpenter 2017-05-04 00:23:57 +03:00 committed by Martin K. Petersen
parent 0d618cf4f2
commit 0d2fc3b48b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/qedf/qedf.h
View File

@ -259,7 +259,7 @@ struct qedf_io_log {
uint16_t task_id; uint16_t task_id;
uint32_t port_id; /* Remote port fabric ID */ uint32_t port_id; /* Remote port fabric ID */
int lun; int lun;
char op; /* SCSI CDB */ unsigned char op; /* SCSI CDB */
uint8_t lba[4]; uint8_t lba[4];
unsigned int bufflen; /* SCSI buffer length */ unsigned int bufflen; /* SCSI buffer length */
unsigned int sg_count; /* Number of SG elements */ unsigned int sg_count; /* Number of SG elements */