leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

8139cp/8139too: terminate the eeprom access with the right opmode

Browse Source 
Currently, we terminate the eeprom access through clearing the CS by:

RTL_W8 (Cfg9346, ~EE_CS); or writeb (~EE_CS, ee_addr);

This would left the eeprom into "Config. Register Write Enable:"
state which is not expcted as the highest two bits were set to
0x11 ( expected is the "Normal" mode (0x00)). Solving this by write
0x0 instead of ~EE_CS when terminating the eeprom access.

Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jason Wang 2012-05-31 18:19:48 +00:00 committed by David S. Miller
parent b01af4579e
commit 0bc777bca4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/realtek/8139cp.c
View File

@ -1636,7 +1636,7 @@ static void eeprom_cmd(void __iomem *ee_addr, int cmd, int cmd_len)
static void eeprom_cmd_end(void __iomem *ee_addr) static void eeprom_cmd_end(void __iomem *ee_addr)
{ {
writeb (~EE_CS, ee_addr); writeb(0, ee_addr);
eeprom_delay (); eeprom_delay ();
} }

2
drivers/net/ethernet/realtek/8139too.c
View File

@ -1173,7 +1173,7 @@ static int __devinit read_eeprom (void __iomem *ioaddr, int location, int addr_l
} }
/* Terminate the EEPROM access. */ /* Terminate the EEPROM access. */
RTL_W8 (Cfg9346, ~EE_CS); RTL_W8(Cfg9346, 0);
eeprom_delay (); eeprom_delay ();
return retval; return retval;