mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.
This promise never materialized. And unlikely will.
We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE. And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.
Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.
Let's stop pretending that pages in page cache are special. They are
not.
The changes are pretty straight-forward:
- <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;
- PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};
- page_cache_get() -> get_page();
- page_cache_release() -> put_page();
This patch contains automated changes generated with coccinelle using
script below. For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.
The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.
There are few places in the code where coccinelle didn't reach. I'll
fix them manually in a separate patch. Comments and documentation also
will be addressed with the separate patch.
virtual patch
@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E
@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT
@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE
@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK
@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)
@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)
@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
committed by
Linus Torvalds
parent
c05c2ec96b
commit
09cbfeaf1a
@@ -3742,11 +3742,11 @@ xfs_bmap_btalloc(
|
||||
args.prod = align;
|
||||
if ((args.mod = (xfs_extlen_t)do_mod(ap->offset, args.prod)))
|
||||
args.mod = (xfs_extlen_t)(args.prod - args.mod);
|
||||
} else if (mp->m_sb.sb_blocksize >= PAGE_CACHE_SIZE) {
|
||||
} else if (mp->m_sb.sb_blocksize >= PAGE_SIZE) {
|
||||
args.prod = 1;
|
||||
args.mod = 0;
|
||||
} else {
|
||||
args.prod = PAGE_CACHE_SIZE >> mp->m_sb.sb_blocklog;
|
||||
args.prod = PAGE_SIZE >> mp->m_sb.sb_blocklog;
|
||||
if ((args.mod = (xfs_extlen_t)(do_mod(ap->offset, args.prod))))
|
||||
args.mod = (xfs_extlen_t)(args.prod - args.mod);
|
||||
}
|
||||
|
||||
@@ -704,7 +704,7 @@ next_buffer:
|
||||
|
||||
xfs_iunlock(ip, XFS_ILOCK_EXCL);
|
||||
out_invalidate:
|
||||
xfs_vm_invalidatepage(page, 0, PAGE_CACHE_SIZE);
|
||||
xfs_vm_invalidatepage(page, 0, PAGE_SIZE);
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -925,9 +925,9 @@ xfs_do_writepage(
|
||||
* ---------------------------------^------------------|
|
||||
*/
|
||||
offset = i_size_read(inode);
|
||||
end_index = offset >> PAGE_CACHE_SHIFT;
|
||||
end_index = offset >> PAGE_SHIFT;
|
||||
if (page->index < end_index)
|
||||
end_offset = (xfs_off_t)(page->index + 1) << PAGE_CACHE_SHIFT;
|
||||
end_offset = (xfs_off_t)(page->index + 1) << PAGE_SHIFT;
|
||||
else {
|
||||
/*
|
||||
* Check whether the page to write out is beyond or straddles
|
||||
@@ -940,7 +940,7 @@ xfs_do_writepage(
|
||||
* | | Straddles |
|
||||
* ---------------------------------^-----------|--------|
|
||||
*/
|
||||
unsigned offset_into_page = offset & (PAGE_CACHE_SIZE - 1);
|
||||
unsigned offset_into_page = offset & (PAGE_SIZE - 1);
|
||||
|
||||
/*
|
||||
* Skip the page if it is fully outside i_size, e.g. due to a
|
||||
@@ -971,7 +971,7 @@ xfs_do_writepage(
|
||||
* memory is zeroed when mapped, and writes to that region are
|
||||
* not written out to the file."
|
||||
*/
|
||||
zero_user_segment(page, offset_into_page, PAGE_CACHE_SIZE);
|
||||
zero_user_segment(page, offset_into_page, PAGE_SIZE);
|
||||
|
||||
/* Adjust the end_offset to the end of file */
|
||||
end_offset = offset;
|
||||
@@ -1475,7 +1475,7 @@ xfs_vm_write_failed(
|
||||
loff_t block_offset;
|
||||
loff_t block_start;
|
||||
loff_t block_end;
|
||||
loff_t from = pos & (PAGE_CACHE_SIZE - 1);
|
||||
loff_t from = pos & (PAGE_SIZE - 1);
|
||||
loff_t to = from + len;
|
||||
struct buffer_head *bh, *head;
|
||||
struct xfs_mount *mp = XFS_I(inode)->i_mount;
|
||||
@@ -1491,7 +1491,7 @@ xfs_vm_write_failed(
|
||||
* start of the page by using shifts rather than masks the mismatch
|
||||
* problem.
|
||||
*/
|
||||
block_offset = (pos >> PAGE_CACHE_SHIFT) << PAGE_CACHE_SHIFT;
|
||||
block_offset = (pos >> PAGE_SHIFT) << PAGE_SHIFT;
|
||||
|
||||
ASSERT(block_offset + from == pos);
|
||||
|
||||
@@ -1558,7 +1558,7 @@ xfs_vm_write_begin(
|
||||
struct page **pagep,
|
||||
void **fsdata)
|
||||
{
|
||||
pgoff_t index = pos >> PAGE_CACHE_SHIFT;
|
||||
pgoff_t index = pos >> PAGE_SHIFT;
|
||||
struct page *page;
|
||||
int status;
|
||||
struct xfs_mount *mp = XFS_I(mapping->host)->i_mount;
|
||||
@@ -1592,7 +1592,7 @@ xfs_vm_write_begin(
|
||||
truncate_pagecache_range(inode, start, pos + len);
|
||||
}
|
||||
|
||||
page_cache_release(page);
|
||||
put_page(page);
|
||||
page = NULL;
|
||||
}
|
||||
|
||||
|
||||
@@ -1237,7 +1237,7 @@ xfs_free_file_space(
|
||||
/* wait for the completion of any pending DIOs */
|
||||
inode_dio_wait(VFS_I(ip));
|
||||
|
||||
rounding = max_t(xfs_off_t, 1 << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE);
|
||||
rounding = max_t(xfs_off_t, 1 << mp->m_sb.sb_blocklog, PAGE_SIZE);
|
||||
ioffset = round_down(offset, rounding);
|
||||
iendoffset = round_up(offset + len, rounding) - 1;
|
||||
error = filemap_write_and_wait_range(VFS_I(ip)->i_mapping, ioffset,
|
||||
@@ -1466,7 +1466,7 @@ xfs_shift_file_space(
|
||||
if (error)
|
||||
return error;
|
||||
error = invalidate_inode_pages2_range(VFS_I(ip)->i_mapping,
|
||||
offset >> PAGE_CACHE_SHIFT, -1);
|
||||
offset >> PAGE_SHIFT, -1);
|
||||
if (error)
|
||||
return error;
|
||||
|
||||
|
||||
@@ -106,8 +106,8 @@ xfs_iozero(
|
||||
unsigned offset, bytes;
|
||||
void *fsdata;
|
||||
|
||||
offset = (pos & (PAGE_CACHE_SIZE -1)); /* Within page */
|
||||
bytes = PAGE_CACHE_SIZE - offset;
|
||||
offset = (pos & (PAGE_SIZE -1)); /* Within page */
|
||||
bytes = PAGE_SIZE - offset;
|
||||
if (bytes > count)
|
||||
bytes = count;
|
||||
|
||||
@@ -799,8 +799,8 @@ xfs_file_dio_aio_write(
|
||||
/* see generic_file_direct_write() for why this is necessary */
|
||||
if (mapping->nrpages) {
|
||||
invalidate_inode_pages2_range(mapping,
|
||||
pos >> PAGE_CACHE_SHIFT,
|
||||
end >> PAGE_CACHE_SHIFT);
|
||||
pos >> PAGE_SHIFT,
|
||||
end >> PAGE_SHIFT);
|
||||
}
|
||||
|
||||
if (ret > 0) {
|
||||
@@ -1207,9 +1207,9 @@ xfs_find_get_desired_pgoff(
|
||||
|
||||
pagevec_init(&pvec, 0);
|
||||
|
||||
index = startoff >> PAGE_CACHE_SHIFT;
|
||||
index = startoff >> PAGE_SHIFT;
|
||||
endoff = XFS_FSB_TO_B(mp, map->br_startoff + map->br_blockcount);
|
||||
end = endoff >> PAGE_CACHE_SHIFT;
|
||||
end = endoff >> PAGE_SHIFT;
|
||||
do {
|
||||
int want;
|
||||
unsigned nr_pages;
|
||||
|
||||
@@ -135,7 +135,7 @@ typedef __u32 xfs_nlink_t;
|
||||
* Size of block device i/o is parameterized here.
|
||||
* Currently the system supports page-sized i/o.
|
||||
*/
|
||||
#define BLKDEV_IOSHIFT PAGE_CACHE_SHIFT
|
||||
#define BLKDEV_IOSHIFT PAGE_SHIFT
|
||||
#define BLKDEV_IOSIZE (1<<BLKDEV_IOSHIFT)
|
||||
/* number of BB's per block device block */
|
||||
#define BLKDEV_BB BTOBB(BLKDEV_IOSIZE)
|
||||
|
||||
@@ -171,7 +171,7 @@ xfs_sb_validate_fsb_count(
|
||||
ASSERT(sbp->sb_blocklog >= BBSHIFT);
|
||||
|
||||
/* Limited by ULONG_MAX of page cache index */
|
||||
if (nblocks >> (PAGE_CACHE_SHIFT - sbp->sb_blocklog) > ULONG_MAX)
|
||||
if (nblocks >> (PAGE_SHIFT - sbp->sb_blocklog) > ULONG_MAX)
|
||||
return -EFBIG;
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -231,12 +231,12 @@ static inline unsigned long
|
||||
xfs_preferred_iosize(xfs_mount_t *mp)
|
||||
{
|
||||
if (mp->m_flags & XFS_MOUNT_COMPAT_IOSIZE)
|
||||
return PAGE_CACHE_SIZE;
|
||||
return PAGE_SIZE;
|
||||
return (mp->m_swidth ?
|
||||
(mp->m_swidth << mp->m_sb.sb_blocklog) :
|
||||
((mp->m_flags & XFS_MOUNT_DFLT_IOSIZE) ?
|
||||
(1 << (int)MAX(mp->m_readio_log, mp->m_writeio_log)) :
|
||||
PAGE_CACHE_SIZE));
|
||||
PAGE_SIZE));
|
||||
}
|
||||
|
||||
#define XFS_LAST_UNMOUNT_WAS_CLEAN(mp) \
|
||||
|
||||
@@ -293,8 +293,8 @@ xfs_fs_commit_blocks(
|
||||
* Make sure reads through the pagecache see the new data.
|
||||
*/
|
||||
error = invalidate_inode_pages2_range(inode->i_mapping,
|
||||
start >> PAGE_CACHE_SHIFT,
|
||||
(end - 1) >> PAGE_CACHE_SHIFT);
|
||||
start >> PAGE_SHIFT,
|
||||
(end - 1) >> PAGE_SHIFT);
|
||||
WARN_ON_ONCE(error);
|
||||
|
||||
error = xfs_iomap_write_unwritten(ip, start, length);
|
||||
|
||||
@@ -570,10 +570,10 @@ xfs_max_file_offset(
|
||||
#if BITS_PER_LONG == 32
|
||||
# if defined(CONFIG_LBDAF)
|
||||
ASSERT(sizeof(sector_t) == 8);
|
||||
pagefactor = PAGE_CACHE_SIZE;
|
||||
pagefactor = PAGE_SIZE;
|
||||
bitshift = BITS_PER_LONG;
|
||||
# else
|
||||
pagefactor = PAGE_CACHE_SIZE >> (PAGE_CACHE_SHIFT - blockshift);
|
||||
pagefactor = PAGE_SIZE >> (PAGE_SHIFT - blockshift);
|
||||
# endif
|
||||
#endif
|
||||
|
||||
|
||||
Reference in New Issue
Block a user