leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/vmwgfx: Optimize the buffer object swap_notify callback somewhat.

Browse Source 
Only try to unmap cached maps when the buffer is moved into or out from
vram. Otherwise the underlying pages stay the same.

Also when unbinding resources from MOBs about to move, make sure we're
really moving out of MOB memory.

Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Deepak Rawat <drawat@vmware.com>
This commit is contained in:
Thomas Hellstrom 2018-06-19 19:20:29 +02:00
parent e9431ea507
commit 098d7d532b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
View File

@ -1105,9 +1105,11 @@ void vmw_bo_move_notify(struct ttm_buffer_object *bo,
vbo = container_of(bo, struct vmw_buffer_object, base); vbo = container_of(bo, struct vmw_buffer_object, base);
/* /*
* Kill any cached kernel maps before move. An optimization could * Kill any cached kernel maps before move to or from VRAM.
* be to do this iff source or destination memory type is in VRAM. * With other types of moves, the underlying pages stay the same,
* and the map can be kept.
*/ */
if (mem->mem_type == TTM_PL_VRAM || bo->mem.mem_type == TTM_PL_VRAM)
vmw_bo_unmap(vbo); vmw_bo_unmap(vbo);
/* /*
@ -1115,6 +1117,6 @@ void vmw_bo_move_notify(struct ttm_buffer_object *bo,
* read back all resource content first, and unbind the MOB from * read back all resource content first, and unbind the MOB from
* the resource. * the resource.
*/ */
if (mem->mem_type != VMW_PL_MOB) if (mem->mem_type != VMW_PL_MOB && bo->mem.mem_type == VMW_PL_MOB)
vmw_resource_unbind_list(vbo); vmw_resource_unbind_list(vbo);
} }