leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats()

Browse Source 
ath10k_wmi_tlv_op_pull_fw_stats() uses tb = ath10k_wmi_tlv_parse_alloc(...)
function, which allocates memory. If any of the three error-paths are
taken, this tb needs to be freed.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
This commit is contained in:
Christian Lamparter 2016-12-29 16:12:09 +02:00 committed by Kalle Valo
parent 8617690174
commit 097e46d2ae
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/net/wireless/ath/ath10k/wmi-tlv.c
View File

@ -1105,8 +1105,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k *ar,
struct ath10k_fw_stats_pdev *dst; struct ath10k_fw_stats_pdev *dst;
src = data; src = data;
if (data_len < sizeof(*src)) if (data_len < sizeof(*src)) {
kfree(tb);
return -EPROTO; return -EPROTO;
}
data += sizeof(*src); data += sizeof(*src);
data_len -= sizeof(*src); data_len -= sizeof(*src);
@ -1126,8 +1128,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k *ar,
struct ath10k_fw_stats_vdev *dst; struct ath10k_fw_stats_vdev *dst;
src = data; src = data;
if (data_len < sizeof(*src)) if (data_len < sizeof(*src)) {
kfree(tb);
return -EPROTO; return -EPROTO;
}
data += sizeof(*src); data += sizeof(*src);
data_len -= sizeof(*src); data_len -= sizeof(*src);
@ -1145,8 +1149,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k *ar,
struct ath10k_fw_stats_peer *dst; struct ath10k_fw_stats_peer *dst;
src = data; src = data;
if (data_len < sizeof(*src)) if (data_len < sizeof(*src)) {
kfree(tb);
return -EPROTO; return -EPROTO;
}
data += sizeof(*src); data += sizeof(*src);
data_len -= sizeof(*src); data_len -= sizeof(*src);