leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

media: allegro: remove unknown39 field from create_channel

Browse Source 
The subframe_latency and lda_control_mode fields directly follow
freq_golden_ref field and there is no unknown field in between. The
unknown field it at the end of the message.

Reorder the fields accordingly. This further allows to drop the hard
coded value from the lda_control_mode field and set the mode to 0.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Michael Tretter 2020-03-16 16:26:24 +01:00 committed by Mauro Carvalho Chehab
parent 8277815349
commit 081172a118
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/media/allegro-dvt/allegro-core.c
View File

@ -397,10 +397,9 @@ struct mcu_msg_create_channel {
u8 num_b;
u8 freq_golden_ref;
u32 unknown39;
u32 subframe_latency;
u32 lda_control_mode;
u32 unknown41;
} __attribute__ ((__packed__));
struct mcu_msg_create_channel_response {
@ -1121,7 +1120,6 @@ static int allegro_mcu_send_create_channel(struct allegro_dev *dev,
msg.gdr_mode = 0x00000000;
msg.gop_length = channel->gop_size;
msg.subframe_latency = 0x00000000;
msg.lda_control_mode = 0x700d0000;
allegro_mbox_write(dev, &dev->mbox_command, &msg, sizeof(msg));
allegro_mcu_interrupt(dev);