leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

module: only handle errors with the *switch* statement in module_sig_check()

Browse Source 
Let's handle the successful call of mod_verify_sig() right after that call,
making the *switch* statement only handle the real errors, and then move
the comment from the first *case* before *switch* itself and the comment
before *default* after it.  Fix the comment style, add article/comma/dash,
spell out "nomem" as "lack of memory" in these comments, while at it...

Suggested-by: Joe Perches <joe@perches.com>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
This commit is contained in:
Sergey Shtylyov
2020-10-31 23:10:28 +03:00
committed by Jessica Yu
parent 10ccd1abb8
commit 076aa52e40
1 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
kernel/module.c
View File

@@ -2895,17 +2895,18 @@ static int module_sig_check(struct load_info *info, int flags)
/* We truncate the module to discard the signature */ /* We truncate the module to discard the signature */
info->len -= markerlen; info->len -= markerlen;
err = mod_verify_sig(mod, info); err = mod_verify_sig(mod, info);
} if (!err) {
switch (err) {
case 0:
info->sig_ok = true; info->sig_ok = true;
return 0; return 0;
}
}
/* We don't permit modules to be loaded into trusted kernels /*
* without a valid signature on them, but if we're not * We don't permit modules to be loaded into the trusted kernels
* enforcing, certain errors are non-fatal. * without a valid signature on them, but if we're not enforcing,
* certain errors are non-fatal.
*/ */
switch (err) {
case -ENODATA: case -ENODATA:
reason = "unsigned module"; reason = "unsigned module";
break; break;
@@ -2916,11 +2917,12 @@ static int module_sig_check(struct load_info *info, int flags)
reason = "module with unavailable key"; reason = "module with unavailable key";
break; break;
/* All other errors are fatal, including nomem, unparseable
* signatures and signature check failures - even if signatures
* aren't required.
*/
default: default:
/*
* All other errors are fatal, including lack of memory,
* unparseable signatures, and signature check failures --
* even if signatures aren't required.
*/
return err; return err;
} }