leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mtd: rawnand: sunxi: Stop using nand_release()

Browse Source 
This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-55-miquel.raynal@bootlin.com
This commit is contained in:
Miquel Raynal 2020-05-19 15:00:27 +02:00
parent 3d84515ffd
commit 068d86ecd9
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/mtd/nand/raw/sunxi_nand.c
View File

@ -2039,13 +2039,18 @@ static int sunxi_nand_chips_init(struct device *dev, struct sunxi_nfc *nfc)
static void sunxi_nand_chips_cleanup(struct sunxi_nfc *nfc) static void sunxi_nand_chips_cleanup(struct sunxi_nfc *nfc)
{ {
struct sunxi_nand_chip *sunxi_nand; struct sunxi_nand_chip *sunxi_nand;
struct nand_chip *chip;
int ret;
while (!list_empty(&nfc->chips)) { while (!list_empty(&nfc->chips)) {
sunxi_nand = list_first_entry(&nfc->chips, sunxi_nand = list_first_entry(&nfc->chips,
struct sunxi_nand_chip, struct sunxi_nand_chip,
node); node);
nand_release(&sunxi_nand->nand); chip = &sunxi_nand->nand;
sunxi_nand_ecc_cleanup(&sunxi_nand->nand.ecc); ret = mtd_device_unregister(nand_to_mtd(chip));
WARN_ON(ret);
nand_cleanup(chip);
sunxi_nand_ecc_cleanup(&chip->ecc);
list_del(&sunxi_nand->node); list_del(&sunxi_nand->node);
} }
} }