leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

selftests/powerpc: Use snprintf to construct DSCR sysfs interface paths

Browse Source 
Currently sprintf is used, and while paths should never exceed
the size of the buffer it is theoretically possible since
dirent.d_name is 256 bytes. As a result this trips
-Wformat-overflow, and since the test is built with -Wall -Werror
the causes the build to fail. Switch to using snprintf and skip
any paths which are too long for the filename buffer.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Seth Forshee 2017-09-28 09:34:26 -04:00 committed by Michael Ellerman
parent 186b8f1587
commit 06755a8713
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/testing/selftests/powerpc/dscr/dscr_sysfs_test.c
View File

@ -53,6 +53,8 @@ static int check_all_cpu_dscr_defaults(unsigned long val)
} }
while ((dp = readdir(sysfs))) { while ((dp = readdir(sysfs))) {
int len;
if (!(dp->d_type & DT_DIR)) if (!(dp->d_type & DT_DIR))
continue; continue;
if (!strcmp(dp->d_name, "cpuidle")) if (!strcmp(dp->d_name, "cpuidle"))
@ -60,7 +62,9 @@ static int check_all_cpu_dscr_defaults(unsigned long val)
if (!strstr(dp->d_name, "cpu")) if (!strstr(dp->d_name, "cpu"))
continue; continue;
sprintf(file, "%s%s/dscr", CPU_PATH, dp->d_name); len = snprintf(file, LEN_MAX, "%s%s/dscr", CPU_PATH, dp->d_name);
if (len >= LEN_MAX)
continue;
if (access(file, F_OK)) if (access(file, F_OK))
continue; continue;