leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/exynos/ipp: replace work_struct casting with better constructs

Browse Source 
Type casting should be avoided if possible. In case of
work_struct it can be simply replaced by reference to member field.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
This commit is contained in:
Andrzej Hajda 2014-08-28 11:07:33 +02:00 committed by Inki Dae
parent 22e816f87c
commit 05afb1ac53
4 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/exynos/exynos_drm_fimc.c
View File

@ -1298,7 +1298,7 @@ static irqreturn_t fimc_irq_handler(int irq, void *dev_id)
event_work->ippdrv = ippdrv; event_work->ippdrv = ippdrv;
event_work->buf_id[EXYNOS_DRM_OPS_DST] = buf_id; event_work->buf_id[EXYNOS_DRM_OPS_DST] = buf_id;
queue_work(ippdrv->event_workq, (struct work_struct *)event_work); queue_work(ippdrv->event_workq, &event_work->work);
return IRQ_HANDLED; return IRQ_HANDLED;
} }

3
drivers/gpu/drm/exynos/exynos_drm_gsc.c
View File

@ -1326,8 +1326,7 @@ static irqreturn_t gsc_irq_handler(int irq, void *dev_id)
buf_id[EXYNOS_DRM_OPS_SRC]; buf_id[EXYNOS_DRM_OPS_SRC];
event_work->buf_id[EXYNOS_DRM_OPS_DST] = event_work->buf_id[EXYNOS_DRM_OPS_DST] =
buf_id[EXYNOS_DRM_OPS_DST]; buf_id[EXYNOS_DRM_OPS_DST];
queue_work(ippdrv->event_workq, queue_work(ippdrv->event_workq, &event_work->work);
(struct work_struct *)event_work);
} }
return IRQ_HANDLED; return IRQ_HANDLED;

6
drivers/gpu/drm/exynos/exynos_drm_ipp.c
View File

@ -790,7 +790,7 @@ static void ipp_handle_cmd_work(struct device *dev,
cmd_work->ippdrv = ippdrv; cmd_work->ippdrv = ippdrv;
cmd_work->c_node = c_node; cmd_work->c_node = c_node;
queue_work(ctx->cmd_workq, (struct work_struct *)cmd_work); queue_work(ctx->cmd_workq, &cmd_work->work);
} }
static int ipp_queue_buf_with_run(struct device *dev, static int ipp_queue_buf_with_run(struct device *dev,
@ -1318,7 +1318,7 @@ err_clear:
void ipp_sched_cmd(struct work_struct *work) void ipp_sched_cmd(struct work_struct *work)
{ {
struct drm_exynos_ipp_cmd_work *cmd_work = struct drm_exynos_ipp_cmd_work *cmd_work =
(struct drm_exynos_ipp_cmd_work *)work; container_of(work, struct drm_exynos_ipp_cmd_work, work);
struct exynos_drm_ippdrv *ippdrv; struct exynos_drm_ippdrv *ippdrv;
struct drm_exynos_ipp_cmd_node *c_node; struct drm_exynos_ipp_cmd_node *c_node;
struct drm_exynos_ipp_property *property; struct drm_exynos_ipp_property *property;
@ -1531,7 +1531,7 @@ err_event_unlock:
void ipp_sched_event(struct work_struct *work) void ipp_sched_event(struct work_struct *work)
{ {
struct drm_exynos_ipp_event_work *event_work = struct drm_exynos_ipp_event_work *event_work =
(struct drm_exynos_ipp_event_work *)work; container_of(work, struct drm_exynos_ipp_event_work, work);
struct exynos_drm_ippdrv *ippdrv; struct exynos_drm_ippdrv *ippdrv;
struct drm_exynos_ipp_cmd_node *c_node; struct drm_exynos_ipp_cmd_node *c_node;
int ret; int ret;

3
drivers/gpu/drm/exynos/exynos_drm_rotator.c
View File

@ -156,8 +156,7 @@ static irqreturn_t rotator_irq_handler(int irq, void *arg)
event_work->ippdrv = ippdrv; event_work->ippdrv = ippdrv;
event_work->buf_id[EXYNOS_DRM_OPS_DST] = event_work->buf_id[EXYNOS_DRM_OPS_DST] =
rot->cur_buf_id[EXYNOS_DRM_OPS_DST]; rot->cur_buf_id[EXYNOS_DRM_OPS_DST];
queue_work(ippdrv->event_workq, queue_work(ippdrv->event_workq, &event_work->work);
(struct work_struct *)event_work);
} else { } else {
DRM_ERROR("the SFR is set illegally\n"); DRM_ERROR("the SFR is set illegally\n");
} }