leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spi/gpio: start with CS non-active

Browse Source 
The chip select line was configured as output with the initial value
being active explicitly. It was later deasserted during
spi_bitbang_setup() without any clock activity in between. So it makes
no sense to activate the device at all and the chip select line can
better start non-active.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
Uwe Kleine-König 2012-02-09 22:21:45 +01:00 committed by Mark Brown
parent 619ac8d3e5
commit 0564414706
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/spi/spi-gpio.c
View File

@ -235,7 +235,8 @@ static int spi_gpio_setup(struct spi_device *spi)
status = gpio_request(cs, dev_name(&spi->dev)); status = gpio_request(cs, dev_name(&spi->dev));
if (status) if (status)
return status; return status;
status = gpio_direction_output(cs, spi->mode & SPI_CS_HIGH); status = gpio_direction_output(cs,
!(spi->mode & SPI_CS_HIGH));
} }
} }
if (!status) if (!status)