forked from Minki/linux
habanalabs: remove unnecessary device status check
Checking if the device is operational when entering the function to wait for user interrupt is not something that is useful or necessary. It is not done in any other wait_for_cs ioctl path. If the device becomes non-operational during the wait, the reset function will make sure the process wait is interrupted. Instead, move the check to the beginning of hl_wait_ioctl(). It will block any attempt to wait on CS or user interrupt once the device is already marked as non-operational. Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
This commit is contained in:
parent
176d23a77e
commit
053caa267f
@ -2741,10 +2741,6 @@ static int _hl_interrupt_wait_ioctl(struct hl_device *hdev, struct hl_ctx *ctx,
|
||||
interrupt = &hdev->user_interrupt[interrupt_offset];
|
||||
|
||||
spin_lock_irqsave(&interrupt->wait_list_lock, flags);
|
||||
if (!hl_device_operational(hdev, NULL)) {
|
||||
rc = -EPERM;
|
||||
goto unlock_and_free_fence;
|
||||
}
|
||||
|
||||
if (copy_from_user(&completion_value, u64_to_user_ptr(user_address),
|
||||
4)) {
|
||||
@ -2891,6 +2887,12 @@ int hl_wait_ioctl(struct hl_fpriv *hpriv, void *data)
|
||||
u32 flags = args->in.flags;
|
||||
int rc;
|
||||
|
||||
/* If the device is not operational, no point in waiting for any command submission or
|
||||
* user interrupt
|
||||
*/
|
||||
if (!hl_device_operational(hpriv->hdev, NULL))
|
||||
return -EPERM;
|
||||
|
||||
if (flags & HL_WAIT_CS_FLAGS_INTERRUPT)
|
||||
rc = hl_interrupt_wait_ioctl(hpriv, data);
|
||||
else if (flags & HL_WAIT_CS_FLAGS_MULTI_CS)
|
||||
|
Loading…
Reference in New Issue
Block a user