leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] staging: omap4iss: remove pads prefix from *_create_pads_links()

Browse Source 
The functions that create ISS internal and external entities links are
called *_create_pads_links() but the "pads" prefix is redundant since
the driver doesn't handle any other kind of link so it can be removed.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Javier Martinez Canillas 2015-12-11 15:16:31 -02:00 committed by Mauro Carvalho Chehab
parent 06a1368faf
commit 04e021511a
7 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/media/omap4iss/iss.c
View File

@ -1273,28 +1273,28 @@ done:
} }
/* /*
* iss_create_pads_links() - Pads links creation for the subdevices * iss_create_links() - Pads links creation for the subdevices
* @iss : Pointer to ISS device * @iss : Pointer to ISS device
* *
* return negative error code or zero on success * return negative error code or zero on success
*/ */
static int iss_create_pads_links(struct iss_device *iss) static int iss_create_links(struct iss_device *iss)
{ {
int ret; int ret;
ret = omap4iss_csi2_create_pads_links(iss); ret = omap4iss_csi2_create_links(iss);
if (ret < 0) { if (ret < 0) {
dev_err(iss->dev, "CSI2 pads links creation failed\n"); dev_err(iss->dev, "CSI2 pads links creation failed\n");
return ret; return ret;
} }
ret = omap4iss_ipipeif_create_pads_links(iss); ret = omap4iss_ipipeif_create_links(iss);
if (ret < 0) { if (ret < 0) {
dev_err(iss->dev, "ISP IPIPEIF pads links creation failed\n"); dev_err(iss->dev, "ISP IPIPEIF pads links creation failed\n");
return ret; return ret;
} }
ret = omap4iss_resizer_create_pads_links(iss); ret = omap4iss_resizer_create_links(iss);
if (ret < 0) { if (ret < 0) {
dev_err(iss->dev, "ISP RESIZER pads links creation failed\n"); dev_err(iss->dev, "ISP RESIZER pads links creation failed\n");
return ret; return ret;
@ -1491,7 +1491,7 @@ static int iss_probe(struct platform_device *pdev)
if (ret < 0) if (ret < 0)
goto error_modules; goto error_modules;
ret = iss_create_pads_links(iss); ret = iss_create_links(iss);
if (ret < 0) if (ret < 0)
goto error_entities; goto error_entities;

4
drivers/staging/media/omap4iss/iss_csi2.c
View File

@ -1339,12 +1339,12 @@ int omap4iss_csi2_init(struct iss_device *iss)
} }
/* /*
* omap4iss_csi2_create_pads_links() - CSI2 pads links creation * omap4iss_csi2_create_links() - CSI2 pads links creation
* @iss: Pointer to ISS device * @iss: Pointer to ISS device
* *
* return negative error code or zero on success * return negative error code or zero on success
*/ */
int omap4iss_csi2_create_pads_links(struct iss_device *iss) int omap4iss_csi2_create_links(struct iss_device *iss)
{ {
struct iss_csi2_device *csi2a = &iss->csi2a; struct iss_csi2_device *csi2a = &iss->csi2a;
struct iss_csi2_device *csi2b = &iss->csi2b; struct iss_csi2_device *csi2b = &iss->csi2b;

2
drivers/staging/media/omap4iss/iss_csi2.h
View File

@ -151,7 +151,7 @@ struct iss_csi2_device {
void omap4iss_csi2_isr(struct iss_csi2_device *csi2); void omap4iss_csi2_isr(struct iss_csi2_device *csi2);
int omap4iss_csi2_reset(struct iss_csi2_device *csi2); int omap4iss_csi2_reset(struct iss_csi2_device *csi2);
int omap4iss_csi2_init(struct iss_device *iss); int omap4iss_csi2_init(struct iss_device *iss);
int omap4iss_csi2_create_pads_links(struct iss_device *iss); int omap4iss_csi2_create_links(struct iss_device *iss);
void omap4iss_csi2_cleanup(struct iss_device *iss); void omap4iss_csi2_cleanup(struct iss_device *iss);
void omap4iss_csi2_unregister_entities(struct iss_csi2_device *csi2); void omap4iss_csi2_unregister_entities(struct iss_csi2_device *csi2);
int omap4iss_csi2_register_entities(struct iss_csi2_device *csi2, int omap4iss_csi2_register_entities(struct iss_csi2_device *csi2,

4
drivers/staging/media/omap4iss/iss_ipipeif.c
View File

@ -815,12 +815,12 @@ int omap4iss_ipipeif_init(struct iss_device *iss)
} }
/* /*
* omap4iss_ipipeif_create_pads_links() - IPIPEIF pads links creation * omap4iss_ipipeif_create_links() - IPIPEIF pads links creation
* @iss: Pointer to ISS device * @iss: Pointer to ISS device
* *
* return negative error code or zero on success * return negative error code or zero on success
*/ */
int omap4iss_ipipeif_create_pads_links(struct iss_device *iss) int omap4iss_ipipeif_create_links(struct iss_device *iss)
{ {
struct iss_ipipeif_device *ipipeif = &iss->ipipeif; struct iss_ipipeif_device *ipipeif = &iss->ipipeif;

2
drivers/staging/media/omap4iss/iss_ipipeif.h
View File

@ -78,7 +78,7 @@ struct iss_ipipeif_device {
struct iss_device; struct iss_device;
int omap4iss_ipipeif_init(struct iss_device *iss); int omap4iss_ipipeif_init(struct iss_device *iss);
int omap4iss_ipipeif_create_pads_links(struct iss_device *iss); int omap4iss_ipipeif_create_links(struct iss_device *iss);
void omap4iss_ipipeif_cleanup(struct iss_device *iss); void omap4iss_ipipeif_cleanup(struct iss_device *iss);
int omap4iss_ipipeif_register_entities(struct iss_ipipeif_device *ipipeif, int omap4iss_ipipeif_register_entities(struct iss_ipipeif_device *ipipeif,
struct v4l2_device *vdev); struct v4l2_device *vdev);

4
drivers/staging/media/omap4iss/iss_resizer.c
View File

@ -857,12 +857,12 @@ int omap4iss_resizer_init(struct iss_device *iss)
} }
/* /*
* omap4iss_resizer_create_pads_links() - RESIZER pads links creation * omap4iss_resizer_create_links() - RESIZER pads links creation
* @iss: Pointer to ISS device * @iss: Pointer to ISS device
* *
* return negative error code or zero on success * return negative error code or zero on success
*/ */
int omap4iss_resizer_create_pads_links(struct iss_device *iss) int omap4iss_resizer_create_links(struct iss_device *iss)
{ {
struct iss_resizer_device *resizer = &iss->resizer; struct iss_resizer_device *resizer = &iss->resizer;

2
drivers/staging/media/omap4iss/iss_resizer.h
View File

@ -61,7 +61,7 @@ struct iss_resizer_device {
struct iss_device; struct iss_device;
int omap4iss_resizer_init(struct iss_device *iss); int omap4iss_resizer_init(struct iss_device *iss);
int omap4iss_resizer_create_pads_links(struct iss_device *iss); int omap4iss_resizer_create_links(struct iss_device *iss);
void omap4iss_resizer_cleanup(struct iss_device *iss); void omap4iss_resizer_cleanup(struct iss_device *iss);
int omap4iss_resizer_register_entities(struct iss_resizer_device *resizer, int omap4iss_resizer_register_entities(struct iss_resizer_device *resizer,
struct v4l2_device *vdev); struct v4l2_device *vdev);