leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/i915: use for_each_power_well in lookup_power_well()

Browse Source 
Use the nice helper function to make the implementation simpler.

v2: Rebase.

Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com> (v1)
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180820233139.11936-3-paulo.r.zanoni@intel.com
This commit is contained in:
Paulo Zanoni
2018-08-20 16:31:37 -07:00
parent 99da0b3539
commit 0229bfd42b
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/gpu/drm/i915/intel_runtime_pm.c
View File

@@ -1087,16 +1087,11 @@ static struct i915_power_well *
lookup_power_well(struct drm_i915_private *dev_priv, lookup_power_well(struct drm_i915_private *dev_priv,
enum i915_power_well_id power_well_id) enum i915_power_well_id power_well_id)
{ {
struct i915_power_domains *power_domains = &dev_priv->power_domains; struct i915_power_well *power_well;
int i;
for (i = 0; i < power_domains->power_well_count; i++) { for_each_power_well(dev_priv, power_well)
struct i915_power_well *power_well;
power_well = &power_domains->power_wells[i];
if (power_well->desc->id == power_well_id) if (power_well->desc->id == power_well_id)
return power_well; return power_well;
}
/* /*
* It's not feasible to add error checking code to the callers since * It's not feasible to add error checking code to the callers since
@@ -1106,7 +1101,7 @@ lookup_power_well(struct drm_i915_private *dev_priv,
* our driver. * our driver.
*/ */
WARN(1, "Power well %d not defined for this platform\n", power_well_id); WARN(1, "Power well %d not defined for this platform\n", power_well_id);
return &power_domains->power_wells[0]; return &dev_priv->power_domains.power_wells[0];
} }
#define BITS_SET(val, bits) (((val) & (bits)) == (bits)) #define BITS_SET(val, bits) (((val) & (bits)) == (bits))