leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gpio: zynq: Take bank offset into account when reporting a IRQ

Browse Source 
When looking up the IRQ the bank offset needs to be taken into account.
Otherwise interrupts for banks other than bank 0 get incorrectly reported as
interrupts for bank 0.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Lars-Peter Clausen 2014-08-18 11:54:56 +02:00 committed by Linus Walleij
parent 0752e169ba
commit 016da14439
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/gpio/gpio-zynq.c
View File

@ -138,6 +138,13 @@ static inline void zynq_gpio_get_bank_pin(unsigned int pin_num,
} }
} }
static const unsigned int zynq_gpio_bank_offset[] = {
ZYNQ_GPIO_BANK0_PIN_MIN,
ZYNQ_GPIO_BANK1_PIN_MIN,
ZYNQ_GPIO_BANK2_PIN_MIN,
ZYNQ_GPIO_BANK3_PIN_MIN,
};
/** /**
* zynq_gpio_get_value - Get the state of the specified pin of GPIO device * zynq_gpio_get_value - Get the state of the specified pin of GPIO device
* @chip: gpio_chip instance to be worked on * @chip: gpio_chip instance to be worked on
@ -461,6 +468,7 @@ static void zynq_gpio_handle_bank_irq(struct zynq_gpio *gpio,
unsigned int bank_num, unsigned int bank_num,
unsigned long pending) unsigned long pending)
{ {
unsigned int bank_offset = zynq_gpio_bank_offset[bank_num];
struct irq_domain *irqdomain = gpio->chip.irqdomain; struct irq_domain *irqdomain = gpio->chip.irqdomain;
int offset; int offset;
@ -470,7 +478,7 @@ static void zynq_gpio_handle_bank_irq(struct zynq_gpio *gpio,
for_each_set_bit(offset, &pending, 32) { for_each_set_bit(offset, &pending, 32) {
unsigned int gpio_irq; unsigned int gpio_irq;
gpio_irq = irq_find_mapping(irqdomain, offset); gpio_irq = irq_find_mapping(irqdomain, offset + bank_offset);
generic_handle_irq(gpio_irq); generic_handle_irq(gpio_irq);
} }
} }