forked from Minki/linux
media: rcar_fdp1: constify vb2_ops structure
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct vb2_ops i@p = { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = &i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
parent
7e645125a8
commit
0169daec96
@ -2032,7 +2032,7 @@ static void fdp1_stop_streaming(struct vb2_queue *q)
|
||||
}
|
||||
}
|
||||
|
||||
static struct vb2_ops fdp1_qops = {
|
||||
static const struct vb2_ops fdp1_qops = {
|
||||
.queue_setup = fdp1_queue_setup,
|
||||
.buf_prepare = fdp1_buf_prepare,
|
||||
.buf_queue = fdp1_buf_queue,
|
||||
|
Loading…
Reference in New Issue
Block a user