2019-05-29 14:17:56 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2014-08-22 10:36:26 +00:00
|
|
|
/*
|
|
|
|
* Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
|
|
|
|
* Author:Mark Yao <mark.yao@rock-chips.com>
|
|
|
|
*/
|
|
|
|
|
2019-07-16 06:42:19 +00:00
|
|
|
#include <linux/clk.h>
|
|
|
|
#include <linux/component.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/iopoll.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/of.h>
|
|
|
|
#include <linux/of_device.h>
|
|
|
|
#include <linux/overflow.h>
|
|
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/pm_runtime.h>
|
|
|
|
#include <linux/reset.h>
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
#include <drm/drm.h>
|
2015-11-30 10:22:42 +00:00
|
|
|
#include <drm/drm_atomic.h>
|
2018-12-05 12:33:10 +00:00
|
|
|
#include <drm/drm_atomic_uapi.h>
|
2014-08-22 10:36:26 +00:00
|
|
|
#include <drm/drm_crtc.h>
|
2016-09-14 12:54:57 +00:00
|
|
|
#include <drm/drm_flip_work.h>
|
2019-07-16 06:42:19 +00:00
|
|
|
#include <drm/drm_fourcc.h>
|
2018-11-30 10:24:49 +00:00
|
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
2014-08-22 10:36:26 +00:00
|
|
|
#include <drm/drm_plane_helper.h>
|
2019-01-17 21:03:34 +00:00
|
|
|
#include <drm/drm_probe_helper.h>
|
2019-06-11 16:08:22 +00:00
|
|
|
#include <drm/drm_self_refresh_helper.h>
|
2019-07-16 06:42:19 +00:00
|
|
|
#include <drm/drm_vblank.h>
|
|
|
|
|
2017-03-06 20:02:26 +00:00
|
|
|
#ifdef CONFIG_DRM_ANALOGIX_DP
|
2017-03-03 13:39:36 +00:00
|
|
|
#include <drm/bridge/analogix_dp.h>
|
2017-03-06 20:02:26 +00:00
|
|
|
#endif
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
#include "rockchip_drm_drv.h"
|
|
|
|
#include "rockchip_drm_gem.h"
|
|
|
|
#include "rockchip_drm_fb.h"
|
|
|
|
#include "rockchip_drm_vop.h"
|
2018-08-30 21:12:06 +00:00
|
|
|
#include "rockchip_rgb.h"
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2019-06-11 16:08:22 +00:00
|
|
|
#define VOP_SELF_REFRESH_ENTRY_DELAY_MS 100
|
|
|
|
|
2019-01-09 18:56:37 +00:00
|
|
|
#define VOP_WIN_SET(vop, win, name, v) \
|
2017-07-28 06:06:25 +00:00
|
|
|
vop_reg_set(vop, &win->phy->name, win->base, ~0, v, #name)
|
2019-01-09 18:56:37 +00:00
|
|
|
#define VOP_SCL_SET(vop, win, name, v) \
|
2017-07-28 06:06:25 +00:00
|
|
|
vop_reg_set(vop, &win->phy->scl->name, win->base, ~0, v, #name)
|
2019-01-09 18:56:37 +00:00
|
|
|
#define VOP_SCL_SET_EXT(vop, win, name, v) \
|
2017-07-28 06:06:25 +00:00
|
|
|
vop_reg_set(vop, &win->phy->scl->ext->name, \
|
|
|
|
win->base, ~0, v, #name)
|
2017-07-26 06:19:19 +00:00
|
|
|
|
2019-01-09 18:56:37 +00:00
|
|
|
#define VOP_WIN_YUV2YUV_SET(vop, win_yuv2yuv, name, v) \
|
2019-01-08 21:46:59 +00:00
|
|
|
do { \
|
|
|
|
if (win_yuv2yuv && win_yuv2yuv->name.mask) \
|
|
|
|
vop_reg_set(vop, &win_yuv2yuv->name, 0, ~0, v, #name); \
|
|
|
|
} while (0)
|
|
|
|
|
2019-01-09 18:56:37 +00:00
|
|
|
#define VOP_WIN_YUV2YUV_COEFFICIENT_SET(vop, win_yuv2yuv, name, v) \
|
2019-01-08 21:46:59 +00:00
|
|
|
do { \
|
|
|
|
if (win_yuv2yuv && win_yuv2yuv->phy->name.mask) \
|
|
|
|
vop_reg_set(vop, &win_yuv2yuv->phy->name, win_yuv2yuv->base, ~0, v, #name); \
|
|
|
|
} while (0)
|
|
|
|
|
2017-07-26 06:19:19 +00:00
|
|
|
#define VOP_INTR_SET_MASK(vop, name, mask, v) \
|
2017-07-28 06:06:25 +00:00
|
|
|
vop_reg_set(vop, &vop->data->intr->name, 0, mask, v, #name)
|
|
|
|
|
|
|
|
#define VOP_REG_SET(vop, group, name, v) \
|
|
|
|
vop_reg_set(vop, &vop->data->group->name, 0, ~0, v, #name)
|
2017-07-26 06:19:19 +00:00
|
|
|
|
2015-12-15 00:36:55 +00:00
|
|
|
#define VOP_INTR_SET_TYPE(vop, name, type, v) \
|
|
|
|
do { \
|
2016-01-12 18:05:18 +00:00
|
|
|
int i, reg = 0, mask = 0; \
|
2015-12-15 00:36:55 +00:00
|
|
|
for (i = 0; i < vop->data->intr->nintrs; i++) { \
|
2016-01-12 18:05:18 +00:00
|
|
|
if (vop->data->intr->intrs[i] & type) { \
|
2015-12-15 00:36:55 +00:00
|
|
|
reg |= (v) << i; \
|
2016-01-12 18:05:18 +00:00
|
|
|
mask |= 1 << i; \
|
|
|
|
} \
|
2015-12-15 00:36:55 +00:00
|
|
|
} \
|
2017-07-26 06:19:19 +00:00
|
|
|
VOP_INTR_SET_MASK(vop, name, mask, reg); \
|
2015-12-15 00:36:55 +00:00
|
|
|
} while (0)
|
|
|
|
#define VOP_INTR_GET_TYPE(vop, name, type) \
|
|
|
|
vop_get_intr_type(vop, &vop->data->intr->name, type)
|
|
|
|
|
2019-01-09 18:56:37 +00:00
|
|
|
#define VOP_WIN_GET(vop, win, name) \
|
2019-07-03 09:51:11 +00:00
|
|
|
vop_read_reg(vop, win->base, &win->phy->name)
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2019-01-09 18:56:39 +00:00
|
|
|
#define VOP_WIN_HAS_REG(win, name) \
|
|
|
|
(!!(win->phy->name.mask))
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
#define VOP_WIN_GET_YRGBADDR(vop, win) \
|
|
|
|
vop_readl(vop, win->base + win->phy->yrgb_mst.offset)
|
|
|
|
|
2018-04-18 17:31:52 +00:00
|
|
|
#define VOP_WIN_TO_INDEX(vop_win) \
|
|
|
|
((vop_win) - (vop_win)->vop->win)
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
#define to_vop(x) container_of(x, struct vop, crtc)
|
|
|
|
#define to_vop_win(x) container_of(x, struct vop_win, base)
|
|
|
|
|
2019-01-08 21:46:59 +00:00
|
|
|
/*
|
|
|
|
* The coefficients of the following matrix are all fixed points.
|
|
|
|
* The format is S2.10 for the 3x3 part of the matrix, and S9.12 for the offsets.
|
|
|
|
* They are all represented in two's complement.
|
|
|
|
*/
|
|
|
|
static const uint32_t bt601_yuv2rgb[] = {
|
|
|
|
0x4A8, 0x0, 0x662,
|
|
|
|
0x4A8, 0x1E6F, 0x1CBF,
|
|
|
|
0x4A8, 0x812, 0x0,
|
|
|
|
0x321168, 0x0877CF, 0x2EB127
|
|
|
|
};
|
|
|
|
|
2016-09-14 12:54:57 +00:00
|
|
|
enum vop_pending {
|
|
|
|
VOP_PENDING_FB_UNREF,
|
|
|
|
};
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
struct vop_win {
|
|
|
|
struct drm_plane base;
|
|
|
|
const struct vop_win_data *data;
|
2019-01-08 21:46:59 +00:00
|
|
|
const struct vop_win_yuv2yuv_data *yuv2yuv_data;
|
2014-08-22 10:36:26 +00:00
|
|
|
struct vop *vop;
|
|
|
|
};
|
|
|
|
|
2018-08-30 21:12:06 +00:00
|
|
|
struct rockchip_rgb;
|
2014-08-22 10:36:26 +00:00
|
|
|
struct vop {
|
|
|
|
struct drm_crtc crtc;
|
|
|
|
struct device *dev;
|
|
|
|
struct drm_device *drm_dev;
|
2015-01-22 06:37:56 +00:00
|
|
|
bool is_enabled;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-02-04 05:10:31 +00:00
|
|
|
struct completion dsp_hold_completion;
|
2019-06-11 16:08:24 +00:00
|
|
|
unsigned int win_enabled;
|
2016-06-08 12:19:11 +00:00
|
|
|
|
|
|
|
/* protected by dev->event_lock */
|
2015-11-30 10:22:42 +00:00
|
|
|
struct drm_pending_vblank_event *event;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2016-09-14 12:54:57 +00:00
|
|
|
struct drm_flip_work fb_unref_work;
|
|
|
|
unsigned long pending;
|
|
|
|
|
2016-07-24 06:57:40 +00:00
|
|
|
struct completion line_flag_completion;
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
const struct vop_data *data;
|
|
|
|
|
|
|
|
uint32_t *regsbak;
|
|
|
|
void __iomem *regs;
|
|
|
|
|
|
|
|
/* physical map length of vop register */
|
|
|
|
uint32_t len;
|
|
|
|
|
|
|
|
/* one time only one process allowed to config the register */
|
|
|
|
spinlock_t reg_lock;
|
|
|
|
/* lock vop irq reg */
|
|
|
|
spinlock_t irq_lock;
|
2018-03-09 22:22:55 +00:00
|
|
|
/* protects crtc enable/disable */
|
|
|
|
struct mutex vop_lock;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
unsigned int irq;
|
|
|
|
|
|
|
|
/* vop AHP clk */
|
|
|
|
struct clk *hclk;
|
|
|
|
/* vop dclk */
|
|
|
|
struct clk *dclk;
|
|
|
|
/* vop share memory frequency */
|
|
|
|
struct clk *aclk;
|
|
|
|
|
|
|
|
/* vop dclk reset */
|
|
|
|
struct reset_control *dclk_rst;
|
|
|
|
|
2018-08-30 21:12:06 +00:00
|
|
|
/* optional internal rgb encoder */
|
|
|
|
struct rockchip_rgb *rgb;
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
struct vop_win win[];
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
|
|
|
|
{
|
|
|
|
writel(v, vop->regs + offset);
|
|
|
|
vop->regsbak[offset >> 2] = v;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline uint32_t vop_readl(struct vop *vop, uint32_t offset)
|
|
|
|
{
|
|
|
|
return readl(vop->regs + offset);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline uint32_t vop_read_reg(struct vop *vop, uint32_t base,
|
|
|
|
const struct vop_reg *reg)
|
|
|
|
{
|
|
|
|
return (vop_readl(vop, base + reg->offset) >> reg->shift) & reg->mask;
|
|
|
|
}
|
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
static void vop_reg_set(struct vop *vop, const struct vop_reg *reg,
|
|
|
|
uint32_t _offset, uint32_t _mask, uint32_t v,
|
|
|
|
const char *reg_name)
|
2014-08-22 10:36:26 +00:00
|
|
|
{
|
2017-07-28 06:06:25 +00:00
|
|
|
int offset, mask, shift;
|
|
|
|
|
|
|
|
if (!reg || !reg->mask) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_DEBUG(vop->dev, "Warning: not support %s\n", reg_name);
|
2016-04-20 06:18:15 +00:00
|
|
|
return;
|
2017-07-28 06:06:25 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
offset = reg->offset + _offset;
|
|
|
|
mask = reg->mask & _mask;
|
|
|
|
shift = reg->shift;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
if (reg->write_mask) {
|
2016-04-20 06:18:15 +00:00
|
|
|
v = ((v << shift) & 0xffff) | (mask << (shift + 16));
|
|
|
|
} else {
|
2014-08-22 10:36:26 +00:00
|
|
|
uint32_t cached_val = vop->regsbak[offset >> 2];
|
|
|
|
|
2016-04-20 06:18:15 +00:00
|
|
|
v = (cached_val & ~(mask << shift)) | ((v & mask) << shift);
|
|
|
|
vop->regsbak[offset >> 2] = v;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
2016-04-20 06:18:15 +00:00
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
if (reg->relaxed)
|
2016-04-20 06:18:15 +00:00
|
|
|
writel_relaxed(v, vop->regs + offset);
|
|
|
|
else
|
|
|
|
writel(v, vop->regs + offset);
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2015-12-15 00:36:55 +00:00
|
|
|
static inline uint32_t vop_get_intr_type(struct vop *vop,
|
|
|
|
const struct vop_reg *reg, int type)
|
|
|
|
{
|
|
|
|
uint32_t i, ret = 0;
|
|
|
|
uint32_t regs = vop_read_reg(vop, 0, reg);
|
|
|
|
|
|
|
|
for (i = 0; i < vop->data->intr->nintrs; i++) {
|
|
|
|
if ((type & vop->data->intr->intrs[i]) && (regs & 1 << i))
|
|
|
|
ret |= vop->data->intr->intrs[i];
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-12-14 10:14:36 +00:00
|
|
|
static inline void vop_cfg_done(struct vop *vop)
|
|
|
|
{
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, common, cfg_done, 1);
|
2015-12-14 10:14:36 +00:00
|
|
|
}
|
|
|
|
|
2015-05-11 10:55:39 +00:00
|
|
|
static bool has_rb_swapped(uint32_t format)
|
|
|
|
{
|
|
|
|
switch (format) {
|
|
|
|
case DRM_FORMAT_XBGR8888:
|
|
|
|
case DRM_FORMAT_ABGR8888:
|
|
|
|
case DRM_FORMAT_BGR888:
|
|
|
|
case DRM_FORMAT_BGR565:
|
|
|
|
return true;
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
static enum vop_data_format vop_convert_format(uint32_t format)
|
|
|
|
{
|
|
|
|
switch (format) {
|
|
|
|
case DRM_FORMAT_XRGB8888:
|
|
|
|
case DRM_FORMAT_ARGB8888:
|
2015-05-11 10:55:39 +00:00
|
|
|
case DRM_FORMAT_XBGR8888:
|
|
|
|
case DRM_FORMAT_ABGR8888:
|
2014-08-22 10:36:26 +00:00
|
|
|
return VOP_FMT_ARGB8888;
|
|
|
|
case DRM_FORMAT_RGB888:
|
2015-05-11 10:55:39 +00:00
|
|
|
case DRM_FORMAT_BGR888:
|
2014-08-22 10:36:26 +00:00
|
|
|
return VOP_FMT_RGB888;
|
|
|
|
case DRM_FORMAT_RGB565:
|
2015-05-11 10:55:39 +00:00
|
|
|
case DRM_FORMAT_BGR565:
|
2014-08-22 10:36:26 +00:00
|
|
|
return VOP_FMT_RGB565;
|
|
|
|
case DRM_FORMAT_NV12:
|
|
|
|
return VOP_FMT_YUV420SP;
|
|
|
|
case DRM_FORMAT_NV16:
|
|
|
|
return VOP_FMT_YUV422SP;
|
|
|
|
case DRM_FORMAT_NV24:
|
|
|
|
return VOP_FMT_YUV444SP;
|
|
|
|
default:
|
2016-08-12 17:00:54 +00:00
|
|
|
DRM_ERROR("unsupported format[%08x]\n", format);
|
2014-08-22 10:36:26 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-06-26 09:14:46 +00:00
|
|
|
static uint16_t scl_vop_cal_scale(enum scale_mode mode, uint32_t src,
|
|
|
|
uint32_t dst, bool is_horizontal,
|
|
|
|
int vsu_mode, int *vskiplines)
|
|
|
|
{
|
|
|
|
uint16_t val = 1 << SCL_FT_DEFAULT_FIXPOINT_SHIFT;
|
|
|
|
|
2018-02-23 06:22:50 +00:00
|
|
|
if (vskiplines)
|
|
|
|
*vskiplines = 0;
|
|
|
|
|
2015-06-26 09:14:46 +00:00
|
|
|
if (is_horizontal) {
|
|
|
|
if (mode == SCALE_UP)
|
|
|
|
val = GET_SCL_FT_BIC(src, dst);
|
|
|
|
else if (mode == SCALE_DOWN)
|
|
|
|
val = GET_SCL_FT_BILI_DN(src, dst);
|
|
|
|
} else {
|
|
|
|
if (mode == SCALE_UP) {
|
|
|
|
if (vsu_mode == SCALE_UP_BIL)
|
|
|
|
val = GET_SCL_FT_BILI_UP(src, dst);
|
|
|
|
else
|
|
|
|
val = GET_SCL_FT_BIC(src, dst);
|
|
|
|
} else if (mode == SCALE_DOWN) {
|
|
|
|
if (vskiplines) {
|
|
|
|
*vskiplines = scl_get_vskiplines(src, dst);
|
|
|
|
val = scl_get_bili_dn_vskip(src, dst,
|
|
|
|
*vskiplines);
|
|
|
|
} else {
|
|
|
|
val = GET_SCL_FT_BILI_DN(src, dst);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return val;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void scl_vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win,
|
|
|
|
uint32_t src_w, uint32_t src_h, uint32_t dst_w,
|
2019-05-16 10:31:46 +00:00
|
|
|
uint32_t dst_h, const struct drm_format_info *info)
|
2015-06-26 09:14:46 +00:00
|
|
|
{
|
|
|
|
uint16_t yrgb_hor_scl_mode, yrgb_ver_scl_mode;
|
|
|
|
uint16_t cbcr_hor_scl_mode = SCALE_NONE;
|
|
|
|
uint16_t cbcr_ver_scl_mode = SCALE_NONE;
|
2018-07-17 17:13:44 +00:00
|
|
|
bool is_yuv = false;
|
2019-05-16 10:31:48 +00:00
|
|
|
uint16_t cbcr_src_w = src_w / info->hsub;
|
|
|
|
uint16_t cbcr_src_h = src_h / info->vsub;
|
2015-06-26 09:14:46 +00:00
|
|
|
uint16_t vsu_mode;
|
|
|
|
uint16_t lb_mode;
|
|
|
|
uint32_t val;
|
2018-02-23 06:22:50 +00:00
|
|
|
int vskiplines;
|
2015-06-26 09:14:46 +00:00
|
|
|
|
2018-07-17 17:13:44 +00:00
|
|
|
if (info->is_yuv)
|
|
|
|
is_yuv = true;
|
|
|
|
|
2015-06-26 09:14:46 +00:00
|
|
|
if (dst_w > 3840) {
|
2016-08-12 17:00:54 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "Maximum dst width (3840) exceeded\n");
|
2015-06-26 09:14:46 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2015-12-15 01:08:43 +00:00
|
|
|
if (!win->phy->scl->ext) {
|
|
|
|
VOP_SCL_SET(vop, win, scale_yrgb_x,
|
|
|
|
scl_cal_scale2(src_w, dst_w));
|
|
|
|
VOP_SCL_SET(vop, win, scale_yrgb_y,
|
|
|
|
scl_cal_scale2(src_h, dst_h));
|
|
|
|
if (is_yuv) {
|
|
|
|
VOP_SCL_SET(vop, win, scale_cbcr_x,
|
2016-06-06 07:58:46 +00:00
|
|
|
scl_cal_scale2(cbcr_src_w, dst_w));
|
2015-12-15 01:08:43 +00:00
|
|
|
VOP_SCL_SET(vop, win, scale_cbcr_y,
|
2016-06-06 07:58:46 +00:00
|
|
|
scl_cal_scale2(cbcr_src_h, dst_h));
|
2015-12-15 01:08:43 +00:00
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2015-06-26 09:14:46 +00:00
|
|
|
yrgb_hor_scl_mode = scl_get_scl_mode(src_w, dst_w);
|
|
|
|
yrgb_ver_scl_mode = scl_get_scl_mode(src_h, dst_h);
|
|
|
|
|
|
|
|
if (is_yuv) {
|
|
|
|
cbcr_hor_scl_mode = scl_get_scl_mode(cbcr_src_w, dst_w);
|
|
|
|
cbcr_ver_scl_mode = scl_get_scl_mode(cbcr_src_h, dst_h);
|
|
|
|
if (cbcr_hor_scl_mode == SCALE_DOWN)
|
|
|
|
lb_mode = scl_vop_cal_lb_mode(dst_w, true);
|
|
|
|
else
|
|
|
|
lb_mode = scl_vop_cal_lb_mode(cbcr_src_w, true);
|
|
|
|
} else {
|
|
|
|
if (yrgb_hor_scl_mode == SCALE_DOWN)
|
|
|
|
lb_mode = scl_vop_cal_lb_mode(dst_w, false);
|
|
|
|
else
|
|
|
|
lb_mode = scl_vop_cal_lb_mode(src_w, false);
|
|
|
|
}
|
|
|
|
|
2015-12-15 01:08:43 +00:00
|
|
|
VOP_SCL_SET_EXT(vop, win, lb_mode, lb_mode);
|
2015-06-26 09:14:46 +00:00
|
|
|
if (lb_mode == LB_RGB_3840X2) {
|
|
|
|
if (yrgb_ver_scl_mode != SCALE_NONE) {
|
2016-08-12 17:00:54 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "not allow yrgb ver scale\n");
|
2015-06-26 09:14:46 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (cbcr_ver_scl_mode != SCALE_NONE) {
|
2016-08-12 17:00:54 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "not allow cbcr ver scale\n");
|
2015-06-26 09:14:46 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
vsu_mode = SCALE_UP_BIL;
|
|
|
|
} else if (lb_mode == LB_RGB_2560X4) {
|
|
|
|
vsu_mode = SCALE_UP_BIL;
|
|
|
|
} else {
|
|
|
|
vsu_mode = SCALE_UP_BIC;
|
|
|
|
}
|
|
|
|
|
|
|
|
val = scl_vop_cal_scale(yrgb_hor_scl_mode, src_w, dst_w,
|
|
|
|
true, 0, NULL);
|
|
|
|
VOP_SCL_SET(vop, win, scale_yrgb_x, val);
|
|
|
|
val = scl_vop_cal_scale(yrgb_ver_scl_mode, src_h, dst_h,
|
|
|
|
false, vsu_mode, &vskiplines);
|
|
|
|
VOP_SCL_SET(vop, win, scale_yrgb_y, val);
|
|
|
|
|
2015-12-15 01:08:43 +00:00
|
|
|
VOP_SCL_SET_EXT(vop, win, vsd_yrgb_gt4, vskiplines == 4);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, vsd_yrgb_gt2, vskiplines == 2);
|
2015-06-26 09:14:46 +00:00
|
|
|
|
2015-12-15 01:08:43 +00:00
|
|
|
VOP_SCL_SET_EXT(vop, win, yrgb_hor_scl_mode, yrgb_hor_scl_mode);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, yrgb_ver_scl_mode, yrgb_ver_scl_mode);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, yrgb_hsd_mode, SCALE_DOWN_BIL);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, yrgb_vsd_mode, SCALE_DOWN_BIL);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, yrgb_vsu_mode, vsu_mode);
|
2015-06-26 09:14:46 +00:00
|
|
|
if (is_yuv) {
|
|
|
|
val = scl_vop_cal_scale(cbcr_hor_scl_mode, cbcr_src_w,
|
|
|
|
dst_w, true, 0, NULL);
|
|
|
|
VOP_SCL_SET(vop, win, scale_cbcr_x, val);
|
|
|
|
val = scl_vop_cal_scale(cbcr_ver_scl_mode, cbcr_src_h,
|
|
|
|
dst_h, false, vsu_mode, &vskiplines);
|
|
|
|
VOP_SCL_SET(vop, win, scale_cbcr_y, val);
|
|
|
|
|
2015-12-15 01:08:43 +00:00
|
|
|
VOP_SCL_SET_EXT(vop, win, vsd_cbcr_gt4, vskiplines == 4);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, vsd_cbcr_gt2, vskiplines == 2);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, cbcr_hor_scl_mode, cbcr_hor_scl_mode);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, cbcr_ver_scl_mode, cbcr_ver_scl_mode);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, cbcr_hsd_mode, SCALE_DOWN_BIL);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, cbcr_vsd_mode, SCALE_DOWN_BIL);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, cbcr_vsu_mode, vsu_mode);
|
2015-06-26 09:14:46 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-04 05:10:31 +00:00
|
|
|
static void vop_dsp_hold_valid_irq_enable(struct vop *vop)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (WARN_ON(!vop->is_enabled))
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&vop->irq_lock, flags);
|
|
|
|
|
2016-09-14 12:54:54 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, clear, DSP_HOLD_VALID_INTR, 1);
|
2015-12-15 00:36:55 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, enable, DSP_HOLD_VALID_INTR, 1);
|
2015-02-04 05:10:31 +00:00
|
|
|
|
|
|
|
spin_unlock_irqrestore(&vop->irq_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_dsp_hold_valid_irq_disable(struct vop *vop)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (WARN_ON(!vop->is_enabled))
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&vop->irq_lock, flags);
|
|
|
|
|
2015-12-15 00:36:55 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, enable, DSP_HOLD_VALID_INTR, 0);
|
2015-02-04 05:10:31 +00:00
|
|
|
|
|
|
|
spin_unlock_irqrestore(&vop->irq_lock, flags);
|
|
|
|
}
|
|
|
|
|
2016-07-24 06:57:40 +00:00
|
|
|
/*
|
|
|
|
* (1) each frame starts at the start of the Vsync pulse which is signaled by
|
|
|
|
* the "FRAME_SYNC" interrupt.
|
|
|
|
* (2) the active data region of each frame ends at dsp_vact_end
|
|
|
|
* (3) we should program this same number (dsp_vact_end) into dsp_line_frag_num,
|
|
|
|
* to get "LINE_FLAG" interrupt at the end of the active on screen data.
|
|
|
|
*
|
|
|
|
* VOP_INTR_CTRL0.dsp_line_frag_num = VOP_DSP_VACT_ST_END.dsp_vact_end
|
|
|
|
* Interrupts
|
|
|
|
* LINE_FLAG -------------------------------+
|
|
|
|
* FRAME_SYNC ----+ |
|
|
|
|
* | |
|
|
|
|
* v v
|
|
|
|
* | Vsync | Vbp | Vactive | Vfp |
|
|
|
|
* ^ ^ ^ ^
|
|
|
|
* | | | |
|
|
|
|
* | | | |
|
|
|
|
* dsp_vs_end ------------+ | | | VOP_DSP_VTOTAL_VS_END
|
|
|
|
* dsp_vact_start --------------+ | | VOP_DSP_VACT_ST_END
|
|
|
|
* dsp_vact_end ----------------------------+ | VOP_DSP_VACT_ST_END
|
|
|
|
* dsp_total -------------------------------------+ VOP_DSP_VTOTAL_VS_END
|
|
|
|
*/
|
|
|
|
static bool vop_line_flag_irq_is_enabled(struct vop *vop)
|
|
|
|
{
|
|
|
|
uint32_t line_flag_irq;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&vop->irq_lock, flags);
|
|
|
|
|
|
|
|
line_flag_irq = VOP_INTR_GET_TYPE(vop, enable, LINE_FLAG_INTR);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&vop->irq_lock, flags);
|
|
|
|
|
|
|
|
return !!line_flag_irq;
|
|
|
|
}
|
|
|
|
|
2017-04-27 06:54:17 +00:00
|
|
|
static void vop_line_flag_irq_enable(struct vop *vop)
|
2016-07-24 06:57:40 +00:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (WARN_ON(!vop->is_enabled))
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&vop->irq_lock, flags);
|
|
|
|
|
2016-09-14 12:54:54 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, clear, LINE_FLAG_INTR, 1);
|
2016-07-24 06:57:40 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, enable, LINE_FLAG_INTR, 1);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&vop->irq_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_line_flag_irq_disable(struct vop *vop)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (WARN_ON(!vop->is_enabled))
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&vop->irq_lock, flags);
|
|
|
|
|
|
|
|
VOP_INTR_SET_TYPE(vop, enable, LINE_FLAG_INTR, 0);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&vop->irq_lock, flags);
|
|
|
|
}
|
|
|
|
|
2018-06-12 13:20:27 +00:00
|
|
|
static int vop_core_clks_enable(struct vop *vop)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = clk_enable(vop->hclk);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
ret = clk_enable(vop->aclk);
|
|
|
|
if (ret < 0)
|
|
|
|
goto err_disable_hclk;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
err_disable_hclk:
|
|
|
|
clk_disable(vop->hclk);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_core_clks_disable(struct vop *vop)
|
|
|
|
{
|
|
|
|
clk_disable(vop->aclk);
|
|
|
|
clk_disable(vop->hclk);
|
|
|
|
}
|
|
|
|
|
2019-06-11 16:08:23 +00:00
|
|
|
static void vop_win_disable(struct vop *vop, const struct vop_win *vop_win)
|
2019-02-20 22:40:06 +00:00
|
|
|
{
|
2019-06-11 16:08:23 +00:00
|
|
|
const struct vop_win_data *win = vop_win->data;
|
|
|
|
|
2019-02-20 22:40:06 +00:00
|
|
|
if (win->phy->scl && win->phy->scl->ext) {
|
|
|
|
VOP_SCL_SET_EXT(vop, win, yrgb_hor_scl_mode, SCALE_NONE);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, yrgb_ver_scl_mode, SCALE_NONE);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, cbcr_hor_scl_mode, SCALE_NONE);
|
|
|
|
VOP_SCL_SET_EXT(vop, win, cbcr_ver_scl_mode, SCALE_NONE);
|
|
|
|
}
|
|
|
|
|
|
|
|
VOP_WIN_SET(vop, win, enable, 0);
|
2019-06-11 16:08:24 +00:00
|
|
|
vop->win_enabled &= ~BIT(VOP_WIN_TO_INDEX(vop_win));
|
2019-02-20 22:40:06 +00:00
|
|
|
}
|
|
|
|
|
2019-06-11 16:08:22 +00:00
|
|
|
static int vop_enable(struct drm_crtc *crtc, struct drm_crtc_state *old_state)
|
2014-08-22 10:36:26 +00:00
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(crtc);
|
drm/rockchip: vop: fix iommu page fault when resume
Iommu would get page fault with following path:
vop_disable:
1, disable all windows and set vop config done
2, vop enter to standy, all windows not works, but their registers
are not clean, when you read window's enable bit, may found the
window is enable.
vop_enable:
1, memcpy(vop->regsbak, vop->regs, len)
save current vop registers to vop->regsbak, then you can found
window is enable on regsbak.
2, VOP_WIN_SET(vop, win, gate, 1);
force enable window gate, but gate and enable are on same
hardware register, then window enable bit rewrite to vop hardware.
3, vop power on, and vop might try to scan destroyed buffer,
then iommu get page fault.
Move windows disable after vop regsbak restore, then vop regsbak mechanism
would keep tracing the modify, everything would be safe.
Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Sandy huang <sandy.huang@rock-chips.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1501494582-6934-1-git-send-email-mark.yao@rock-chips.com
2017-07-31 09:49:42 +00:00
|
|
|
int ret, i;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-04-01 05:48:53 +00:00
|
|
|
ret = pm_runtime_get_sync(vop->dev);
|
|
|
|
if (ret < 0) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to get pm runtime: %d\n", ret);
|
2017-04-06 12:31:20 +00:00
|
|
|
return ret;
|
2015-04-01 05:48:53 +00:00
|
|
|
}
|
|
|
|
|
2018-06-12 13:20:27 +00:00
|
|
|
ret = vop_core_clks_enable(vop);
|
2016-08-15 23:12:29 +00:00
|
|
|
if (WARN_ON(ret < 0))
|
|
|
|
goto err_put_pm_runtime;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
ret = clk_enable(vop->dclk);
|
2016-08-15 23:12:29 +00:00
|
|
|
if (WARN_ON(ret < 0))
|
2018-06-12 13:20:27 +00:00
|
|
|
goto err_disable_core;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Slave iommu shares power, irq and clock with vop. It was associated
|
|
|
|
* automatically with this master device via common driver code.
|
|
|
|
* Now that we have enabled the clock we attach it to the shared drm
|
|
|
|
* mapping.
|
|
|
|
*/
|
|
|
|
ret = rockchip_drm_dma_attach_device(vop->drm_dev, vop->dev);
|
|
|
|
if (ret) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev,
|
|
|
|
"failed to attach dma mapping, %d\n", ret);
|
2018-06-12 13:20:27 +00:00
|
|
|
goto err_disable_dclk;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2018-02-20 13:01:19 +00:00
|
|
|
spin_lock(&vop->reg_lock);
|
|
|
|
for (i = 0; i < vop->len; i += 4)
|
|
|
|
writel_relaxed(vop->regsbak[i / 4], vop->regs + i);
|
|
|
|
|
drm/rockchip: vop: fix iommu page fault when resume
Iommu would get page fault with following path:
vop_disable:
1, disable all windows and set vop config done
2, vop enter to standy, all windows not works, but their registers
are not clean, when you read window's enable bit, may found the
window is enable.
vop_enable:
1, memcpy(vop->regsbak, vop->regs, len)
save current vop registers to vop->regsbak, then you can found
window is enable on regsbak.
2, VOP_WIN_SET(vop, win, gate, 1);
force enable window gate, but gate and enable are on same
hardware register, then window enable bit rewrite to vop hardware.
3, vop power on, and vop might try to scan destroyed buffer,
then iommu get page fault.
Move windows disable after vop regsbak restore, then vop regsbak mechanism
would keep tracing the modify, everything would be safe.
Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Sandy huang <sandy.huang@rock-chips.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1501494582-6934-1-git-send-email-mark.yao@rock-chips.com
2017-07-31 09:49:42 +00:00
|
|
|
/*
|
|
|
|
* We need to make sure that all windows are disabled before we
|
|
|
|
* enable the crtc. Otherwise we might try to scan from a destroyed
|
|
|
|
* buffer later.
|
2019-06-11 16:08:22 +00:00
|
|
|
*
|
|
|
|
* In the case of enable-after-PSR, we don't need to worry about this
|
|
|
|
* case since the buffer is guaranteed to be valid and disabling the
|
|
|
|
* window will result in screen glitches on PSR exit.
|
drm/rockchip: vop: fix iommu page fault when resume
Iommu would get page fault with following path:
vop_disable:
1, disable all windows and set vop config done
2, vop enter to standy, all windows not works, but their registers
are not clean, when you read window's enable bit, may found the
window is enable.
vop_enable:
1, memcpy(vop->regsbak, vop->regs, len)
save current vop registers to vop->regsbak, then you can found
window is enable on regsbak.
2, VOP_WIN_SET(vop, win, gate, 1);
force enable window gate, but gate and enable are on same
hardware register, then window enable bit rewrite to vop hardware.
3, vop power on, and vop might try to scan destroyed buffer,
then iommu get page fault.
Move windows disable after vop regsbak restore, then vop regsbak mechanism
would keep tracing the modify, everything would be safe.
Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Sandy huang <sandy.huang@rock-chips.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1501494582-6934-1-git-send-email-mark.yao@rock-chips.com
2017-07-31 09:49:42 +00:00
|
|
|
*/
|
2019-06-11 16:08:22 +00:00
|
|
|
if (!old_state || !old_state->self_refresh_active) {
|
|
|
|
for (i = 0; i < vop->data->win_size; i++) {
|
|
|
|
struct vop_win *vop_win = &vop->win[i];
|
drm/rockchip: vop: fix iommu page fault when resume
Iommu would get page fault with following path:
vop_disable:
1, disable all windows and set vop config done
2, vop enter to standy, all windows not works, but their registers
are not clean, when you read window's enable bit, may found the
window is enable.
vop_enable:
1, memcpy(vop->regsbak, vop->regs, len)
save current vop registers to vop->regsbak, then you can found
window is enable on regsbak.
2, VOP_WIN_SET(vop, win, gate, 1);
force enable window gate, but gate and enable are on same
hardware register, then window enable bit rewrite to vop hardware.
3, vop power on, and vop might try to scan destroyed buffer,
then iommu get page fault.
Move windows disable after vop regsbak restore, then vop regsbak mechanism
would keep tracing the modify, everything would be safe.
Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Sandy huang <sandy.huang@rock-chips.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1501494582-6934-1-git-send-email-mark.yao@rock-chips.com
2017-07-31 09:49:42 +00:00
|
|
|
|
2019-06-11 16:08:23 +00:00
|
|
|
vop_win_disable(vop, vop_win);
|
2019-06-11 16:08:22 +00:00
|
|
|
}
|
drm/rockchip: vop: fix iommu page fault when resume
Iommu would get page fault with following path:
vop_disable:
1, disable all windows and set vop config done
2, vop enter to standy, all windows not works, but their registers
are not clean, when you read window's enable bit, may found the
window is enable.
vop_enable:
1, memcpy(vop->regsbak, vop->regs, len)
save current vop registers to vop->regsbak, then you can found
window is enable on regsbak.
2, VOP_WIN_SET(vop, win, gate, 1);
force enable window gate, but gate and enable are on same
hardware register, then window enable bit rewrite to vop hardware.
3, vop power on, and vop might try to scan destroyed buffer,
then iommu get page fault.
Move windows disable after vop regsbak restore, then vop regsbak mechanism
would keep tracing the modify, everything would be safe.
Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Sandy huang <sandy.huang@rock-chips.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1501494582-6934-1-git-send-email-mark.yao@rock-chips.com
2017-07-31 09:49:42 +00:00
|
|
|
}
|
2018-02-20 13:01:19 +00:00
|
|
|
spin_unlock(&vop->reg_lock);
|
drm/rockchip: vop: fix iommu page fault when resume
Iommu would get page fault with following path:
vop_disable:
1, disable all windows and set vop config done
2, vop enter to standy, all windows not works, but their registers
are not clean, when you read window's enable bit, may found the
window is enable.
vop_enable:
1, memcpy(vop->regsbak, vop->regs, len)
save current vop registers to vop->regsbak, then you can found
window is enable on regsbak.
2, VOP_WIN_SET(vop, win, gate, 1);
force enable window gate, but gate and enable are on same
hardware register, then window enable bit rewrite to vop hardware.
3, vop power on, and vop might try to scan destroyed buffer,
then iommu get page fault.
Move windows disable after vop regsbak restore, then vop regsbak mechanism
would keep tracing the modify, everything would be safe.
Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Sandy huang <sandy.huang@rock-chips.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1501494582-6934-1-git-send-email-mark.yao@rock-chips.com
2017-07-31 09:49:42 +00:00
|
|
|
|
2016-08-27 03:39:38 +00:00
|
|
|
vop_cfg_done(vop);
|
|
|
|
|
2015-01-22 10:29:57 +00:00
|
|
|
/*
|
|
|
|
* At here, vop clock & iommu is enable, R/W vop regs would be safe.
|
|
|
|
*/
|
|
|
|
vop->is_enabled = true;
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
spin_lock(&vop->reg_lock);
|
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, common, standby, 1);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
spin_unlock(&vop->reg_lock);
|
|
|
|
|
2015-11-23 07:21:08 +00:00
|
|
|
drm_crtc_vblank_on(crtc);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2016-08-15 23:12:29 +00:00
|
|
|
return 0;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
err_disable_dclk:
|
|
|
|
clk_disable(vop->dclk);
|
2018-06-12 13:20:27 +00:00
|
|
|
err_disable_core:
|
|
|
|
vop_core_clks_disable(vop);
|
2016-08-15 23:12:29 +00:00
|
|
|
err_put_pm_runtime:
|
|
|
|
pm_runtime_put_sync(vop->dev);
|
|
|
|
return ret;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2019-06-11 16:08:24 +00:00
|
|
|
static void rockchip_drm_set_win_enabled(struct drm_crtc *crtc, bool enabled)
|
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(crtc);
|
|
|
|
int i;
|
|
|
|
|
|
|
|
spin_lock(&vop->reg_lock);
|
|
|
|
|
|
|
|
for (i = 0; i < vop->data->win_size; i++) {
|
|
|
|
struct vop_win *vop_win = &vop->win[i];
|
|
|
|
const struct vop_win_data *win = vop_win->data;
|
|
|
|
|
|
|
|
VOP_WIN_SET(vop, win, enable,
|
|
|
|
enabled && (vop->win_enabled & BIT(i)));
|
|
|
|
}
|
|
|
|
vop_cfg_done(vop);
|
|
|
|
|
|
|
|
spin_unlock(&vop->reg_lock);
|
|
|
|
}
|
|
|
|
|
2017-06-30 09:36:45 +00:00
|
|
|
static void vop_crtc_atomic_disable(struct drm_crtc *crtc,
|
|
|
|
struct drm_crtc_state *old_state)
|
2014-08-22 10:36:26 +00:00
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(crtc);
|
|
|
|
|
2016-06-08 12:19:12 +00:00
|
|
|
WARN_ON(vop->event);
|
|
|
|
|
2019-06-11 16:08:24 +00:00
|
|
|
if (crtc->state->self_refresh_active)
|
|
|
|
rockchip_drm_set_win_enabled(crtc, false);
|
2019-06-11 16:08:22 +00:00
|
|
|
|
2019-06-11 16:08:24 +00:00
|
|
|
mutex_lock(&vop->vop_lock);
|
2019-06-11 16:08:22 +00:00
|
|
|
|
2015-11-23 07:21:08 +00:00
|
|
|
drm_crtc_vblank_off(crtc);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2019-06-11 16:08:24 +00:00
|
|
|
if (crtc->state->self_refresh_active)
|
|
|
|
goto out;
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
/*
|
2015-02-04 05:10:31 +00:00
|
|
|
* Vop standby will take effect at end of current frame,
|
|
|
|
* if dsp hold valid irq happen, it means standby complete.
|
|
|
|
*
|
|
|
|
* we must wait standby complete when we want to disable aclk,
|
|
|
|
* if not, memory bus maybe dead.
|
2014-08-22 10:36:26 +00:00
|
|
|
*/
|
2015-02-04 05:10:31 +00:00
|
|
|
reinit_completion(&vop->dsp_hold_completion);
|
|
|
|
vop_dsp_hold_valid_irq_enable(vop);
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
spin_lock(&vop->reg_lock);
|
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, common, standby, 1);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
spin_unlock(&vop->reg_lock);
|
2015-01-22 10:29:57 +00:00
|
|
|
|
2015-02-04 05:10:31 +00:00
|
|
|
wait_for_completion(&vop->dsp_hold_completion);
|
|
|
|
|
|
|
|
vop_dsp_hold_valid_irq_disable(vop);
|
|
|
|
|
2015-01-22 10:29:57 +00:00
|
|
|
vop->is_enabled = false;
|
2015-02-04 05:10:31 +00:00
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
/*
|
2015-02-04 05:10:31 +00:00
|
|
|
* vop standby complete, so iommu detach is safe.
|
2014-08-22 10:36:26 +00:00
|
|
|
*/
|
|
|
|
rockchip_drm_dma_detach_device(vop->drm_dev, vop->dev);
|
|
|
|
|
2015-02-04 05:10:31 +00:00
|
|
|
clk_disable(vop->dclk);
|
2018-06-12 13:20:27 +00:00
|
|
|
vop_core_clks_disable(vop);
|
2015-04-01 05:48:53 +00:00
|
|
|
pm_runtime_put(vop->dev);
|
2019-06-11 16:08:24 +00:00
|
|
|
|
|
|
|
out:
|
2018-03-09 22:22:55 +00:00
|
|
|
mutex_unlock(&vop->vop_lock);
|
2016-06-08 12:19:12 +00:00
|
|
|
|
|
|
|
if (crtc->state->event && !crtc->state->active) {
|
|
|
|
spin_lock_irq(&crtc->dev->event_lock);
|
|
|
|
drm_crtc_send_vblank_event(crtc, crtc->state->event);
|
|
|
|
spin_unlock_irq(&crtc->dev->event_lock);
|
|
|
|
|
|
|
|
crtc->state->event = NULL;
|
|
|
|
}
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
static void vop_plane_destroy(struct drm_plane *plane)
|
2014-08-22 10:36:26 +00:00
|
|
|
{
|
2015-11-30 10:22:42 +00:00
|
|
|
drm_plane_cleanup(plane);
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
static int vop_plane_atomic_check(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *state)
|
2014-08-22 10:36:26 +00:00
|
|
|
{
|
2015-11-30 10:22:42 +00:00
|
|
|
struct drm_crtc *crtc = state->crtc;
|
2016-03-04 11:04:03 +00:00
|
|
|
struct drm_crtc_state *crtc_state;
|
2015-11-30 10:22:42 +00:00
|
|
|
struct drm_framebuffer *fb = state->fb;
|
2014-08-22 10:36:26 +00:00
|
|
|
struct vop_win *vop_win = to_vop_win(plane);
|
|
|
|
const struct vop_win_data *win = vop_win->data;
|
|
|
|
int ret;
|
2015-06-26 09:14:46 +00:00
|
|
|
int min_scale = win->phy->scl ? FRAC_16_16(1, 8) :
|
|
|
|
DRM_PLANE_HELPER_NO_SCALING;
|
|
|
|
int max_scale = win->phy->scl ? FRAC_16_16(8, 1) :
|
|
|
|
DRM_PLANE_HELPER_NO_SCALING;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
if (!crtc || !fb)
|
2016-09-14 12:55:01 +00:00
|
|
|
return 0;
|
2016-03-04 11:04:03 +00:00
|
|
|
|
|
|
|
crtc_state = drm_atomic_get_existing_crtc_state(state->state, crtc);
|
|
|
|
if (WARN_ON(!crtc_state))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2018-01-23 17:08:57 +00:00
|
|
|
ret = drm_atomic_helper_check_plane_state(state, crtc_state,
|
2017-11-01 20:16:19 +00:00
|
|
|
min_scale, max_scale,
|
|
|
|
true, true);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2016-07-26 16:07:02 +00:00
|
|
|
if (!state->visible)
|
2016-09-14 12:55:01 +00:00
|
|
|
return 0;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2016-12-14 21:32:55 +00:00
|
|
|
ret = vop_convert_format(fb->format->format);
|
2016-09-14 12:55:01 +00:00
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2015-07-20 08:16:49 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
/*
|
|
|
|
* Src.x1 can be odd when do clip, but yuv plane start point
|
|
|
|
* need align with 2 pixel.
|
|
|
|
*/
|
2018-07-17 17:13:44 +00:00
|
|
|
if (fb->format->is_yuv && ((state->src.x1 >> 16) % 2)) {
|
2017-07-31 09:49:55 +00:00
|
|
|
DRM_ERROR("Invalid Source: Yuv format not support odd xpos\n");
|
2014-08-22 10:36:26 +00:00
|
|
|
return -EINVAL;
|
2017-07-31 09:49:55 +00:00
|
|
|
}
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2019-01-09 18:56:39 +00:00
|
|
|
if (fb->format->is_yuv && state->rotation & DRM_MODE_REFLECT_Y) {
|
|
|
|
DRM_ERROR("Invalid Source: Yuv format does not support this rotation\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
static void vop_plane_atomic_disable(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *old_state)
|
|
|
|
{
|
|
|
|
struct vop_win *vop_win = to_vop_win(plane);
|
|
|
|
struct vop *vop = to_vop(old_state->crtc);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
if (!old_state->crtc)
|
|
|
|
return;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
spin_lock(&vop->reg_lock);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2019-06-11 16:08:23 +00:00
|
|
|
vop_win_disable(vop, vop_win);
|
2015-07-20 08:16:49 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
spin_unlock(&vop->reg_lock);
|
|
|
|
}
|
2015-07-20 08:16:49 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
static void vop_plane_atomic_update(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *old_state)
|
|
|
|
{
|
|
|
|
struct drm_plane_state *state = plane->state;
|
|
|
|
struct drm_crtc *crtc = state->crtc;
|
|
|
|
struct vop_win *vop_win = to_vop_win(plane);
|
|
|
|
const struct vop_win_data *win = vop_win->data;
|
2019-01-08 21:46:59 +00:00
|
|
|
const struct vop_win_yuv2yuv_data *win_yuv2yuv = vop_win->yuv2yuv_data;
|
2015-11-30 10:22:42 +00:00
|
|
|
struct vop *vop = to_vop(state->crtc);
|
|
|
|
struct drm_framebuffer *fb = state->fb;
|
|
|
|
unsigned int actual_w, actual_h;
|
|
|
|
unsigned int dsp_stx, dsp_sty;
|
|
|
|
uint32_t act_info, dsp_info, dsp_st;
|
2016-07-26 16:07:01 +00:00
|
|
|
struct drm_rect *src = &state->src;
|
|
|
|
struct drm_rect *dest = &state->dst;
|
2015-11-30 10:22:42 +00:00
|
|
|
struct drm_gem_object *obj, *uv_obj;
|
|
|
|
struct rockchip_gem_object *rk_obj, *rk_uv_obj;
|
|
|
|
unsigned long offset;
|
|
|
|
dma_addr_t dma_addr;
|
|
|
|
uint32_t val;
|
|
|
|
bool rb_swap;
|
2018-04-18 17:31:52 +00:00
|
|
|
int win_index = VOP_WIN_TO_INDEX(vop_win);
|
2016-09-14 12:55:01 +00:00
|
|
|
int format;
|
2019-01-08 21:46:59 +00:00
|
|
|
int is_yuv = fb->format->is_yuv;
|
|
|
|
int i;
|
2015-07-20 08:16:49 +00:00
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
/*
|
2015-11-30 10:22:42 +00:00
|
|
|
* can't update plane when vop is disabled.
|
2014-08-22 10:36:26 +00:00
|
|
|
*/
|
2016-06-08 12:19:11 +00:00
|
|
|
if (WARN_ON(!crtc))
|
2015-11-30 10:22:42 +00:00
|
|
|
return;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
if (WARN_ON(!vop->is_enabled))
|
|
|
|
return;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2016-09-14 12:55:01 +00:00
|
|
|
if (!state->visible) {
|
2015-11-30 10:22:42 +00:00
|
|
|
vop_plane_atomic_disable(plane, old_state);
|
|
|
|
return;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
2015-11-30 10:22:42 +00:00
|
|
|
|
2018-03-30 14:11:19 +00:00
|
|
|
obj = fb->obj[0];
|
2015-11-30 10:22:42 +00:00
|
|
|
rk_obj = to_rockchip_obj(obj);
|
|
|
|
|
|
|
|
actual_w = drm_rect_width(src) >> 16;
|
|
|
|
actual_h = drm_rect_height(src) >> 16;
|
|
|
|
act_info = (actual_h - 1) << 16 | ((actual_w - 1) & 0xffff);
|
|
|
|
|
|
|
|
dsp_info = (drm_rect_height(dest) - 1) << 16;
|
|
|
|
dsp_info |= (drm_rect_width(dest) - 1) & 0xffff;
|
|
|
|
|
|
|
|
dsp_stx = dest->x1 + crtc->mode.htotal - crtc->mode.hsync_start;
|
|
|
|
dsp_sty = dest->y1 + crtc->mode.vtotal - crtc->mode.vsync_start;
|
|
|
|
dsp_st = dsp_sty << 16 | (dsp_stx & 0xffff);
|
|
|
|
|
2016-12-14 21:30:57 +00:00
|
|
|
offset = (src->x1 >> 16) * fb->format->cpp[0];
|
2015-11-30 10:22:42 +00:00
|
|
|
offset += (src->y1 >> 16) * fb->pitches[0];
|
2016-09-14 12:55:01 +00:00
|
|
|
dma_addr = rk_obj->dma_addr + offset + fb->offsets[0];
|
|
|
|
|
2019-01-09 18:56:39 +00:00
|
|
|
/*
|
|
|
|
* For y-mirroring we need to move address
|
|
|
|
* to the beginning of the last line.
|
|
|
|
*/
|
|
|
|
if (state->rotation & DRM_MODE_REFLECT_Y)
|
|
|
|
dma_addr += (actual_h - 1) * fb->pitches[0];
|
|
|
|
|
2016-12-14 21:32:55 +00:00
|
|
|
format = vop_convert_format(fb->format->format);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
spin_lock(&vop->reg_lock);
|
|
|
|
|
2016-09-14 12:55:01 +00:00
|
|
|
VOP_WIN_SET(vop, win, format, format);
|
2017-07-31 09:49:50 +00:00
|
|
|
VOP_WIN_SET(vop, win, yrgb_vir, DIV_ROUND_UP(fb->pitches[0], 4));
|
2016-09-14 12:55:01 +00:00
|
|
|
VOP_WIN_SET(vop, win, yrgb_mst, dma_addr);
|
2019-01-08 21:46:59 +00:00
|
|
|
VOP_WIN_YUV2YUV_SET(vop, win_yuv2yuv, y2r_en, is_yuv);
|
2019-01-09 18:56:39 +00:00
|
|
|
VOP_WIN_SET(vop, win, y_mir_en,
|
|
|
|
(state->rotation & DRM_MODE_REFLECT_Y) ? 1 : 0);
|
|
|
|
VOP_WIN_SET(vop, win, x_mir_en,
|
|
|
|
(state->rotation & DRM_MODE_REFLECT_X) ? 1 : 0);
|
2019-01-08 21:46:59 +00:00
|
|
|
|
|
|
|
if (is_yuv) {
|
2019-05-16 10:31:48 +00:00
|
|
|
int hsub = fb->format->hsub;
|
|
|
|
int vsub = fb->format->vsub;
|
2016-12-14 21:30:57 +00:00
|
|
|
int bpp = fb->format->cpp[1];
|
2015-11-30 10:22:42 +00:00
|
|
|
|
2018-03-30 14:11:19 +00:00
|
|
|
uv_obj = fb->obj[1];
|
2015-11-30 10:22:42 +00:00
|
|
|
rk_uv_obj = to_rockchip_obj(uv_obj);
|
|
|
|
|
|
|
|
offset = (src->x1 >> 16) * bpp / hsub;
|
|
|
|
offset += (src->y1 >> 16) * fb->pitches[1] / vsub;
|
|
|
|
|
|
|
|
dma_addr = rk_uv_obj->dma_addr + offset + fb->offsets[1];
|
2017-07-31 09:49:50 +00:00
|
|
|
VOP_WIN_SET(vop, win, uv_vir, DIV_ROUND_UP(fb->pitches[1], 4));
|
2015-11-30 10:22:42 +00:00
|
|
|
VOP_WIN_SET(vop, win, uv_mst, dma_addr);
|
2019-01-08 21:46:59 +00:00
|
|
|
|
|
|
|
for (i = 0; i < NUM_YUV2YUV_COEFFICIENTS; i++) {
|
|
|
|
VOP_WIN_YUV2YUV_COEFFICIENT_SET(vop,
|
|
|
|
win_yuv2yuv,
|
|
|
|
y2r_coefficients[i],
|
|
|
|
bt601_yuv2rgb[i]);
|
|
|
|
}
|
2015-07-20 08:16:49 +00:00
|
|
|
}
|
2015-06-26 09:14:46 +00:00
|
|
|
|
|
|
|
if (win->phy->scl)
|
|
|
|
scl_vop_cal_scl_fac(vop, win, actual_w, actual_h,
|
2015-11-30 10:22:42 +00:00
|
|
|
drm_rect_width(dest), drm_rect_height(dest),
|
2019-05-16 10:31:46 +00:00
|
|
|
fb->format);
|
2015-06-26 09:14:46 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
VOP_WIN_SET(vop, win, act_info, act_info);
|
|
|
|
VOP_WIN_SET(vop, win, dsp_info, dsp_info);
|
|
|
|
VOP_WIN_SET(vop, win, dsp_st, dsp_st);
|
2015-06-26 09:14:46 +00:00
|
|
|
|
2016-12-14 21:32:55 +00:00
|
|
|
rb_swap = has_rb_swapped(fb->format->format);
|
2015-05-11 10:55:39 +00:00
|
|
|
VOP_WIN_SET(vop, win, rb_swap, rb_swap);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2018-04-18 17:31:52 +00:00
|
|
|
/*
|
|
|
|
* Blending win0 with the background color doesn't seem to work
|
|
|
|
* correctly. We only get the background color, no matter the contents
|
|
|
|
* of the win0 framebuffer. However, blending pre-multiplied color
|
|
|
|
* with the default opaque black default background color is a no-op,
|
|
|
|
* so we can just disable blending to get the correct result.
|
|
|
|
*/
|
|
|
|
if (fb->format->has_alpha && win_index > 0) {
|
2014-08-22 10:36:26 +00:00
|
|
|
VOP_WIN_SET(vop, win, dst_alpha_ctl,
|
|
|
|
DST_FACTOR_M0(ALPHA_SRC_INVERSE));
|
|
|
|
val = SRC_ALPHA_EN(1) | SRC_COLOR_M0(ALPHA_SRC_PRE_MUL) |
|
|
|
|
SRC_ALPHA_M0(ALPHA_STRAIGHT) |
|
|
|
|
SRC_BLEND_M0(ALPHA_PER_PIX) |
|
|
|
|
SRC_ALPHA_CAL_M0(ALPHA_NO_SATURATION) |
|
|
|
|
SRC_FACTOR_M0(ALPHA_ONE);
|
|
|
|
VOP_WIN_SET(vop, win, src_alpha_ctl, val);
|
|
|
|
} else {
|
|
|
|
VOP_WIN_SET(vop, win, src_alpha_ctl, SRC_ALPHA_EN(0));
|
|
|
|
}
|
|
|
|
|
|
|
|
VOP_WIN_SET(vop, win, enable, 1);
|
2019-06-11 16:08:24 +00:00
|
|
|
vop->win_enabled |= BIT(win_index);
|
2014-08-22 10:36:26 +00:00
|
|
|
spin_unlock(&vop->reg_lock);
|
|
|
|
}
|
|
|
|
|
2018-12-05 12:33:10 +00:00
|
|
|
static int vop_plane_atomic_async_check(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *state)
|
|
|
|
{
|
|
|
|
struct vop_win *vop_win = to_vop_win(plane);
|
|
|
|
const struct vop_win_data *win = vop_win->data;
|
|
|
|
int min_scale = win->phy->scl ? FRAC_16_16(1, 8) :
|
|
|
|
DRM_PLANE_HELPER_NO_SCALING;
|
|
|
|
int max_scale = win->phy->scl ? FRAC_16_16(8, 1) :
|
|
|
|
DRM_PLANE_HELPER_NO_SCALING;
|
|
|
|
struct drm_crtc_state *crtc_state;
|
|
|
|
|
|
|
|
if (plane != state->crtc->cursor)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (!plane->state)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (!plane->state->fb)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (state->state)
|
|
|
|
crtc_state = drm_atomic_get_existing_crtc_state(state->state,
|
|
|
|
state->crtc);
|
|
|
|
else /* Special case for asynchronous cursor updates. */
|
|
|
|
crtc_state = plane->crtc->state;
|
|
|
|
|
|
|
|
return drm_atomic_helper_check_plane_state(plane->state, crtc_state,
|
|
|
|
min_scale, max_scale,
|
|
|
|
true, true);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_plane_atomic_async_update(struct drm_plane *plane,
|
|
|
|
struct drm_plane_state *new_state)
|
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(plane->state->crtc);
|
drm/rockchip: fix fb references in async update
In the case of async update, modifications are done in place, i.e. in the
current plane state, so the new_state is prepared and the new_state is
cleaned up (instead of the old_state, unlike what happens in a
normal sync update).
To cleanup the old_fb properly, it needs to be placed in the new_state
in the end of async_update, so cleanup call will unreference the old_fb
correctly.
Also, the previous code had a:
plane_state = plane->funcs->atomic_duplicate_state(plane);
...
swap(plane_state, plane->state);
if (plane->state->fb && plane->state->fb != new_state->fb) {
...
}
Which was wrong, as the fb were just assigned to be equal, so this if
statement nevers evaluates to true.
Another details is that the function drm_crtc_vblank_get() can only be
called when vop->is_enabled is true, otherwise it has no effect and
trows a WARN_ON().
Calling drm_atomic_set_fb_for_plane() (which get a referent of the new
fb and pus the old fb) is not required, as it is taken care by
drm_mode_cursor_universal() when calling
drm_atomic_helper_update_plane().
Fixes: 15609559a834 ("drm/rockchip: update cursors asynchronously through atomic.")
Cc: <stable@vger.kernel.org> # v4.20+
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190603165610.24614-2-helen.koike@collabora.com
2019-06-03 16:56:06 +00:00
|
|
|
struct drm_framebuffer *old_fb = plane->state->fb;
|
|
|
|
|
|
|
|
plane->state->crtc_x = new_state->crtc_x;
|
|
|
|
plane->state->crtc_y = new_state->crtc_y;
|
|
|
|
plane->state->crtc_h = new_state->crtc_h;
|
|
|
|
plane->state->crtc_w = new_state->crtc_w;
|
|
|
|
plane->state->src_x = new_state->src_x;
|
|
|
|
plane->state->src_y = new_state->src_y;
|
|
|
|
plane->state->src_h = new_state->src_h;
|
|
|
|
plane->state->src_w = new_state->src_w;
|
|
|
|
swap(plane->state->fb, new_state->fb);
|
2018-12-05 12:33:10 +00:00
|
|
|
|
|
|
|
if (vop->is_enabled) {
|
|
|
|
vop_plane_atomic_update(plane, plane->state);
|
|
|
|
spin_lock(&vop->reg_lock);
|
|
|
|
vop_cfg_done(vop);
|
|
|
|
spin_unlock(&vop->reg_lock);
|
|
|
|
|
drm/rockchip: fix fb references in async update
In the case of async update, modifications are done in place, i.e. in the
current plane state, so the new_state is prepared and the new_state is
cleaned up (instead of the old_state, unlike what happens in a
normal sync update).
To cleanup the old_fb properly, it needs to be placed in the new_state
in the end of async_update, so cleanup call will unreference the old_fb
correctly.
Also, the previous code had a:
plane_state = plane->funcs->atomic_duplicate_state(plane);
...
swap(plane_state, plane->state);
if (plane->state->fb && plane->state->fb != new_state->fb) {
...
}
Which was wrong, as the fb were just assigned to be equal, so this if
statement nevers evaluates to true.
Another details is that the function drm_crtc_vblank_get() can only be
called when vop->is_enabled is true, otherwise it has no effect and
trows a WARN_ON().
Calling drm_atomic_set_fb_for_plane() (which get a referent of the new
fb and pus the old fb) is not required, as it is taken care by
drm_mode_cursor_universal() when calling
drm_atomic_helper_update_plane().
Fixes: 15609559a834 ("drm/rockchip: update cursors asynchronously through atomic.")
Cc: <stable@vger.kernel.org> # v4.20+
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190603165610.24614-2-helen.koike@collabora.com
2019-06-03 16:56:06 +00:00
|
|
|
/*
|
|
|
|
* A scanout can still be occurring, so we can't drop the
|
|
|
|
* reference to the old framebuffer. To solve this we get a
|
|
|
|
* reference to old_fb and set a worker to release it later.
|
|
|
|
* FIXME: if we perform 500 async_update calls before the
|
|
|
|
* vblank, then we can have 500 different framebuffers waiting
|
|
|
|
* to be released.
|
|
|
|
*/
|
|
|
|
if (old_fb && plane->state->fb != old_fb) {
|
|
|
|
drm_framebuffer_get(old_fb);
|
|
|
|
WARN_ON(drm_crtc_vblank_get(plane->state->crtc) != 0);
|
|
|
|
drm_flip_work_queue(&vop->fb_unref_work, old_fb);
|
|
|
|
set_bit(VOP_PENDING_FB_UNREF, &vop->pending);
|
|
|
|
}
|
|
|
|
}
|
2018-12-05 12:33:10 +00:00
|
|
|
}
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
static const struct drm_plane_helper_funcs plane_helper_funcs = {
|
|
|
|
.atomic_check = vop_plane_atomic_check,
|
|
|
|
.atomic_update = vop_plane_atomic_update,
|
|
|
|
.atomic_disable = vop_plane_atomic_disable,
|
2018-12-05 12:33:10 +00:00
|
|
|
.atomic_async_check = vop_plane_atomic_async_check,
|
|
|
|
.atomic_async_update = vop_plane_atomic_async_update,
|
2018-11-30 10:24:49 +00:00
|
|
|
.prepare_fb = drm_gem_fb_prepare_fb,
|
2015-11-30 10:22:42 +00:00
|
|
|
};
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
static const struct drm_plane_funcs vop_plane_funcs = {
|
2015-11-30 10:22:42 +00:00
|
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
2014-08-22 10:36:26 +00:00
|
|
|
.destroy = vop_plane_destroy,
|
2016-09-14 12:55:01 +00:00
|
|
|
.reset = drm_atomic_helper_plane_reset,
|
|
|
|
.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
|
|
|
|
.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
|
2014-08-22 10:36:26 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
static int vop_crtc_enable_vblank(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(crtc);
|
|
|
|
unsigned long flags;
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
if (WARN_ON(!vop->is_enabled))
|
2014-08-22 10:36:26 +00:00
|
|
|
return -EPERM;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&vop->irq_lock, flags);
|
|
|
|
|
2016-09-14 12:54:54 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, clear, FS_INTR, 1);
|
2015-12-15 00:36:55 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, enable, FS_INTR, 1);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
spin_unlock_irqrestore(&vop->irq_lock, flags);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_crtc_disable_vblank(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(crtc);
|
|
|
|
unsigned long flags;
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
if (WARN_ON(!vop->is_enabled))
|
2014-08-22 10:36:26 +00:00
|
|
|
return;
|
2015-01-22 06:37:56 +00:00
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
spin_lock_irqsave(&vop->irq_lock, flags);
|
2015-12-15 00:36:55 +00:00
|
|
|
|
|
|
|
VOP_INTR_SET_TYPE(vop, enable, FS_INTR, 0);
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
spin_unlock_irqrestore(&vop->irq_lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
|
|
|
|
const struct drm_display_mode *mode,
|
|
|
|
struct drm_display_mode *adjusted_mode)
|
|
|
|
{
|
2016-01-06 04:03:53 +00:00
|
|
|
struct vop *vop = to_vop(crtc);
|
|
|
|
|
|
|
|
adjusted_mode->clock =
|
2019-06-14 22:47:30 +00:00
|
|
|
DIV_ROUND_UP(clk_round_rate(vop->dclk,
|
|
|
|
adjusted_mode->clock * 1000), 1000);
|
2016-01-06 04:03:53 +00:00
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2017-06-30 09:36:44 +00:00
|
|
|
static void vop_crtc_atomic_enable(struct drm_crtc *crtc,
|
|
|
|
struct drm_crtc_state *old_state)
|
2014-08-22 10:36:26 +00:00
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(crtc);
|
2017-05-27 11:43:36 +00:00
|
|
|
const struct vop_data *vop_data = vop->data;
|
2016-04-20 02:41:42 +00:00
|
|
|
struct rockchip_crtc_state *s = to_rockchip_crtc_state(crtc->state);
|
2015-11-30 10:22:42 +00:00
|
|
|
struct drm_display_mode *adjusted_mode = &crtc->state->adjusted_mode;
|
2014-08-22 10:36:26 +00:00
|
|
|
u16 hsync_len = adjusted_mode->hsync_end - adjusted_mode->hsync_start;
|
|
|
|
u16 hdisplay = adjusted_mode->hdisplay;
|
|
|
|
u16 htotal = adjusted_mode->htotal;
|
|
|
|
u16 hact_st = adjusted_mode->htotal - adjusted_mode->hsync_start;
|
|
|
|
u16 hact_end = hact_st + hdisplay;
|
|
|
|
u16 vdisplay = adjusted_mode->vdisplay;
|
|
|
|
u16 vtotal = adjusted_mode->vtotal;
|
|
|
|
u16 vsync_len = adjusted_mode->vsync_end - adjusted_mode->vsync_start;
|
|
|
|
u16 vact_st = adjusted_mode->vtotal - adjusted_mode->vsync_start;
|
|
|
|
u16 vact_end = vact_st + vdisplay;
|
2016-04-20 06:18:16 +00:00
|
|
|
uint32_t pin_pol, val;
|
2019-03-18 15:44:12 +00:00
|
|
|
int dither_bpc = s->output_bpc ? s->output_bpc : 10;
|
2016-08-15 23:12:29 +00:00
|
|
|
int ret;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2019-06-11 16:08:24 +00:00
|
|
|
if (old_state && old_state->self_refresh_active) {
|
|
|
|
drm_crtc_vblank_on(crtc);
|
|
|
|
rockchip_drm_set_win_enabled(crtc, true);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-03-09 22:22:55 +00:00
|
|
|
mutex_lock(&vop->vop_lock);
|
|
|
|
|
2016-06-08 12:19:12 +00:00
|
|
|
WARN_ON(vop->event);
|
|
|
|
|
2019-06-11 16:08:22 +00:00
|
|
|
ret = vop_enable(crtc, old_state);
|
2016-08-15 23:12:29 +00:00
|
|
|
if (ret) {
|
2018-03-09 22:22:55 +00:00
|
|
|
mutex_unlock(&vop->vop_lock);
|
2016-08-15 23:12:29 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "Failed to enable vop (%d)\n", ret);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-02-05 07:54:56 +00:00
|
|
|
pin_pol = BIT(DCLK_INVERT);
|
2017-02-24 12:55:03 +00:00
|
|
|
pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) ?
|
|
|
|
BIT(HSYNC_POSITIVE) : 0;
|
|
|
|
pin_pol |= (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC) ?
|
|
|
|
BIT(VSYNC_POSITIVE) : 0;
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, output, pin_pol, pin_pol);
|
2018-10-01 12:38:45 +00:00
|
|
|
VOP_REG_SET(vop, output, mipi_dual_channel_en, 0);
|
2016-04-20 06:18:16 +00:00
|
|
|
|
2016-04-20 02:41:42 +00:00
|
|
|
switch (s->output_type) {
|
|
|
|
case DRM_MODE_CONNECTOR_LVDS:
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, output, rgb_en, 1);
|
|
|
|
VOP_REG_SET(vop, output, rgb_pin_pol, pin_pol);
|
2016-04-20 02:41:42 +00:00
|
|
|
break;
|
|
|
|
case DRM_MODE_CONNECTOR_eDP:
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, output, edp_pin_pol, pin_pol);
|
|
|
|
VOP_REG_SET(vop, output, edp_en, 1);
|
2016-04-20 02:41:42 +00:00
|
|
|
break;
|
|
|
|
case DRM_MODE_CONNECTOR_HDMIA:
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, output, hdmi_pin_pol, pin_pol);
|
|
|
|
VOP_REG_SET(vop, output, hdmi_en, 1);
|
2016-04-20 02:41:42 +00:00
|
|
|
break;
|
|
|
|
case DRM_MODE_CONNECTOR_DSI:
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, output, mipi_pin_pol, pin_pol);
|
|
|
|
VOP_REG_SET(vop, output, mipi_en, 1);
|
2018-10-01 12:38:45 +00:00
|
|
|
VOP_REG_SET(vop, output, mipi_dual_channel_en,
|
|
|
|
!!(s->output_flags & ROCKCHIP_OUTPUT_DSI_DUAL));
|
2016-04-20 02:41:42 +00:00
|
|
|
break;
|
2017-02-05 07:54:56 +00:00
|
|
|
case DRM_MODE_CONNECTOR_DisplayPort:
|
|
|
|
pin_pol &= ~BIT(DCLK_INVERT);
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, output, dp_pin_pol, pin_pol);
|
|
|
|
VOP_REG_SET(vop, output, dp_en, 1);
|
2017-02-05 07:54:56 +00:00
|
|
|
break;
|
2016-04-20 02:41:42 +00:00
|
|
|
default:
|
2016-08-12 17:00:54 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "unsupported connector_type [%d]\n",
|
|
|
|
s->output_type);
|
2016-04-20 02:41:42 +00:00
|
|
|
}
|
2017-05-27 11:43:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* if vop is not support RGB10 output, need force RGB10 to RGB888.
|
|
|
|
*/
|
|
|
|
if (s->output_mode == ROCKCHIP_OUT_MODE_AAAA &&
|
|
|
|
!(vop_data->feature & VOP_FEATURE_OUTPUT_RGB10))
|
|
|
|
s->output_mode = ROCKCHIP_OUT_MODE_P888;
|
2018-04-23 10:49:57 +00:00
|
|
|
|
2019-03-18 15:44:12 +00:00
|
|
|
if (s->output_mode == ROCKCHIP_OUT_MODE_AAAA && dither_bpc <= 8)
|
2018-04-23 10:49:57 +00:00
|
|
|
VOP_REG_SET(vop, common, pre_dither_down, 1);
|
|
|
|
else
|
|
|
|
VOP_REG_SET(vop, common, pre_dither_down, 0);
|
|
|
|
|
2019-03-18 15:44:12 +00:00
|
|
|
if (dither_bpc == 6) {
|
|
|
|
VOP_REG_SET(vop, common, dither_down_sel, DITHER_DOWN_ALLEGRO);
|
|
|
|
VOP_REG_SET(vop, common, dither_down_mode, RGB888_TO_RGB666);
|
|
|
|
VOP_REG_SET(vop, common, dither_down_en, 1);
|
|
|
|
} else {
|
|
|
|
VOP_REG_SET(vop, common, dither_down_en, 0);
|
|
|
|
}
|
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, common, out_mode, s->output_mode);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, modeset, htotal_pw, (htotal << 16) | hsync_len);
|
2014-08-22 10:36:26 +00:00
|
|
|
val = hact_st << 16;
|
|
|
|
val |= hact_end;
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, modeset, hact_st_end, val);
|
|
|
|
VOP_REG_SET(vop, modeset, hpost_st_end, val);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, modeset, vtotal_pw, (vtotal << 16) | vsync_len);
|
2014-08-22 10:36:26 +00:00
|
|
|
val = vact_st << 16;
|
|
|
|
val |= vact_end;
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, modeset, vact_st_end, val);
|
|
|
|
VOP_REG_SET(vop, modeset, vpost_st_end, val);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, intr, line_flag_num[0], vact_end);
|
2017-04-27 06:54:17 +00:00
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
clk_set_rate(vop->dclk, adjusted_mode->clock * 1000);
|
2015-12-16 10:08:17 +00:00
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, common, standby, 0);
|
2018-03-09 22:22:55 +00:00
|
|
|
mutex_unlock(&vop->vop_lock);
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2016-09-14 12:54:56 +00:00
|
|
|
static bool vop_fs_irq_is_pending(struct vop *vop)
|
|
|
|
{
|
|
|
|
return VOP_INTR_GET_TYPE(vop, status, FS_INTR);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_wait_for_irq_handler(struct vop *vop)
|
|
|
|
{
|
|
|
|
bool pending;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Spin until frame start interrupt status bit goes low, which means
|
|
|
|
* that interrupt handler was invoked and cleared it. The timeout of
|
|
|
|
* 10 msecs is really too long, but it is just a safety measure if
|
|
|
|
* something goes really wrong. The wait will only happen in the very
|
|
|
|
* unlikely case of a vblank happening exactly at the same time and
|
|
|
|
* shouldn't exceed microseconds range.
|
|
|
|
*/
|
|
|
|
ret = readx_poll_timeout_atomic(vop_fs_irq_is_pending, vop, pending,
|
|
|
|
!pending, 0, 10 * 1000);
|
|
|
|
if (ret)
|
|
|
|
DRM_DEV_ERROR(vop->dev, "VOP vblank IRQ stuck for 10 ms\n");
|
|
|
|
|
|
|
|
synchronize_irq(vop->irq);
|
|
|
|
}
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
static void vop_crtc_atomic_flush(struct drm_crtc *crtc,
|
|
|
|
struct drm_crtc_state *old_crtc_state)
|
2014-08-22 10:36:26 +00:00
|
|
|
{
|
2016-09-14 12:54:57 +00:00
|
|
|
struct drm_atomic_state *old_state = old_crtc_state->state;
|
2017-07-12 08:13:37 +00:00
|
|
|
struct drm_plane_state *old_plane_state, *new_plane_state;
|
2014-08-22 10:36:26 +00:00
|
|
|
struct vop *vop = to_vop(crtc);
|
2016-09-14 12:54:57 +00:00
|
|
|
struct drm_plane *plane;
|
|
|
|
int i;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
if (WARN_ON(!vop->is_enabled))
|
|
|
|
return;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
spin_lock(&vop->reg_lock);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
vop_cfg_done(vop);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
spin_unlock(&vop->reg_lock);
|
2016-09-14 12:54:56 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* There is a (rather unlikely) possiblity that a vblank interrupt
|
|
|
|
* fired before we set the cfg_done bit. To avoid spuriously
|
|
|
|
* signalling flip completion we need to wait for it to finish.
|
|
|
|
*/
|
|
|
|
vop_wait_for_irq_handler(vop);
|
2016-09-14 12:54:57 +00:00
|
|
|
|
2016-09-14 12:55:00 +00:00
|
|
|
spin_lock_irq(&crtc->dev->event_lock);
|
|
|
|
if (crtc->state->event) {
|
|
|
|
WARN_ON(drm_crtc_vblank_get(crtc) != 0);
|
|
|
|
WARN_ON(vop->event);
|
|
|
|
|
|
|
|
vop->event = crtc->state->event;
|
|
|
|
crtc->state->event = NULL;
|
|
|
|
}
|
|
|
|
spin_unlock_irq(&crtc->dev->event_lock);
|
|
|
|
|
2017-07-12 08:13:37 +00:00
|
|
|
for_each_oldnew_plane_in_state(old_state, plane, old_plane_state,
|
|
|
|
new_plane_state, i) {
|
2016-09-14 12:54:57 +00:00
|
|
|
if (!old_plane_state->fb)
|
|
|
|
continue;
|
|
|
|
|
2017-07-12 08:13:37 +00:00
|
|
|
if (old_plane_state->fb == new_plane_state->fb)
|
2016-09-14 12:54:57 +00:00
|
|
|
continue;
|
|
|
|
|
2017-08-11 12:33:06 +00:00
|
|
|
drm_framebuffer_get(old_plane_state->fb);
|
2018-03-28 16:03:51 +00:00
|
|
|
WARN_ON(drm_crtc_vblank_get(crtc) != 0);
|
2016-09-14 12:54:57 +00:00
|
|
|
drm_flip_work_queue(&vop->fb_unref_work, old_plane_state->fb);
|
|
|
|
set_bit(VOP_PENDING_FB_UNREF, &vop->pending);
|
|
|
|
}
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
static const struct drm_crtc_helper_funcs vop_crtc_helper_funcs = {
|
|
|
|
.mode_fixup = vop_crtc_mode_fixup,
|
|
|
|
.atomic_flush = vop_crtc_atomic_flush,
|
2017-06-30 09:36:44 +00:00
|
|
|
.atomic_enable = vop_crtc_atomic_enable,
|
2017-06-30 09:36:45 +00:00
|
|
|
.atomic_disable = vop_crtc_atomic_disable,
|
2015-11-30 10:22:42 +00:00
|
|
|
};
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
static void vop_crtc_destroy(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
drm_crtc_cleanup(crtc);
|
|
|
|
}
|
|
|
|
|
2016-04-20 02:41:42 +00:00
|
|
|
static struct drm_crtc_state *vop_crtc_duplicate_state(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
struct rockchip_crtc_state *rockchip_state;
|
|
|
|
|
|
|
|
rockchip_state = kzalloc(sizeof(*rockchip_state), GFP_KERNEL);
|
|
|
|
if (!rockchip_state)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
__drm_atomic_helper_crtc_duplicate_state(crtc, &rockchip_state->base);
|
|
|
|
return &rockchip_state->base;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_crtc_destroy_state(struct drm_crtc *crtc,
|
|
|
|
struct drm_crtc_state *state)
|
|
|
|
{
|
|
|
|
struct rockchip_crtc_state *s = to_rockchip_crtc_state(state);
|
|
|
|
|
2016-05-09 14:34:09 +00:00
|
|
|
__drm_atomic_helper_crtc_destroy_state(&s->base);
|
2016-04-20 02:41:42 +00:00
|
|
|
kfree(s);
|
|
|
|
}
|
|
|
|
|
2019-03-01 12:56:23 +00:00
|
|
|
static void vop_crtc_reset(struct drm_crtc *crtc)
|
|
|
|
{
|
|
|
|
struct rockchip_crtc_state *crtc_state =
|
|
|
|
kzalloc(sizeof(*crtc_state), GFP_KERNEL);
|
|
|
|
|
|
|
|
if (crtc->state)
|
|
|
|
vop_crtc_destroy_state(crtc, crtc->state);
|
|
|
|
|
|
|
|
__drm_atomic_helper_crtc_reset(crtc, &crtc_state->base);
|
|
|
|
}
|
|
|
|
|
2017-03-06 20:02:26 +00:00
|
|
|
#ifdef CONFIG_DRM_ANALOGIX_DP
|
2017-03-03 13:39:36 +00:00
|
|
|
static struct drm_connector *vop_get_edp_connector(struct vop *vop)
|
|
|
|
{
|
|
|
|
struct drm_connector *connector;
|
2017-05-15 13:43:30 +00:00
|
|
|
struct drm_connector_list_iter conn_iter;
|
2017-03-03 13:39:36 +00:00
|
|
|
|
2017-05-15 13:43:30 +00:00
|
|
|
drm_connector_list_iter_begin(vop->drm_dev, &conn_iter);
|
|
|
|
drm_for_each_connector_iter(connector, &conn_iter) {
|
2017-03-03 13:39:36 +00:00
|
|
|
if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
|
2017-05-15 13:43:30 +00:00
|
|
|
drm_connector_list_iter_end(&conn_iter);
|
2017-03-03 13:39:36 +00:00
|
|
|
return connector;
|
|
|
|
}
|
2017-05-15 13:43:30 +00:00
|
|
|
}
|
|
|
|
drm_connector_list_iter_end(&conn_iter);
|
2017-03-03 13:39:36 +00:00
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int vop_crtc_set_crc_source(struct drm_crtc *crtc,
|
2018-08-21 08:38:56 +00:00
|
|
|
const char *source_name)
|
2017-03-03 13:39:36 +00:00
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(crtc);
|
|
|
|
struct drm_connector *connector;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
connector = vop_get_edp_connector(vop);
|
|
|
|
if (!connector)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (source_name && strcmp(source_name, "auto") == 0)
|
|
|
|
ret = analogix_dp_start_crc(connector);
|
|
|
|
else if (!source_name)
|
|
|
|
ret = analogix_dp_stop_crc(connector);
|
|
|
|
else
|
|
|
|
ret = -EINVAL;
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
2018-07-13 13:59:35 +00:00
|
|
|
|
|
|
|
static int
|
|
|
|
vop_crtc_verify_crc_source(struct drm_crtc *crtc, const char *source_name,
|
|
|
|
size_t *values_cnt)
|
|
|
|
{
|
|
|
|
if (source_name && strcmp(source_name, "auto") != 0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
*values_cnt = 3;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-03-06 20:02:26 +00:00
|
|
|
#else
|
|
|
|
static int vop_crtc_set_crc_source(struct drm_crtc *crtc,
|
2018-08-21 08:38:56 +00:00
|
|
|
const char *source_name)
|
2017-03-06 20:02:26 +00:00
|
|
|
{
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
2018-07-13 13:59:35 +00:00
|
|
|
|
|
|
|
static int
|
|
|
|
vop_crtc_verify_crc_source(struct drm_crtc *crtc, const char *source_name,
|
|
|
|
size_t *values_cnt)
|
|
|
|
{
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
2017-03-06 20:02:26 +00:00
|
|
|
#endif
|
2017-03-03 13:39:36 +00:00
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
static const struct drm_crtc_funcs vop_crtc_funcs = {
|
2015-11-30 10:22:42 +00:00
|
|
|
.set_config = drm_atomic_helper_set_config,
|
|
|
|
.page_flip = drm_atomic_helper_page_flip,
|
2014-08-22 10:36:26 +00:00
|
|
|
.destroy = vop_crtc_destroy,
|
2016-07-14 15:29:15 +00:00
|
|
|
.reset = vop_crtc_reset,
|
2016-04-20 02:41:42 +00:00
|
|
|
.atomic_duplicate_state = vop_crtc_duplicate_state,
|
|
|
|
.atomic_destroy_state = vop_crtc_destroy_state,
|
2017-02-07 09:16:29 +00:00
|
|
|
.enable_vblank = vop_crtc_enable_vblank,
|
|
|
|
.disable_vblank = vop_crtc_disable_vblank,
|
2017-03-03 13:39:36 +00:00
|
|
|
.set_crc_source = vop_crtc_set_crc_source,
|
2018-07-13 13:59:35 +00:00
|
|
|
.verify_crc_source = vop_crtc_verify_crc_source,
|
2014-08-22 10:36:26 +00:00
|
|
|
};
|
|
|
|
|
2016-09-14 12:54:57 +00:00
|
|
|
static void vop_fb_unref_worker(struct drm_flip_work *work, void *val)
|
|
|
|
{
|
|
|
|
struct vop *vop = container_of(work, struct vop, fb_unref_work);
|
|
|
|
struct drm_framebuffer *fb = val;
|
|
|
|
|
|
|
|
drm_crtc_vblank_put(&vop->crtc);
|
2017-08-11 12:33:06 +00:00
|
|
|
drm_framebuffer_put(fb);
|
2016-09-14 12:54:57 +00:00
|
|
|
}
|
|
|
|
|
2015-11-30 10:22:42 +00:00
|
|
|
static void vop_handle_vblank(struct vop *vop)
|
2014-08-22 10:36:26 +00:00
|
|
|
{
|
2015-11-30 10:22:42 +00:00
|
|
|
struct drm_device *drm = vop->drm_dev;
|
|
|
|
struct drm_crtc *crtc = &vop->crtc;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2018-02-20 13:01:20 +00:00
|
|
|
spin_lock(&drm->event_lock);
|
2015-11-30 10:22:42 +00:00
|
|
|
if (vop->event) {
|
|
|
|
drm_crtc_send_vblank_event(crtc, vop->event);
|
2016-08-10 20:24:39 +00:00
|
|
|
drm_crtc_vblank_put(crtc);
|
2016-09-14 12:54:59 +00:00
|
|
|
vop->event = NULL;
|
2016-08-10 20:24:39 +00:00
|
|
|
}
|
2018-02-20 13:01:20 +00:00
|
|
|
spin_unlock(&drm->event_lock);
|
2016-06-08 12:19:12 +00:00
|
|
|
|
2016-09-14 12:54:57 +00:00
|
|
|
if (test_and_clear_bit(VOP_PENDING_FB_UNREF, &vop->pending))
|
|
|
|
drm_flip_work_commit(&vop->fb_unref_work, system_unbound_wq);
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static irqreturn_t vop_isr(int irq, void *data)
|
|
|
|
{
|
|
|
|
struct vop *vop = data;
|
2015-11-23 07:21:08 +00:00
|
|
|
struct drm_crtc *crtc = &vop->crtc;
|
2015-12-15 00:36:55 +00:00
|
|
|
uint32_t active_irqs;
|
2015-02-04 05:10:31 +00:00
|
|
|
int ret = IRQ_NONE;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2018-06-12 13:20:28 +00:00
|
|
|
/*
|
|
|
|
* The irq is shared with the iommu. If the runtime-pm state of the
|
|
|
|
* vop-device is disabled the irq has to be targeted at the iommu.
|
|
|
|
*/
|
|
|
|
if (!pm_runtime_get_if_in_use(vop->dev))
|
|
|
|
return IRQ_NONE;
|
|
|
|
|
|
|
|
if (vop_core_clks_enable(vop)) {
|
|
|
|
DRM_DEV_ERROR_RATELIMITED(vop->dev, "couldn't enable clocks\n");
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
/*
|
2015-12-15 00:36:55 +00:00
|
|
|
* interrupt register has interrupt status, enable and clear bits, we
|
2014-08-22 10:36:26 +00:00
|
|
|
* must hold irq_lock to avoid a race with enable/disable_vblank().
|
|
|
|
*/
|
2018-02-20 13:01:20 +00:00
|
|
|
spin_lock(&vop->irq_lock);
|
2015-12-15 00:36:55 +00:00
|
|
|
|
|
|
|
active_irqs = VOP_INTR_GET_TYPE(vop, status, INTR_MASK);
|
2014-08-22 10:36:26 +00:00
|
|
|
/* Clear all active interrupt sources */
|
|
|
|
if (active_irqs)
|
2015-12-15 00:36:55 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, clear, active_irqs, 1);
|
|
|
|
|
2018-02-20 13:01:20 +00:00
|
|
|
spin_unlock(&vop->irq_lock);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
/* This is expected for vop iommu irqs, since the irq is shared */
|
|
|
|
if (!active_irqs)
|
2018-06-12 13:20:28 +00:00
|
|
|
goto out_disable;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-02-04 05:10:31 +00:00
|
|
|
if (active_irqs & DSP_HOLD_VALID_INTR) {
|
|
|
|
complete(&vop->dsp_hold_completion);
|
|
|
|
active_irqs &= ~DSP_HOLD_VALID_INTR;
|
|
|
|
ret = IRQ_HANDLED;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2016-07-24 06:57:40 +00:00
|
|
|
if (active_irqs & LINE_FLAG_INTR) {
|
|
|
|
complete(&vop->line_flag_completion);
|
|
|
|
active_irqs &= ~LINE_FLAG_INTR;
|
|
|
|
ret = IRQ_HANDLED;
|
|
|
|
}
|
|
|
|
|
2015-02-04 05:10:31 +00:00
|
|
|
if (active_irqs & FS_INTR) {
|
2015-11-23 07:21:08 +00:00
|
|
|
drm_crtc_handle_vblank(crtc);
|
2015-11-30 10:22:42 +00:00
|
|
|
vop_handle_vblank(vop);
|
2015-02-04 05:10:31 +00:00
|
|
|
active_irqs &= ~FS_INTR;
|
2015-11-30 10:22:42 +00:00
|
|
|
ret = IRQ_HANDLED;
|
2015-02-04 05:10:31 +00:00
|
|
|
}
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-02-04 05:10:31 +00:00
|
|
|
/* Unhandled irqs are spurious. */
|
|
|
|
if (active_irqs)
|
2016-08-12 17:00:54 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "Unknown VOP IRQs: %#02x\n",
|
|
|
|
active_irqs);
|
2015-02-04 05:10:31 +00:00
|
|
|
|
2018-06-12 13:20:28 +00:00
|
|
|
out_disable:
|
|
|
|
vop_core_clks_disable(vop);
|
|
|
|
out:
|
|
|
|
pm_runtime_put(vop->dev);
|
2015-02-04 05:10:31 +00:00
|
|
|
return ret;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2019-01-09 18:56:39 +00:00
|
|
|
static void vop_plane_add_properties(struct drm_plane *plane,
|
|
|
|
const struct vop_win_data *win_data)
|
|
|
|
{
|
|
|
|
unsigned int flags = 0;
|
|
|
|
|
|
|
|
flags |= VOP_WIN_HAS_REG(win_data, x_mir_en) ? DRM_MODE_REFLECT_X : 0;
|
|
|
|
flags |= VOP_WIN_HAS_REG(win_data, y_mir_en) ? DRM_MODE_REFLECT_Y : 0;
|
|
|
|
if (flags)
|
|
|
|
drm_plane_create_rotation_property(plane, DRM_MODE_ROTATE_0,
|
|
|
|
DRM_MODE_ROTATE_0 | flags);
|
|
|
|
}
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
static int vop_create_crtc(struct vop *vop)
|
|
|
|
{
|
|
|
|
const struct vop_data *vop_data = vop->data;
|
|
|
|
struct device *dev = vop->dev;
|
|
|
|
struct drm_device *drm_dev = vop->drm_dev;
|
2016-03-07 22:00:52 +00:00
|
|
|
struct drm_plane *primary = NULL, *cursor = NULL, *plane, *tmp;
|
2014-08-22 10:36:26 +00:00
|
|
|
struct drm_crtc *crtc = &vop->crtc;
|
|
|
|
struct device_node *port;
|
|
|
|
int ret;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Create drm_plane for primary and cursor planes first, since we need
|
|
|
|
* to pass them to drm_crtc_init_with_planes, which sets the
|
|
|
|
* "possible_crtcs" to the newly initialized crtc.
|
|
|
|
*/
|
|
|
|
for (i = 0; i < vop_data->win_size; i++) {
|
|
|
|
struct vop_win *vop_win = &vop->win[i];
|
|
|
|
const struct vop_win_data *win_data = vop_win->data;
|
|
|
|
|
|
|
|
if (win_data->type != DRM_PLANE_TYPE_PRIMARY &&
|
|
|
|
win_data->type != DRM_PLANE_TYPE_CURSOR)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
ret = drm_universal_plane_init(vop->drm_dev, &vop_win->base,
|
|
|
|
0, &vop_plane_funcs,
|
|
|
|
win_data->phy->data_formats,
|
|
|
|
win_data->phy->nformats,
|
2017-07-24 03:46:38 +00:00
|
|
|
NULL, win_data->type, NULL);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (ret) {
|
2016-08-12 17:00:54 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to init plane %d\n",
|
|
|
|
ret);
|
2014-08-22 10:36:26 +00:00
|
|
|
goto err_cleanup_planes;
|
|
|
|
}
|
|
|
|
|
|
|
|
plane = &vop_win->base;
|
2015-11-30 10:22:42 +00:00
|
|
|
drm_plane_helper_add(plane, &plane_helper_funcs);
|
2019-01-09 18:56:39 +00:00
|
|
|
vop_plane_add_properties(plane, win_data);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (plane->type == DRM_PLANE_TYPE_PRIMARY)
|
|
|
|
primary = plane;
|
|
|
|
else if (plane->type == DRM_PLANE_TYPE_CURSOR)
|
|
|
|
cursor = plane;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = drm_crtc_init_with_planes(drm_dev, crtc, primary, cursor,
|
drm: Pass 'name' to drm_crtc_init_with_planes()
Done with coccinelle for the most part. However, it thinks '...' is
part of the semantic patch, so I put an 'int DOTDOTDOT' placeholder
in its place and got rid of it with sed afterwards.
I didn't convert drm_crtc_init() since passing the varargs through
would mean either cpp macros or va_list, and I figured we don't
care about these legacy functions enough to warrant the extra pain.
@@
identifier dev, crtc, primary, cursor, funcs;
@@
int drm_crtc_init_with_planes(struct drm_device *dev,
struct drm_crtc *crtc,
struct drm_plane *primary, struct drm_plane *cursor,
const struct drm_crtc_funcs *funcs
+ ,const char *name, int DOTDOTDOT
)
{ ... }
@@
identifier dev, crtc, primary, cursor, funcs;
@@
int drm_crtc_init_with_planes(struct drm_device *dev,
struct drm_crtc *crtc,
struct drm_plane *primary, struct drm_plane *cursor,
const struct drm_crtc_funcs *funcs
+ ,const char *name, int DOTDOTDOT
);
@@
expression E1, E2, E3, E4, E5;
@@
drm_crtc_init_with_planes(E1, E2, E3, E4, E5
+ ,NULL
)
v2: Split crtc and plane changes apart
Pass NULL for no-name instead of ""
Leave drm_crtc_init() alone
v3: Add ', or NULL...' to @name kernel doc (Jani)
Annotate the function with __printf() attribute (Jani)
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1449670771-2751-1-git-send-email-ville.syrjala@linux.intel.com
2015-12-09 14:19:31 +00:00
|
|
|
&vop_crtc_funcs, NULL);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (ret)
|
2016-03-07 22:00:52 +00:00
|
|
|
goto err_cleanup_planes;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
drm_crtc_helper_add(crtc, &vop_crtc_helper_funcs);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Create drm_planes for overlay windows with possible_crtcs restricted
|
|
|
|
* to the newly created crtc.
|
|
|
|
*/
|
|
|
|
for (i = 0; i < vop_data->win_size; i++) {
|
|
|
|
struct vop_win *vop_win = &vop->win[i];
|
|
|
|
const struct vop_win_data *win_data = vop_win->data;
|
2018-06-26 19:47:13 +00:00
|
|
|
unsigned long possible_crtcs = drm_crtc_mask(crtc);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
if (win_data->type != DRM_PLANE_TYPE_OVERLAY)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
ret = drm_universal_plane_init(vop->drm_dev, &vop_win->base,
|
|
|
|
possible_crtcs,
|
|
|
|
&vop_plane_funcs,
|
|
|
|
win_data->phy->data_formats,
|
|
|
|
win_data->phy->nformats,
|
2017-07-24 03:46:38 +00:00
|
|
|
NULL, win_data->type, NULL);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (ret) {
|
2016-08-12 17:00:54 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to init overlay %d\n",
|
|
|
|
ret);
|
2014-08-22 10:36:26 +00:00
|
|
|
goto err_cleanup_crtc;
|
|
|
|
}
|
2015-11-30 10:22:42 +00:00
|
|
|
drm_plane_helper_add(&vop_win->base, &plane_helper_funcs);
|
2019-01-09 18:56:39 +00:00
|
|
|
vop_plane_add_properties(&vop_win->base, win_data);
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
port = of_get_child_by_name(dev->of_node, "port");
|
|
|
|
if (!port) {
|
2017-07-18 21:43:04 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "no port node found in %pOF\n",
|
|
|
|
dev->of_node);
|
2016-03-07 22:00:52 +00:00
|
|
|
ret = -ENOENT;
|
2014-08-22 10:36:26 +00:00
|
|
|
goto err_cleanup_crtc;
|
|
|
|
}
|
|
|
|
|
2016-09-14 12:54:57 +00:00
|
|
|
drm_flip_work_init(&vop->fb_unref_work, "fb_unref",
|
|
|
|
vop_fb_unref_worker);
|
|
|
|
|
2015-02-04 05:10:31 +00:00
|
|
|
init_completion(&vop->dsp_hold_completion);
|
2016-07-24 06:57:40 +00:00
|
|
|
init_completion(&vop->line_flag_completion);
|
2014-08-22 10:36:26 +00:00
|
|
|
crtc->port = port;
|
|
|
|
|
2019-06-11 16:08:22 +00:00
|
|
|
ret = drm_self_refresh_helper_init(crtc,
|
|
|
|
VOP_SELF_REFRESH_ENTRY_DELAY_MS);
|
|
|
|
if (ret)
|
|
|
|
DRM_DEV_DEBUG_KMS(vop->dev,
|
|
|
|
"Failed to init %s with SR helpers %d, ignoring\n",
|
|
|
|
crtc->name, ret);
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
err_cleanup_crtc:
|
|
|
|
drm_crtc_cleanup(crtc);
|
|
|
|
err_cleanup_planes:
|
2016-03-07 22:00:52 +00:00
|
|
|
list_for_each_entry_safe(plane, tmp, &drm_dev->mode_config.plane_list,
|
|
|
|
head)
|
2014-08-22 10:36:26 +00:00
|
|
|
drm_plane_cleanup(plane);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_destroy_crtc(struct vop *vop)
|
|
|
|
{
|
|
|
|
struct drm_crtc *crtc = &vop->crtc;
|
2016-03-07 22:00:52 +00:00
|
|
|
struct drm_device *drm_dev = vop->drm_dev;
|
|
|
|
struct drm_plane *plane, *tmp;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2019-06-11 16:08:22 +00:00
|
|
|
drm_self_refresh_helper_cleanup(crtc);
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
of_node_put(crtc->port);
|
2016-03-07 22:00:52 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We need to cleanup the planes now. Why?
|
|
|
|
*
|
|
|
|
* The planes are "&vop->win[i].base". That means the memory is
|
|
|
|
* all part of the big "struct vop" chunk of memory. That memory
|
|
|
|
* was devm allocated and associated with this component. We need to
|
|
|
|
* free it ourselves before vop_unbind() finishes.
|
|
|
|
*/
|
|
|
|
list_for_each_entry_safe(plane, tmp, &drm_dev->mode_config.plane_list,
|
|
|
|
head)
|
|
|
|
vop_plane_destroy(plane);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Destroy CRTC after vop_plane_destroy() since vop_disable_plane()
|
|
|
|
* references the CRTC.
|
|
|
|
*/
|
2014-08-22 10:36:26 +00:00
|
|
|
drm_crtc_cleanup(crtc);
|
2016-09-14 12:54:57 +00:00
|
|
|
drm_flip_work_cleanup(&vop->fb_unref_work);
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int vop_initial(struct vop *vop)
|
|
|
|
{
|
|
|
|
struct reset_control *ahb_rst;
|
|
|
|
int i, ret;
|
|
|
|
|
|
|
|
vop->hclk = devm_clk_get(vop->dev, "hclk_vop");
|
|
|
|
if (IS_ERR(vop->hclk)) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to get hclk source\n");
|
2014-08-22 10:36:26 +00:00
|
|
|
return PTR_ERR(vop->hclk);
|
|
|
|
}
|
|
|
|
vop->aclk = devm_clk_get(vop->dev, "aclk_vop");
|
|
|
|
if (IS_ERR(vop->aclk)) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to get aclk source\n");
|
2014-08-22 10:36:26 +00:00
|
|
|
return PTR_ERR(vop->aclk);
|
|
|
|
}
|
|
|
|
vop->dclk = devm_clk_get(vop->dev, "dclk_vop");
|
|
|
|
if (IS_ERR(vop->dclk)) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to get dclk source\n");
|
2014-08-22 10:36:26 +00:00
|
|
|
return PTR_ERR(vop->dclk);
|
|
|
|
}
|
|
|
|
|
2017-04-06 12:31:20 +00:00
|
|
|
ret = pm_runtime_get_sync(vop->dev);
|
|
|
|
if (ret < 0) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to get pm runtime: %d\n", ret);
|
2017-04-06 12:31:20 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
ret = clk_prepare(vop->dclk);
|
|
|
|
if (ret < 0) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to prepare dclk\n");
|
2017-04-06 12:31:20 +00:00
|
|
|
goto err_put_pm_runtime;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2015-11-06 12:22:24 +00:00
|
|
|
/* Enable both the hclk and aclk to setup the vop */
|
|
|
|
ret = clk_prepare_enable(vop->hclk);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (ret < 0) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to prepare/enable hclk\n");
|
2014-08-22 10:36:26 +00:00
|
|
|
goto err_unprepare_dclk;
|
|
|
|
}
|
|
|
|
|
2015-11-06 12:22:24 +00:00
|
|
|
ret = clk_prepare_enable(vop->aclk);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (ret < 0) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to prepare/enable aclk\n");
|
2015-11-06 12:22:24 +00:00
|
|
|
goto err_disable_hclk;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
2015-11-06 12:22:24 +00:00
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
/*
|
|
|
|
* do hclk_reset, reset all vop registers.
|
|
|
|
*/
|
|
|
|
ahb_rst = devm_reset_control_get(vop->dev, "ahb");
|
|
|
|
if (IS_ERR(ahb_rst)) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to get ahb reset\n");
|
2014-08-22 10:36:26 +00:00
|
|
|
ret = PTR_ERR(ahb_rst);
|
2015-11-06 12:22:24 +00:00
|
|
|
goto err_disable_aclk;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
reset_control_assert(ahb_rst);
|
|
|
|
usleep_range(10, 20);
|
|
|
|
reset_control_deassert(ahb_rst);
|
|
|
|
|
2018-02-20 13:01:18 +00:00
|
|
|
VOP_INTR_SET_TYPE(vop, clear, INTR_MASK, 1);
|
|
|
|
VOP_INTR_SET_TYPE(vop, enable, INTR_MASK, 0);
|
|
|
|
|
2018-02-20 13:01:19 +00:00
|
|
|
for (i = 0; i < vop->len; i += sizeof(u32))
|
|
|
|
vop->regsbak[i / 4] = readl_relaxed(vop->regs + i);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2017-07-28 06:06:25 +00:00
|
|
|
VOP_REG_SET(vop, misc, global_regdone_en, 1);
|
|
|
|
VOP_REG_SET(vop, common, dsp_blank, 0);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2019-06-11 16:08:23 +00:00
|
|
|
for (i = 0; i < vop->data->win_size; i++) {
|
|
|
|
struct vop_win *vop_win = &vop->win[i];
|
|
|
|
const struct vop_win_data *win = vop_win->data;
|
2017-07-26 06:19:39 +00:00
|
|
|
int channel = i * 2 + 1;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2017-07-26 06:19:39 +00:00
|
|
|
VOP_WIN_SET(vop, win, channel, (channel + 1) << 4 | channel);
|
2019-06-11 16:08:23 +00:00
|
|
|
vop_win_disable(vop, vop_win);
|
2017-07-26 06:19:05 +00:00
|
|
|
VOP_WIN_SET(vop, win, gate, 1);
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
vop_cfg_done(vop);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* do dclk_reset, let all config take affect.
|
|
|
|
*/
|
|
|
|
vop->dclk_rst = devm_reset_control_get(vop->dev, "dclk");
|
|
|
|
if (IS_ERR(vop->dclk_rst)) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "failed to get dclk reset\n");
|
2014-08-22 10:36:26 +00:00
|
|
|
ret = PTR_ERR(vop->dclk_rst);
|
2015-11-06 12:22:24 +00:00
|
|
|
goto err_disable_aclk;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
reset_control_assert(vop->dclk_rst);
|
|
|
|
usleep_range(10, 20);
|
|
|
|
reset_control_deassert(vop->dclk_rst);
|
|
|
|
|
|
|
|
clk_disable(vop->hclk);
|
2015-11-06 12:22:24 +00:00
|
|
|
clk_disable(vop->aclk);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-01-22 06:37:56 +00:00
|
|
|
vop->is_enabled = false;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2017-04-06 12:31:20 +00:00
|
|
|
pm_runtime_put_sync(vop->dev);
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
return 0;
|
|
|
|
|
2015-11-06 12:22:24 +00:00
|
|
|
err_disable_aclk:
|
|
|
|
clk_disable_unprepare(vop->aclk);
|
2014-08-22 10:36:26 +00:00
|
|
|
err_disable_hclk:
|
2015-11-06 12:22:24 +00:00
|
|
|
clk_disable_unprepare(vop->hclk);
|
2014-08-22 10:36:26 +00:00
|
|
|
err_unprepare_dclk:
|
|
|
|
clk_unprepare(vop->dclk);
|
2017-04-06 12:31:20 +00:00
|
|
|
err_put_pm_runtime:
|
|
|
|
pm_runtime_put_sync(vop->dev);
|
2014-08-22 10:36:26 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Initialize the vop->win array elements.
|
|
|
|
*/
|
|
|
|
static void vop_win_init(struct vop *vop)
|
|
|
|
{
|
|
|
|
const struct vop_data *vop_data = vop->data;
|
|
|
|
unsigned int i;
|
|
|
|
|
|
|
|
for (i = 0; i < vop_data->win_size; i++) {
|
|
|
|
struct vop_win *vop_win = &vop->win[i];
|
|
|
|
const struct vop_win_data *win_data = &vop_data->win[i];
|
|
|
|
|
|
|
|
vop_win->data = win_data;
|
|
|
|
vop_win->vop = vop;
|
2019-01-26 00:24:37 +00:00
|
|
|
|
|
|
|
if (vop_data->win_yuv2yuv)
|
|
|
|
vop_win->yuv2yuv_data = &vop_data->win_yuv2yuv[i];
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-07-24 06:57:40 +00:00
|
|
|
/**
|
2017-04-27 06:54:17 +00:00
|
|
|
* rockchip_drm_wait_vact_end
|
2016-07-24 06:57:40 +00:00
|
|
|
* @crtc: CRTC to enable line flag
|
|
|
|
* @mstimeout: millisecond for timeout
|
|
|
|
*
|
2017-04-27 06:54:17 +00:00
|
|
|
* Wait for vact_end line flag irq or timeout.
|
2016-07-24 06:57:40 +00:00
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* Zero on success, negative errno on failure.
|
|
|
|
*/
|
2017-04-27 06:54:17 +00:00
|
|
|
int rockchip_drm_wait_vact_end(struct drm_crtc *crtc, unsigned int mstimeout)
|
2016-07-24 06:57:40 +00:00
|
|
|
{
|
|
|
|
struct vop *vop = to_vop(crtc);
|
|
|
|
unsigned long jiffies_left;
|
2018-03-09 22:22:55 +00:00
|
|
|
int ret = 0;
|
2016-07-24 06:57:40 +00:00
|
|
|
|
|
|
|
if (!crtc || !vop->is_enabled)
|
|
|
|
return -ENODEV;
|
|
|
|
|
2018-03-09 22:22:55 +00:00
|
|
|
mutex_lock(&vop->vop_lock);
|
|
|
|
if (mstimeout <= 0) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
2016-07-24 06:57:40 +00:00
|
|
|
|
2018-03-09 22:22:55 +00:00
|
|
|
if (vop_line_flag_irq_is_enabled(vop)) {
|
|
|
|
ret = -EBUSY;
|
|
|
|
goto out;
|
|
|
|
}
|
2016-07-24 06:57:40 +00:00
|
|
|
|
|
|
|
reinit_completion(&vop->line_flag_completion);
|
2017-04-27 06:54:17 +00:00
|
|
|
vop_line_flag_irq_enable(vop);
|
2016-07-24 06:57:40 +00:00
|
|
|
|
|
|
|
jiffies_left = wait_for_completion_timeout(&vop->line_flag_completion,
|
|
|
|
msecs_to_jiffies(mstimeout));
|
|
|
|
vop_line_flag_irq_disable(vop);
|
|
|
|
|
|
|
|
if (jiffies_left == 0) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(vop->dev, "Timeout waiting for IRQ\n");
|
2018-03-09 22:22:55 +00:00
|
|
|
ret = -ETIMEDOUT;
|
|
|
|
goto out;
|
2016-07-24 06:57:40 +00:00
|
|
|
}
|
|
|
|
|
2018-03-09 22:22:55 +00:00
|
|
|
out:
|
|
|
|
mutex_unlock(&vop->vop_lock);
|
|
|
|
return ret;
|
2016-07-24 06:57:40 +00:00
|
|
|
}
|
2017-04-27 06:54:17 +00:00
|
|
|
EXPORT_SYMBOL(rockchip_drm_wait_vact_end);
|
2016-07-24 06:57:40 +00:00
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
static int vop_bind(struct device *dev, struct device *master, void *data)
|
|
|
|
{
|
|
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
|
|
const struct vop_data *vop_data;
|
|
|
|
struct drm_device *drm_dev = data;
|
|
|
|
struct vop *vop;
|
|
|
|
struct resource *res;
|
2015-04-19 23:00:53 +00:00
|
|
|
int ret, irq;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
2015-12-15 00:58:26 +00:00
|
|
|
vop_data = of_device_get_match_data(dev);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (!vop_data)
|
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
/* Allocate vop struct and its vop_win array */
|
drm/rockchip: Use struct_size() in devm_kzalloc()
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};
instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
or, like in this particular case:
size = sizeof(struct foo) + sizeof(void *) * count;
instance = devm_kzalloc(dev, size, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:
instance = devm_kzalloc(dev, struct_size(instance, entry, count),
GFP_KERNEL);
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20180826184712.GA9330@embeddedor.com
2018-08-26 18:47:12 +00:00
|
|
|
vop = devm_kzalloc(dev, struct_size(vop, win, vop_data->win_size),
|
|
|
|
GFP_KERNEL);
|
2014-08-22 10:36:26 +00:00
|
|
|
if (!vop)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
vop->dev = dev;
|
|
|
|
vop->data = vop_data;
|
|
|
|
vop->drm_dev = drm_dev;
|
|
|
|
dev_set_drvdata(dev, vop);
|
|
|
|
|
|
|
|
vop_win_init(vop);
|
|
|
|
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
|
|
vop->len = resource_size(res);
|
|
|
|
vop->regs = devm_ioremap_resource(dev, res);
|
|
|
|
if (IS_ERR(vop->regs))
|
|
|
|
return PTR_ERR(vop->regs);
|
|
|
|
|
|
|
|
vop->regsbak = devm_kzalloc(dev, vop->len, GFP_KERNEL);
|
|
|
|
if (!vop->regsbak)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2015-04-19 23:00:53 +00:00
|
|
|
irq = platform_get_irq(pdev, 0);
|
|
|
|
if (irq < 0) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(dev, "cannot find irq for vop\n");
|
2015-04-19 23:00:53 +00:00
|
|
|
return irq;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
2015-04-19 23:00:53 +00:00
|
|
|
vop->irq = (unsigned int)irq;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
spin_lock_init(&vop->reg_lock);
|
|
|
|
spin_lock_init(&vop->irq_lock);
|
2018-03-09 22:22:55 +00:00
|
|
|
mutex_init(&vop->vop_lock);
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
ret = vop_create_crtc(vop);
|
|
|
|
if (ret)
|
2018-02-20 13:01:18 +00:00
|
|
|
return ret;
|
2014-08-22 10:36:26 +00:00
|
|
|
|
|
|
|
pm_runtime_enable(&pdev->dev);
|
2016-07-24 06:57:44 +00:00
|
|
|
|
2017-04-06 12:31:20 +00:00
|
|
|
ret = vop_initial(vop);
|
|
|
|
if (ret < 0) {
|
2017-09-15 08:36:03 +00:00
|
|
|
DRM_DEV_ERROR(&pdev->dev,
|
|
|
|
"cannot initial vop dev - err %d\n", ret);
|
2017-04-06 12:31:20 +00:00
|
|
|
goto err_disable_pm_runtime;
|
|
|
|
}
|
|
|
|
|
2018-02-20 13:01:18 +00:00
|
|
|
ret = devm_request_irq(dev, vop->irq, vop_isr,
|
|
|
|
IRQF_SHARED, dev_name(dev), vop);
|
|
|
|
if (ret)
|
|
|
|
goto err_disable_pm_runtime;
|
|
|
|
|
2018-08-30 21:12:06 +00:00
|
|
|
if (vop->data->feature & VOP_FEATURE_INTERNAL_RGB) {
|
|
|
|
vop->rgb = rockchip_rgb_init(dev, &vop->crtc, vop->drm_dev);
|
|
|
|
if (IS_ERR(vop->rgb)) {
|
|
|
|
ret = PTR_ERR(vop->rgb);
|
|
|
|
goto err_disable_pm_runtime;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
return 0;
|
2016-09-16 18:22:03 +00:00
|
|
|
|
2017-04-06 12:31:20 +00:00
|
|
|
err_disable_pm_runtime:
|
|
|
|
pm_runtime_disable(&pdev->dev);
|
|
|
|
vop_destroy_crtc(vop);
|
2016-09-16 18:22:03 +00:00
|
|
|
return ret;
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void vop_unbind(struct device *dev, struct device *master, void *data)
|
|
|
|
{
|
|
|
|
struct vop *vop = dev_get_drvdata(dev);
|
|
|
|
|
2018-08-30 21:12:06 +00:00
|
|
|
if (vop->rgb)
|
|
|
|
rockchip_rgb_fini(vop->rgb);
|
|
|
|
|
2014-08-22 10:36:26 +00:00
|
|
|
pm_runtime_disable(dev);
|
|
|
|
vop_destroy_crtc(vop);
|
2017-04-06 12:31:21 +00:00
|
|
|
|
|
|
|
clk_unprepare(vop->aclk);
|
|
|
|
clk_unprepare(vop->hclk);
|
|
|
|
clk_unprepare(vop->dclk);
|
2014-08-22 10:36:26 +00:00
|
|
|
}
|
|
|
|
|
2015-12-15 00:58:26 +00:00
|
|
|
const struct component_ops vop_component_ops = {
|
2014-08-22 10:36:26 +00:00
|
|
|
.bind = vop_bind,
|
|
|
|
.unbind = vop_unbind,
|
|
|
|
};
|
2015-12-31 02:40:11 +00:00
|
|
|
EXPORT_SYMBOL_GPL(vop_component_ops);
|