2019-05-27 06:55:06 +00:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
2006-01-09 17:25:35 +00:00
|
|
|
/*
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
* cx88-vp3054-i2c.h -- support for the secondary I2C bus of the
|
|
|
|
|
* DNTV Live! DVB-T Pro (VP-3054), wired as:
|
|
|
|
|
* GPIO[0] -> SCL, GPIO[1] -> SDA
|
|
|
|
|
*
|
|
|
|
|
* (c) 2005 Chris Pascoe <c.pascoe@itee.uq.edu.au>
|
|
|
|
|
*/
|
2006-01-09 17:25:35 +00:00
|
|
|
|
|
|
|
|
/* ----------------------------------------------------------------------- */
|
|
|
|
|
struct vp3054_i2c_state {
|
|
|
|
|
struct i2c_adapter adap;
|
|
|
|
|
struct i2c_algo_bit_data algo;
|
|
|
|
|
u32 state;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* ----------------------------------------------------------------------- */
|
2013-01-20 04:32:56 +00:00
|
|
|
#if IS_ENABLED(CONFIG_VIDEO_CX88_VP3054)
|
2006-01-09 17:25:35 +00:00
|
|
|
int vp3054_i2c_probe(struct cx8802_dev *dev);
|
|
|
|
|
void vp3054_i2c_remove(struct cx8802_dev *dev);
|
2007-05-05 23:11:32 +00:00
|
|
|
#else
|
|
|
|
|
static inline int vp3054_i2c_probe(struct cx8802_dev *dev)
|
|
|
|
|
{ return 0; }
|
|
|
|
|
static inline void vp3054_i2c_remove(struct cx8802_dev *dev)
|
|
|
|
|
{ }
|
|
|
|
|
#endif
|
