2018-06-06 02:42:14 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
2005-11-02 03:58:39 +00:00
|
|
|
* Copyright (c) 2000-2005 Silicon Graphics, Inc.
|
|
|
|
* All Rights Reserved.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
#include "xfs.h"
|
2005-11-02 03:38:42 +00:00
|
|
|
#include "xfs_fs.h"
|
2013-10-22 23:36:05 +00:00
|
|
|
#include "xfs_shared.h"
|
2013-10-22 23:50:10 +00:00
|
|
|
#include "xfs_format.h"
|
|
|
|
#include "xfs_log_format.h"
|
|
|
|
#include "xfs_trans_resv.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "xfs_mount.h"
|
2016-08-03 01:15:38 +00:00
|
|
|
#include "xfs_defer.h"
|
2013-10-14 22:17:51 +00:00
|
|
|
#include "xfs_da_format.h"
|
2005-11-02 03:38:42 +00:00
|
|
|
#include "xfs_da_btree.h"
|
|
|
|
#include "xfs_attr_sf.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "xfs_inode.h"
|
2013-10-22 23:50:10 +00:00
|
|
|
#include "xfs_trans.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "xfs_bmap.h"
|
2013-10-22 23:51:50 +00:00
|
|
|
#include "xfs_bmap_btree.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "xfs_attr.h"
|
|
|
|
#include "xfs_attr_leaf.h"
|
2013-04-03 05:11:27 +00:00
|
|
|
#include "xfs_attr_remote.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "xfs_quota.h"
|
|
|
|
#include "xfs_trans_space.h"
|
2009-12-14 23:14:59 +00:00
|
|
|
#include "xfs_trace.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* xfs_attr.c
|
|
|
|
*
|
|
|
|
* Provide the external interfaces to manage attribute lists.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*========================================================================
|
|
|
|
* Function prototypes for the kernel.
|
|
|
|
*========================================================================*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Internal routines when attribute list fits inside the inode.
|
|
|
|
*/
|
|
|
|
STATIC int xfs_attr_shortform_addname(xfs_da_args_t *args);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Internal routines when attribute list is one block.
|
|
|
|
*/
|
2005-06-21 05:36:52 +00:00
|
|
|
STATIC int xfs_attr_leaf_get(xfs_da_args_t *args);
|
2005-04-16 22:20:36 +00:00
|
|
|
STATIC int xfs_attr_leaf_addname(xfs_da_args_t *args);
|
|
|
|
STATIC int xfs_attr_leaf_removename(xfs_da_args_t *args);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Internal routines when attribute list is more than one block.
|
|
|
|
*/
|
2005-06-21 05:36:52 +00:00
|
|
|
STATIC int xfs_attr_node_get(xfs_da_args_t *args);
|
2005-04-16 22:20:36 +00:00
|
|
|
STATIC int xfs_attr_node_addname(xfs_da_args_t *args);
|
|
|
|
STATIC int xfs_attr_node_removename(xfs_da_args_t *args);
|
|
|
|
STATIC int xfs_attr_fillstate(xfs_da_state_t *state);
|
|
|
|
STATIC int xfs_attr_refillstate(xfs_da_state_t *state);
|
|
|
|
|
2013-08-12 10:49:38 +00:00
|
|
|
int
|
2008-06-23 03:23:41 +00:00
|
|
|
xfs_inode_hasattr(
|
|
|
|
struct xfs_inode *ip)
|
|
|
|
{
|
|
|
|
if (!XFS_IFORK_Q(ip) ||
|
|
|
|
(ip->i_d.di_aformat == XFS_DINODE_FMT_EXTENTS &&
|
|
|
|
ip->i_d.di_anextents == 0))
|
|
|
|
return 0;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*========================================================================
|
|
|
|
* Overall external interface routines.
|
|
|
|
*========================================================================*/
|
|
|
|
|
2019-08-29 16:04:08 +00:00
|
|
|
/*
|
|
|
|
* Retrieve an extended attribute and its value. Must have ilock.
|
|
|
|
* Returns 0 on successful retrieval, otherwise an error.
|
|
|
|
*/
|
2017-06-16 18:00:14 +00:00
|
|
|
int
|
|
|
|
xfs_attr_get_ilocked(
|
|
|
|
struct xfs_da_args *args)
|
|
|
|
{
|
2020-02-27 01:30:34 +00:00
|
|
|
ASSERT(xfs_isilocked(args->dp, XFS_ILOCK_SHARED | XFS_ILOCK_EXCL));
|
2017-07-13 19:14:33 +00:00
|
|
|
|
2020-02-27 01:30:34 +00:00
|
|
|
if (!xfs_inode_hasattr(args->dp))
|
2017-06-16 18:00:14 +00:00
|
|
|
return -ENOATTR;
|
2020-02-27 01:30:34 +00:00
|
|
|
|
|
|
|
if (args->dp->i_d.di_aformat == XFS_DINODE_FMT_LOCAL)
|
2017-06-16 18:00:14 +00:00
|
|
|
return xfs_attr_shortform_getvalue(args);
|
2020-02-27 01:30:34 +00:00
|
|
|
if (xfs_bmap_one_block(args->dp, XFS_ATTR_FORK))
|
2017-06-16 18:00:14 +00:00
|
|
|
return xfs_attr_leaf_get(args);
|
2020-02-27 01:30:34 +00:00
|
|
|
return xfs_attr_node_get(args);
|
2017-06-16 18:00:14 +00:00
|
|
|
}
|
|
|
|
|
xfs: allocate xattr buffer on demand
When doing file lookups and checking for permissions, we end up in
xfs_get_acl() to see if there are any ACLs on the inode. This
requires and xattr lookup, and to do that we have to supply a buffer
large enough to hold an maximum sized xattr.
On workloads were we are accessing a wide range of cache cold files
under memory pressure (e.g. NFS fileservers) we end up spending a
lot of time allocating the buffer. The buffer is 64k in length, so
is a contiguous multi-page allocation, and if that then fails we
fall back to vmalloc(). Hence the allocation here is /expensive/
when we are looking up hundreds of thousands of files a second.
Initial numbers from a bpf trace show average time in xfs_get_acl()
is ~32us, with ~19us of that in the memory allocation. Note these
are average times, so there are going to be affected by the worst
case allocations more than the common fast case...
To avoid this, we could just do a "null" lookup to see if the ACL
xattr exists and then only do the allocation if it exists. This,
however, optimises the path for the "no ACL present" case at the
expense of the "acl present" case. i.e. we can halve the time in
xfs_get_acl() for the no acl case (i.e down to ~10-15us), but that
then increases the ACL case by 30% (i.e. up to 40-45us).
To solve this and speed up both cases, drive the xattr buffer
allocation into the attribute code once we know what the actual
xattr length is. For the no-xattr case, we avoid the allocation
completely, speeding up that case. For the common ACL case, we'll
end up with a fast heap allocation (because it'll be smaller than a
page), and only for the rarer "we have a remote xattr" will we have
a multi-page allocation occur. Hence the common ACL case will be
much faster, too.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2019-08-29 16:04:10 +00:00
|
|
|
/*
|
|
|
|
* Retrieve an extended attribute by name, and its value if requested.
|
|
|
|
*
|
2020-02-27 01:30:35 +00:00
|
|
|
* If args->valuelen is zero, then the caller does not want the value, just an
|
|
|
|
* indication whether the attribute exists and the size of the value if it
|
|
|
|
* exists. The size is returned in args.valuelen.
|
xfs: allocate xattr buffer on demand
When doing file lookups and checking for permissions, we end up in
xfs_get_acl() to see if there are any ACLs on the inode. This
requires and xattr lookup, and to do that we have to supply a buffer
large enough to hold an maximum sized xattr.
On workloads were we are accessing a wide range of cache cold files
under memory pressure (e.g. NFS fileservers) we end up spending a
lot of time allocating the buffer. The buffer is 64k in length, so
is a contiguous multi-page allocation, and if that then fails we
fall back to vmalloc(). Hence the allocation here is /expensive/
when we are looking up hundreds of thousands of files a second.
Initial numbers from a bpf trace show average time in xfs_get_acl()
is ~32us, with ~19us of that in the memory allocation. Note these
are average times, so there are going to be affected by the worst
case allocations more than the common fast case...
To avoid this, we could just do a "null" lookup to see if the ACL
xattr exists and then only do the allocation if it exists. This,
however, optimises the path for the "no ACL present" case at the
expense of the "acl present" case. i.e. we can halve the time in
xfs_get_acl() for the no acl case (i.e down to ~10-15us), but that
then increases the ACL case by 30% (i.e. up to 40-45us).
To solve this and speed up both cases, drive the xattr buffer
allocation into the attribute code once we know what the actual
xattr length is. For the no-xattr case, we avoid the allocation
completely, speeding up that case. For the common ACL case, we'll
end up with a fast heap allocation (because it'll be smaller than a
page), and only for the rarer "we have a remote xattr" will we have
a multi-page allocation occur. Hence the common ACL case will be
much faster, too.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2019-08-29 16:04:10 +00:00
|
|
|
*
|
2020-02-27 01:30:35 +00:00
|
|
|
* If args->value is NULL but args->valuelen is non-zero, allocate the buffer
|
|
|
|
* for the value after existence of the attribute has been determined. The
|
|
|
|
* caller always has to free args->value if it is set, no matter if this
|
|
|
|
* function was successful or not.
|
|
|
|
*
|
xfs: allocate xattr buffer on demand
When doing file lookups and checking for permissions, we end up in
xfs_get_acl() to see if there are any ACLs on the inode. This
requires and xattr lookup, and to do that we have to supply a buffer
large enough to hold an maximum sized xattr.
On workloads were we are accessing a wide range of cache cold files
under memory pressure (e.g. NFS fileservers) we end up spending a
lot of time allocating the buffer. The buffer is 64k in length, so
is a contiguous multi-page allocation, and if that then fails we
fall back to vmalloc(). Hence the allocation here is /expensive/
when we are looking up hundreds of thousands of files a second.
Initial numbers from a bpf trace show average time in xfs_get_acl()
is ~32us, with ~19us of that in the memory allocation. Note these
are average times, so there are going to be affected by the worst
case allocations more than the common fast case...
To avoid this, we could just do a "null" lookup to see if the ACL
xattr exists and then only do the allocation if it exists. This,
however, optimises the path for the "no ACL present" case at the
expense of the "acl present" case. i.e. we can halve the time in
xfs_get_acl() for the no acl case (i.e down to ~10-15us), but that
then increases the ACL case by 30% (i.e. up to 40-45us).
To solve this and speed up both cases, drive the xattr buffer
allocation into the attribute code once we know what the actual
xattr length is. For the no-xattr case, we avoid the allocation
completely, speeding up that case. For the common ACL case, we'll
end up with a fast heap allocation (because it'll be smaller than a
page), and only for the rarer "we have a remote xattr" will we have
a multi-page allocation occur. Hence the common ACL case will be
much faster, too.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2019-08-29 16:04:10 +00:00
|
|
|
* If the attribute is found, but exceeds the size limit set by the caller in
|
2020-02-27 01:30:34 +00:00
|
|
|
* args->valuelen, return -ERANGE with the size of the attribute that was found
|
|
|
|
* in args->valuelen.
|
xfs: allocate xattr buffer on demand
When doing file lookups and checking for permissions, we end up in
xfs_get_acl() to see if there are any ACLs on the inode. This
requires and xattr lookup, and to do that we have to supply a buffer
large enough to hold an maximum sized xattr.
On workloads were we are accessing a wide range of cache cold files
under memory pressure (e.g. NFS fileservers) we end up spending a
lot of time allocating the buffer. The buffer is 64k in length, so
is a contiguous multi-page allocation, and if that then fails we
fall back to vmalloc(). Hence the allocation here is /expensive/
when we are looking up hundreds of thousands of files a second.
Initial numbers from a bpf trace show average time in xfs_get_acl()
is ~32us, with ~19us of that in the memory allocation. Note these
are average times, so there are going to be affected by the worst
case allocations more than the common fast case...
To avoid this, we could just do a "null" lookup to see if the ACL
xattr exists and then only do the allocation if it exists. This,
however, optimises the path for the "no ACL present" case at the
expense of the "acl present" case. i.e. we can halve the time in
xfs_get_acl() for the no acl case (i.e down to ~10-15us), but that
then increases the ACL case by 30% (i.e. up to 40-45us).
To solve this and speed up both cases, drive the xattr buffer
allocation into the attribute code once we know what the actual
xattr length is. For the no-xattr case, we avoid the allocation
completely, speeding up that case. For the common ACL case, we'll
end up with a fast heap allocation (because it'll be smaller than a
page), and only for the rarer "we have a remote xattr" will we have
a multi-page allocation occur. Hence the common ACL case will be
much faster, too.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2019-08-29 16:04:10 +00:00
|
|
|
*/
|
2014-05-13 06:34:24 +00:00
|
|
|
int
|
|
|
|
xfs_attr_get(
|
2020-02-27 01:30:34 +00:00
|
|
|
struct xfs_da_args *args)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-05-13 06:34:24 +00:00
|
|
|
uint lock_mode;
|
|
|
|
int error;
|
|
|
|
|
2020-02-27 01:30:34 +00:00
|
|
|
XFS_STATS_INC(args->dp->i_mount, xs_attr_get);
|
2014-05-13 06:34:24 +00:00
|
|
|
|
2020-02-27 01:30:34 +00:00
|
|
|
if (XFS_FORCED_SHUTDOWN(args->dp->i_mount))
|
2014-06-25 04:58:08 +00:00
|
|
|
return -EIO;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-02-27 01:30:34 +00:00
|
|
|
args->geo = args->dp->i_mount->m_attr_geo;
|
|
|
|
args->whichfork = XFS_ATTR_FORK;
|
|
|
|
args->hashval = xfs_da_hashname(args->name, args->namelen);
|
2014-05-13 06:34:24 +00:00
|
|
|
|
xfs: set XFS_DA_OP_OKNOENT in xfs_attr_get
It's entirely possible for userspace to ask for an xattr which
does not exist.
Normally, there is no problem whatsoever when we ask for such
a thing, but when we look at an obfuscated metadump image
on a debug kernel with selinux, we trip over this ASSERT in
xfs_da3_path_shift():
*result = -ENOENT; /* we're out of our tree */
ASSERT(args->op_flags & XFS_DA_OP_OKNOENT);
It (more or less) only shows up in the above scenario, because
xfs_metadump obfuscates attr names, but chooses names which
keep the same hash value - and xfs_da3_node_lookup_int does:
if (((retval == -ENOENT) || (retval == -ENOATTR)) &&
(blk->hashval == args->hashval)) {
error = xfs_da3_path_shift(state, &state->path, 1, 1,
&retval);
IOWS, we only get down to the xfs_da3_path_shift() ASSERT
if we are looking for an xattr which doesn't exist, but we
find xattrs on disk which have the same hash, and so might be
a hash collision, so we try the path shift. When *that*
fails to find what we're looking for, we hit the assert about
XFS_DA_OP_OKNOENT.
Simply setting XFS_DA_OP_OKNOENT in xfs_attr_get solves this
rather corner-case problem with no ill side effects. It's
fine for an attr name lookup to fail.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2015-08-19 00:30:48 +00:00
|
|
|
/* Entirely possible to look up a name which doesn't exist */
|
2020-02-27 01:30:34 +00:00
|
|
|
args->op_flags = XFS_DA_OP_OKNOENT;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-02-27 01:30:34 +00:00
|
|
|
lock_mode = xfs_ilock_attr_map_shared(args->dp);
|
2020-02-27 01:30:34 +00:00
|
|
|
error = xfs_attr_get_ilocked(args);
|
2020-02-27 01:30:34 +00:00
|
|
|
xfs_iunlock(args->dp, lock_mode);
|
xfs: allocate xattr buffer on demand
When doing file lookups and checking for permissions, we end up in
xfs_get_acl() to see if there are any ACLs on the inode. This
requires and xattr lookup, and to do that we have to supply a buffer
large enough to hold an maximum sized xattr.
On workloads were we are accessing a wide range of cache cold files
under memory pressure (e.g. NFS fileservers) we end up spending a
lot of time allocating the buffer. The buffer is 64k in length, so
is a contiguous multi-page allocation, and if that then fails we
fall back to vmalloc(). Hence the allocation here is /expensive/
when we are looking up hundreds of thousands of files a second.
Initial numbers from a bpf trace show average time in xfs_get_acl()
is ~32us, with ~19us of that in the memory allocation. Note these
are average times, so there are going to be affected by the worst
case allocations more than the common fast case...
To avoid this, we could just do a "null" lookup to see if the ACL
xattr exists and then only do the allocation if it exists. This,
however, optimises the path for the "no ACL present" case at the
expense of the "acl present" case. i.e. we can halve the time in
xfs_get_acl() for the no acl case (i.e down to ~10-15us), but that
then increases the ACL case by 30% (i.e. up to 40-45us).
To solve this and speed up both cases, drive the xattr buffer
allocation into the attribute code once we know what the actual
xattr length is. For the no-xattr case, we avoid the allocation
completely, speeding up that case. For the common ACL case, we'll
end up with a fast heap allocation (because it'll be smaller than a
page), and only for the rarer "we have a remote xattr" will we have
a multi-page allocation occur. Hence the common ACL case will be
much faster, too.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
2019-08-29 16:04:10 +00:00
|
|
|
|
2020-02-27 01:30:34 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-08-13 06:03:35 +00:00
|
|
|
/*
|
|
|
|
* Calculate how many blocks we need for the new attribute,
|
|
|
|
*/
|
2009-11-19 15:52:00 +00:00
|
|
|
STATIC int
|
2008-08-13 06:03:35 +00:00
|
|
|
xfs_attr_calc_size(
|
2014-05-13 06:40:19 +00:00
|
|
|
struct xfs_da_args *args,
|
2008-08-13 06:03:35 +00:00
|
|
|
int *local)
|
|
|
|
{
|
2014-05-13 06:40:19 +00:00
|
|
|
struct xfs_mount *mp = args->dp->i_mount;
|
2008-08-13 06:03:35 +00:00
|
|
|
int size;
|
|
|
|
int nblks;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Determine space new attribute will use, and if it would be
|
|
|
|
* "local" or "remote" (note: local != inline).
|
|
|
|
*/
|
2014-06-06 05:21:27 +00:00
|
|
|
size = xfs_attr_leaf_newentsize(args, local);
|
2008-08-13 06:03:35 +00:00
|
|
|
nblks = XFS_DAENTER_SPACE_RES(mp, XFS_ATTR_FORK);
|
|
|
|
if (*local) {
|
2014-06-06 05:21:10 +00:00
|
|
|
if (size > (args->geo->blksize / 2)) {
|
2008-08-13 06:03:35 +00:00
|
|
|
/* Double split possible */
|
|
|
|
nblks *= 2;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* Out of line attribute, cannot double split, but
|
|
|
|
* make room for the attribute value itself.
|
|
|
|
*/
|
2014-05-14 23:39:28 +00:00
|
|
|
uint dblocks = xfs_attr3_rmt_blocks(mp, args->valuelen);
|
2008-08-13 06:03:35 +00:00
|
|
|
nblks += dblocks;
|
|
|
|
nblks += XFS_NEXTENTADD_SPACE_RES(mp, dblocks, XFS_ATTR_FORK);
|
|
|
|
}
|
|
|
|
|
|
|
|
return nblks;
|
|
|
|
}
|
|
|
|
|
2018-10-18 06:20:50 +00:00
|
|
|
STATIC int
|
|
|
|
xfs_attr_try_sf_addname(
|
|
|
|
struct xfs_inode *dp,
|
|
|
|
struct xfs_da_args *args)
|
|
|
|
{
|
|
|
|
|
|
|
|
struct xfs_mount *mp = dp->i_mount;
|
|
|
|
int error, error2;
|
|
|
|
|
|
|
|
error = xfs_attr_shortform_addname(args);
|
|
|
|
if (error == -ENOSPC)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Commit the shortform mods, and we're done.
|
|
|
|
* NOTE: this is also the error path (EEXIST, etc).
|
|
|
|
*/
|
2020-02-27 01:30:36 +00:00
|
|
|
if (!error && !(args->op_flags & XFS_DA_OP_NOTIME))
|
2018-10-18 06:20:50 +00:00
|
|
|
xfs_trans_ichgtime(args->trans, dp, XFS_ICHGTIME_CHG);
|
|
|
|
|
|
|
|
if (mp->m_flags & XFS_MOUNT_WSYNC)
|
|
|
|
xfs_trans_set_sync(args->trans);
|
|
|
|
|
|
|
|
error2 = xfs_trans_commit(args->trans);
|
2018-10-18 06:21:16 +00:00
|
|
|
args->trans = NULL;
|
2018-10-18 06:20:50 +00:00
|
|
|
return error ? error : error2;
|
|
|
|
}
|
|
|
|
|
2018-10-18 06:21:16 +00:00
|
|
|
/*
|
|
|
|
* Set the attribute specified in @args.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_attr_set_args(
|
2019-04-24 16:27:41 +00:00
|
|
|
struct xfs_da_args *args)
|
2018-10-18 06:21:16 +00:00
|
|
|
{
|
|
|
|
struct xfs_inode *dp = args->dp;
|
2019-04-24 16:27:41 +00:00
|
|
|
struct xfs_buf *leaf_bp = NULL;
|
2018-10-18 06:21:16 +00:00
|
|
|
int error;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the attribute list is non-existent or a shortform list,
|
|
|
|
* upgrade it to a single-leaf-block attribute list.
|
|
|
|
*/
|
|
|
|
if (dp->i_d.di_aformat == XFS_DINODE_FMT_LOCAL ||
|
|
|
|
(dp->i_d.di_aformat == XFS_DINODE_FMT_EXTENTS &&
|
|
|
|
dp->i_d.di_anextents == 0)) {
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Build initial attribute list (if required).
|
|
|
|
*/
|
|
|
|
if (dp->i_d.di_aformat == XFS_DINODE_FMT_EXTENTS)
|
|
|
|
xfs_attr_shortform_create(args);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Try to add the attr to the attribute list in the inode.
|
|
|
|
*/
|
|
|
|
error = xfs_attr_try_sf_addname(dp, args);
|
|
|
|
if (error != -ENOSPC)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* It won't fit in the shortform, transform to a leaf block.
|
|
|
|
* GROT: another possible req'mt for a double-split btree op.
|
|
|
|
*/
|
2019-04-24 16:27:41 +00:00
|
|
|
error = xfs_attr_shortform_to_leaf(args, &leaf_bp);
|
2018-10-18 06:21:16 +00:00
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Prevent the leaf buffer from being unlocked so that a
|
|
|
|
* concurrent AIL push cannot grab the half-baked leaf
|
|
|
|
* buffer and run into problems with the write verifier.
|
2019-04-24 16:27:41 +00:00
|
|
|
* Once we're done rolling the transaction we can release
|
|
|
|
* the hold and add the attr to the leaf.
|
2018-10-18 06:21:16 +00:00
|
|
|
*/
|
2019-04-24 16:27:41 +00:00
|
|
|
xfs_trans_bhold(args->trans, leaf_bp);
|
2018-10-18 06:21:16 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2019-04-24 16:27:41 +00:00
|
|
|
xfs_trans_bhold_release(args->trans, leaf_bp);
|
|
|
|
if (error) {
|
|
|
|
xfs_trans_brelse(args->trans, leaf_bp);
|
2018-10-18 06:21:16 +00:00
|
|
|
return error;
|
2019-04-24 16:27:41 +00:00
|
|
|
}
|
2018-10-18 06:21:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (xfs_bmap_one_block(dp, XFS_ATTR_FORK))
|
|
|
|
error = xfs_attr_leaf_addname(args);
|
|
|
|
else
|
|
|
|
error = xfs_attr_node_addname(args);
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2018-10-18 06:21:23 +00:00
|
|
|
/*
|
|
|
|
* Remove the attribute specified in @args.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
xfs_attr_remove_args(
|
|
|
|
struct xfs_da_args *args)
|
|
|
|
{
|
|
|
|
struct xfs_inode *dp = args->dp;
|
|
|
|
int error;
|
|
|
|
|
|
|
|
if (!xfs_inode_hasattr(dp)) {
|
|
|
|
error = -ENOATTR;
|
|
|
|
} else if (dp->i_d.di_aformat == XFS_DINODE_FMT_LOCAL) {
|
|
|
|
ASSERT(dp->i_afp->if_flags & XFS_IFINLINE);
|
|
|
|
error = xfs_attr_shortform_remove(args);
|
|
|
|
} else if (xfs_bmap_one_block(dp, XFS_ATTR_FORK)) {
|
|
|
|
error = xfs_attr_leaf_removename(args);
|
|
|
|
} else {
|
|
|
|
error = xfs_attr_node_removename(args);
|
|
|
|
}
|
|
|
|
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2020-02-27 01:30:29 +00:00
|
|
|
/*
|
2020-02-27 01:30:33 +00:00
|
|
|
* Note: If args->value is NULL the attribute will be removed, just like the
|
2020-02-27 01:30:29 +00:00
|
|
|
* Linux ->setattr API.
|
|
|
|
*/
|
2014-05-13 06:34:14 +00:00
|
|
|
int
|
|
|
|
xfs_attr_set(
|
2020-02-27 01:30:33 +00:00
|
|
|
struct xfs_da_args *args)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2020-02-27 01:30:33 +00:00
|
|
|
struct xfs_inode *dp = args->dp;
|
2013-08-12 10:49:59 +00:00
|
|
|
struct xfs_mount *mp = dp->i_mount;
|
|
|
|
struct xfs_trans_res tres;
|
2020-02-27 01:30:42 +00:00
|
|
|
bool rsvd = (args->attr_filter & XFS_ATTR_ROOT);
|
2018-10-18 06:20:50 +00:00
|
|
|
int error, local;
|
2020-02-27 01:30:29 +00:00
|
|
|
unsigned int total;
|
2014-05-13 06:34:14 +00:00
|
|
|
|
|
|
|
if (XFS_FORCED_SHUTDOWN(dp->i_mount))
|
2014-06-25 04:58:08 +00:00
|
|
|
return -EIO;
|
2014-05-13 06:34:14 +00:00
|
|
|
|
2020-02-27 01:30:29 +00:00
|
|
|
error = xfs_qm_dqattach(dp);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2020-02-27 01:30:33 +00:00
|
|
|
args->geo = mp->m_attr_geo;
|
|
|
|
args->whichfork = XFS_ATTR_FORK;
|
|
|
|
args->hashval = xfs_da_hashname(args->name, args->namelen);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
2020-02-27 01:30:29 +00:00
|
|
|
* We have no control over the attribute names that userspace passes us
|
|
|
|
* to remove, so we have to allow the name lookup prior to attribute
|
|
|
|
* removal to fail as well.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2020-02-27 01:30:33 +00:00
|
|
|
args->op_flags = XFS_DA_OP_OKNOENT;
|
2007-02-10 07:35:58 +00:00
|
|
|
|
2020-02-27 01:30:33 +00:00
|
|
|
if (args->value) {
|
2020-02-27 01:30:29 +00:00
|
|
|
XFS_STATS_INC(mp, xs_attr_set);
|
|
|
|
|
2020-02-27 01:30:33 +00:00
|
|
|
args->op_flags |= XFS_DA_OP_ADDNAME;
|
|
|
|
args->total = xfs_attr_calc_size(args, &local);
|
2020-02-27 01:30:29 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the inode doesn't have an attribute fork, add one.
|
|
|
|
* (inode must not be locked when we call this routine)
|
|
|
|
*/
|
|
|
|
if (XFS_IFORK_Q(dp) == 0) {
|
|
|
|
int sf_size = sizeof(struct xfs_attr_sf_hdr) +
|
2020-02-27 01:30:33 +00:00
|
|
|
XFS_ATTR_SF_ENTSIZE_BYNAME(args->namelen,
|
|
|
|
args->valuelen);
|
2020-02-27 01:30:29 +00:00
|
|
|
|
|
|
|
error = xfs_bmap_add_attrfork(dp, sf_size, rsvd);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
tres.tr_logres = M_RES(mp)->tr_attrsetm.tr_logres +
|
2020-02-27 01:30:33 +00:00
|
|
|
M_RES(mp)->tr_attrsetrt.tr_logres *
|
|
|
|
args->total;
|
2020-02-27 01:30:29 +00:00
|
|
|
tres.tr_logcount = XFS_ATTRSET_LOG_COUNT;
|
|
|
|
tres.tr_logflags = XFS_TRANS_PERM_LOG_RES;
|
2020-02-27 01:30:33 +00:00
|
|
|
total = args->total;
|
2020-02-27 01:30:29 +00:00
|
|
|
} else {
|
|
|
|
XFS_STATS_INC(mp, xs_attr_remove);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-02-27 01:30:29 +00:00
|
|
|
tres = M_RES(mp)->tr_attrrm;
|
|
|
|
total = XFS_ATTRRM_SPACE_RES(mp);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Root fork attributes can use reserved data blocks for this
|
|
|
|
* operation if necessary
|
|
|
|
*/
|
2020-02-27 01:30:29 +00:00
|
|
|
error = xfs_trans_alloc(mp, &tres, total, 0,
|
2020-02-27 01:30:33 +00:00
|
|
|
rsvd ? XFS_TRANS_RESERVE : 0, &args->trans);
|
2016-04-05 23:19:55 +00:00
|
|
|
if (error)
|
2014-05-13 06:34:14 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-04-05 23:19:55 +00:00
|
|
|
xfs_ilock(dp, XFS_ILOCK_EXCL);
|
2020-02-27 01:30:33 +00:00
|
|
|
xfs_trans_ijoin(args->trans, dp, 0);
|
|
|
|
if (args->value) {
|
2020-02-27 01:30:29 +00:00
|
|
|
unsigned int quota_flags = XFS_QMOPT_RES_REGBLKS;
|
|
|
|
|
|
|
|
if (rsvd)
|
|
|
|
quota_flags |= XFS_QMOPT_FORCE_RES;
|
2020-02-27 01:30:33 +00:00
|
|
|
error = xfs_trans_reserve_quota_nblks(args->trans, dp,
|
|
|
|
args->total, 0, quota_flags);
|
2020-02-27 01:30:29 +00:00
|
|
|
if (error)
|
|
|
|
goto out_trans_cancel;
|
2020-02-27 01:30:33 +00:00
|
|
|
error = xfs_attr_set_args(args);
|
2020-02-27 01:30:29 +00:00
|
|
|
if (error)
|
|
|
|
goto out_trans_cancel;
|
2018-10-18 06:21:16 +00:00
|
|
|
/* shortform attribute has already been committed */
|
2020-02-27 01:30:33 +00:00
|
|
|
if (!args->trans)
|
2020-02-27 01:30:29 +00:00
|
|
|
goto out_unlock;
|
|
|
|
} else {
|
2020-02-27 01:30:33 +00:00
|
|
|
error = xfs_attr_remove_args(args);
|
2020-02-27 01:30:29 +00:00
|
|
|
if (error)
|
|
|
|
goto out_trans_cancel;
|
2018-10-18 06:21:16 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If this is a synchronous mount, make sure that the
|
|
|
|
* transaction goes to disk before returning to the user.
|
|
|
|
*/
|
2014-05-13 06:34:14 +00:00
|
|
|
if (mp->m_flags & XFS_MOUNT_WSYNC)
|
2020-02-27 01:30:33 +00:00
|
|
|
xfs_trans_set_sync(args->trans);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-02-27 01:30:36 +00:00
|
|
|
if (!(args->op_flags & XFS_DA_OP_NOTIME))
|
2020-02-27 01:30:33 +00:00
|
|
|
xfs_trans_ichgtime(args->trans, dp, XFS_ICHGTIME_CHG);
|
2010-09-28 02:27:25 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Commit the last in the sequence of transactions.
|
|
|
|
*/
|
2020-02-27 01:30:33 +00:00
|
|
|
xfs_trans_log_inode(args->trans, dp, XFS_ILOG_CORE);
|
|
|
|
error = xfs_trans_commit(args->trans);
|
2018-10-18 06:21:16 +00:00
|
|
|
out_unlock:
|
2005-04-16 22:20:36 +00:00
|
|
|
xfs_iunlock(dp, XFS_ILOCK_EXCL);
|
2014-05-13 06:34:14 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-10-18 06:21:16 +00:00
|
|
|
out_trans_cancel:
|
2020-02-27 01:30:33 +00:00
|
|
|
if (args->trans)
|
|
|
|
xfs_trans_cancel(args->trans);
|
2018-10-18 06:21:16 +00:00
|
|
|
goto out_unlock;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*========================================================================
|
|
|
|
* External routines when attribute list is inside the inode
|
|
|
|
*========================================================================*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Add a name to the shortform attribute list structure
|
|
|
|
* This is the external routine.
|
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_attr_shortform_addname(xfs_da_args_t *args)
|
|
|
|
{
|
2005-11-01 23:34:53 +00:00
|
|
|
int newsize, forkoff, retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-03-22 05:15:13 +00:00
|
|
|
trace_xfs_attr_sf_addname(args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
retval = xfs_attr_shortform_lookup(args);
|
2020-02-27 01:30:42 +00:00
|
|
|
if (retval == -ENOATTR && (args->attr_flags & XATTR_REPLACE))
|
2014-06-22 05:03:54 +00:00
|
|
|
return retval;
|
2020-02-27 01:30:42 +00:00
|
|
|
if (retval == -EEXIST) {
|
2020-02-27 01:30:42 +00:00
|
|
|
if (args->attr_flags & XATTR_CREATE)
|
2014-06-22 05:03:54 +00:00
|
|
|
return retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
retval = xfs_attr_shortform_remove(args);
|
2018-04-18 02:10:15 +00:00
|
|
|
if (retval)
|
|
|
|
return retval;
|
|
|
|
/*
|
|
|
|
* Since we have removed the old attr, clear ATTR_REPLACE so
|
|
|
|
* that the leaf format add routine won't trip over the attr
|
|
|
|
* not being around.
|
|
|
|
*/
|
2020-02-27 01:30:42 +00:00
|
|
|
args->attr_flags &= ~XATTR_REPLACE;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2005-11-01 23:34:53 +00:00
|
|
|
if (args->namelen >= XFS_ATTR_SF_ENTSIZE_MAX ||
|
|
|
|
args->valuelen >= XFS_ATTR_SF_ENTSIZE_MAX)
|
2014-06-25 04:58:08 +00:00
|
|
|
return -ENOSPC;
|
2005-11-01 23:34:53 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
newsize = XFS_ATTR_SF_TOTSIZE(args->dp);
|
|
|
|
newsize += XFS_ATTR_SF_ENTSIZE_BYNAME(args->namelen, args->valuelen);
|
2005-11-01 23:34:53 +00:00
|
|
|
|
|
|
|
forkoff = xfs_attr_shortform_bytesfit(args->dp, newsize);
|
|
|
|
if (!forkoff)
|
2014-06-25 04:58:08 +00:00
|
|
|
return -ENOSPC;
|
2005-11-01 23:34:53 +00:00
|
|
|
|
|
|
|
xfs_attr_shortform_add(args, forkoff);
|
2014-06-22 05:03:54 +00:00
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*========================================================================
|
|
|
|
* External routines when attribute list is one block
|
|
|
|
*========================================================================*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Add a name to the leaf attribute list structure
|
|
|
|
*
|
|
|
|
* This leaf block cannot have a "remote" value, we only call this routine
|
|
|
|
* if bmap_one_block() says there is only one block (ie: no remote blks).
|
|
|
|
*/
|
2007-11-23 05:28:09 +00:00
|
|
|
STATIC int
|
2018-07-12 05:26:11 +00:00
|
|
|
xfs_attr_leaf_addname(
|
|
|
|
struct xfs_da_args *args)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2018-07-12 05:26:11 +00:00
|
|
|
struct xfs_inode *dp;
|
|
|
|
struct xfs_buf *bp;
|
|
|
|
int retval, error, forkoff;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-03-22 05:15:13 +00:00
|
|
|
trace_xfs_attr_leaf_addname(args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Read the (only) block in the attribute list in.
|
|
|
|
*/
|
|
|
|
dp = args->dp;
|
|
|
|
args->blkno = 0;
|
2019-11-20 17:46:02 +00:00
|
|
|
error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
2012-11-12 11:54:16 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Look up the given attribute in the leaf block. Figure out if
|
|
|
|
* the given flags produce an error or call for an atomic rename.
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
retval = xfs_attr3_leaf_lookup_int(bp, args);
|
2020-02-27 01:30:42 +00:00
|
|
|
if (retval == -ENOATTR && (args->attr_flags & XATTR_REPLACE))
|
2020-02-27 01:30:42 +00:00
|
|
|
goto out_brelse;
|
|
|
|
if (retval == -EEXIST) {
|
2020-02-27 01:30:42 +00:00
|
|
|
if (args->attr_flags & XATTR_CREATE)
|
2020-02-27 01:30:42 +00:00
|
|
|
goto out_brelse;
|
2012-03-22 05:15:13 +00:00
|
|
|
|
|
|
|
trace_xfs_attr_leaf_replace(args);
|
|
|
|
|
xfs: remote attribute overwrite causes transaction overrun
Commit e461fcb ("xfs: remote attribute lookups require the value
length") passes the remote attribute length in the xfs_da_args
structure on lookup so that CRC calculations and validity checking
can be performed correctly by related code. This, unfortunately has
the side effect of changing the args->valuelen parameter in cases
where it shouldn't.
That is, when we replace a remote attribute, the incoming
replacement stores the value and length in args->value and
args->valuelen, but then the lookup which finds the existing remote
attribute overwrites args->valuelen with the length of the remote
attribute being replaced. Hence when we go to create the new
attribute, we create it of the size of the existing remote
attribute, not the size it is supposed to be. When the new attribute
is much smaller than the old attribute, this results in a
transaction overrun and an ASSERT() failure on a debug kernel:
XFS: Assertion failed: tp->t_blk_res_used <= tp->t_blk_res, file: fs/xfs/xfs_trans.c, line: 331
Fix this by keeping the remote attribute value length separate to
the attribute value length in the xfs_da_args structure. The enables
us to pass the length of the remote attribute to be removed without
overwriting the new attribute's length.
Also, ensure that when we save remote block contexts for a later
rename we zero the original state variables so that we don't confuse
the state of the attribute to be removes with the state of the new
attribute that we just added. [Spotted by Brain Foster.]
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 21:37:31 +00:00
|
|
|
/* save the attribute state for later removal*/
|
2008-05-21 06:42:05 +00:00
|
|
|
args->op_flags |= XFS_DA_OP_RENAME; /* an atomic rename */
|
2005-04-16 22:20:36 +00:00
|
|
|
args->blkno2 = args->blkno; /* set 2nd entry info*/
|
|
|
|
args->index2 = args->index;
|
|
|
|
args->rmtblkno2 = args->rmtblkno;
|
|
|
|
args->rmtblkcnt2 = args->rmtblkcnt;
|
xfs: remote attribute overwrite causes transaction overrun
Commit e461fcb ("xfs: remote attribute lookups require the value
length") passes the remote attribute length in the xfs_da_args
structure on lookup so that CRC calculations and validity checking
can be performed correctly by related code. This, unfortunately has
the side effect of changing the args->valuelen parameter in cases
where it shouldn't.
That is, when we replace a remote attribute, the incoming
replacement stores the value and length in args->value and
args->valuelen, but then the lookup which finds the existing remote
attribute overwrites args->valuelen with the length of the remote
attribute being replaced. Hence when we go to create the new
attribute, we create it of the size of the existing remote
attribute, not the size it is supposed to be. When the new attribute
is much smaller than the old attribute, this results in a
transaction overrun and an ASSERT() failure on a debug kernel:
XFS: Assertion failed: tp->t_blk_res_used <= tp->t_blk_res, file: fs/xfs/xfs_trans.c, line: 331
Fix this by keeping the remote attribute value length separate to
the attribute value length in the xfs_da_args structure. The enables
us to pass the length of the remote attribute to be removed without
overwriting the new attribute's length.
Also, ensure that when we save remote block contexts for a later
rename we zero the original state variables so that we don't confuse
the state of the attribute to be removes with the state of the new
attribute that we just added. [Spotted by Brain Foster.]
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 21:37:31 +00:00
|
|
|
args->rmtvaluelen2 = args->rmtvaluelen;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* clear the remote attr state now that it is saved so that the
|
|
|
|
* values reflect the state of the attribute we are about to
|
|
|
|
* add, not the attribute we just found and will remove later.
|
|
|
|
*/
|
|
|
|
args->rmtblkno = 0;
|
|
|
|
args->rmtblkcnt = 0;
|
|
|
|
args->rmtvaluelen = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Add the attribute to the leaf block, transitioning to a Btree
|
|
|
|
* if required.
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
retval = xfs_attr3_leaf_add(bp, args);
|
2014-06-25 04:58:08 +00:00
|
|
|
if (retval == -ENOSPC) {
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Promote the attribute list to the Btree format, then
|
|
|
|
* Commit that transaction so that the node_addname() call
|
|
|
|
* can manage its own transactions.
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_to_node(args);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-09-29 03:41:58 +00:00
|
|
|
return error;
|
2018-07-24 20:43:15 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-08-01 14:20:33 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Commit the current trans (including the inode) and start
|
|
|
|
* a new one.
|
|
|
|
*/
|
2017-08-28 17:21:03 +00:00
|
|
|
error = xfs_trans_roll_inode(&args->trans, dp);
|
2008-08-13 06:05:49 +00:00
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Fob the whole rest of the problem off on the Btree code.
|
|
|
|
*/
|
|
|
|
error = xfs_attr_node_addname(args);
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Commit the transaction that added the attr name so that
|
|
|
|
* later routines can manage their own transactions.
|
|
|
|
*/
|
2017-08-28 17:21:03 +00:00
|
|
|
error = xfs_trans_roll_inode(&args->trans, dp);
|
2008-08-13 06:05:49 +00:00
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If there was an out-of-line value, allocate the blocks we
|
|
|
|
* identified for its storage and copy the value. This is done
|
|
|
|
* after we create the attribute so that we don't overflow the
|
|
|
|
* maximum size of a transaction and/or hit a deadlock.
|
|
|
|
*/
|
|
|
|
if (args->rmtblkno > 0) {
|
|
|
|
error = xfs_attr_rmtval_set(args);
|
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If this is an atomic rename operation, we must "flip" the
|
|
|
|
* incomplete flags on the "new" and "old" attribute/value pairs
|
|
|
|
* so that one disappears and one appears atomically. Then we
|
|
|
|
* must remove the "old" attribute/value pair.
|
|
|
|
*/
|
2008-05-21 06:42:05 +00:00
|
|
|
if (args->op_flags & XFS_DA_OP_RENAME) {
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* In a separate transaction, set the incomplete flag on the
|
|
|
|
* "old" attr and clear the incomplete flag on the "new" attr.
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_flipflags(args);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Dismantle the "old" attribute/value pair by removing
|
|
|
|
* a "remote" value (if it exists).
|
|
|
|
*/
|
|
|
|
args->index = args->index2;
|
|
|
|
args->blkno = args->blkno2;
|
|
|
|
args->rmtblkno = args->rmtblkno2;
|
|
|
|
args->rmtblkcnt = args->rmtblkcnt2;
|
xfs: remote attribute overwrite causes transaction overrun
Commit e461fcb ("xfs: remote attribute lookups require the value
length") passes the remote attribute length in the xfs_da_args
structure on lookup so that CRC calculations and validity checking
can be performed correctly by related code. This, unfortunately has
the side effect of changing the args->valuelen parameter in cases
where it shouldn't.
That is, when we replace a remote attribute, the incoming
replacement stores the value and length in args->value and
args->valuelen, but then the lookup which finds the existing remote
attribute overwrites args->valuelen with the length of the remote
attribute being replaced. Hence when we go to create the new
attribute, we create it of the size of the existing remote
attribute, not the size it is supposed to be. When the new attribute
is much smaller than the old attribute, this results in a
transaction overrun and an ASSERT() failure on a debug kernel:
XFS: Assertion failed: tp->t_blk_res_used <= tp->t_blk_res, file: fs/xfs/xfs_trans.c, line: 331
Fix this by keeping the remote attribute value length separate to
the attribute value length in the xfs_da_args structure. The enables
us to pass the length of the remote attribute to be removed without
overwriting the new attribute's length.
Also, ensure that when we save remote block contexts for a later
rename we zero the original state variables so that we don't confuse
the state of the attribute to be removes with the state of the new
attribute that we just added. [Spotted by Brain Foster.]
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 21:37:31 +00:00
|
|
|
args->rmtvaluelen = args->rmtvaluelen2;
|
2005-04-16 22:20:36 +00:00
|
|
|
if (args->rmtblkno) {
|
|
|
|
error = xfs_attr_rmtval_remove(args);
|
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Read in the block containing the "old" attr, then
|
|
|
|
* remove the "old" attr from that block (neat, huh!)
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno,
|
2019-11-20 17:46:02 +00:00
|
|
|
&bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
2012-11-12 11:54:16 +00:00
|
|
|
return error;
|
|
|
|
|
2013-04-24 08:58:55 +00:00
|
|
|
xfs_attr3_leaf_remove(bp, args);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the result is small enough, shrink it all into the inode.
|
|
|
|
*/
|
2005-11-01 23:34:53 +00:00
|
|
|
if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
|
2005-04-16 22:20:36 +00:00
|
|
|
/* bp is gone due to xfs_da_shrink_inode */
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-09-29 03:41:58 +00:00
|
|
|
return error;
|
2018-07-24 20:43:15 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-08-01 14:20:33 +00:00
|
|
|
return error;
|
2012-06-22 08:50:14 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Commit the remove and start the next trans in series.
|
|
|
|
*/
|
2017-08-28 17:21:03 +00:00
|
|
|
error = xfs_trans_roll_inode(&args->trans, dp);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
} else if (args->rmtblkno > 0) {
|
|
|
|
/*
|
|
|
|
* Added a "remote" value, just clear the incomplete flag.
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_clearflag(args);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2013-04-24 08:58:55 +00:00
|
|
|
return error;
|
2020-02-27 01:30:42 +00:00
|
|
|
out_brelse:
|
|
|
|
xfs_trans_brelse(args->trans, bp);
|
|
|
|
return retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Remove a name from the leaf attribute list structure
|
|
|
|
*
|
|
|
|
* This leaf block cannot have a "remote" value, we only call this routine
|
|
|
|
* if bmap_one_block() says there is only one block (ie: no remote blks).
|
|
|
|
*/
|
|
|
|
STATIC int
|
2018-07-12 05:26:11 +00:00
|
|
|
xfs_attr_leaf_removename(
|
|
|
|
struct xfs_da_args *args)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2018-07-12 05:26:11 +00:00
|
|
|
struct xfs_inode *dp;
|
|
|
|
struct xfs_buf *bp;
|
|
|
|
int error, forkoff;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-03-22 05:15:13 +00:00
|
|
|
trace_xfs_attr_leaf_removename(args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Remove the attribute.
|
|
|
|
*/
|
|
|
|
dp = args->dp;
|
|
|
|
args->blkno = 0;
|
2019-11-20 17:46:02 +00:00
|
|
|
error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp);
|
2012-11-12 11:54:16 +00:00
|
|
|
if (error)
|
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_lookup_int(bp, args);
|
2014-06-25 04:58:08 +00:00
|
|
|
if (error == -ENOATTR) {
|
2012-06-22 08:50:14 +00:00
|
|
|
xfs_trans_brelse(args->trans, bp);
|
2013-04-24 08:58:55 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2013-04-24 08:58:55 +00:00
|
|
|
xfs_attr3_leaf_remove(bp, args);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the result is small enough, shrink it all into the inode.
|
|
|
|
*/
|
2005-11-01 23:34:53 +00:00
|
|
|
if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
|
2005-04-16 22:20:36 +00:00
|
|
|
/* bp is gone due to xfs_da_shrink_inode */
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-09-29 03:41:58 +00:00
|
|
|
return error;
|
2018-07-24 20:43:15 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-08-01 14:20:33 +00:00
|
|
|
return error;
|
2012-06-22 08:50:14 +00:00
|
|
|
}
|
2013-04-24 08:58:55 +00:00
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Look up a name in a leaf attribute list structure.
|
|
|
|
*
|
|
|
|
* This leaf block cannot have a "remote" value, we only call this routine
|
|
|
|
* if bmap_one_block() says there is only one block (ie: no remote blks).
|
2019-08-29 16:04:08 +00:00
|
|
|
*
|
|
|
|
* Returns 0 on successful retrieval, otherwise an error.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2005-06-21 05:36:52 +00:00
|
|
|
STATIC int
|
2005-04-16 22:20:36 +00:00
|
|
|
xfs_attr_leaf_get(xfs_da_args_t *args)
|
|
|
|
{
|
2012-06-22 08:50:14 +00:00
|
|
|
struct xfs_buf *bp;
|
2005-04-16 22:20:36 +00:00
|
|
|
int error;
|
|
|
|
|
2012-11-12 11:53:53 +00:00
|
|
|
trace_xfs_attr_leaf_get(args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
args->blkno = 0;
|
2019-11-20 17:46:02 +00:00
|
|
|
error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
2012-11-12 11:54:16 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_lookup_int(bp, args);
|
2014-06-25 04:58:08 +00:00
|
|
|
if (error != -EEXIST) {
|
2012-06-22 08:50:14 +00:00
|
|
|
xfs_trans_brelse(args->trans, bp);
|
2013-04-24 08:58:55 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_getvalue(bp, args);
|
2012-06-22 08:50:14 +00:00
|
|
|
xfs_trans_brelse(args->trans, bp);
|
2019-08-29 16:04:09 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*========================================================================
|
2014-06-06 05:21:45 +00:00
|
|
|
* External routines when attribute list size > geo->blksize
|
2005-04-16 22:20:36 +00:00
|
|
|
*========================================================================*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Add a name to a Btree-format attribute list.
|
|
|
|
*
|
|
|
|
* This will involve walking down the Btree, and may involve splitting
|
|
|
|
* leaf nodes and even splitting intermediate nodes up to and including
|
|
|
|
* the root node (a special case of an intermediate node).
|
|
|
|
*
|
|
|
|
* "Remote" attribute values confuse the issue and atomic rename operations
|
|
|
|
* add a whole extra layer of confusion on top of that.
|
|
|
|
*/
|
|
|
|
STATIC int
|
2018-07-12 05:26:11 +00:00
|
|
|
xfs_attr_node_addname(
|
|
|
|
struct xfs_da_args *args)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2018-07-12 05:26:11 +00:00
|
|
|
struct xfs_da_state *state;
|
|
|
|
struct xfs_da_state_blk *blk;
|
|
|
|
struct xfs_inode *dp;
|
|
|
|
struct xfs_mount *mp;
|
|
|
|
int retval, error;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-03-22 05:15:13 +00:00
|
|
|
trace_xfs_attr_node_addname(args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Fill in bucket of arguments/results/context to carry around.
|
|
|
|
*/
|
|
|
|
dp = args->dp;
|
|
|
|
mp = dp->i_mount;
|
|
|
|
restart:
|
|
|
|
state = xfs_da_state_alloc();
|
|
|
|
state->args = args;
|
|
|
|
state->mp = mp;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Search to see if name already exists, and get back a pointer
|
|
|
|
* to where it should go.
|
|
|
|
*/
|
2013-04-24 08:58:02 +00:00
|
|
|
error = xfs_da3_node_lookup_int(state, &retval);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
blk = &state->path.blk[ state->path.active-1 ];
|
|
|
|
ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
|
2020-02-27 01:30:42 +00:00
|
|
|
if (retval == -ENOATTR && (args->attr_flags & XATTR_REPLACE))
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
2020-02-27 01:30:42 +00:00
|
|
|
if (retval == -EEXIST) {
|
2020-02-27 01:30:42 +00:00
|
|
|
if (args->attr_flags & XATTR_CREATE)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
2012-03-22 05:15:13 +00:00
|
|
|
|
|
|
|
trace_xfs_attr_node_replace(args);
|
|
|
|
|
xfs: remote attribute overwrite causes transaction overrun
Commit e461fcb ("xfs: remote attribute lookups require the value
length") passes the remote attribute length in the xfs_da_args
structure on lookup so that CRC calculations and validity checking
can be performed correctly by related code. This, unfortunately has
the side effect of changing the args->valuelen parameter in cases
where it shouldn't.
That is, when we replace a remote attribute, the incoming
replacement stores the value and length in args->value and
args->valuelen, but then the lookup which finds the existing remote
attribute overwrites args->valuelen with the length of the remote
attribute being replaced. Hence when we go to create the new
attribute, we create it of the size of the existing remote
attribute, not the size it is supposed to be. When the new attribute
is much smaller than the old attribute, this results in a
transaction overrun and an ASSERT() failure on a debug kernel:
XFS: Assertion failed: tp->t_blk_res_used <= tp->t_blk_res, file: fs/xfs/xfs_trans.c, line: 331
Fix this by keeping the remote attribute value length separate to
the attribute value length in the xfs_da_args structure. The enables
us to pass the length of the remote attribute to be removed without
overwriting the new attribute's length.
Also, ensure that when we save remote block contexts for a later
rename we zero the original state variables so that we don't confuse
the state of the attribute to be removes with the state of the new
attribute that we just added. [Spotted by Brain Foster.]
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 21:37:31 +00:00
|
|
|
/* save the attribute state for later removal*/
|
2008-05-21 06:42:05 +00:00
|
|
|
args->op_flags |= XFS_DA_OP_RENAME; /* atomic rename op */
|
2005-04-16 22:20:36 +00:00
|
|
|
args->blkno2 = args->blkno; /* set 2nd entry info*/
|
|
|
|
args->index2 = args->index;
|
|
|
|
args->rmtblkno2 = args->rmtblkno;
|
|
|
|
args->rmtblkcnt2 = args->rmtblkcnt;
|
xfs: remote attribute overwrite causes transaction overrun
Commit e461fcb ("xfs: remote attribute lookups require the value
length") passes the remote attribute length in the xfs_da_args
structure on lookup so that CRC calculations and validity checking
can be performed correctly by related code. This, unfortunately has
the side effect of changing the args->valuelen parameter in cases
where it shouldn't.
That is, when we replace a remote attribute, the incoming
replacement stores the value and length in args->value and
args->valuelen, but then the lookup which finds the existing remote
attribute overwrites args->valuelen with the length of the remote
attribute being replaced. Hence when we go to create the new
attribute, we create it of the size of the existing remote
attribute, not the size it is supposed to be. When the new attribute
is much smaller than the old attribute, this results in a
transaction overrun and an ASSERT() failure on a debug kernel:
XFS: Assertion failed: tp->t_blk_res_used <= tp->t_blk_res, file: fs/xfs/xfs_trans.c, line: 331
Fix this by keeping the remote attribute value length separate to
the attribute value length in the xfs_da_args structure. The enables
us to pass the length of the remote attribute to be removed without
overwriting the new attribute's length.
Also, ensure that when we save remote block contexts for a later
rename we zero the original state variables so that we don't confuse
the state of the attribute to be removes with the state of the new
attribute that we just added. [Spotted by Brain Foster.]
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 21:37:31 +00:00
|
|
|
args->rmtvaluelen2 = args->rmtvaluelen;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* clear the remote attr state now that it is saved so that the
|
|
|
|
* values reflect the state of the attribute we are about to
|
|
|
|
* add, not the attribute we just found and will remove later.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
args->rmtblkno = 0;
|
|
|
|
args->rmtblkcnt = 0;
|
xfs: remote attribute overwrite causes transaction overrun
Commit e461fcb ("xfs: remote attribute lookups require the value
length") passes the remote attribute length in the xfs_da_args
structure on lookup so that CRC calculations and validity checking
can be performed correctly by related code. This, unfortunately has
the side effect of changing the args->valuelen parameter in cases
where it shouldn't.
That is, when we replace a remote attribute, the incoming
replacement stores the value and length in args->value and
args->valuelen, but then the lookup which finds the existing remote
attribute overwrites args->valuelen with the length of the remote
attribute being replaced. Hence when we go to create the new
attribute, we create it of the size of the existing remote
attribute, not the size it is supposed to be. When the new attribute
is much smaller than the old attribute, this results in a
transaction overrun and an ASSERT() failure on a debug kernel:
XFS: Assertion failed: tp->t_blk_res_used <= tp->t_blk_res, file: fs/xfs/xfs_trans.c, line: 331
Fix this by keeping the remote attribute value length separate to
the attribute value length in the xfs_da_args structure. The enables
us to pass the length of the remote attribute to be removed without
overwriting the new attribute's length.
Also, ensure that when we save remote block contexts for a later
rename we zero the original state variables so that we don't confuse
the state of the attribute to be removes with the state of the new
attribute that we just added. [Spotted by Brain Foster.]
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 21:37:31 +00:00
|
|
|
args->rmtvaluelen = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2013-04-24 08:58:55 +00:00
|
|
|
retval = xfs_attr3_leaf_add(blk->bp, state->args);
|
2014-06-25 04:58:08 +00:00
|
|
|
if (retval == -ENOSPC) {
|
2005-04-16 22:20:36 +00:00
|
|
|
if (state->path.active == 1) {
|
|
|
|
/*
|
|
|
|
* Its really a single leaf node, but it had
|
|
|
|
* out-of-line values so it looked like it *might*
|
|
|
|
* have been a b-tree.
|
|
|
|
*/
|
|
|
|
xfs_da_state_free(state);
|
2013-08-01 01:18:54 +00:00
|
|
|
state = NULL;
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_to_node(args);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-09-29 03:41:58 +00:00
|
|
|
goto out;
|
2018-07-24 20:43:15 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-08-01 14:20:33 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Commit the node conversion and start the next
|
|
|
|
* trans in the chain.
|
|
|
|
*/
|
2017-08-28 17:21:03 +00:00
|
|
|
error = xfs_trans_roll_inode(&args->trans, dp);
|
2008-08-13 06:05:49 +00:00
|
|
|
if (error)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
goto restart;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Split as many Btree elements as required.
|
|
|
|
* This code tracks the new and old attr's location
|
|
|
|
* in the index/blkno/rmtblkno/rmtblkcnt fields and
|
|
|
|
* in the index2/blkno2/rmtblkno2/rmtblkcnt2 fields.
|
|
|
|
*/
|
2013-04-24 08:58:02 +00:00
|
|
|
error = xfs_da3_split(state);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-09-29 03:41:58 +00:00
|
|
|
goto out;
|
2018-07-24 20:43:15 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-08-01 14:20:33 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* Addition succeeded, update Btree hashvals.
|
|
|
|
*/
|
2013-04-24 08:58:02 +00:00
|
|
|
xfs_da3_fixhashpath(state, &state->path);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Kill the state structure, we're done with it and need to
|
|
|
|
* allow the buffers to come back later.
|
|
|
|
*/
|
|
|
|
xfs_da_state_free(state);
|
|
|
|
state = NULL;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Commit the leaf addition or btree split and start the next
|
|
|
|
* trans in the chain.
|
|
|
|
*/
|
2017-08-28 17:21:03 +00:00
|
|
|
error = xfs_trans_roll_inode(&args->trans, dp);
|
2008-08-13 06:05:49 +00:00
|
|
|
if (error)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If there was an out-of-line value, allocate the blocks we
|
|
|
|
* identified for its storage and copy the value. This is done
|
|
|
|
* after we create the attribute so that we don't overflow the
|
|
|
|
* maximum size of a transaction and/or hit a deadlock.
|
|
|
|
*/
|
|
|
|
if (args->rmtblkno > 0) {
|
|
|
|
error = xfs_attr_rmtval_set(args);
|
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If this is an atomic rename operation, we must "flip" the
|
|
|
|
* incomplete flags on the "new" and "old" attribute/value pairs
|
|
|
|
* so that one disappears and one appears atomically. Then we
|
|
|
|
* must remove the "old" attribute/value pair.
|
|
|
|
*/
|
2008-05-21 06:42:05 +00:00
|
|
|
if (args->op_flags & XFS_DA_OP_RENAME) {
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* In a separate transaction, set the incomplete flag on the
|
|
|
|
* "old" attr and clear the incomplete flag on the "new" attr.
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_flipflags(args);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Dismantle the "old" attribute/value pair by removing
|
|
|
|
* a "remote" value (if it exists).
|
|
|
|
*/
|
|
|
|
args->index = args->index2;
|
|
|
|
args->blkno = args->blkno2;
|
|
|
|
args->rmtblkno = args->rmtblkno2;
|
|
|
|
args->rmtblkcnt = args->rmtblkcnt2;
|
xfs: remote attribute overwrite causes transaction overrun
Commit e461fcb ("xfs: remote attribute lookups require the value
length") passes the remote attribute length in the xfs_da_args
structure on lookup so that CRC calculations and validity checking
can be performed correctly by related code. This, unfortunately has
the side effect of changing the args->valuelen parameter in cases
where it shouldn't.
That is, when we replace a remote attribute, the incoming
replacement stores the value and length in args->value and
args->valuelen, but then the lookup which finds the existing remote
attribute overwrites args->valuelen with the length of the remote
attribute being replaced. Hence when we go to create the new
attribute, we create it of the size of the existing remote
attribute, not the size it is supposed to be. When the new attribute
is much smaller than the old attribute, this results in a
transaction overrun and an ASSERT() failure on a debug kernel:
XFS: Assertion failed: tp->t_blk_res_used <= tp->t_blk_res, file: fs/xfs/xfs_trans.c, line: 331
Fix this by keeping the remote attribute value length separate to
the attribute value length in the xfs_da_args structure. The enables
us to pass the length of the remote attribute to be removed without
overwriting the new attribute's length.
Also, ensure that when we save remote block contexts for a later
rename we zero the original state variables so that we don't confuse
the state of the attribute to be removes with the state of the new
attribute that we just added. [Spotted by Brain Foster.]
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2014-05-05 21:37:31 +00:00
|
|
|
args->rmtvaluelen = args->rmtvaluelen2;
|
2005-04-16 22:20:36 +00:00
|
|
|
if (args->rmtblkno) {
|
|
|
|
error = xfs_attr_rmtval_remove(args);
|
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Re-find the "old" attribute entry after any split ops.
|
|
|
|
* The INCOMPLETE flag means that we will find the "old"
|
|
|
|
* attr, not the "new" one.
|
|
|
|
*/
|
2020-02-27 01:30:43 +00:00
|
|
|
args->attr_filter |= XFS_ATTR_INCOMPLETE;
|
2005-04-16 22:20:36 +00:00
|
|
|
state = xfs_da_state_alloc();
|
|
|
|
state->args = args;
|
|
|
|
state->mp = mp;
|
|
|
|
state->inleaf = 0;
|
2013-04-24 08:58:02 +00:00
|
|
|
error = xfs_da3_node_lookup_int(state, &retval);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Remove the name and update the hashvals in the tree.
|
|
|
|
*/
|
|
|
|
blk = &state->path.blk[ state->path.active-1 ];
|
|
|
|
ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_remove(blk->bp, args);
|
2013-04-24 08:58:02 +00:00
|
|
|
xfs_da3_fixhashpath(state, &state->path);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Check to see if the tree needs to be collapsed.
|
|
|
|
*/
|
|
|
|
if (retval && (state->path.active > 1)) {
|
2013-04-24 08:58:02 +00:00
|
|
|
error = xfs_da3_join(state);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-09-29 03:41:58 +00:00
|
|
|
goto out;
|
2018-07-24 20:43:15 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-08-01 14:20:33 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Commit and start the next trans in the chain.
|
|
|
|
*/
|
2017-08-28 17:21:03 +00:00
|
|
|
error = xfs_trans_roll_inode(&args->trans, dp);
|
2008-08-13 06:05:49 +00:00
|
|
|
if (error)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
} else if (args->rmtblkno > 0) {
|
|
|
|
/*
|
|
|
|
* Added a "remote" value, just clear the incomplete flag.
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_clearflag(args);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
retval = error = 0;
|
|
|
|
|
|
|
|
out:
|
|
|
|
if (state)
|
|
|
|
xfs_da_state_free(state);
|
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
|
|
|
return retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Remove a name from a B-tree attribute list.
|
|
|
|
*
|
|
|
|
* This will involve walking down the Btree, and may involve joining
|
|
|
|
* leaf nodes and even joining intermediate nodes up to and including
|
|
|
|
* the root node (a special case of an intermediate node).
|
|
|
|
*/
|
|
|
|
STATIC int
|
2018-07-12 05:26:11 +00:00
|
|
|
xfs_attr_node_removename(
|
|
|
|
struct xfs_da_args *args)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2018-07-12 05:26:11 +00:00
|
|
|
struct xfs_da_state *state;
|
|
|
|
struct xfs_da_state_blk *blk;
|
|
|
|
struct xfs_inode *dp;
|
|
|
|
struct xfs_buf *bp;
|
|
|
|
int retval, error, forkoff;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-03-22 05:15:13 +00:00
|
|
|
trace_xfs_attr_node_removename(args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Tie a string around our finger to remind us where we are.
|
|
|
|
*/
|
|
|
|
dp = args->dp;
|
|
|
|
state = xfs_da_state_alloc();
|
|
|
|
state->args = args;
|
|
|
|
state->mp = dp->i_mount;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Search to see if name exists, and get back a pointer to it.
|
|
|
|
*/
|
2013-04-24 08:58:02 +00:00
|
|
|
error = xfs_da3_node_lookup_int(state, &retval);
|
2014-06-25 04:58:08 +00:00
|
|
|
if (error || (retval != -EEXIST)) {
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error == 0)
|
|
|
|
error = retval;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If there is an out-of-line value, de-allocate the blocks.
|
|
|
|
* This is done before we remove the attribute so that we don't
|
|
|
|
* overflow the maximum size of a transaction and/or hit a deadlock.
|
|
|
|
*/
|
|
|
|
blk = &state->path.blk[ state->path.active-1 ];
|
|
|
|
ASSERT(blk->bp != NULL);
|
|
|
|
ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
|
|
|
|
if (args->rmtblkno > 0) {
|
|
|
|
/*
|
|
|
|
* Fill in disk block numbers in the state structure
|
|
|
|
* so that we can get the buffers back after we commit
|
|
|
|
* several transactions in the following calls.
|
|
|
|
*/
|
|
|
|
error = xfs_attr_fillstate(state);
|
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Mark the attribute as INCOMPLETE, then bunmapi() the
|
|
|
|
* remote value.
|
|
|
|
*/
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_setflag(args);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
error = xfs_attr_rmtval_remove(args);
|
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Refill the state structure with buffers, the prior calls
|
|
|
|
* released our buffers.
|
|
|
|
*/
|
|
|
|
error = xfs_attr_refillstate(state);
|
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Remove the name and update the hashvals in the tree.
|
|
|
|
*/
|
|
|
|
blk = &state->path.blk[ state->path.active-1 ];
|
|
|
|
ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
|
2013-04-24 08:58:55 +00:00
|
|
|
retval = xfs_attr3_leaf_remove(blk->bp, args);
|
2013-04-24 08:58:02 +00:00
|
|
|
xfs_da3_fixhashpath(state, &state->path);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Check to see if the tree needs to be collapsed.
|
|
|
|
*/
|
|
|
|
if (retval && (state->path.active > 1)) {
|
2013-04-24 08:58:02 +00:00
|
|
|
error = xfs_da3_join(state);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-09-29 03:41:58 +00:00
|
|
|
goto out;
|
2018-07-24 20:43:15 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-08-01 14:20:33 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Commit the Btree join operation and start a new trans.
|
|
|
|
*/
|
2017-08-28 17:21:03 +00:00
|
|
|
error = xfs_trans_roll_inode(&args->trans, dp);
|
2008-08-13 06:05:49 +00:00
|
|
|
if (error)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the result is small enough, push it all into the inode.
|
|
|
|
*/
|
|
|
|
if (xfs_bmap_one_block(dp, XFS_ATTR_FORK)) {
|
|
|
|
/*
|
|
|
|
* Have to get rid of the copy of this dabuf in the state.
|
|
|
|
*/
|
|
|
|
ASSERT(state->path.active == 1);
|
|
|
|
ASSERT(state->path.blk[0].bp);
|
|
|
|
state->path.blk[0].bp = NULL;
|
|
|
|
|
2019-11-20 17:46:02 +00:00
|
|
|
error = xfs_attr3_leaf_read(args->trans, args->dp, 0, &bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
|
|
|
goto out;
|
|
|
|
|
2005-11-01 23:34:53 +00:00
|
|
|
if ((forkoff = xfs_attr_shortform_allfit(bp, dp))) {
|
2013-04-24 08:58:55 +00:00
|
|
|
error = xfs_attr3_leaf_to_shortform(bp, args, forkoff);
|
2005-04-16 22:20:36 +00:00
|
|
|
/* bp is gone due to xfs_da_shrink_inode */
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-09-29 03:41:58 +00:00
|
|
|
goto out;
|
2018-07-24 20:43:15 +00:00
|
|
|
error = xfs_defer_finish(&args->trans);
|
2017-08-28 17:21:04 +00:00
|
|
|
if (error)
|
2018-08-01 14:20:33 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
} else
|
2012-06-22 08:50:14 +00:00
|
|
|
xfs_trans_brelse(args->trans, bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
error = 0;
|
|
|
|
|
|
|
|
out:
|
|
|
|
xfs_da_state_free(state);
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Fill in the disk block numbers in the state structure for the buffers
|
|
|
|
* that are attached to the state structure.
|
|
|
|
* This is done so that we can quickly reattach ourselves to those buffers
|
2006-03-28 22:55:14 +00:00
|
|
|
* after some set of transaction commits have released these buffers.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_attr_fillstate(xfs_da_state_t *state)
|
|
|
|
{
|
|
|
|
xfs_da_state_path_t *path;
|
|
|
|
xfs_da_state_blk_t *blk;
|
|
|
|
int level;
|
|
|
|
|
2012-11-12 11:53:53 +00:00
|
|
|
trace_xfs_attr_fillstate(state->args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Roll down the "path" in the state structure, storing the on-disk
|
|
|
|
* block number for those buffers in the "path".
|
|
|
|
*/
|
|
|
|
path = &state->path;
|
|
|
|
ASSERT((path->active >= 0) && (path->active < XFS_DA_NODE_MAXDEPTH));
|
|
|
|
for (blk = path->blk, level = 0; level < path->active; blk++, level++) {
|
|
|
|
if (blk->bp) {
|
2012-06-22 08:50:14 +00:00
|
|
|
blk->disk_blkno = XFS_BUF_ADDR(blk->bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
blk->bp = NULL;
|
|
|
|
} else {
|
|
|
|
blk->disk_blkno = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Roll down the "altpath" in the state structure, storing the on-disk
|
|
|
|
* block number for those buffers in the "altpath".
|
|
|
|
*/
|
|
|
|
path = &state->altpath;
|
|
|
|
ASSERT((path->active >= 0) && (path->active < XFS_DA_NODE_MAXDEPTH));
|
|
|
|
for (blk = path->blk, level = 0; level < path->active; blk++, level++) {
|
|
|
|
if (blk->bp) {
|
2012-06-22 08:50:14 +00:00
|
|
|
blk->disk_blkno = XFS_BUF_ADDR(blk->bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
blk->bp = NULL;
|
|
|
|
} else {
|
|
|
|
blk->disk_blkno = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-22 05:03:54 +00:00
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Reattach the buffers to the state structure based on the disk block
|
|
|
|
* numbers stored in the state structure.
|
2006-03-28 22:55:14 +00:00
|
|
|
* This is done after some set of transaction commits have released those
|
2005-04-16 22:20:36 +00:00
|
|
|
* buffers from our grip.
|
|
|
|
*/
|
|
|
|
STATIC int
|
|
|
|
xfs_attr_refillstate(xfs_da_state_t *state)
|
|
|
|
{
|
|
|
|
xfs_da_state_path_t *path;
|
|
|
|
xfs_da_state_blk_t *blk;
|
|
|
|
int level, error;
|
|
|
|
|
2012-11-12 11:53:53 +00:00
|
|
|
trace_xfs_attr_refillstate(state->args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Roll down the "path" in the state structure, storing the on-disk
|
|
|
|
* block number for those buffers in the "path".
|
|
|
|
*/
|
|
|
|
path = &state->path;
|
|
|
|
ASSERT((path->active >= 0) && (path->active < XFS_DA_NODE_MAXDEPTH));
|
|
|
|
for (blk = path->blk, level = 0; level < path->active; blk++, level++) {
|
|
|
|
if (blk->disk_blkno) {
|
2019-11-20 17:46:04 +00:00
|
|
|
error = xfs_da3_node_read_mapped(state->args->trans,
|
|
|
|
state->args->dp, blk->disk_blkno,
|
|
|
|
&blk->bp, XFS_ATTR_FORK);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
} else {
|
|
|
|
blk->bp = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Roll down the "altpath" in the state structure, storing the on-disk
|
|
|
|
* block number for those buffers in the "altpath".
|
|
|
|
*/
|
|
|
|
path = &state->altpath;
|
|
|
|
ASSERT((path->active >= 0) && (path->active < XFS_DA_NODE_MAXDEPTH));
|
|
|
|
for (blk = path->blk, level = 0; level < path->active; blk++, level++) {
|
|
|
|
if (blk->disk_blkno) {
|
2019-11-20 17:46:04 +00:00
|
|
|
error = xfs_da3_node_read_mapped(state->args->trans,
|
|
|
|
state->args->dp, blk->disk_blkno,
|
|
|
|
&blk->bp, XFS_ATTR_FORK);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error)
|
2014-06-22 05:03:54 +00:00
|
|
|
return error;
|
2005-04-16 22:20:36 +00:00
|
|
|
} else {
|
|
|
|
blk->bp = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-22 05:03:54 +00:00
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2019-08-29 16:04:08 +00:00
|
|
|
* Retrieve the attribute data from a node attribute list.
|
2005-04-16 22:20:36 +00:00
|
|
|
*
|
|
|
|
* This routine gets called for any attribute fork that has more than one
|
|
|
|
* block, ie: both true Btree attr lists and for single-leaf-blocks with
|
|
|
|
* "remote" values taking up more blocks.
|
2019-08-29 16:04:08 +00:00
|
|
|
*
|
|
|
|
* Returns 0 on successful retrieval, otherwise an error.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2005-06-21 05:36:52 +00:00
|
|
|
STATIC int
|
2005-04-16 22:20:36 +00:00
|
|
|
xfs_attr_node_get(xfs_da_args_t *args)
|
|
|
|
{
|
|
|
|
xfs_da_state_t *state;
|
|
|
|
xfs_da_state_blk_t *blk;
|
|
|
|
int error, retval;
|
|
|
|
int i;
|
|
|
|
|
2012-11-12 11:53:53 +00:00
|
|
|
trace_xfs_attr_node_get(args);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
state = xfs_da_state_alloc();
|
|
|
|
state->args = args;
|
|
|
|
state->mp = args->dp->i_mount;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Search to see if name exists, and get back a pointer to it.
|
|
|
|
*/
|
2013-04-24 08:58:02 +00:00
|
|
|
error = xfs_da3_node_lookup_int(state, &retval);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (error) {
|
|
|
|
retval = error;
|
2019-08-29 16:04:08 +00:00
|
|
|
goto out_release;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2019-08-29 16:04:08 +00:00
|
|
|
if (retval != -EEXIST)
|
|
|
|
goto out_release;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Get the value, local or "remote"
|
|
|
|
*/
|
|
|
|
blk = &state->path.blk[state->path.active - 1];
|
|
|
|
retval = xfs_attr3_leaf_getvalue(blk->bp, args);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If not in a transaction, we have to release all the buffers.
|
|
|
|
*/
|
2019-08-29 16:04:08 +00:00
|
|
|
out_release:
|
2005-04-16 22:20:36 +00:00
|
|
|
for (i = 0; i < state->path.active; i++) {
|
2012-06-22 08:50:14 +00:00
|
|
|
xfs_trans_brelse(args->trans, state->path.blk[i].bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
state->path.blk[i].bp = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
xfs_da_state_free(state);
|
2014-06-22 05:03:54 +00:00
|
|
|
return retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2019-02-01 17:08:54 +00:00
|
|
|
|
|
|
|
/* Returns true if the attribute entry name is valid. */
|
|
|
|
bool
|
|
|
|
xfs_attr_namecheck(
|
|
|
|
const void *name,
|
|
|
|
size_t length)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* MAXNAMELEN includes the trailing null, but (name/length) leave it
|
|
|
|
* out, so use >= for the length check.
|
|
|
|
*/
|
|
|
|
if (length >= MAXNAMELEN)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* There shouldn't be any nulls here */
|
|
|
|
return !memchr(name, 0, length);
|
|
|
|
}
|