2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* device driver for Conexant 2388x based TV cards
|
|
|
|
* MPEG Transport Stream (DVB) routines
|
|
|
|
*
|
2006-01-09 17:25:35 +00:00
|
|
|
* (c) 2004, 2005 Chris Pascoe <c.pascoe@itee.uq.edu.au>
|
2005-04-16 22:20:36 +00:00
|
|
|
* (c) 2004 Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*/
|
|
|
|
|
2016-11-13 12:07:38 +00:00
|
|
|
#include "cx88.h"
|
|
|
|
#include "dvb-pll.h"
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/kthread.h>
|
|
|
|
#include <linux/file.h>
|
|
|
|
#include <linux/suspend.h>
|
|
|
|
|
2006-01-09 17:32:31 +00:00
|
|
|
#include <media/v4l2-common.h>
|
2005-07-12 20:58:44 +00:00
|
|
|
|
2006-08-08 12:10:09 +00:00
|
|
|
#include "mt352.h"
|
|
|
|
#include "mt352_priv.h"
|
2007-05-05 23:11:32 +00:00
|
|
|
#include "cx88-vp3054-i2c.h"
|
2006-08-08 12:10:09 +00:00
|
|
|
#include "zl10353.h"
|
|
|
|
#include "cx22702.h"
|
|
|
|
#include "or51132.h"
|
|
|
|
#include "lgdt330x.h"
|
2008-01-05 19:53:01 +00:00
|
|
|
#include "s5h1409.h"
|
2011-06-07 16:12:29 +00:00
|
|
|
#include "xc4000.h"
|
2008-01-05 19:53:01 +00:00
|
|
|
#include "xc5000.h"
|
2006-08-08 12:10:09 +00:00
|
|
|
#include "nxt200x.h"
|
|
|
|
#include "cx24123.h"
|
2006-05-12 23:31:51 +00:00
|
|
|
#include "isl6421.h"
|
2008-04-22 17:46:13 +00:00
|
|
|
#include "tuner-simple.h"
|
2008-04-22 17:46:16 +00:00
|
|
|
#include "tda9887.h"
|
2008-04-25 06:46:43 +00:00
|
|
|
#include "s5h1411.h"
|
2008-09-23 18:43:57 +00:00
|
|
|
#include "stv0299.h"
|
|
|
|
#include "z0194a.h"
|
|
|
|
#include "stv0288.h"
|
|
|
|
#include "stb6000.h"
|
2008-09-04 04:17:33 +00:00
|
|
|
#include "cx24116.h"
|
2009-11-17 01:22:32 +00:00
|
|
|
#include "stv0900.h"
|
|
|
|
#include "stb6100.h"
|
|
|
|
#include "stb6100_proc.h"
|
2010-08-09 13:18:32 +00:00
|
|
|
#include "mb86a16.h"
|
2012-12-23 22:25:38 +00:00
|
|
|
#include "ts2020.h"
|
2011-02-25 21:41:24 +00:00
|
|
|
#include "ds3000.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
MODULE_DESCRIPTION("driver for cx2388x based DVB cards");
|
|
|
|
MODULE_AUTHOR("Chris Pascoe <c.pascoe@itee.uq.edu.au>");
|
|
|
|
MODULE_AUTHOR("Gerd Knorr <kraxel@bytesex.org> [SuSE Labs]");
|
|
|
|
MODULE_LICENSE("GPL");
|
[media] Stop using linux/version.h on most video drivers
All the modified drivers didn't have any version increment since
Jan, 1 2011. Several of them didn't have any version increment
for a long time, even having new features and important bug fixes
happening.
As we're now filling the QUERYCAP version with the current Kernel
Release, we don't need to maintain a per-driver version control
anymore. So, let's just use the default.
In order to preserve the Kernel module version history, a
KERNEL_VERSION() macro were added to all modified drivers, and
the extraver number were incremented.
I opted to preserve the per-driver version control to a few
pwc, pvrusb2, s2255, s5p-fimc and sh_vou.
A few drivers are still using the legacy way to handle ioctl's.
So, we can't do such change on them, otherwise, they'll break.
Those are: uvc, et61x251 and sn9c102.
The rationale is that the per-driver version control seems to be
actively maintained on those.
Yet, I think that the better for them would be to just use the
default version numbering, instead of doing that by themselves.
While here, removed a few uneeded include linux/version.h
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2011-06-24 17:45:49 +00:00
|
|
|
MODULE_VERSION(CX88_VERSION);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-22 17:41:48 +00:00
|
|
|
static unsigned int debug;
|
2005-04-16 22:20:36 +00:00
|
|
|
module_param(debug, int, 0644);
|
2016-11-16 08:59:49 +00:00
|
|
|
MODULE_PARM_DESC(debug, "enable debug messages [dvb]");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-12-24 05:40:46 +00:00
|
|
|
static unsigned int dvb_buf_tscnt = 32;
|
|
|
|
module_param(dvb_buf_tscnt, int, 0644);
|
|
|
|
MODULE_PARM_DESC(dvb_buf_tscnt, "DVB Buffer TS count [dvb]");
|
|
|
|
|
2008-04-09 22:13:13 +00:00
|
|
|
DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
|
|
|
|
|
2016-11-13 12:07:38 +00:00
|
|
|
#define dprintk(level, fmt, arg...) do { \
|
|
|
|
if (debug >= level) \
|
|
|
|
printk(KERN_DEBUG pr_fmt("%s: dvb:" fmt), \
|
|
|
|
__func__, ##arg); \
|
|
|
|
} while (0)
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* ------------------------------------------------------------------ */
|
|
|
|
|
2015-10-28 02:50:37 +00:00
|
|
|
static int queue_setup(struct vb2_queue *q,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
unsigned int *num_buffers, unsigned int *num_planes,
|
|
|
|
unsigned int sizes[], struct device *alloc_devs[])
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-20 12:22:18 +00:00
|
|
|
struct cx8802_dev *dev = q->drv_priv;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2014-09-20 12:22:18 +00:00
|
|
|
*num_planes = 1;
|
2005-04-16 22:20:36 +00:00
|
|
|
dev->ts_packet_size = 188 * 4;
|
2010-12-24 05:40:46 +00:00
|
|
|
dev->ts_packet_count = dvb_buf_tscnt;
|
2014-09-20 12:22:18 +00:00
|
|
|
sizes[0] = dev->ts_packet_size * dev->ts_packet_count;
|
|
|
|
*num_buffers = dvb_buf_tscnt;
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-09-20 12:22:18 +00:00
|
|
|
static int buffer_prepare(struct vb2_buffer *vb)
|
|
|
|
{
|
[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer.
Add new member variables - bytesused, length, offset, userptr, fd,
data_offset - to struct vb2_plane in order to cover all information
of v4l2_plane.
struct vb2_plane {
<snip>
unsigned int bytesused;
unsigned int length;
union {
unsigned int offset;
unsigned long userptr;
int fd;
} m;
unsigned int data_offset;
}
Replace v4l2_buf with new member variables - index, type, memory - which
are common fields for buffer management.
struct vb2_buffer {
<snip>
unsigned int index;
unsigned int type;
unsigned int memory;
unsigned int num_planes;
struct vb2_plane planes[VIDEO_MAX_PLANES];
<snip>
};
v4l2 specific fields - flags, field, timestamp, timecode,
sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c
struct vb2_v4l2_buffer {
struct vb2_buffer vb2_buf;
__u32 flags;
__u32 field;
struct timeval timestamp;
struct v4l2_timecode timecode;
__u32 sequence;
};
Signed-off-by: Junghak Sung <jh1009.sung@samsung.com>
Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2015-09-22 13:30:30 +00:00
|
|
|
struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
|
2014-09-20 12:22:18 +00:00
|
|
|
struct cx8802_dev *dev = vb->vb2_queue->drv_priv;
|
[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer.
Add new member variables - bytesused, length, offset, userptr, fd,
data_offset - to struct vb2_plane in order to cover all information
of v4l2_plane.
struct vb2_plane {
<snip>
unsigned int bytesused;
unsigned int length;
union {
unsigned int offset;
unsigned long userptr;
int fd;
} m;
unsigned int data_offset;
}
Replace v4l2_buf with new member variables - index, type, memory - which
are common fields for buffer management.
struct vb2_buffer {
<snip>
unsigned int index;
unsigned int type;
unsigned int memory;
unsigned int num_planes;
struct vb2_plane planes[VIDEO_MAX_PLANES];
<snip>
};
v4l2 specific fields - flags, field, timestamp, timecode,
sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c
struct vb2_v4l2_buffer {
struct vb2_buffer vb2_buf;
__u32 flags;
__u32 field;
struct timeval timestamp;
struct v4l2_timecode timecode;
__u32 sequence;
};
Signed-off-by: Junghak Sung <jh1009.sung@samsung.com>
Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2015-09-22 13:30:30 +00:00
|
|
|
struct cx88_buffer *buf = container_of(vbuf, struct cx88_buffer, vb);
|
2014-09-20 12:22:18 +00:00
|
|
|
|
2014-09-20 12:23:44 +00:00
|
|
|
return cx8802_buf_prepare(vb->vb2_queue, dev, buf);
|
2014-09-20 12:22:18 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void buffer_finish(struct vb2_buffer *vb)
|
|
|
|
{
|
[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer.
Add new member variables - bytesused, length, offset, userptr, fd,
data_offset - to struct vb2_plane in order to cover all information
of v4l2_plane.
struct vb2_plane {
<snip>
unsigned int bytesused;
unsigned int length;
union {
unsigned int offset;
unsigned long userptr;
int fd;
} m;
unsigned int data_offset;
}
Replace v4l2_buf with new member variables - index, type, memory - which
are common fields for buffer management.
struct vb2_buffer {
<snip>
unsigned int index;
unsigned int type;
unsigned int memory;
unsigned int num_planes;
struct vb2_plane planes[VIDEO_MAX_PLANES];
<snip>
};
v4l2 specific fields - flags, field, timestamp, timecode,
sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c
struct vb2_v4l2_buffer {
struct vb2_buffer vb2_buf;
__u32 flags;
__u32 field;
struct timeval timestamp;
struct v4l2_timecode timecode;
__u32 sequence;
};
Signed-off-by: Junghak Sung <jh1009.sung@samsung.com>
Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2015-09-22 13:30:30 +00:00
|
|
|
struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
|
2014-09-20 12:22:18 +00:00
|
|
|
struct cx8802_dev *dev = vb->vb2_queue->drv_priv;
|
[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer.
Add new member variables - bytesused, length, offset, userptr, fd,
data_offset - to struct vb2_plane in order to cover all information
of v4l2_plane.
struct vb2_plane {
<snip>
unsigned int bytesused;
unsigned int length;
union {
unsigned int offset;
unsigned long userptr;
int fd;
} m;
unsigned int data_offset;
}
Replace v4l2_buf with new member variables - index, type, memory - which
are common fields for buffer management.
struct vb2_buffer {
<snip>
unsigned int index;
unsigned int type;
unsigned int memory;
unsigned int num_planes;
struct vb2_plane planes[VIDEO_MAX_PLANES];
<snip>
};
v4l2 specific fields - flags, field, timestamp, timecode,
sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c
struct vb2_v4l2_buffer {
struct vb2_buffer vb2_buf;
__u32 flags;
__u32 field;
struct timeval timestamp;
struct v4l2_timecode timecode;
__u32 sequence;
};
Signed-off-by: Junghak Sung <jh1009.sung@samsung.com>
Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2015-09-22 13:30:30 +00:00
|
|
|
struct cx88_buffer *buf = container_of(vbuf, struct cx88_buffer, vb);
|
2014-08-29 07:11:54 +00:00
|
|
|
struct cx88_riscmem *risc = &buf->risc;
|
2014-09-20 12:22:18 +00:00
|
|
|
|
2014-08-29 07:11:54 +00:00
|
|
|
if (risc->cpu)
|
|
|
|
pci_free_consistent(dev->pci, risc->size, risc->cpu, risc->dma);
|
|
|
|
memset(risc, 0, sizeof(*risc));
|
2014-09-20 12:22:18 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void buffer_queue(struct vb2_buffer *vb)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer.
Add new member variables - bytesused, length, offset, userptr, fd,
data_offset - to struct vb2_plane in order to cover all information
of v4l2_plane.
struct vb2_plane {
<snip>
unsigned int bytesused;
unsigned int length;
union {
unsigned int offset;
unsigned long userptr;
int fd;
} m;
unsigned int data_offset;
}
Replace v4l2_buf with new member variables - index, type, memory - which
are common fields for buffer management.
struct vb2_buffer {
<snip>
unsigned int index;
unsigned int type;
unsigned int memory;
unsigned int num_planes;
struct vb2_plane planes[VIDEO_MAX_PLANES];
<snip>
};
v4l2 specific fields - flags, field, timestamp, timecode,
sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c
struct vb2_v4l2_buffer {
struct vb2_buffer vb2_buf;
__u32 flags;
__u32 field;
struct timeval timestamp;
struct v4l2_timecode timecode;
__u32 sequence;
};
Signed-off-by: Junghak Sung <jh1009.sung@samsung.com>
Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2015-09-22 13:30:30 +00:00
|
|
|
struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
|
2014-09-20 12:22:18 +00:00
|
|
|
struct cx8802_dev *dev = vb->vb2_queue->drv_priv;
|
[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer.
Add new member variables - bytesused, length, offset, userptr, fd,
data_offset - to struct vb2_plane in order to cover all information
of v4l2_plane.
struct vb2_plane {
<snip>
unsigned int bytesused;
unsigned int length;
union {
unsigned int offset;
unsigned long userptr;
int fd;
} m;
unsigned int data_offset;
}
Replace v4l2_buf with new member variables - index, type, memory - which
are common fields for buffer management.
struct vb2_buffer {
<snip>
unsigned int index;
unsigned int type;
unsigned int memory;
unsigned int num_planes;
struct vb2_plane planes[VIDEO_MAX_PLANES];
<snip>
};
v4l2 specific fields - flags, field, timestamp, timecode,
sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c
struct vb2_v4l2_buffer {
struct vb2_buffer vb2_buf;
__u32 flags;
__u32 field;
struct timeval timestamp;
struct v4l2_timecode timecode;
__u32 sequence;
};
Signed-off-by: Junghak Sung <jh1009.sung@samsung.com>
Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2015-09-22 13:30:30 +00:00
|
|
|
struct cx88_buffer *buf = container_of(vbuf, struct cx88_buffer, vb);
|
2014-09-20 12:22:18 +00:00
|
|
|
|
|
|
|
cx8802_buf_queue(dev, buf);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2014-09-20 12:22:18 +00:00
|
|
|
static int start_streaming(struct vb2_queue *q, unsigned int count)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-20 12:22:18 +00:00
|
|
|
struct cx8802_dev *dev = q->drv_priv;
|
|
|
|
struct cx88_dmaqueue *dmaq = &dev->mpegq;
|
|
|
|
struct cx88_buffer *buf;
|
|
|
|
|
|
|
|
buf = list_entry(dmaq->active.next, struct cx88_buffer, list);
|
|
|
|
cx8802_start_dma(dev, dmaq, buf);
|
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2014-09-20 12:22:18 +00:00
|
|
|
static void stop_streaming(struct vb2_queue *q)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-20 12:22:18 +00:00
|
|
|
struct cx8802_dev *dev = q->drv_priv;
|
|
|
|
struct cx88_dmaqueue *dmaq = &dev->mpegq;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
cx8802_cancel_buffers(dev);
|
|
|
|
|
|
|
|
spin_lock_irqsave(&dev->slock, flags);
|
|
|
|
while (!list_empty(&dmaq->active)) {
|
|
|
|
struct cx88_buffer *buf = list_entry(dmaq->active.next,
|
|
|
|
struct cx88_buffer, list);
|
|
|
|
|
|
|
|
list_del(&buf->list);
|
[media] media: videobuf2: Restructure vb2_buffer
Remove v4l2 stuff - v4l2_buf, v4l2_plane - from struct vb2_buffer.
Add new member variables - bytesused, length, offset, userptr, fd,
data_offset - to struct vb2_plane in order to cover all information
of v4l2_plane.
struct vb2_plane {
<snip>
unsigned int bytesused;
unsigned int length;
union {
unsigned int offset;
unsigned long userptr;
int fd;
} m;
unsigned int data_offset;
}
Replace v4l2_buf with new member variables - index, type, memory - which
are common fields for buffer management.
struct vb2_buffer {
<snip>
unsigned int index;
unsigned int type;
unsigned int memory;
unsigned int num_planes;
struct vb2_plane planes[VIDEO_MAX_PLANES];
<snip>
};
v4l2 specific fields - flags, field, timestamp, timecode,
sequence - are moved to vb2_v4l2_buffer in videobuf2-v4l2.c
struct vb2_v4l2_buffer {
struct vb2_buffer vb2_buf;
__u32 flags;
__u32 field;
struct timeval timestamp;
struct v4l2_timecode timecode;
__u32 sequence;
};
Signed-off-by: Junghak Sung <jh1009.sung@samsung.com>
Signed-off-by: Geunyoung Kim <nenggun.kim@samsung.com>
Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2015-09-22 13:30:30 +00:00
|
|
|
vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_ERROR);
|
2014-09-20 12:22:18 +00:00
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&dev->slock, flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-09-08 23:59:18 +00:00
|
|
|
static const struct vb2_ops dvb_qops = {
|
2014-09-20 12:22:18 +00:00
|
|
|
.queue_setup = queue_setup,
|
|
|
|
.buf_prepare = buffer_prepare,
|
|
|
|
.buf_finish = buffer_finish,
|
|
|
|
.buf_queue = buffer_queue,
|
|
|
|
.wait_prepare = vb2_ops_wait_prepare,
|
|
|
|
.wait_finish = vb2_ops_wait_finish,
|
|
|
|
.start_streaming = start_streaming,
|
|
|
|
.stop_streaming = stop_streaming,
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
/* ------------------------------------------------------------------ */
|
2006-12-05 04:38:58 +00:00
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int cx88_dvb_bus_ctrl(struct dvb_frontend *fe, int acquire)
|
2006-12-05 04:38:58 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
2006-12-05 04:38:58 +00:00
|
|
|
struct cx8802_driver *drv = NULL;
|
|
|
|
int ret = 0;
|
2008-10-11 14:05:50 +00:00
|
|
|
int fe_id;
|
|
|
|
|
2014-09-20 12:22:18 +00:00
|
|
|
fe_id = vb2_dvb_find_frontend(&dev->frontends, fe);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!fe_id) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("%s() No frontend found\n", __func__);
|
2008-10-11 14:05:50 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2011-05-01 09:29:16 +00:00
|
|
|
mutex_lock(&dev->core->lock);
|
2006-12-05 04:38:58 +00:00
|
|
|
drv = cx8802_get_driver(dev, CX88_MPEG_DVB);
|
|
|
|
if (drv) {
|
2016-11-16 08:59:49 +00:00
|
|
|
if (acquire) {
|
2008-10-11 14:05:50 +00:00
|
|
|
dev->frontends.active_fe_id = fe_id;
|
2006-12-05 04:38:58 +00:00
|
|
|
ret = drv->request_acquire(drv);
|
2008-10-11 14:05:50 +00:00
|
|
|
} else {
|
2006-12-05 04:38:58 +00:00
|
|
|
ret = drv->request_release(drv);
|
2008-10-11 14:05:50 +00:00
|
|
|
dev->frontends.active_fe_id = 0;
|
|
|
|
}
|
2006-12-05 04:38:58 +00:00
|
|
|
}
|
2011-05-01 09:29:37 +00:00
|
|
|
mutex_unlock(&dev->core->lock);
|
2006-12-05 04:38:58 +00:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
static void cx88_dvb_gate_ctrl(struct cx88_core *core, int open)
|
|
|
|
{
|
2014-09-20 12:22:18 +00:00
|
|
|
struct vb2_dvb_frontends *f;
|
|
|
|
struct vb2_dvb_frontend *fe;
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
|
|
|
|
if (!core->dvbdev)
|
|
|
|
return;
|
|
|
|
|
|
|
|
f = &core->dvbdev->frontends;
|
|
|
|
|
|
|
|
if (!f)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (f->gate <= 1) /* undefined or fe0 */
|
2014-09-20 12:22:18 +00:00
|
|
|
fe = vb2_dvb_get_frontend(f, 1);
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
else
|
2014-09-20 12:22:18 +00:00
|
|
|
fe = vb2_dvb_get_frontend(f, f->gate);
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
|
|
|
|
if (fe && fe->dvb.frontend && fe->dvb.frontend->ops.i2c_gate_ctrl)
|
|
|
|
fe->dvb.frontend->ops.i2c_gate_ctrl(fe->dvb.frontend, open);
|
|
|
|
}
|
|
|
|
|
2006-12-05 04:38:58 +00:00
|
|
|
/* ------------------------------------------------------------------ */
|
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int dvico_fusionhdtv_demod_init(struct dvb_frontend *fe)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
static const u8 clock_config[] = { CLOCK_CTL, 0x38, 0x39 };
|
|
|
|
static const u8 reset[] = { RESET, 0x80 };
|
|
|
|
static const u8 adc_ctl_1_cfg[] = { ADC_CTL_1, 0x40 };
|
|
|
|
static const u8 agc_cfg[] = { AGC_TARGET, 0x24, 0x20 };
|
|
|
|
static const u8 gpp_ctl_cfg[] = { GPP_CTL, 0x33 };
|
2010-08-25 12:50:20 +00:00
|
|
|
static const u8 capt_range_cfg[] = { CAPT_RANGE, 0x32 };
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
mt352_write(fe, clock_config, sizeof(clock_config));
|
|
|
|
udelay(200);
|
|
|
|
mt352_write(fe, reset, sizeof(reset));
|
|
|
|
mt352_write(fe, adc_ctl_1_cfg, sizeof(adc_ctl_1_cfg));
|
|
|
|
|
|
|
|
mt352_write(fe, agc_cfg, sizeof(agc_cfg));
|
|
|
|
mt352_write(fe, gpp_ctl_cfg, sizeof(gpp_ctl_cfg));
|
|
|
|
mt352_write(fe, capt_range_cfg, sizeof(capt_range_cfg));
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-01-09 20:21:28 +00:00
|
|
|
static int dvico_dual_demod_init(struct dvb_frontend *fe)
|
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
static const u8 clock_config[] = { CLOCK_CTL, 0x38, 0x38 };
|
|
|
|
static const u8 reset[] = { RESET, 0x80 };
|
|
|
|
static const u8 adc_ctl_1_cfg[] = { ADC_CTL_1, 0x40 };
|
|
|
|
static const u8 agc_cfg[] = { AGC_TARGET, 0x28, 0x20 };
|
|
|
|
static const u8 gpp_ctl_cfg[] = { GPP_CTL, 0x33 };
|
2010-08-25 12:50:20 +00:00
|
|
|
static const u8 capt_range_cfg[] = { CAPT_RANGE, 0x32 };
|
2006-01-09 20:21:28 +00:00
|
|
|
|
|
|
|
mt352_write(fe, clock_config, sizeof(clock_config));
|
|
|
|
udelay(200);
|
|
|
|
mt352_write(fe, reset, sizeof(reset));
|
|
|
|
mt352_write(fe, adc_ctl_1_cfg, sizeof(adc_ctl_1_cfg));
|
|
|
|
|
|
|
|
mt352_write(fe, agc_cfg, sizeof(agc_cfg));
|
|
|
|
mt352_write(fe, gpp_ctl_cfg, sizeof(gpp_ctl_cfg));
|
|
|
|
mt352_write(fe, capt_range_cfg, sizeof(capt_range_cfg));
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int dntv_live_dvbt_demod_init(struct dvb_frontend *fe)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
static const u8 clock_config[] = { 0x89, 0x38, 0x39 };
|
|
|
|
static const u8 reset[] = { 0x50, 0x80 };
|
|
|
|
static const u8 adc_ctl_1_cfg[] = { 0x8E, 0x40 };
|
|
|
|
static const u8 agc_cfg[] = { 0x67, 0x10, 0x23, 0x00, 0xFF, 0xFF,
|
2005-11-09 05:37:45 +00:00
|
|
|
0x00, 0xFF, 0x00, 0x40, 0x40 };
|
2010-08-25 12:50:20 +00:00
|
|
|
static const u8 dntv_extra[] = { 0xB5, 0x7A };
|
|
|
|
static const u8 capt_range_cfg[] = { 0x75, 0x32 };
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
mt352_write(fe, clock_config, sizeof(clock_config));
|
|
|
|
udelay(2000);
|
|
|
|
mt352_write(fe, reset, sizeof(reset));
|
|
|
|
mt352_write(fe, adc_ctl_1_cfg, sizeof(adc_ctl_1_cfg));
|
|
|
|
|
|
|
|
mt352_write(fe, agc_cfg, sizeof(agc_cfg));
|
|
|
|
udelay(2000);
|
|
|
|
mt352_write(fe, dntv_extra, sizeof(dntv_extra));
|
|
|
|
mt352_write(fe, capt_range_cfg, sizeof(capt_range_cfg));
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct mt352_config dvico_fusionhdtv = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x0f,
|
2006-01-09 20:21:31 +00:00
|
|
|
.demod_init = dvico_fusionhdtv_demod_init,
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct mt352_config dntv_live_dvbt_config = {
|
2005-04-16 22:20:36 +00:00
|
|
|
.demod_address = 0x0f,
|
|
|
|
.demod_init = dntv_live_dvbt_demod_init,
|
|
|
|
};
|
2006-01-09 17:25:35 +00:00
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct mt352_config dvico_fusionhdtv_dual = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x0f,
|
2006-01-09 20:21:28 +00:00
|
|
|
.demod_init = dvico_dual_demod_init,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct zl10353_config cx88_terratec_cinergy_ht_pci_mkii_config = {
|
2009-03-10 22:08:06 +00:00
|
|
|
.demod_address = (0x1e >> 1),
|
|
|
|
.no_tuner = 1,
|
|
|
|
.if2 = 45600,
|
|
|
|
};
|
|
|
|
|
2017-02-19 17:29:07 +00:00
|
|
|
static const struct mb86a16_config twinhan_vp1027 = {
|
2010-08-09 13:18:32 +00:00
|
|
|
.demod_address = 0x08,
|
|
|
|
};
|
|
|
|
|
2013-01-20 04:32:56 +00:00
|
|
|
#if IS_ENABLED(CONFIG_VIDEO_CX88_VP3054)
|
2016-11-16 08:59:49 +00:00
|
|
|
static int dntv_live_dvbt_pro_demod_init(struct dvb_frontend *fe)
|
2006-01-09 20:21:31 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
static const u8 clock_config[] = { 0x89, 0x38, 0x38 };
|
|
|
|
static const u8 reset[] = { 0x50, 0x80 };
|
|
|
|
static const u8 adc_ctl_1_cfg[] = { 0x8E, 0x40 };
|
|
|
|
static const u8 agc_cfg[] = { 0x67, 0x10, 0x20, 0x00, 0xFF, 0xFF,
|
2006-01-09 20:21:31 +00:00
|
|
|
0x00, 0xFF, 0x00, 0x40, 0x40 };
|
2010-08-25 12:50:20 +00:00
|
|
|
static const u8 dntv_extra[] = { 0xB5, 0x7A };
|
|
|
|
static const u8 capt_range_cfg[] = { 0x75, 0x32 };
|
2006-01-09 20:21:31 +00:00
|
|
|
|
|
|
|
mt352_write(fe, clock_config, sizeof(clock_config));
|
|
|
|
udelay(2000);
|
|
|
|
mt352_write(fe, reset, sizeof(reset));
|
|
|
|
mt352_write(fe, adc_ctl_1_cfg, sizeof(adc_ctl_1_cfg));
|
|
|
|
|
|
|
|
mt352_write(fe, agc_cfg, sizeof(agc_cfg));
|
|
|
|
udelay(2000);
|
|
|
|
mt352_write(fe, dntv_extra, sizeof(dntv_extra));
|
|
|
|
mt352_write(fe, capt_range_cfg, sizeof(capt_range_cfg));
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct mt352_config dntv_live_dvbt_pro_config = {
|
2006-01-09 17:25:35 +00:00
|
|
|
.demod_address = 0x0f,
|
|
|
|
.no_tuner = 1,
|
2006-01-09 20:21:31 +00:00
|
|
|
.demod_init = dntv_live_dvbt_pro_demod_init,
|
2006-01-09 17:25:35 +00:00
|
|
|
};
|
|
|
|
#endif
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct zl10353_config dvico_fusionhdtv_hybrid = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x0f,
|
2006-04-18 20:56:10 +00:00
|
|
|
.no_tuner = 1,
|
2006-02-28 11:34:59 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct zl10353_config dvico_fusionhdtv_xc3028 = {
|
2008-04-22 17:45:15 +00:00
|
|
|
.demod_address = 0x0f,
|
|
|
|
.if2 = 45600,
|
|
|
|
.no_tuner = 1,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct mt352_config dvico_fusionhdtv_mt352_xc3028 = {
|
2008-04-22 17:45:15 +00:00
|
|
|
.demod_address = 0x0f,
|
|
|
|
.if2 = 4560,
|
|
|
|
.no_tuner = 1,
|
|
|
|
.demod_init = dvico_fusionhdtv_demod_init,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct zl10353_config dvico_fusionhdtv_plus_v1_1 = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x0f,
|
2006-02-28 11:34:59 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct cx22702_config connexant_refboard_config = {
|
2005-04-16 22:20:36 +00:00
|
|
|
.demod_address = 0x43,
|
2005-07-15 19:20:26 +00:00
|
|
|
.output_mode = CX22702_SERIAL_OUTPUT,
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct cx22702_config hauppauge_hvr_config = {
|
2006-09-14 18:41:13 +00:00
|
|
|
.demod_address = 0x63,
|
|
|
|
.output_mode = CX22702_SERIAL_OUTPUT,
|
|
|
|
};
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int or51132_set_ts_param(struct dvb_frontend *fe, int is_punctured)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
dev->ts_gen_cntrl = is_punctured ? 0x04 : 0x00;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct or51132_config pchdtv_hd3000 = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x15,
|
|
|
|
.set_ts_params = or51132_set_ts_param,
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int lgdt330x_pll_rf_set(struct dvb_frontend *fe, int index)
|
2005-07-27 18:45:55 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
2005-07-27 18:45:55 +00:00
|
|
|
struct cx88_core *core = dev->core;
|
|
|
|
|
2008-04-09 02:20:00 +00:00
|
|
|
dprintk(1, "%s: index = %d\n", __func__, index);
|
2005-07-27 18:45:55 +00:00
|
|
|
if (index == 0)
|
|
|
|
cx_clear(MO_GP0_IO, 8);
|
|
|
|
else
|
|
|
|
cx_set(MO_GP0_IO, 8);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int lgdt330x_set_ts_param(struct dvb_frontend *fe, int is_punctured)
|
2005-07-08 00:58:39 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
|
2005-07-08 00:58:39 +00:00
|
|
|
if (is_punctured)
|
|
|
|
dev->ts_gen_cntrl |= 0x04;
|
|
|
|
else
|
|
|
|
dev->ts_gen_cntrl &= ~0x04;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-07-27 18:46:00 +00:00
|
|
|
static struct lgdt330x_config fusionhdtv_3_gold = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_chip = LGDT3302,
|
|
|
|
.serial_mpeg = 0x04, /* TPSERIAL for 3302 in TOP_CONTROL */
|
|
|
|
.set_ts_params = lgdt330x_set_ts_param,
|
2005-07-08 00:58:42 +00:00
|
|
|
};
|
2005-09-09 20:03:41 +00:00
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct lgdt330x_config fusionhdtv_5_gold = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_chip = LGDT3303,
|
|
|
|
.serial_mpeg = 0x40, /* TPSERIAL for 3303 in TOP_CONTROL */
|
|
|
|
.set_ts_params = lgdt330x_set_ts_param,
|
2005-09-09 20:03:41 +00:00
|
|
|
};
|
2006-04-07 05:21:31 +00:00
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct lgdt330x_config pchdtv_hd5500 = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_chip = LGDT3303,
|
|
|
|
.serial_mpeg = 0x40, /* TPSERIAL for 3303 in TOP_CONTROL */
|
|
|
|
.set_ts_params = lgdt330x_set_ts_param,
|
2006-04-07 05:21:31 +00:00
|
|
|
};
|
2005-07-08 00:58:39 +00:00
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int nxt200x_set_ts_param(struct dvb_frontend *fe, int is_punctured)
|
2005-11-09 05:38:18 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
|
2005-11-09 05:38:18 +00:00
|
|
|
dev->ts_gen_cntrl = is_punctured ? 0x04 : 0x00;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct nxt200x_config ati_hdtvwonder = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x0a,
|
|
|
|
.set_ts_params = nxt200x_set_ts_param,
|
2005-11-09 05:38:18 +00:00
|
|
|
};
|
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int cx24123_set_ts_param(struct dvb_frontend *fe,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
int is_punctured)
|
2006-01-09 17:25:02 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
|
2006-08-08 18:48:08 +00:00
|
|
|
dev->ts_gen_cntrl = 0x02;
|
2006-01-09 17:25:02 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
static int kworld_dvbs_100_set_voltage(struct dvb_frontend *fe,
|
2015-06-07 17:53:52 +00:00
|
|
|
enum fe_sec_voltage voltage)
|
2006-01-09 17:25:02 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
2006-01-09 17:25:02 +00:00
|
|
|
struct cx88_core *core = dev->core;
|
|
|
|
|
2006-12-05 05:00:53 +00:00
|
|
|
if (voltage == SEC_VOLTAGE_OFF)
|
2006-08-08 18:48:08 +00:00
|
|
|
cx_write(MO_GP0_IO, 0x000006fb);
|
2006-12-05 05:00:53 +00:00
|
|
|
else
|
2006-05-12 23:31:51 +00:00
|
|
|
cx_write(MO_GP0_IO, 0x000006f9);
|
|
|
|
|
|
|
|
if (core->prev_set_voltage)
|
|
|
|
return core->prev_set_voltage(fe, voltage);
|
|
|
|
return 0;
|
2006-01-09 17:25:02 +00:00
|
|
|
}
|
|
|
|
|
2006-08-08 18:48:08 +00:00
|
|
|
static int geniatech_dvbs_set_voltage(struct dvb_frontend *fe,
|
2015-06-07 17:53:52 +00:00
|
|
|
enum fe_sec_voltage voltage)
|
2006-06-29 23:29:33 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
2006-06-29 23:29:33 +00:00
|
|
|
struct cx88_core *core = dev->core;
|
|
|
|
|
|
|
|
if (voltage == SEC_VOLTAGE_OFF) {
|
2016-11-16 08:59:49 +00:00
|
|
|
dprintk(1, "LNB Voltage OFF\n");
|
2006-06-29 23:29:33 +00:00
|
|
|
cx_write(MO_GP0_IO, 0x0000efff);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (core->prev_set_voltage)
|
|
|
|
return core->prev_set_voltage(fe, voltage);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-09-04 20:24:14 +00:00
|
|
|
static int tevii_dvbs_set_voltage(struct dvb_frontend *fe,
|
2015-06-07 17:53:52 +00:00
|
|
|
enum fe_sec_voltage voltage)
|
2008-09-04 20:24:14 +00:00
|
|
|
{
|
2016-11-16 08:59:49 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
2008-09-04 20:24:14 +00:00
|
|
|
struct cx88_core *core = dev->core;
|
|
|
|
|
2009-07-29 22:18:28 +00:00
|
|
|
cx_set(MO_GP0_IO, 0x6040);
|
2008-09-04 20:24:14 +00:00
|
|
|
switch (voltage) {
|
2010-08-09 13:18:32 +00:00
|
|
|
case SEC_VOLTAGE_13:
|
|
|
|
cx_clear(MO_GP0_IO, 0x20);
|
|
|
|
break;
|
|
|
|
case SEC_VOLTAGE_18:
|
|
|
|
cx_set(MO_GP0_IO, 0x20);
|
|
|
|
break;
|
|
|
|
case SEC_VOLTAGE_OFF:
|
|
|
|
cx_clear(MO_GP0_IO, 0x20);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (core->prev_set_voltage)
|
|
|
|
return core->prev_set_voltage(fe, voltage);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int vp1027_set_voltage(struct dvb_frontend *fe,
|
2015-06-07 17:53:52 +00:00
|
|
|
enum fe_sec_voltage voltage)
|
2010-08-09 13:18:32 +00:00
|
|
|
{
|
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
struct cx88_core *core = dev->core;
|
|
|
|
|
|
|
|
switch (voltage) {
|
|
|
|
case SEC_VOLTAGE_13:
|
|
|
|
dprintk(1, "LNB SEC Voltage=13\n");
|
|
|
|
cx_write(MO_GP0_IO, 0x00001220);
|
|
|
|
break;
|
|
|
|
case SEC_VOLTAGE_18:
|
|
|
|
dprintk(1, "LNB SEC Voltage=18\n");
|
|
|
|
cx_write(MO_GP0_IO, 0x00001222);
|
|
|
|
break;
|
|
|
|
case SEC_VOLTAGE_OFF:
|
|
|
|
dprintk(1, "LNB Voltage OFF\n");
|
|
|
|
cx_write(MO_GP0_IO, 0x00001230);
|
|
|
|
break;
|
2008-09-04 20:24:14 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if (core->prev_set_voltage)
|
|
|
|
return core->prev_set_voltage(fe, voltage);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct cx24123_config geniatech_dvbs_config = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x55,
|
|
|
|
.set_ts_params = cx24123_set_ts_param,
|
2006-06-29 23:29:33 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct cx24123_config hauppauge_novas_config = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x55,
|
|
|
|
.set_ts_params = cx24123_set_ts_param,
|
2006-01-09 17:25:02 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct cx24123_config kworld_dvbs_100_config = {
|
2006-08-08 18:48:08 +00:00
|
|
|
.demod_address = 0x15,
|
|
|
|
.set_ts_params = cx24123_set_ts_param,
|
2006-09-26 15:30:14 +00:00
|
|
|
.lnb_polarity = 1,
|
2006-01-09 17:25:02 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct s5h1409_config pinnacle_pctv_hd_800i_config = {
|
2008-01-05 19:53:01 +00:00
|
|
|
.demod_address = 0x32 >> 1,
|
|
|
|
.output_mode = S5H1409_PARALLEL_OUTPUT,
|
|
|
|
.gpio = S5H1409_GPIO_ON,
|
|
|
|
.qam_if = 44000,
|
|
|
|
.inversion = S5H1409_INVERSION_OFF,
|
|
|
|
.status_mode = S5H1409_DEMODLOCKING,
|
2018-03-03 14:53:32 +00:00
|
|
|
.mpeg_timing = S5H1409_MPEGTIMING_NONCONTINUOUS_NONINVERTING_CLOCK,
|
2008-01-05 19:53:01 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct s5h1409_config dvico_hdtv5_pci_nano_config = {
|
2008-04-22 17:45:14 +00:00
|
|
|
.demod_address = 0x32 >> 1,
|
|
|
|
.output_mode = S5H1409_SERIAL_OUTPUT,
|
|
|
|
.gpio = S5H1409_GPIO_OFF,
|
|
|
|
.inversion = S5H1409_INVERSION_OFF,
|
|
|
|
.status_mode = S5H1409_DEMODLOCKING,
|
2018-03-03 14:53:32 +00:00
|
|
|
.mpeg_timing = S5H1409_MPEGTIMING_CONTINUOUS_NONINVERTING_CLOCK,
|
2008-04-22 17:45:14 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct s5h1409_config kworld_atsc_120_config = {
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
.demod_address = 0x32 >> 1,
|
|
|
|
.output_mode = S5H1409_SERIAL_OUTPUT,
|
|
|
|
.gpio = S5H1409_GPIO_OFF,
|
|
|
|
.inversion = S5H1409_INVERSION_OFF,
|
|
|
|
.status_mode = S5H1409_DEMODLOCKING,
|
2018-03-03 14:53:32 +00:00
|
|
|
.mpeg_timing = S5H1409_MPEGTIMING_CONTINUOUS_NONINVERTING_CLOCK,
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct xc5000_config pinnacle_pctv_hd_800i_tuner_config = {
|
2008-01-05 19:53:01 +00:00
|
|
|
.i2c_address = 0x64,
|
|
|
|
.if_khz = 5380,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct zl10353_config cx88_pinnacle_hybrid_pctv = {
|
2008-09-05 17:33:54 +00:00
|
|
|
.demod_address = (0x1e >> 1),
|
|
|
|
.no_tuner = 1,
|
|
|
|
.if2 = 45600,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct zl10353_config cx88_geniatech_x8000_mt = {
|
2009-08-20 13:14:45 +00:00
|
|
|
.demod_address = (0x1e >> 1),
|
|
|
|
.no_tuner = 1,
|
|
|
|
.disable_i2c_gate_ctrl = 1,
|
2008-04-22 17:45:15 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct s5h1411_config dvico_fusionhdtv7_config = {
|
2008-04-25 06:46:43 +00:00
|
|
|
.output_mode = S5H1411_SERIAL_OUTPUT,
|
|
|
|
.gpio = S5H1411_GPIO_ON,
|
2018-03-03 14:53:32 +00:00
|
|
|
.mpeg_timing = S5H1411_MPEGTIMING_CONTINUOUS_NONINVERTING_CLOCK,
|
2008-04-25 06:46:43 +00:00
|
|
|
.qam_if = S5H1411_IF_44000,
|
|
|
|
.vsb_if = S5H1411_IF_44000,
|
|
|
|
.inversion = S5H1411_INVERSION_OFF,
|
|
|
|
.status_mode = S5H1411_DEMODLOCKING
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct xc5000_config dvico_fusionhdtv7_tuner_config = {
|
2008-04-25 06:46:43 +00:00
|
|
|
.i2c_address = 0xc2 >> 1,
|
|
|
|
.if_khz = 5380,
|
|
|
|
};
|
|
|
|
|
2008-04-22 17:45:30 +00:00
|
|
|
static int attach_xc3028(u8 addr, struct cx8802_dev *dev)
|
|
|
|
{
|
|
|
|
struct dvb_frontend *fe;
|
2014-09-20 12:22:18 +00:00
|
|
|
struct vb2_dvb_frontend *fe0 = NULL;
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
struct xc2028_ctrl ctl;
|
2008-04-22 17:45:30 +00:00
|
|
|
struct xc2028_config cfg = {
|
|
|
|
.i2c_adap = &dev->core->i2c_adap,
|
|
|
|
.i2c_addr = addr,
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
.ctrl = &ctl,
|
2008-04-22 17:45:30 +00:00
|
|
|
};
|
|
|
|
|
2008-10-11 14:18:53 +00:00
|
|
|
/* Get the first frontend */
|
2014-09-20 12:22:18 +00:00
|
|
|
fe0 = vb2_dvb_get_frontend(&dev->frontends, 1);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!fe0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (!fe0->dvb.frontend) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("dvb frontend not attached. Can't attach xc3028\n");
|
2008-04-22 17:45:46 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
/*
|
|
|
|
* Some xc3028 devices may be hidden by an I2C gate. This is known
|
|
|
|
* to happen with some s5h1409-based devices.
|
|
|
|
* Now that I2C gate is open, sets up xc3028 configuration
|
|
|
|
*/
|
|
|
|
cx88_setup_xc3028(dev->core, &ctl);
|
|
|
|
|
2008-10-11 14:05:50 +00:00
|
|
|
fe = dvb_attach(xc2028_attach, fe0->dvb.frontend, &cfg);
|
2008-04-22 17:45:30 +00:00
|
|
|
if (!fe) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("xc3028 attach failed\n");
|
2008-10-11 14:05:50 +00:00
|
|
|
dvb_frontend_detach(fe0->dvb.frontend);
|
|
|
|
dvb_unregister_frontend(fe0->dvb.frontend);
|
|
|
|
fe0->dvb.frontend = NULL;
|
2008-04-22 17:45:30 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_info("xc3028 attached\n");
|
2008-04-22 17:45:30 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2008-04-22 17:45:15 +00:00
|
|
|
|
2011-06-07 16:12:29 +00:00
|
|
|
static int attach_xc4000(struct cx8802_dev *dev, struct xc4000_config *cfg)
|
|
|
|
{
|
|
|
|
struct dvb_frontend *fe;
|
2014-09-20 12:22:18 +00:00
|
|
|
struct vb2_dvb_frontend *fe0 = NULL;
|
2011-06-07 16:12:29 +00:00
|
|
|
|
|
|
|
/* Get the first frontend */
|
2014-09-20 12:22:18 +00:00
|
|
|
fe0 = vb2_dvb_get_frontend(&dev->frontends, 1);
|
2011-06-07 16:12:29 +00:00
|
|
|
if (!fe0)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (!fe0->dvb.frontend) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("dvb frontend not attached. Can't attach xc4000\n");
|
2011-06-07 16:12:29 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
fe = dvb_attach(xc4000_attach, fe0->dvb.frontend, &dev->core->i2c_adap,
|
|
|
|
cfg);
|
|
|
|
if (!fe) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("xc4000 attach failed\n");
|
2011-06-07 16:12:29 +00:00
|
|
|
dvb_frontend_detach(fe0->dvb.frontend);
|
|
|
|
dvb_unregister_frontend(fe0->dvb.frontend);
|
|
|
|
fe0->dvb.frontend = NULL;
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_info("xc4000 attached\n");
|
2011-06-07 16:12:29 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-09-04 04:17:33 +00:00
|
|
|
static int cx24116_set_ts_param(struct dvb_frontend *fe,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
int is_punctured)
|
2008-09-04 04:17:33 +00:00
|
|
|
{
|
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
2016-11-16 08:59:49 +00:00
|
|
|
|
2008-09-04 04:17:33 +00:00
|
|
|
dev->ts_gen_cntrl = 0x2;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-11-17 01:22:32 +00:00
|
|
|
static int stv0900_set_ts_param(struct dvb_frontend *fe,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
int is_punctured)
|
2009-11-17 01:22:32 +00:00
|
|
|
{
|
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
2016-11-16 08:59:49 +00:00
|
|
|
|
2009-11-17 01:22:32 +00:00
|
|
|
dev->ts_gen_cntrl = 0;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-09-04 04:17:33 +00:00
|
|
|
static int cx24116_reset_device(struct dvb_frontend *fe)
|
|
|
|
{
|
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
struct cx88_core *core = dev->core;
|
|
|
|
|
|
|
|
/* Reset the part */
|
2008-10-11 14:05:50 +00:00
|
|
|
/* Put the cx24116 into reset */
|
2008-09-04 04:17:33 +00:00
|
|
|
cx_write(MO_SRST_IO, 0);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
usleep_range(10000, 20000);
|
2008-10-11 14:05:50 +00:00
|
|
|
/* Take the cx24116 out of reset */
|
2008-09-04 04:17:33 +00:00
|
|
|
cx_write(MO_SRST_IO, 1);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
usleep_range(10000, 20000);
|
2008-09-04 04:17:33 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct cx24116_config hauppauge_hvr4000_config = {
|
2008-09-04 04:17:33 +00:00
|
|
|
.demod_address = 0x05,
|
|
|
|
.set_ts_params = cx24116_set_ts_param,
|
|
|
|
.reset_device = cx24116_reset_device,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct cx24116_config tevii_s460_config = {
|
2008-09-04 20:24:14 +00:00
|
|
|
.demod_address = 0x55,
|
|
|
|
.set_ts_params = cx24116_set_ts_param,
|
|
|
|
.reset_device = cx24116_reset_device,
|
|
|
|
};
|
|
|
|
|
2011-02-25 21:41:24 +00:00
|
|
|
static int ds3000_set_ts_param(struct dvb_frontend *fe,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
int is_punctured)
|
2011-02-25 21:41:24 +00:00
|
|
|
{
|
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
2016-11-16 08:59:49 +00:00
|
|
|
|
2011-02-25 21:41:24 +00:00
|
|
|
dev->ts_gen_cntrl = 4;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct ds3000_config tevii_ds3000_config = {
|
|
|
|
.demod_address = 0x68,
|
|
|
|
.set_ts_params = ds3000_set_ts_param,
|
|
|
|
};
|
|
|
|
|
2012-12-23 22:25:38 +00:00
|
|
|
static struct ts2020_config tevii_ts2020_config = {
|
|
|
|
.tuner_address = 0x60,
|
2012-12-28 22:40:33 +00:00
|
|
|
.clk_out_div = 1,
|
2012-12-23 22:25:38 +00:00
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct stv0900_config prof_7301_stv0900_config = {
|
2009-11-17 01:22:32 +00:00
|
|
|
.demod_address = 0x6a,
|
|
|
|
/* demod_mode = 0,*/
|
|
|
|
.xtal = 27000000,
|
|
|
|
.clkmode = 3,/* 0-CLKI, 2-XTALI, else AUTO */
|
|
|
|
.diseqc_mode = 2,/* 2/3 PWM */
|
|
|
|
.tun1_maddress = 0,/* 0x60 */
|
|
|
|
.tun1_adc = 0,/* 2 Vpp */
|
|
|
|
.path1_mode = 3,
|
|
|
|
.set_ts_params = stv0900_set_ts_param,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct stb6100_config prof_7301_stb6100_config = {
|
2009-11-17 01:22:32 +00:00
|
|
|
.tuner_address = 0x60,
|
|
|
|
.refclock = 27000000,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct stv0299_config tevii_tuner_sharp_config = {
|
2008-09-23 18:43:57 +00:00
|
|
|
.demod_address = 0x68,
|
2008-10-17 16:45:55 +00:00
|
|
|
.inittab = sharp_z0194a_inittab,
|
2008-09-23 18:43:57 +00:00
|
|
|
.mclk = 88000000UL,
|
|
|
|
.invert = 1,
|
|
|
|
.skip_reinit = 0,
|
|
|
|
.lock_output = 1,
|
|
|
|
.volt13_op0_op1 = STV0299_VOLT13_OP1,
|
|
|
|
.min_delay_ms = 100,
|
2008-10-17 16:45:55 +00:00
|
|
|
.set_symbol_rate = sharp_z0194a_set_symbol_rate,
|
2008-09-23 18:43:57 +00:00
|
|
|
.set_ts_params = cx24116_set_ts_param,
|
|
|
|
};
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct stv0288_config tevii_tuner_earda_config = {
|
2008-09-23 18:43:57 +00:00
|
|
|
.demod_address = 0x68,
|
|
|
|
.min_delay_ms = 100,
|
|
|
|
.set_ts_params = cx24116_set_ts_param,
|
|
|
|
};
|
|
|
|
|
2009-01-12 00:18:04 +00:00
|
|
|
static int cx8802_alloc_frontends(struct cx8802_dev *dev)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-04-30 21:14:36 +00:00
|
|
|
struct cx88_core *core = dev->core;
|
2014-09-20 12:22:18 +00:00
|
|
|
struct vb2_dvb_frontend *fe = NULL;
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
int i;
|
2008-04-30 21:14:36 +00:00
|
|
|
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
mutex_init(&dev->frontends.lock);
|
|
|
|
INIT_LIST_HEAD(&dev->frontends.felist);
|
|
|
|
|
2009-01-12 00:18:04 +00:00
|
|
|
if (!core->board.num_frontends)
|
|
|
|
return -ENODEV;
|
|
|
|
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_info("%s: allocating %d frontend(s)\n", __func__,
|
|
|
|
core->board.num_frontends);
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
for (i = 1; i <= core->board.num_frontends; i++) {
|
2014-09-20 12:22:18 +00:00
|
|
|
fe = vb2_dvb_alloc_frontend(&dev->frontends, i);
|
2009-01-12 00:18:04 +00:00
|
|
|
if (!fe) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("%s() failed to alloc\n", __func__);
|
2014-09-20 12:22:18 +00:00
|
|
|
vb2_dvb_dealloc_frontends(&dev->frontends);
|
2009-01-12 00:18:04 +00:00
|
|
|
return -ENOMEM;
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
}
|
|
|
|
}
|
2009-01-12 00:18:04 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const u8 samsung_smt_7020_inittab[] = {
|
2010-02-11 21:06:34 +00:00
|
|
|
0x01, 0x15,
|
|
|
|
0x02, 0x00,
|
|
|
|
0x03, 0x00,
|
|
|
|
0x04, 0x7D,
|
|
|
|
0x05, 0x0F,
|
|
|
|
0x06, 0x02,
|
|
|
|
0x07, 0x00,
|
|
|
|
0x08, 0x60,
|
|
|
|
|
|
|
|
0x0A, 0xC2,
|
|
|
|
0x0B, 0x00,
|
|
|
|
0x0C, 0x01,
|
|
|
|
0x0D, 0x81,
|
|
|
|
0x0E, 0x44,
|
|
|
|
0x0F, 0x09,
|
|
|
|
0x10, 0x3C,
|
|
|
|
0x11, 0x84,
|
|
|
|
0x12, 0xDA,
|
|
|
|
0x13, 0x99,
|
|
|
|
0x14, 0x8D,
|
|
|
|
0x15, 0xCE,
|
|
|
|
0x16, 0xE8,
|
|
|
|
0x17, 0x43,
|
|
|
|
0x18, 0x1C,
|
|
|
|
0x19, 0x1B,
|
|
|
|
0x1A, 0x1D,
|
|
|
|
|
|
|
|
0x1C, 0x12,
|
|
|
|
0x1D, 0x00,
|
|
|
|
0x1E, 0x00,
|
|
|
|
0x1F, 0x00,
|
|
|
|
0x20, 0x00,
|
|
|
|
0x21, 0x00,
|
|
|
|
0x22, 0x00,
|
|
|
|
0x23, 0x00,
|
|
|
|
|
|
|
|
0x28, 0x02,
|
|
|
|
0x29, 0x28,
|
|
|
|
0x2A, 0x14,
|
|
|
|
0x2B, 0x0F,
|
|
|
|
0x2C, 0x09,
|
|
|
|
0x2D, 0x05,
|
|
|
|
|
|
|
|
0x31, 0x1F,
|
|
|
|
0x32, 0x19,
|
|
|
|
0x33, 0xFC,
|
|
|
|
0x34, 0x13,
|
|
|
|
0xff, 0xff,
|
|
|
|
};
|
|
|
|
|
2011-12-24 15:24:33 +00:00
|
|
|
static int samsung_smt_7020_tuner_set_params(struct dvb_frontend *fe)
|
2010-02-11 21:06:34 +00:00
|
|
|
{
|
2011-12-23 15:33:05 +00:00
|
|
|
struct dtv_frontend_properties *c = &fe->dtv_property_cache;
|
2010-02-11 21:06:34 +00:00
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
u8 buf[4];
|
|
|
|
u32 div;
|
|
|
|
struct i2c_msg msg = {
|
|
|
|
.addr = 0x61,
|
|
|
|
.flags = 0,
|
|
|
|
.buf = buf,
|
|
|
|
.len = sizeof(buf) };
|
|
|
|
|
2011-12-23 15:33:05 +00:00
|
|
|
div = c->frequency / 125;
|
2010-02-11 21:06:34 +00:00
|
|
|
|
|
|
|
buf[0] = (div >> 8) & 0x7f;
|
|
|
|
buf[1] = div & 0xff;
|
|
|
|
buf[2] = 0x84; /* 0xC4 */
|
|
|
|
buf[3] = 0x00;
|
|
|
|
|
2011-12-23 15:33:05 +00:00
|
|
|
if (c->frequency < 1500000)
|
2010-02-11 21:06:34 +00:00
|
|
|
buf[3] |= 0x10;
|
|
|
|
|
|
|
|
if (fe->ops.i2c_gate_ctrl)
|
|
|
|
fe->ops.i2c_gate_ctrl(fe, 1);
|
|
|
|
|
|
|
|
if (i2c_transfer(&dev->core->i2c_adap, &msg, 1) != 1)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int samsung_smt_7020_set_tone(struct dvb_frontend *fe,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
enum fe_sec_tone_mode tone)
|
2010-02-11 21:06:34 +00:00
|
|
|
{
|
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
struct cx88_core *core = dev->core;
|
|
|
|
|
|
|
|
cx_set(MO_GP0_IO, 0x0800);
|
|
|
|
|
|
|
|
switch (tone) {
|
|
|
|
case SEC_TONE_ON:
|
|
|
|
cx_set(MO_GP0_IO, 0x08);
|
|
|
|
break;
|
|
|
|
case SEC_TONE_OFF:
|
|
|
|
cx_clear(MO_GP0_IO, 0x08);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int samsung_smt_7020_set_voltage(struct dvb_frontend *fe,
|
2015-06-07 17:53:52 +00:00
|
|
|
enum fe_sec_voltage voltage)
|
2010-02-11 21:06:34 +00:00
|
|
|
{
|
|
|
|
struct cx8802_dev *dev = fe->dvb->priv;
|
|
|
|
struct cx88_core *core = dev->core;
|
|
|
|
|
|
|
|
u8 data;
|
|
|
|
struct i2c_msg msg = {
|
|
|
|
.addr = 8,
|
|
|
|
.flags = 0,
|
|
|
|
.buf = &data,
|
|
|
|
.len = sizeof(data) };
|
|
|
|
|
|
|
|
cx_set(MO_GP0_IO, 0x8000);
|
|
|
|
|
|
|
|
switch (voltage) {
|
|
|
|
case SEC_VOLTAGE_OFF:
|
|
|
|
break;
|
|
|
|
case SEC_VOLTAGE_13:
|
|
|
|
data = ISL6421_EN1 | ISL6421_LLC1;
|
|
|
|
cx_clear(MO_GP0_IO, 0x80);
|
|
|
|
break;
|
|
|
|
case SEC_VOLTAGE_18:
|
|
|
|
data = ISL6421_EN1 | ISL6421_LLC1 | ISL6421_VSEL1;
|
|
|
|
cx_clear(MO_GP0_IO, 0x80);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return -EINVAL;
|
2012-09-28 08:37:22 +00:00
|
|
|
}
|
2010-02-11 21:06:34 +00:00
|
|
|
|
|
|
|
return (i2c_transfer(&dev->core->i2c_adap, &msg, 1) == 1) ? 0 : -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int samsung_smt_7020_stv0299_set_symbol_rate(struct dvb_frontend *fe,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
u32 srate, u32 ratio)
|
2010-02-11 21:06:34 +00:00
|
|
|
{
|
|
|
|
u8 aclk = 0;
|
|
|
|
u8 bclk = 0;
|
|
|
|
|
|
|
|
if (srate < 1500000) {
|
|
|
|
aclk = 0xb7;
|
|
|
|
bclk = 0x47;
|
|
|
|
} else if (srate < 3000000) {
|
|
|
|
aclk = 0xb7;
|
|
|
|
bclk = 0x4b;
|
|
|
|
} else if (srate < 7000000) {
|
|
|
|
aclk = 0xb7;
|
|
|
|
bclk = 0x4f;
|
|
|
|
} else if (srate < 14000000) {
|
|
|
|
aclk = 0xb7;
|
|
|
|
bclk = 0x53;
|
|
|
|
} else if (srate < 30000000) {
|
|
|
|
aclk = 0xb6;
|
|
|
|
bclk = 0x53;
|
|
|
|
} else if (srate < 45000000) {
|
|
|
|
aclk = 0xb4;
|
|
|
|
bclk = 0x51;
|
|
|
|
}
|
|
|
|
|
|
|
|
stv0299_writereg(fe, 0x13, aclk);
|
|
|
|
stv0299_writereg(fe, 0x14, bclk);
|
|
|
|
stv0299_writereg(fe, 0x1f, (ratio >> 16) & 0xff);
|
|
|
|
stv0299_writereg(fe, 0x20, (ratio >> 8) & 0xff);
|
|
|
|
stv0299_writereg(fe, 0x21, ratio & 0xf0);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-08-25 12:50:20 +00:00
|
|
|
static const struct stv0299_config samsung_stv0299_config = {
|
2010-02-11 21:06:34 +00:00
|
|
|
.demod_address = 0x68,
|
|
|
|
.inittab = samsung_smt_7020_inittab,
|
|
|
|
.mclk = 88000000UL,
|
|
|
|
.invert = 0,
|
|
|
|
.skip_reinit = 0,
|
|
|
|
.lock_output = STV0299_LOCKOUTPUT_LK,
|
|
|
|
.volt13_op0_op1 = STV0299_VOLT13_OP1,
|
|
|
|
.min_delay_ms = 100,
|
|
|
|
.set_symbol_rate = samsung_smt_7020_stv0299_set_symbol_rate,
|
|
|
|
};
|
|
|
|
|
2009-01-12 00:18:04 +00:00
|
|
|
static int dvb_register(struct cx8802_dev *dev)
|
|
|
|
{
|
|
|
|
struct cx88_core *core = dev->core;
|
2014-09-20 12:22:18 +00:00
|
|
|
struct vb2_dvb_frontend *fe0, *fe1 = NULL;
|
2009-01-12 00:18:04 +00:00
|
|
|
int mfe_shared = 0; /* bus not shared by default */
|
2011-12-15 04:59:20 +00:00
|
|
|
int res = -EINVAL;
|
2009-01-12 00:18:04 +00:00
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
if (core->i2c_rc != 0) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("no i2c-bus available, cannot attach dvb drivers\n");
|
2009-01-12 00:18:04 +00:00
|
|
|
goto frontend_detach;
|
|
|
|
}
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
|
2008-10-11 14:05:50 +00:00
|
|
|
/* Get the first frontend */
|
2014-09-20 12:22:18 +00:00
|
|
|
fe0 = vb2_dvb_get_frontend(&dev->frontends, 1);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!fe0)
|
2008-11-11 11:48:27 +00:00
|
|
|
goto frontend_detach;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-10-11 14:31:41 +00:00
|
|
|
/* multi-frontend gate control is undefined or defaults to fe0 */
|
|
|
|
dev->frontends.gate = 0;
|
|
|
|
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
/* Sets the gate control callback to be used by i2c command calls */
|
|
|
|
core->gate_ctrl = cx88_dvb_gate_ctrl;
|
|
|
|
|
2008-10-11 14:31:41 +00:00
|
|
|
/* init frontend(s) */
|
2008-04-30 21:14:36 +00:00
|
|
|
switch (core->boardnr) {
|
2005-04-16 22:20:36 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_DVB_T1:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx22702_attach,
|
2006-12-05 04:34:56 +00:00
|
|
|
&connexant_refboard_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
0x61, &core->i2c_adap,
|
|
|
|
DVB_PLL_THOMSON_DTT759X))
|
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2005-07-08 00:58:40 +00:00
|
|
|
case CX88_BOARD_TERRATEC_CINERGY_1400_DVB_T1:
|
2005-04-16 22:20:36 +00:00
|
|
|
case CX88_BOARD_CONEXANT_DVB_T1:
|
2006-01-09 17:32:45 +00:00
|
|
|
case CX88_BOARD_KWORLD_DVB_T_CX22702:
|
2005-11-09 05:37:22 +00:00
|
|
|
case CX88_BOARD_WINFAST_DTV1000:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx22702_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&connexant_refboard_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
0x60, &core->i2c_adap,
|
|
|
|
DVB_PLL_THOMSON_DTT7579))
|
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2006-05-29 16:51:59 +00:00
|
|
|
case CX88_BOARD_WINFAST_DTV2000H:
|
2006-01-09 17:25:12 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR1100:
|
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR1100LP:
|
2007-03-09 18:07:07 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR1300:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx22702_attach,
|
2006-12-05 04:34:56 +00:00
|
|
|
&hauppauge_hvr_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_PHILIPS_FMD1216ME_MK3))
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2006-01-09 17:25:12 +00:00
|
|
|
break;
|
2011-12-13 18:36:15 +00:00
|
|
|
case CX88_BOARD_WINFAST_DTV2000H_J:
|
|
|
|
fe0->dvb.frontend = dvb_attach(cx22702_attach,
|
|
|
|
&hauppauge_hvr_config,
|
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2011-12-13 18:36:15 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_PHILIPS_FMD1216MEX_MK3))
|
2011-12-13 18:36:15 +00:00
|
|
|
goto frontend_detach;
|
|
|
|
}
|
|
|
|
break;
|
2008-10-11 14:05:50 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR3000:
|
2008-11-11 11:48:27 +00:00
|
|
|
/* MFE frontend 1 */
|
|
|
|
mfe_shared = 1;
|
|
|
|
dev->frontends.gate = 2;
|
2008-10-11 14:05:50 +00:00
|
|
|
/* DVB-S init */
|
|
|
|
fe0->dvb.frontend = dvb_attach(cx24123_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&hauppauge_novas_config,
|
|
|
|
&dev->core->i2c_adap);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-11-11 11:48:27 +00:00
|
|
|
if (!dvb_attach(isl6421_attach,
|
|
|
|
fe0->dvb.frontend,
|
|
|
|
&dev->core->i2c_adap,
|
2013-04-05 15:18:54 +00:00
|
|
|
0x08, ISL6421_DCL, 0x00, false))
|
2008-11-11 11:48:27 +00:00
|
|
|
goto frontend_detach;
|
2008-10-11 14:05:50 +00:00
|
|
|
}
|
2008-11-11 11:48:27 +00:00
|
|
|
/* MFE frontend 2 */
|
2014-09-20 12:22:18 +00:00
|
|
|
fe1 = vb2_dvb_get_frontend(&dev->frontends, 2);
|
2008-11-11 11:48:27 +00:00
|
|
|
if (!fe1)
|
|
|
|
goto frontend_detach;
|
|
|
|
/* DVB-T init */
|
|
|
|
fe1->dvb.frontend = dvb_attach(cx22702_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&hauppauge_hvr_config,
|
|
|
|
&dev->core->i2c_adap);
|
2008-11-11 11:48:27 +00:00
|
|
|
if (fe1->dvb.frontend) {
|
|
|
|
fe1->dvb.frontend->id = 1;
|
|
|
|
if (!dvb_attach(simple_tuner_attach,
|
|
|
|
fe1->dvb.frontend,
|
|
|
|
&dev->core->i2c_adap,
|
|
|
|
0x61, TUNER_PHILIPS_FMD1216ME_MK3))
|
|
|
|
goto frontend_detach;
|
2008-10-11 14:05:50 +00:00
|
|
|
}
|
|
|
|
break;
|
2006-02-28 11:34:59 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_PLUS:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(mt352_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&dvico_fusionhdtv,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
0x60, NULL, DVB_PLL_THOMSON_DTT7579))
|
|
|
|
goto frontend_detach;
|
2006-02-28 11:34:59 +00:00
|
|
|
break;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2006-02-28 11:34:59 +00:00
|
|
|
/* ZL10353 replaces MT352 on later cards */
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(zl10353_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&dvico_fusionhdtv_plus_v1_1,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
0x60, NULL, DVB_PLL_THOMSON_DTT7579))
|
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2006-06-12 17:06:22 +00:00
|
|
|
break;
|
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL:
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
/*
|
|
|
|
* The tin box says DEE1601, but it seems to be DTT7579
|
|
|
|
* compatible, with a slightly different MT352 AGC gain.
|
|
|
|
*/
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(mt352_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&dvico_fusionhdtv_dual,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
0x61, NULL, DVB_PLL_THOMSON_DTT7579))
|
|
|
|
goto frontend_detach;
|
2006-06-12 17:06:22 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
/* ZL10353 replaces MT352 on later cards */
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(zl10353_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&dvico_fusionhdtv_plus_v1_1,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
0x61, NULL, DVB_PLL_THOMSON_DTT7579))
|
|
|
|
goto frontend_detach;
|
2006-06-12 17:06:22 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2006-02-28 11:34:59 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T1:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(mt352_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&dvico_fusionhdtv,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
0x61, NULL, DVB_PLL_LG_Z201))
|
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case CX88_BOARD_KWORLD_DVB_T:
|
|
|
|
case CX88_BOARD_DNTV_LIVE_DVB_T:
|
2005-07-08 00:58:36 +00:00
|
|
|
case CX88_BOARD_ADSTECH_DVB_T_PCI:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(mt352_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&dntv_live_dvbt_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
0x61, NULL, DVB_PLL_UNKNOWN_1))
|
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2006-01-09 17:25:35 +00:00
|
|
|
case CX88_BOARD_DNTV_LIVE_DVB_T_PRO:
|
2013-01-20 04:32:56 +00:00
|
|
|
#if IS_ENABLED(CONFIG_VIDEO_CX88_VP3054)
|
2007-10-14 05:52:16 +00:00
|
|
|
/* MT352 is on a secondary I2C bus made from some GPIO lines */
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(mt352_attach,
|
|
|
|
&dntv_live_dvbt_pro_config,
|
2007-10-14 05:52:16 +00:00
|
|
|
&dev->vp3054->adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_PHILIPS_FMD1216ME_MK3))
|
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2006-01-09 17:25:35 +00:00
|
|
|
#else
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("built without vp3054 support\n");
|
2006-01-09 17:25:35 +00:00
|
|
|
#endif
|
|
|
|
break;
|
2006-02-28 11:34:59 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_HYBRID:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(zl10353_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&dvico_fusionhdtv_hybrid,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_THOMSON_FE6600))
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2006-02-28 11:34:59 +00:00
|
|
|
break;
|
2008-04-22 17:45:15 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_DVB_T_PRO:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(zl10353_attach,
|
2008-04-22 17:45:15 +00:00
|
|
|
&dvico_fusionhdtv_xc3028,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (!fe0->dvb.frontend)
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(mt352_attach,
|
2008-04-22 17:45:15 +00:00
|
|
|
&dvico_fusionhdtv_mt352_xc3028,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
2008-04-22 17:45:15 +00:00
|
|
|
/*
|
|
|
|
* On this board, the demod provides the I2C bus pullup.
|
|
|
|
* We must not permit gate_ctrl to be performed, or
|
|
|
|
* the xc3028 cannot communicate on the bus.
|
|
|
|
*/
|
2008-10-11 14:05:50 +00:00
|
|
|
if (fe0->dvb.frontend)
|
|
|
|
fe0->dvb.frontend->ops.i2c_gate_ctrl = NULL;
|
2008-04-22 17:45:30 +00:00
|
|
|
if (attach_xc3028(0x61, dev) < 0)
|
2008-10-21 14:47:50 +00:00
|
|
|
goto frontend_detach;
|
2008-04-22 17:45:15 +00:00
|
|
|
break;
|
2005-04-16 22:20:36 +00:00
|
|
|
case CX88_BOARD_PCHDTV_HD3000:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(or51132_attach, &pchdtv_hd3000,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_THOMSON_DTT761X))
|
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2005-07-08 00:58:39 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_3_GOLD_Q:
|
|
|
|
dev->ts_gen_cntrl = 0x08;
|
|
|
|
|
2008-04-30 21:14:36 +00:00
|
|
|
/* Do a hardware reset of chip before using it. */
|
2005-07-08 00:58:39 +00:00
|
|
|
cx_clear(MO_GP0_IO, 1);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(100);
|
2005-07-27 18:45:55 +00:00
|
|
|
cx_set(MO_GP0_IO, 1);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(200);
|
2005-07-27 18:45:55 +00:00
|
|
|
|
|
|
|
/* Select RF connector callback */
|
2005-07-27 18:46:00 +00:00
|
|
|
fusionhdtv_3_gold.pll_rf_set = lgdt330x_pll_rf_set;
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(lgdt330x_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&fusionhdtv_3_gold,
|
2018-03-09 15:53:30 +00:00
|
|
|
0x0e,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_MICROTUNE_4042FI5))
|
|
|
|
goto frontend_detach;
|
2005-07-08 00:58:39 +00:00
|
|
|
}
|
|
|
|
break;
|
2005-07-08 00:58:42 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_3_GOLD_T:
|
|
|
|
dev->ts_gen_cntrl = 0x08;
|
|
|
|
|
2008-04-30 21:14:36 +00:00
|
|
|
/* Do a hardware reset of chip before using it. */
|
2005-07-08 00:58:42 +00:00
|
|
|
cx_clear(MO_GP0_IO, 1);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(100);
|
2005-07-27 18:45:56 +00:00
|
|
|
cx_set(MO_GP0_IO, 9);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(200);
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(lgdt330x_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&fusionhdtv_3_gold,
|
2018-03-09 15:53:30 +00:00
|
|
|
0x0e,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_THOMSON_DTT761X))
|
|
|
|
goto frontend_detach;
|
2005-07-08 00:58:42 +00:00
|
|
|
}
|
|
|
|
break;
|
2005-09-09 20:03:41 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_5_GOLD:
|
|
|
|
dev->ts_gen_cntrl = 0x08;
|
|
|
|
|
2008-04-30 21:14:36 +00:00
|
|
|
/* Do a hardware reset of chip before using it. */
|
2005-09-09 20:03:41 +00:00
|
|
|
cx_clear(MO_GP0_IO, 1);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(100);
|
2005-09-09 20:03:41 +00:00
|
|
|
cx_set(MO_GP0_IO, 1);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(200);
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(lgdt330x_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&fusionhdtv_5_gold,
|
2018-03-09 15:53:30 +00:00
|
|
|
0x0e,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_LG_TDVS_H06XF))
|
|
|
|
goto frontend_detach;
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(tda9887_attach, fe0->dvb.frontend,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&core->i2c_adap, 0x43))
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
2005-09-09 20:03:41 +00:00
|
|
|
}
|
|
|
|
break;
|
2006-04-07 05:21:31 +00:00
|
|
|
case CX88_BOARD_PCHDTV_HD5500:
|
|
|
|
dev->ts_gen_cntrl = 0x08;
|
|
|
|
|
2008-04-30 21:14:36 +00:00
|
|
|
/* Do a hardware reset of chip before using it. */
|
2006-04-07 05:21:31 +00:00
|
|
|
cx_clear(MO_GP0_IO, 1);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(100);
|
2006-04-07 05:21:31 +00:00
|
|
|
cx_set(MO_GP0_IO, 1);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(200);
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(lgdt330x_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&pchdtv_hd5500,
|
2018-03-09 15:53:30 +00:00
|
|
|
0x59,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_LG_TDVS_H06XF))
|
|
|
|
goto frontend_detach;
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(tda9887_attach, fe0->dvb.frontend,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&core->i2c_adap, 0x43))
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
2006-04-07 05:21:31 +00:00
|
|
|
}
|
|
|
|
break;
|
2005-11-09 05:38:18 +00:00
|
|
|
case CX88_BOARD_ATI_HDTVWONDER:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(nxt200x_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&ati_hdtvwonder,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap, 0x61,
|
|
|
|
TUNER_PHILIPS_TUV1236D))
|
|
|
|
goto frontend_detach;
|
2006-04-18 20:56:10 +00:00
|
|
|
}
|
2006-01-09 17:25:02 +00:00
|
|
|
break;
|
|
|
|
case CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1:
|
|
|
|
case CX88_BOARD_HAUPPAUGE_NOVASE2_S1:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx24123_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&hauppauge_novas_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2013-04-05 15:18:54 +00:00
|
|
|
bool override_tone;
|
|
|
|
|
|
|
|
if (core->model == 92001)
|
|
|
|
override_tone = true;
|
|
|
|
else
|
|
|
|
override_tone = false;
|
|
|
|
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(isl6421_attach, fe0->dvb.frontend,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&core->i2c_adap, 0x08, ISL6421_DCL,
|
|
|
|
0x00, override_tone))
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
2006-05-12 23:31:51 +00:00
|
|
|
}
|
2006-01-09 17:25:02 +00:00
|
|
|
break;
|
|
|
|
case CX88_BOARD_KWORLD_DVBS_100:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx24123_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&kworld_dvbs_100_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
|
|
|
core->prev_set_voltage = fe0->dvb.frontend->ops.set_voltage;
|
|
|
|
fe0->dvb.frontend->ops.set_voltage = kworld_dvbs_100_set_voltage;
|
2006-05-12 23:31:51 +00:00
|
|
|
}
|
2005-11-09 05:38:18 +00:00
|
|
|
break;
|
2006-06-29 23:29:33 +00:00
|
|
|
case CX88_BOARD_GENIATECH_DVBS:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx24123_attach,
|
2006-08-08 18:48:08 +00:00
|
|
|
&geniatech_dvbs_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
|
|
|
core->prev_set_voltage = fe0->dvb.frontend->ops.set_voltage;
|
|
|
|
fe0->dvb.frontend->ops.set_voltage = geniatech_dvbs_set_voltage;
|
2006-06-29 23:29:33 +00:00
|
|
|
}
|
|
|
|
break;
|
2008-01-05 19:53:01 +00:00
|
|
|
case CX88_BOARD_PINNACLE_PCTV_HD_800i:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(s5h1409_attach,
|
2008-01-05 19:53:01 +00:00
|
|
|
&pinnacle_pctv_hd_800i_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(xc5000_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap,
|
2008-09-06 17:56:58 +00:00
|
|
|
&pinnacle_pctv_hd_800i_tuner_config))
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
2008-01-05 19:53:01 +00:00
|
|
|
}
|
|
|
|
break;
|
2008-04-22 17:45:14 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_5_PCI_NANO:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(s5h1409_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&dvico_hdtv5_pci_nano_config,
|
|
|
|
&core->i2c_adap);
|
|
|
|
if (fe0->dvb.frontend) {
|
2008-04-22 17:45:14 +00:00
|
|
|
struct dvb_frontend *fe;
|
|
|
|
struct xc2028_config cfg = {
|
2008-04-30 21:14:36 +00:00
|
|
|
.i2c_adap = &core->i2c_adap,
|
2008-04-22 17:45:14 +00:00
|
|
|
.i2c_addr = 0x61,
|
|
|
|
};
|
|
|
|
static struct xc2028_ctrl ctl = {
|
2008-09-16 05:15:30 +00:00
|
|
|
.fname = XC2028_DEFAULT_FIRMWARE,
|
2008-04-22 17:45:14 +00:00
|
|
|
.max_len = 64,
|
2008-04-21 09:58:48 +00:00
|
|
|
.scode_table = XC3028_FE_OREN538,
|
2008-04-22 17:45:14 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
fe = dvb_attach(xc2028_attach,
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend, &cfg);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe && fe->ops.tuner_ops.set_config)
|
2008-04-22 17:45:14 +00:00
|
|
|
fe->ops.tuner_ops.set_config(fe, &ctl);
|
|
|
|
}
|
|
|
|
break;
|
2010-04-06 05:40:43 +00:00
|
|
|
case CX88_BOARD_PINNACLE_HYBRID_PCTV:
|
2009-05-31 19:47:28 +00:00
|
|
|
case CX88_BOARD_WINFAST_DTV1800H:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(zl10353_attach,
|
2008-09-05 17:33:54 +00:00
|
|
|
&cx88_pinnacle_hybrid_pctv,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
|
|
|
fe0->dvb.frontend->ops.i2c_gate_ctrl = NULL;
|
2008-09-05 17:33:54 +00:00
|
|
|
if (attach_xc3028(0x61, dev) < 0)
|
|
|
|
goto frontend_detach;
|
|
|
|
}
|
2008-04-22 17:45:15 +00:00
|
|
|
break;
|
2011-06-07 16:16:56 +00:00
|
|
|
case CX88_BOARD_WINFAST_DTV1800H_XC4000:
|
2011-06-07 16:14:53 +00:00
|
|
|
case CX88_BOARD_WINFAST_DTV2000H_PLUS:
|
|
|
|
fe0->dvb.frontend = dvb_attach(zl10353_attach,
|
|
|
|
&cx88_pinnacle_hybrid_pctv,
|
|
|
|
&core->i2c_adap);
|
|
|
|
if (fe0->dvb.frontend) {
|
|
|
|
struct xc4000_config cfg = {
|
|
|
|
.i2c_address = 0x61,
|
|
|
|
.default_pm = 0,
|
|
|
|
.dvb_amplitude = 134,
|
|
|
|
.set_smoothedcvbs = 1,
|
|
|
|
.if_khz = 4560
|
|
|
|
};
|
|
|
|
fe0->dvb.frontend->ops.i2c_gate_ctrl = NULL;
|
|
|
|
if (attach_xc4000(dev, &cfg) < 0)
|
|
|
|
goto frontend_detach;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case CX88_BOARD_GENIATECH_X8000_MT:
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
dev->ts_gen_cntrl = 0x00;
|
2008-04-22 17:45:15 +00:00
|
|
|
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(zl10353_attach,
|
2008-04-22 17:45:15 +00:00
|
|
|
&cx88_geniatech_x8000_mt,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
2008-04-22 17:45:30 +00:00
|
|
|
if (attach_xc3028(0x61, dev) < 0)
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
2008-04-22 17:45:15 +00:00
|
|
|
break;
|
2016-11-16 08:59:49 +00:00
|
|
|
case CX88_BOARD_KWORLD_ATSC_120:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(s5h1409_attach,
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
&kworld_atsc_120_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
if (attach_xc3028(0x61, dev) < 0)
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
V4L/DVB (7448): Add support for Kworld ATSC 120
This board has a s5h1409 demod, plus a xc30x8 tuner (probably, xc3018).
This patch adds proper support for radio, video, s-video, composite and ATSC.
However, support for radio and video depends on having s5h1409 i2c gate open,
otherwise, xc30x8 chip won't be visible.
For a better support, some rework is needed on cx88 driver, to allow adding
xc30x8 to i2c bus without sending i2c 0 byte reading to 0xc2 address.
Thanks to Vanessa Ezekowitz <vanessaezekowitz@gmail.com> for helping to figure
out the proper parameters for s5h1409 and the GPIO pins used by each
configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-03-28 02:18:30 +00:00
|
|
|
break;
|
2008-04-25 06:46:43 +00:00
|
|
|
case CX88_BOARD_DVICO_FUSIONHDTV_7_GOLD:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(s5h1411_attach,
|
2008-04-25 06:46:43 +00:00
|
|
|
&dvico_fusionhdtv7_config,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(xc5000_attach, fe0->dvb.frontend,
|
2008-04-30 21:14:36 +00:00
|
|
|
&core->i2c_adap,
|
2008-09-06 17:56:58 +00:00
|
|
|
&dvico_fusionhdtv7_tuner_config))
|
2008-04-30 21:14:36 +00:00
|
|
|
goto frontend_detach;
|
2008-04-25 06:46:43 +00:00
|
|
|
}
|
|
|
|
break;
|
2008-09-04 04:17:33 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR4000:
|
2008-11-11 11:48:27 +00:00
|
|
|
/* MFE frontend 1 */
|
|
|
|
mfe_shared = 1;
|
|
|
|
dev->frontends.gate = 2;
|
2008-10-11 14:05:50 +00:00
|
|
|
/* DVB-S/S2 Init */
|
|
|
|
fe0->dvb.frontend = dvb_attach(cx24116_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&hauppauge_hvr4000_config,
|
|
|
|
&dev->core->i2c_adap);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-11-11 11:48:27 +00:00
|
|
|
if (!dvb_attach(isl6421_attach,
|
|
|
|
fe0->dvb.frontend,
|
|
|
|
&dev->core->i2c_adap,
|
2013-04-05 15:18:54 +00:00
|
|
|
0x08, ISL6421_DCL, 0x00, false))
|
2008-11-11 11:48:27 +00:00
|
|
|
goto frontend_detach;
|
2008-10-11 14:05:50 +00:00
|
|
|
}
|
2008-11-11 11:48:27 +00:00
|
|
|
/* MFE frontend 2 */
|
2014-09-20 12:22:18 +00:00
|
|
|
fe1 = vb2_dvb_get_frontend(&dev->frontends, 2);
|
2008-11-11 11:48:27 +00:00
|
|
|
if (!fe1)
|
|
|
|
goto frontend_detach;
|
|
|
|
/* DVB-T Init */
|
|
|
|
fe1->dvb.frontend = dvb_attach(cx22702_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&hauppauge_hvr_config,
|
|
|
|
&dev->core->i2c_adap);
|
2008-11-11 11:48:27 +00:00
|
|
|
if (fe1->dvb.frontend) {
|
|
|
|
fe1->dvb.frontend->id = 1;
|
|
|
|
if (!dvb_attach(simple_tuner_attach,
|
|
|
|
fe1->dvb.frontend,
|
|
|
|
&dev->core->i2c_adap,
|
|
|
|
0x61, TUNER_PHILIPS_FMD1216ME_MK3))
|
|
|
|
goto frontend_detach;
|
2008-10-11 14:05:50 +00:00
|
|
|
}
|
|
|
|
break;
|
2008-09-04 04:17:33 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR4000LITE:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx24116_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&hauppauge_hvr4000_config,
|
|
|
|
&dev->core->i2c_adap);
|
2008-10-11 14:05:50 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-11-11 11:48:27 +00:00
|
|
|
if (!dvb_attach(isl6421_attach,
|
|
|
|
fe0->dvb.frontend,
|
|
|
|
&dev->core->i2c_adap,
|
2013-04-05 15:18:54 +00:00
|
|
|
0x08, ISL6421_DCL, 0x00, false))
|
2008-11-11 11:48:27 +00:00
|
|
|
goto frontend_detach;
|
2008-09-04 04:17:33 +00:00
|
|
|
}
|
|
|
|
break;
|
2008-11-09 18:26:25 +00:00
|
|
|
case CX88_BOARD_PROF_6200:
|
2008-11-09 18:25:31 +00:00
|
|
|
case CX88_BOARD_TBS_8910:
|
2008-09-23 18:43:57 +00:00
|
|
|
case CX88_BOARD_TEVII_S420:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(stv0299_attach,
|
2008-09-23 18:43:57 +00:00
|
|
|
&tevii_tuner_sharp_config,
|
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2008-10-11 14:05:50 +00:00
|
|
|
if (!dvb_attach(dvb_pll_attach, fe0->dvb.frontend, 0x60,
|
2008-09-23 18:43:57 +00:00
|
|
|
&core->i2c_adap, DVB_PLL_OPERA1))
|
|
|
|
goto frontend_detach;
|
2008-10-11 14:05:50 +00:00
|
|
|
core->prev_set_voltage = fe0->dvb.frontend->ops.set_voltage;
|
|
|
|
fe0->dvb.frontend->ops.set_voltage = tevii_dvbs_set_voltage;
|
2008-09-23 18:43:57 +00:00
|
|
|
|
|
|
|
} else {
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(stv0288_attach,
|
2008-09-23 18:43:57 +00:00
|
|
|
&tevii_tuner_earda_config,
|
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
|
|
|
if (!dvb_attach(stb6000_attach,
|
|
|
|
fe0->dvb.frontend, 0x61,
|
2008-09-23 18:43:57 +00:00
|
|
|
&core->i2c_adap))
|
|
|
|
goto frontend_detach;
|
2008-10-11 14:05:50 +00:00
|
|
|
core->prev_set_voltage = fe0->dvb.frontend->ops.set_voltage;
|
|
|
|
fe0->dvb.frontend->ops.set_voltage = tevii_dvbs_set_voltage;
|
2008-09-23 18:43:57 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
break;
|
2008-09-04 20:24:14 +00:00
|
|
|
case CX88_BOARD_TEVII_S460:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx24116_attach,
|
2008-09-04 20:24:14 +00:00
|
|
|
&tevii_s460_config,
|
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend)
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend->ops.set_voltage = tevii_dvbs_set_voltage;
|
2008-09-17 14:30:21 +00:00
|
|
|
break;
|
2011-02-25 21:41:24 +00:00
|
|
|
case CX88_BOARD_TEVII_S464:
|
|
|
|
fe0->dvb.frontend = dvb_attach(ds3000_attach,
|
|
|
|
&tevii_ds3000_config,
|
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
2012-12-23 22:25:38 +00:00
|
|
|
dvb_attach(ts2020_attach, fe0->dvb.frontend,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&tevii_ts2020_config, &core->i2c_adap);
|
2011-02-25 21:41:24 +00:00
|
|
|
fe0->dvb.frontend->ops.set_voltage =
|
|
|
|
tevii_dvbs_set_voltage;
|
2012-12-23 22:25:38 +00:00
|
|
|
}
|
2011-02-25 21:41:24 +00:00
|
|
|
break;
|
2008-09-17 14:30:21 +00:00
|
|
|
case CX88_BOARD_OMICOM_SS4_PCI:
|
2008-09-17 14:58:33 +00:00
|
|
|
case CX88_BOARD_TBS_8920:
|
2008-10-08 09:48:08 +00:00
|
|
|
case CX88_BOARD_PROF_7300:
|
2008-11-09 18:25:31 +00:00
|
|
|
case CX88_BOARD_SATTRADE_ST4200:
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend = dvb_attach(cx24116_attach,
|
2008-09-17 14:58:33 +00:00
|
|
|
&hauppauge_hvr4000_config,
|
|
|
|
&core->i2c_adap);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (fe0->dvb.frontend)
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend->ops.set_voltage = tevii_dvbs_set_voltage;
|
2008-09-04 20:24:14 +00:00
|
|
|
break;
|
2009-03-10 22:08:06 +00:00
|
|
|
case CX88_BOARD_TERRATEC_CINERGY_HT_PCI_MKII:
|
|
|
|
fe0->dvb.frontend = dvb_attach(zl10353_attach,
|
|
|
|
&cx88_terratec_cinergy_ht_pci_mkii_config,
|
|
|
|
&core->i2c_adap);
|
|
|
|
if (fe0->dvb.frontend) {
|
|
|
|
fe0->dvb.frontend->ops.i2c_gate_ctrl = NULL;
|
|
|
|
if (attach_xc3028(0x61, dev) < 0)
|
|
|
|
goto frontend_detach;
|
|
|
|
}
|
|
|
|
break;
|
2009-11-17 01:22:32 +00:00
|
|
|
case CX88_BOARD_PROF_7301:{
|
|
|
|
struct dvb_tuner_ops *tuner_ops = NULL;
|
|
|
|
|
|
|
|
fe0->dvb.frontend = dvb_attach(stv0900_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&prof_7301_stv0900_config,
|
|
|
|
&core->i2c_adap, 0);
|
|
|
|
if (fe0->dvb.frontend) {
|
2009-11-17 01:22:32 +00:00
|
|
|
if (!dvb_attach(stb6100_attach, fe0->dvb.frontend,
|
|
|
|
&prof_7301_stb6100_config,
|
|
|
|
&core->i2c_adap))
|
|
|
|
goto frontend_detach;
|
|
|
|
|
|
|
|
tuner_ops = &fe0->dvb.frontend->ops.tuner_ops;
|
|
|
|
tuner_ops->set_frequency = stb6100_set_freq;
|
|
|
|
tuner_ops->get_frequency = stb6100_get_freq;
|
|
|
|
tuner_ops->set_bandwidth = stb6100_set_bandw;
|
|
|
|
tuner_ops->get_bandwidth = stb6100_get_bandw;
|
|
|
|
|
|
|
|
core->prev_set_voltage =
|
|
|
|
fe0->dvb.frontend->ops.set_voltage;
|
|
|
|
fe0->dvb.frontend->ops.set_voltage =
|
|
|
|
tevii_dvbs_set_voltage;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2010-02-11 21:06:34 +00:00
|
|
|
case CX88_BOARD_SAMSUNG_SMT_7020:
|
|
|
|
dev->ts_gen_cntrl = 0x08;
|
|
|
|
|
|
|
|
cx_set(MO_GP0_IO, 0x0101);
|
|
|
|
|
|
|
|
cx_clear(MO_GP0_IO, 0x01);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(100);
|
2010-02-11 21:06:34 +00:00
|
|
|
cx_set(MO_GP0_IO, 0x01);
|
2018-07-27 03:41:50 +00:00
|
|
|
msleep(200);
|
2010-02-11 21:06:34 +00:00
|
|
|
|
|
|
|
fe0->dvb.frontend = dvb_attach(stv0299_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&samsung_stv0299_config,
|
|
|
|
&dev->core->i2c_adap);
|
2010-02-11 21:06:34 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
|
|
|
fe0->dvb.frontend->ops.tuner_ops.set_params =
|
|
|
|
samsung_smt_7020_tuner_set_params;
|
|
|
|
fe0->dvb.frontend->tuner_priv =
|
|
|
|
&dev->core->i2c_adap;
|
|
|
|
fe0->dvb.frontend->ops.set_voltage =
|
|
|
|
samsung_smt_7020_set_voltage;
|
|
|
|
fe0->dvb.frontend->ops.set_tone =
|
|
|
|
samsung_smt_7020_set_tone;
|
|
|
|
}
|
|
|
|
|
|
|
|
break;
|
2010-08-09 13:18:32 +00:00
|
|
|
case CX88_BOARD_TWINHAN_VP1027_DVBS:
|
|
|
|
dev->ts_gen_cntrl = 0x00;
|
|
|
|
fe0->dvb.frontend = dvb_attach(mb86a16_attach,
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
&twinhan_vp1027,
|
|
|
|
&core->i2c_adap);
|
2010-08-09 13:18:32 +00:00
|
|
|
if (fe0->dvb.frontend) {
|
|
|
|
core->prev_set_voltage =
|
|
|
|
fe0->dvb.frontend->ops.set_voltage;
|
|
|
|
fe0->dvb.frontend->ops.set_voltage =
|
|
|
|
vp1027_set_voltage;
|
|
|
|
}
|
|
|
|
break;
|
2010-02-11 21:06:34 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
default:
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("The frontend of your DVB/ATSC card isn't supported yet\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
2008-10-11 14:05:50 +00:00
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
if ((NULL == fe0->dvb.frontend) || (fe1 && NULL == fe1->dvb.frontend)) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("frontend initialization failed\n");
|
2008-11-11 11:48:27 +00:00
|
|
|
goto frontend_detach;
|
2008-04-22 17:45:15 +00:00
|
|
|
}
|
2008-09-12 16:31:45 +00:00
|
|
|
/* define general-purpose callback pointer */
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend->callback = cx88_tuner_callback;
|
2008-04-22 17:45:15 +00:00
|
|
|
|
2006-12-02 23:15:51 +00:00
|
|
|
/* Ensure all frontends negotiate bus access */
|
2008-10-11 14:05:50 +00:00
|
|
|
fe0->dvb.frontend->ops.ts_bus_ctrl = cx88_dvb_bus_ctrl;
|
|
|
|
if (fe1)
|
|
|
|
fe1->dvb.frontend->ops.ts_bus_ctrl = cx88_dvb_bus_ctrl;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
media: add tuner standby op, use where needed
The v4l2_subdev core s_power op was used for two different things: power on/off
sensors or video decoders/encoders and to put a tuner in standby (and only the
tuner!). There is no 'tuner wakeup' op, that's done automatically when the tuner
is accessed.
The danger with calling (s_power, 0) to put a tuner into standby is that it is
usually broadcast for all subdevs. So a video receiver subdev that supports
s_power will also be powered off, and since there is no corresponding (s_power, 1)
they will never be powered on again.
In addition, this is specifically meant for tuners only since they draw the most
current.
This patch adds a new tuner op called 'standby' and replaces all calls to
(core, s_power, 0) by (tuner, standby). This prevents confusion between the two
uses of s_power. Note that there is no overlap: bridge drivers either just want
to put the tuner into standby, or they deal with powering on/off sensors. Never
both.
This also makes it easier to replace s_power for the remaining bridge drivers
with some PM code later.
Whether we want something cleaner for tuners in the future is a separate topic.
There is a lot of legacy code surrounding tuners, and I am very hesitant about
making changes there.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2018-02-21 07:49:25 +00:00
|
|
|
/* Put the tuner in standby to keep it quiet */
|
|
|
|
call_all(core, tuner, standby);
|
2005-09-13 08:25:42 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* register everything */
|
2014-09-20 12:22:18 +00:00
|
|
|
res = vb2_dvb_register_bus(&dev->frontends, THIS_MODULE, dev,
|
2016-02-05 10:35:50 +00:00
|
|
|
&dev->pci->dev, NULL, adapter_nr,
|
|
|
|
mfe_shared);
|
2011-12-15 04:59:20 +00:00
|
|
|
if (res)
|
|
|
|
goto frontend_detach;
|
|
|
|
return res;
|
2008-04-30 21:14:36 +00:00
|
|
|
|
|
|
|
frontend_detach:
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
core->gate_ctrl = NULL;
|
2014-09-20 12:22:18 +00:00
|
|
|
vb2_dvb_dealloc_frontends(&dev->frontends);
|
2011-12-15 04:59:20 +00:00
|
|
|
return res;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* ----------------------------------------------------------- */
|
|
|
|
|
2006-12-02 23:15:51 +00:00
|
|
|
/* CX8802 MPEG -> mini driver - We have been given the hardware */
|
|
|
|
static int cx8802_dvb_advise_acquire(struct cx8802_driver *drv)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-12-02 23:15:51 +00:00
|
|
|
struct cx88_core *core = drv->core;
|
|
|
|
int err = 0;
|
2016-11-16 08:59:49 +00:00
|
|
|
|
|
|
|
dprintk(1, "%s\n", __func__);
|
2006-12-02 23:15:51 +00:00
|
|
|
|
2007-08-15 17:41:57 +00:00
|
|
|
switch (core->boardnr) {
|
2006-12-02 23:15:51 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR1300:
|
|
|
|
/* We arrive here with either the cx23416 or the cx22702
|
|
|
|
* on the bus. Take the bus from the cx23416 and enable the
|
|
|
|
* cx22702 demod
|
|
|
|
*/
|
2008-12-18 09:28:35 +00:00
|
|
|
/* Toggle reset on cx22702 leaving i2c active */
|
|
|
|
cx_set(MO_GP0_IO, 0x00000080);
|
|
|
|
udelay(1000);
|
|
|
|
cx_clear(MO_GP0_IO, 0x00000080);
|
|
|
|
udelay(50);
|
|
|
|
cx_set(MO_GP0_IO, 0x00000080);
|
|
|
|
udelay(1000);
|
|
|
|
/* enable the cx22702 pins */
|
2006-12-02 23:15:51 +00:00
|
|
|
cx_clear(MO_GP0_IO, 0x00000004);
|
|
|
|
udelay(1000);
|
|
|
|
break;
|
2008-10-11 14:05:50 +00:00
|
|
|
|
2008-10-11 14:18:53 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR3000:
|
2008-10-11 14:05:50 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR4000:
|
2008-12-18 09:28:35 +00:00
|
|
|
/* Toggle reset on cx22702 leaving i2c active */
|
|
|
|
cx_set(MO_GP0_IO, 0x00000080);
|
|
|
|
udelay(1000);
|
|
|
|
cx_clear(MO_GP0_IO, 0x00000080);
|
|
|
|
udelay(50);
|
|
|
|
cx_set(MO_GP0_IO, 0x00000080);
|
|
|
|
udelay(1000);
|
|
|
|
switch (core->dvbdev->frontends.active_fe_id) {
|
|
|
|
case 1: /* DVB-S/S2 Enabled */
|
|
|
|
/* tri-state the cx22702 pins */
|
|
|
|
cx_set(MO_GP0_IO, 0x00000004);
|
|
|
|
/* Take the cx24116/cx24123 out of reset */
|
|
|
|
cx_write(MO_SRST_IO, 1);
|
2008-10-11 14:05:50 +00:00
|
|
|
core->dvbdev->ts_gen_cntrl = 0x02; /* Parallel IO */
|
2008-12-18 09:28:35 +00:00
|
|
|
break;
|
|
|
|
case 2: /* DVB-T Enabled */
|
2008-10-11 14:05:50 +00:00
|
|
|
/* Put the cx24116/cx24123 into reset */
|
|
|
|
cx_write(MO_SRST_IO, 0);
|
2008-12-18 09:28:35 +00:00
|
|
|
/* enable the cx22702 pins */
|
2008-10-11 14:05:50 +00:00
|
|
|
cx_clear(MO_GP0_IO, 0x00000004);
|
|
|
|
core->dvbdev->ts_gen_cntrl = 0x0c; /* Serial IO */
|
2008-12-18 09:28:35 +00:00
|
|
|
break;
|
2008-10-11 14:05:50 +00:00
|
|
|
}
|
2008-12-18 09:28:35 +00:00
|
|
|
udelay(1000);
|
2008-10-11 14:05:50 +00:00
|
|
|
break;
|
|
|
|
|
2011-06-07 16:14:53 +00:00
|
|
|
case CX88_BOARD_WINFAST_DTV2000H_PLUS:
|
|
|
|
/* set RF input to AIR for DVB-T (GPIO 16) */
|
|
|
|
cx_write(MO_GP2_IO, 0x0101);
|
|
|
|
break;
|
|
|
|
|
2006-12-02 23:15:51 +00:00
|
|
|
default:
|
|
|
|
err = -ENODEV;
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* CX8802 MPEG -> mini driver - We no longer have the hardware */
|
|
|
|
static int cx8802_dvb_advise_release(struct cx8802_driver *drv)
|
|
|
|
{
|
|
|
|
struct cx88_core *core = drv->core;
|
|
|
|
int err = 0;
|
2016-11-16 08:59:49 +00:00
|
|
|
|
|
|
|
dprintk(1, "%s\n", __func__);
|
2006-12-02 23:15:51 +00:00
|
|
|
|
2007-08-15 17:41:57 +00:00
|
|
|
switch (core->boardnr) {
|
2006-12-02 23:15:51 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR1300:
|
|
|
|
/* Do Nothing, leave the cx22702 on the bus. */
|
|
|
|
break;
|
2008-10-11 14:05:50 +00:00
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR3000:
|
|
|
|
case CX88_BOARD_HAUPPAUGE_HVR4000:
|
|
|
|
break;
|
2006-12-02 23:15:51 +00:00
|
|
|
default:
|
|
|
|
err = -ENODEV;
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int cx8802_dvb_probe(struct cx8802_driver *drv)
|
|
|
|
{
|
|
|
|
struct cx88_core *core = drv->core;
|
|
|
|
struct cx8802_dev *dev = drv->core->dvbdev;
|
2008-10-30 08:07:44 +00:00
|
|
|
int err;
|
2014-09-20 12:22:18 +00:00
|
|
|
struct vb2_dvb_frontend *fe;
|
2009-01-12 00:18:04 +00:00
|
|
|
int i;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
dprintk(1, "%s\n", __func__);
|
|
|
|
dprintk(1, " ->being probed by Card=%d Name=%s, PCI %02x:%02x\n",
|
2007-08-15 17:41:57 +00:00
|
|
|
core->boardnr,
|
2006-12-02 23:15:51 +00:00
|
|
|
core->name,
|
|
|
|
core->pci_bus,
|
|
|
|
core->pci_slot);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
err = -ENODEV;
|
2007-08-15 17:41:57 +00:00
|
|
|
if (!(core->board.mpeg & CX88_MPEG_DVB))
|
2005-04-16 22:20:36 +00:00
|
|
|
goto fail_core;
|
|
|
|
|
2007-05-05 23:11:32 +00:00
|
|
|
/* If vp3054 isn't enabled, a stub will just return 0 */
|
2006-01-09 17:25:35 +00:00
|
|
|
err = vp3054_i2c_probe(dev);
|
2016-11-16 08:59:49 +00:00
|
|
|
if (err != 0)
|
2009-01-12 00:18:04 +00:00
|
|
|
goto fail_core;
|
2006-01-09 17:25:35 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* dvb stuff */
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_info("cx2388x based DVB/ATSC card\n");
|
2008-10-11 14:05:50 +00:00
|
|
|
dev->ts_gen_cntrl = 0x0c;
|
|
|
|
|
2009-01-12 00:18:04 +00:00
|
|
|
err = cx8802_alloc_frontends(dev);
|
|
|
|
if (err)
|
|
|
|
goto fail_core;
|
|
|
|
|
|
|
|
for (i = 1; i <= core->board.num_frontends; i++) {
|
2014-09-20 12:22:18 +00:00
|
|
|
struct vb2_queue *q;
|
|
|
|
|
|
|
|
fe = vb2_dvb_get_frontend(&core->dvbdev->frontends, i);
|
[media] cx88: make checkpatch.pl happy
Usually, I don't like fixing coding style issues on non-staging
drivers, as it could be a mess pretty easy, and could become like
a snow ball. That's the case of recent changes on two changesets:
they disalign some statements. Yet, a care a lot with cx88 driver,
as it was the first driver I touched at the Kernel, and I've been
maintaining it since 2005. So, several of the coding style issues
were due to my code.
Per Andrey's suggestion, I ran checkpatch.pl in strict mode, with
fixed several other issues, did some function alinments, but broke
other alinments.
So, I had to manually apply another round of manual fixes to make
sure that everything is ok, and to make checkpatch happy with
this patch.
With this patch, checkpatch.pl is now happy when called with:
./scripts/checkpatch.pl -f --max-line-length=998 --ignore PREFER_PR_LEVEL
Also, the 80-cols violations that made sense were fixed.
Checkpatch would be happier if we convert it to use dev_foo(),
but this is a more complex change.
NOTE: there are some places with msleep(1). As this driver was
written at the time that the default was to sleep at least 10ms
on such calls (e. g. CONFIG_HZ=100), I replaced those calls by
usleep_range(10000, 20000), with should be safe to avoid breakages.
Fixes: 65bc2fe86e66 ("[media] cx88: convert it to use pr_foo() macros")
Fixes: 7b61ba8ff838 ("[media] cx88: make checkpatch happier")
Suggested-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Reviewed-by: Andrey Utkin <andrey_utkin@fastmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-11-19 21:27:30 +00:00
|
|
|
if (!fe) {
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("%s() failed to get frontend(%d)\n",
|
|
|
|
__func__, i);
|
2016-09-21 15:12:58 +00:00
|
|
|
err = -ENODEV;
|
2009-01-12 00:18:04 +00:00
|
|
|
goto fail_probe;
|
|
|
|
}
|
2014-09-20 12:22:18 +00:00
|
|
|
q = &fe->dvb.dvbq;
|
|
|
|
q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
|
|
|
|
q->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF | VB2_READ;
|
|
|
|
q->gfp_flags = GFP_DMA32;
|
|
|
|
q->min_buffers_needed = 2;
|
|
|
|
q->drv_priv = dev;
|
|
|
|
q->buf_struct_size = sizeof(struct cx88_buffer);
|
|
|
|
q->ops = &dvb_qops;
|
|
|
|
q->mem_ops = &vb2_dma_sg_memops;
|
|
|
|
q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
|
|
|
|
q->lock = &core->lock;
|
2016-02-15 14:37:15 +00:00
|
|
|
q->dev = &dev->pci->dev;
|
2014-09-20 12:22:18 +00:00
|
|
|
|
|
|
|
err = vb2_queue_init(q);
|
|
|
|
if (err < 0)
|
|
|
|
goto fail_probe;
|
|
|
|
|
|
|
|
/* init struct vb2_dvb */
|
2009-01-12 00:18:04 +00:00
|
|
|
fe->dvb.name = dev->core->name;
|
2008-10-11 14:05:50 +00:00
|
|
|
}
|
2009-01-12 00:18:04 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
err = dvb_register(dev);
|
2008-10-30 08:07:44 +00:00
|
|
|
if (err)
|
|
|
|
/* frontends/adapter de-allocated in dvb_register */
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_err("dvb_register failed (err = %d)\n", err);
|
2008-10-30 08:07:44 +00:00
|
|
|
return err;
|
|
|
|
fail_probe:
|
2014-09-20 12:22:18 +00:00
|
|
|
vb2_dvb_dealloc_frontends(&core->dvbdev->frontends);
|
2008-10-11 14:18:53 +00:00
|
|
|
fail_core:
|
2005-04-16 22:20:36 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2006-12-02 23:15:51 +00:00
|
|
|
static int cx8802_dvb_remove(struct cx8802_driver *drv)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-10-21 14:18:47 +00:00
|
|
|
struct cx88_core *core = drv->core;
|
2006-12-02 23:15:51 +00:00
|
|
|
struct cx8802_dev *dev = drv->core->dvbdev;
|
2006-01-09 17:25:12 +00:00
|
|
|
|
2016-11-16 08:59:49 +00:00
|
|
|
dprintk(1, "%s\n", __func__);
|
2008-10-21 14:18:47 +00:00
|
|
|
|
2014-09-20 12:22:18 +00:00
|
|
|
vb2_dvb_unregister_bus(&dev->frontends);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-01-09 17:25:35 +00:00
|
|
|
vp3054_i2c_remove(dev);
|
|
|
|
|
V4L/DVB (10190): cx88: Fix some Kbuild troubles
As Randy Dunlap <randy.dunlap@oracle.com> reported, cx88 has some compilation issues:
drivers/built-in.o: In function `cx88_call_i2c_clients':
(.text+0x20af17): undefined reference to `videobuf_dvb_get_frontend'
drivers/built-in.o: In function `cx8802_probe':
cx88-mpeg.c:(.devinit.text+0x268c4): undefined reference to `videobuf_dvb_alloc_frontend'
cx88-mpeg.c:(.devinit.text+0x268ea): undefined reference to `videobuf_dvb_dealloc_frontends'
With those configs:
CONFIG_VIDEO_CX88=y
CONFIG_VIDEO_CX88_BLACKBIRD=y
CONFIG_VIDEO_CX88_DVB=m
CONFIG_DVB_CORE=m
After carefully examining the code, with the current code, several cx88 drivers
(cx8800, cx8802, cx88_dvb and cx88_blackbird) should be compiled as a module,
if one of them is marked as such. Just fixing Kconfig could create a very complex
set of rules. Also, this hides a problem with the current approach where the dvb
functionality weren't confined inside dvb module.
What happens is that:
- cx88-i2c (part of cx8800) has some special rules if DVB;
- cx88-mpeg (cx8802 module) has also part of DVB init code;
- cx88-dvb has the rest of the dvb code;
- cx88-blackbird can be used with cx88-mpeg, having cx88-dvb or not.
So, instead of doing some tricks at Kconfig and wait for a next breakage,
this patch moves the dvb code inside cx88-i2c and cx88-mpeg into cx88-dvb.
Another problem is that cx8802 were being compiled, even without cx88-dvb
and cx88-blackbird modules.
While on this code, let's fix also a reported problem:
http://www.linuxtv.org/pipermail/linux-dvb/2009-January/031225.html
A solution for the issue were proposed here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg00021.html
Thanks to Randy, Andy, Gregoire and Thomas for helping us to detect
and solve the issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2009-01-06 19:06:07 +00:00
|
|
|
core->gate_ctrl = NULL;
|
|
|
|
|
2006-12-02 23:15:51 +00:00
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2006-12-02 23:15:51 +00:00
|
|
|
static struct cx8802_driver cx8802_dvb_driver = {
|
|
|
|
.type_id = CX88_MPEG_DVB,
|
|
|
|
.hw_access = CX8802_DRVCTL_SHARED,
|
|
|
|
.probe = cx8802_dvb_probe,
|
|
|
|
.remove = cx8802_dvb_remove,
|
|
|
|
.advise_acquire = cx8802_dvb_advise_acquire,
|
|
|
|
.advise_release = cx8802_dvb_advise_release,
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
2009-07-16 23:00:01 +00:00
|
|
|
static int __init dvb_init(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2016-11-13 12:07:38 +00:00
|
|
|
pr_info("cx2388x dvb driver version %s loaded\n", CX88_VERSION);
|
2006-12-02 23:15:51 +00:00
|
|
|
return cx8802_register_driver(&cx8802_dvb_driver);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2009-07-16 23:00:01 +00:00
|
|
|
static void __exit dvb_fini(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-12-02 23:15:51 +00:00
|
|
|
cx8802_unregister_driver(&cx8802_dvb_driver);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
module_init(dvb_init);
|
|
|
|
module_exit(dvb_fini);
|