2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Handle incoming frames
|
|
|
|
* Linux ethernet bridge
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Lennert Buytenhek <buytenh@gnu.org>
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version
|
|
|
|
* 2 of the License, or (at your option) any later version.
|
|
|
|
*/
|
|
|
|
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/netdevice.h>
|
|
|
|
#include <linux/etherdevice.h>
|
|
|
|
#include <linux/netfilter_bridge.h>
|
2011-07-15 15:47:34 +00:00
|
|
|
#include <linux/export.h>
|
2013-02-13 12:00:10 +00:00
|
|
|
#include <linux/rculist.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "br_private.h"
|
|
|
|
|
2010-11-15 06:38:11 +00:00
|
|
|
/* Hook for brouter */
|
|
|
|
br_should_route_hook_t __rcu *br_should_route_hook __read_mostly;
|
|
|
|
EXPORT_SYMBOL(br_should_route_hook);
|
|
|
|
|
2010-02-27 19:41:40 +00:00
|
|
|
static int br_pass_frame_up(struct sk_buff *skb)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2010-02-27 19:41:40 +00:00
|
|
|
struct net_device *indev, *brdev = BR_INPUT_SKB_CB(skb)->brdev;
|
2010-03-02 13:32:09 +00:00
|
|
|
struct net_bridge *br = netdev_priv(brdev);
|
2014-01-04 05:57:59 +00:00
|
|
|
struct pcpu_sw_netstats *brstats = this_cpu_ptr(br->stats);
|
2014-03-28 01:51:18 +00:00
|
|
|
struct net_port_vlans *pv;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-06-23 20:00:48 +00:00
|
|
|
u64_stats_update_begin(&brstats->syncp);
|
2010-03-02 13:32:09 +00:00
|
|
|
brstats->rx_packets++;
|
|
|
|
brstats->rx_bytes += skb->len;
|
2010-06-23 20:00:48 +00:00
|
|
|
u64_stats_update_end(&brstats->syncp);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2013-02-13 12:00:11 +00:00
|
|
|
/* Bridge is just like any other port. Make sure the
|
|
|
|
* packet is allowed except in promisc modue when someone
|
|
|
|
* may be running packet capture.
|
|
|
|
*/
|
2014-03-28 01:51:18 +00:00
|
|
|
pv = br_get_vlan_info(br);
|
2013-02-13 12:00:11 +00:00
|
|
|
if (!(brdev->flags & IFF_PROMISC) &&
|
2014-03-28 01:51:18 +00:00
|
|
|
!br_allowed_egress(br, pv, skb)) {
|
2013-02-13 12:00:11 +00:00
|
|
|
kfree_skb(skb);
|
|
|
|
return NET_RX_DROP;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
indev = skb->dev;
|
2008-05-21 21:13:47 +00:00
|
|
|
skb->dev = brdev;
|
2014-03-28 01:51:18 +00:00
|
|
|
skb = br_handle_vlan(br, pv, skb);
|
|
|
|
if (!skb)
|
|
|
|
return NET_RX_DROP;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-03-23 03:07:21 +00:00
|
|
|
return NF_HOOK(NFPROTO_BRIDGE, NF_BR_LOCAL_IN, skb, indev, NULL,
|
2010-02-27 19:41:40 +00:00
|
|
|
netif_receive_skb);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-07-27 08:26:30 +00:00
|
|
|
/* note: already called with rcu_read_lock */
|
2005-04-16 22:20:36 +00:00
|
|
|
int br_handle_frame_finish(struct sk_buff *skb)
|
|
|
|
{
|
|
|
|
const unsigned char *dest = eth_hdr(skb)->h_dest;
|
2010-06-15 06:50:45 +00:00
|
|
|
struct net_bridge_port *p = br_port_get_rcu(skb->dev);
|
2006-02-10 01:08:52 +00:00
|
|
|
struct net_bridge *br;
|
2005-04-16 22:20:36 +00:00
|
|
|
struct net_bridge_fdb_entry *dst;
|
2010-02-27 19:41:48 +00:00
|
|
|
struct net_bridge_mdb_entry *mdst;
|
2007-09-16 23:20:48 +00:00
|
|
|
struct sk_buff *skb2;
|
2013-06-05 14:08:01 +00:00
|
|
|
bool unicast = true;
|
2013-02-13 12:00:14 +00:00
|
|
|
u16 vid = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-02-10 01:08:52 +00:00
|
|
|
if (!p || p->state == BR_STATE_DISABLED)
|
|
|
|
goto drop;
|
|
|
|
|
2013-02-13 12:00:14 +00:00
|
|
|
if (!br_allowed_ingress(p->br, nbp_get_vlan_info(p), skb, &vid))
|
2014-04-09 08:00:30 +00:00
|
|
|
goto out;
|
2013-02-13 12:00:10 +00:00
|
|
|
|
2005-05-29 21:15:55 +00:00
|
|
|
/* insert into forwarding database after filtering to avoid spoofing */
|
2006-02-10 01:08:52 +00:00
|
|
|
br = p->br;
|
2013-06-05 14:08:00 +00:00
|
|
|
if (p->flags & BR_LEARNING)
|
bridge: Fix the way to find old local fdb entries in br_fdb_changeaddr
br_fdb_changeaddr() assumes that there is at most one local entry per port
per vlan. It used to be true, but since commit 36fd2b63e3b4 ("bridge: allow
creating/deleting fdb entries via netlink"), it has not been so.
Therefore, the function might fail to search a correct previous address
to be deleted and delete an arbitrary local entry if user has added local
entries manually.
Example of problematic case:
ip link set eth0 address ee:ff:12:34:56:78
brctl addif br0 eth0
bridge fdb add 12:34:56:78:90:ab dev eth0 master
ip link set eth0 address aa:bb:cc:dd:ee:ff
Then, the address 12:34:56:78:90:ab might be deleted instead of
ee:ff:12:34:56:78, the original mac address of eth0.
Address this issue by introducing a new flag, added_by_user, to struct
net_bridge_fdb_entry.
Note that br_fdb_delete_by_port() has to set added_by_user to 0 in cases
like:
ip link set eth0 address 12:34:56:78:90:ab
ip link set eth1 address aa:bb:cc:dd:ee:ff
brctl addif br0 eth0
bridge fdb add aa:bb:cc:dd:ee:ff dev eth0 master
brctl addif br0 eth1
brctl delif br0 eth0
In this case, kernel should delete the user-added entry aa:bb:cc:dd:ee:ff,
but it also should have been added by "brctl addif br0 eth1" originally,
so we don't delete it and treat it a new kernel-created entry.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-02-07 07:48:18 +00:00
|
|
|
br_fdb_update(br, p, eth_hdr(skb)->h_source, vid, false);
|
2005-05-29 21:15:55 +00:00
|
|
|
|
2011-07-05 13:58:33 +00:00
|
|
|
if (!is_broadcast_ether_addr(dest) && is_multicast_ether_addr(dest) &&
|
2013-10-28 19:45:07 +00:00
|
|
|
br_multicast_rcv(br, p, skb, vid))
|
2010-02-27 19:41:48 +00:00
|
|
|
goto drop;
|
|
|
|
|
2006-02-10 01:08:52 +00:00
|
|
|
if (p->state == BR_STATE_LEARNING)
|
|
|
|
goto drop;
|
2005-12-22 03:00:18 +00:00
|
|
|
|
2010-02-27 19:41:40 +00:00
|
|
|
BR_INPUT_SKB_CB(skb)->brdev = br->dev;
|
|
|
|
|
2007-09-16 23:20:48 +00:00
|
|
|
/* The packet skb2 goes to the local host (NULL to skip). */
|
|
|
|
skb2 = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-09-16 23:20:48 +00:00
|
|
|
if (br->dev->flags & IFF_PROMISC)
|
|
|
|
skb2 = skb;
|
|
|
|
|
|
|
|
dst = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2013-06-05 14:08:01 +00:00
|
|
|
if (is_broadcast_ether_addr(dest)) {
|
2011-07-05 13:58:33 +00:00
|
|
|
skb2 = skb;
|
2013-06-05 14:08:01 +00:00
|
|
|
unicast = false;
|
|
|
|
} else if (is_multicast_ether_addr(dest)) {
|
2013-03-07 03:05:33 +00:00
|
|
|
mdst = br_mdb_get(br, skb, vid);
|
2013-07-31 23:06:20 +00:00
|
|
|
if ((mdst || BR_INPUT_SKB_CB_MROUTERS_ONLY(skb)) &&
|
2013-08-30 15:28:17 +00:00
|
|
|
br_multicast_querier_exists(br, eth_hdr(skb))) {
|
2011-02-12 09:05:42 +00:00
|
|
|
if ((mdst && mdst->mglist) ||
|
2010-02-27 19:41:48 +00:00
|
|
|
br_multicast_is_router(br))
|
|
|
|
skb2 = skb;
|
|
|
|
br_multicast_forward(mdst, skb, skb2);
|
|
|
|
skb = NULL;
|
|
|
|
if (!skb2)
|
|
|
|
goto out;
|
|
|
|
} else
|
|
|
|
skb2 = skb;
|
|
|
|
|
2013-06-05 14:08:01 +00:00
|
|
|
unicast = false;
|
2008-05-21 21:13:47 +00:00
|
|
|
br->dev->stats.multicast++;
|
2013-02-13 12:00:16 +00:00
|
|
|
} else if ((dst = __br_fdb_get(br, dest, vid)) &&
|
|
|
|
dst->is_local) {
|
2007-09-16 23:20:48 +00:00
|
|
|
skb2 = skb;
|
|
|
|
/* Do not forward the packet since it's local. */
|
|
|
|
skb = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2007-09-16 23:20:48 +00:00
|
|
|
if (skb) {
|
2011-04-04 14:03:28 +00:00
|
|
|
if (dst) {
|
|
|
|
dst->used = jiffies;
|
2010-03-16 07:26:22 +00:00
|
|
|
br_forward(dst->dst, skb, skb2);
|
2011-04-04 14:03:28 +00:00
|
|
|
} else
|
2013-06-05 14:08:01 +00:00
|
|
|
br_flood_forward(br, skb, skb2, unicast);
|
2007-09-16 23:20:48 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-02-27 19:41:39 +00:00
|
|
|
if (skb2)
|
2010-02-27 19:41:40 +00:00
|
|
|
return br_pass_frame_up(skb2);
|
2010-02-27 19:41:39 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
out:
|
|
|
|
return 0;
|
2006-02-10 01:08:52 +00:00
|
|
|
drop:
|
|
|
|
kfree_skb(skb);
|
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2014-09-18 09:29:03 +00:00
|
|
|
EXPORT_SYMBOL_GPL(br_handle_frame_finish);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-07-27 08:26:30 +00:00
|
|
|
/* note: already called with rcu_read_lock */
|
2006-03-21 06:59:06 +00:00
|
|
|
static int br_handle_local_finish(struct sk_buff *skb)
|
|
|
|
{
|
2010-06-15 06:50:45 +00:00
|
|
|
struct net_bridge_port *p = br_port_get_rcu(skb->dev);
|
2013-02-13 12:00:16 +00:00
|
|
|
u16 vid = 0;
|
2006-03-21 06:59:06 +00:00
|
|
|
|
2014-05-26 06:15:53 +00:00
|
|
|
/* check if vlan is allowed, to avoid spoofing */
|
|
|
|
if (p->flags & BR_LEARNING && br_should_learn(p, skb, &vid))
|
bridge: Fix the way to find old local fdb entries in br_fdb_changeaddr
br_fdb_changeaddr() assumes that there is at most one local entry per port
per vlan. It used to be true, but since commit 36fd2b63e3b4 ("bridge: allow
creating/deleting fdb entries via netlink"), it has not been so.
Therefore, the function might fail to search a correct previous address
to be deleted and delete an arbitrary local entry if user has added local
entries manually.
Example of problematic case:
ip link set eth0 address ee:ff:12:34:56:78
brctl addif br0 eth0
bridge fdb add 12:34:56:78:90:ab dev eth0 master
ip link set eth0 address aa:bb:cc:dd:ee:ff
Then, the address 12:34:56:78:90:ab might be deleted instead of
ee:ff:12:34:56:78, the original mac address of eth0.
Address this issue by introducing a new flag, added_by_user, to struct
net_bridge_fdb_entry.
Note that br_fdb_delete_by_port() has to set added_by_user to 0 in cases
like:
ip link set eth0 address 12:34:56:78:90:ab
ip link set eth1 address aa:bb:cc:dd:ee:ff
brctl addif br0 eth0
bridge fdb add aa:bb:cc:dd:ee:ff dev eth0 master
brctl addif br0 eth1
brctl delif br0 eth0
In this case, kernel should delete the user-added entry aa:bb:cc:dd:ee:ff,
but it also should have been added by "brctl addif br0 eth1" originally,
so we don't delete it and treat it a new kernel-created entry.
Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-02-07 07:48:18 +00:00
|
|
|
br_fdb_update(p->br, p, eth_hdr(skb)->h_source, vid, false);
|
2006-03-21 06:59:06 +00:00
|
|
|
return 0; /* process further */
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
2007-03-21 20:38:47 +00:00
|
|
|
* Return NULL if skb is handled
|
2010-07-27 08:26:30 +00:00
|
|
|
* note: already called with rcu_read_lock
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2011-03-12 03:14:39 +00:00
|
|
|
rx_handler_result_t br_handle_frame(struct sk_buff **pskb)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2010-06-01 21:52:08 +00:00
|
|
|
struct net_bridge_port *p;
|
2011-03-12 03:14:39 +00:00
|
|
|
struct sk_buff *skb = *pskb;
|
2005-04-16 22:20:36 +00:00
|
|
|
const unsigned char *dest = eth_hdr(skb)->h_dest;
|
2010-11-15 06:38:11 +00:00
|
|
|
br_should_route_hook_t *rhook;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-08-22 17:35:32 +00:00
|
|
|
if (unlikely(skb->pkt_type == PACKET_LOOPBACK))
|
2011-03-12 03:14:39 +00:00
|
|
|
return RX_HANDLER_PASS;
|
2010-06-01 21:52:08 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!is_valid_ether_addr(eth_hdr(skb)->h_source))
|
2007-03-21 20:42:06 +00:00
|
|
|
goto drop;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-10-14 07:39:01 +00:00
|
|
|
skb = skb_share_check(skb, GFP_ATOMIC);
|
|
|
|
if (!skb)
|
2011-03-12 03:14:39 +00:00
|
|
|
return RX_HANDLER_CONSUMED;
|
2007-10-14 07:39:01 +00:00
|
|
|
|
2010-06-15 06:50:45 +00:00
|
|
|
p = br_port_get_rcu(skb->dev);
|
2010-06-01 21:52:08 +00:00
|
|
|
|
2012-11-01 09:11:11 +00:00
|
|
|
if (unlikely(is_link_local_ether_addr(dest))) {
|
2014-06-10 11:59:24 +00:00
|
|
|
u16 fwd_mask = p->br->group_fwd_mask_required;
|
|
|
|
|
2011-10-03 18:14:46 +00:00
|
|
|
/*
|
|
|
|
* See IEEE 802.1D Table 7-10 Reserved addresses
|
|
|
|
*
|
|
|
|
* Assignment Value
|
|
|
|
* Bridge Group Address 01-80-C2-00-00-00
|
|
|
|
* (MAC Control) 802.3 01-80-C2-00-00-01
|
|
|
|
* (Link Aggregation) 802.3 01-80-C2-00-00-02
|
|
|
|
* 802.1X PAE address 01-80-C2-00-00-03
|
|
|
|
*
|
|
|
|
* 802.1AB LLDP 01-80-C2-00-00-0E
|
|
|
|
*
|
|
|
|
* Others reserved for future standardization
|
|
|
|
*/
|
|
|
|
switch (dest[5]) {
|
|
|
|
case 0x00: /* Bridge Group Address */
|
|
|
|
/* If STP is turned off,
|
|
|
|
then must forward to keep loop detection */
|
2014-06-10 11:59:24 +00:00
|
|
|
if (p->br->stp_enabled == BR_NO_STP ||
|
|
|
|
fwd_mask & (1u << dest[5]))
|
2011-10-03 18:14:46 +00:00
|
|
|
goto forward;
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 0x01: /* IEEE MAC (Pause) */
|
2007-04-26 05:05:55 +00:00
|
|
|
goto drop;
|
|
|
|
|
2011-10-03 18:14:46 +00:00
|
|
|
default:
|
|
|
|
/* Allow selective forwarding for most other protocols */
|
2014-06-10 11:59:24 +00:00
|
|
|
fwd_mask |= p->br->group_fwd_mask;
|
|
|
|
if (fwd_mask & (1u << dest[5]))
|
2011-10-03 18:14:46 +00:00
|
|
|
goto forward;
|
|
|
|
}
|
2009-05-15 06:10:13 +00:00
|
|
|
|
2011-10-03 18:14:46 +00:00
|
|
|
/* Deliver packet to local host only */
|
2010-03-23 03:07:21 +00:00
|
|
|
if (NF_HOOK(NFPROTO_BRIDGE, NF_BR_LOCAL_IN, skb, skb->dev,
|
2011-03-12 03:14:39 +00:00
|
|
|
NULL, br_handle_local_finish)) {
|
|
|
|
return RX_HANDLER_CONSUMED; /* consumed by filter */
|
|
|
|
} else {
|
|
|
|
*pskb = skb;
|
|
|
|
return RX_HANDLER_PASS; /* continue processing */
|
|
|
|
}
|
2007-04-26 05:05:55 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-05-15 06:10:13 +00:00
|
|
|
forward:
|
2007-03-21 20:42:06 +00:00
|
|
|
switch (p->state) {
|
|
|
|
case BR_STATE_FORWARDING:
|
2007-11-29 12:58:58 +00:00
|
|
|
rhook = rcu_dereference(br_should_route_hook);
|
2010-11-15 06:38:11 +00:00
|
|
|
if (rhook) {
|
2011-03-12 03:14:39 +00:00
|
|
|
if ((*rhook)(skb)) {
|
|
|
|
*pskb = skb;
|
|
|
|
return RX_HANDLER_PASS;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
dest = eth_hdr(skb)->h_dest;
|
|
|
|
}
|
2007-03-21 20:42:06 +00:00
|
|
|
/* fall through */
|
|
|
|
case BR_STATE_LEARNING:
|
bridge: Convert compare_ether_addr to ether_addr_equal
Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.
Done via cocci script:
$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
- !compare_ether_addr(a, b)
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- compare_ether_addr(a, b)
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) == 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !ether_addr_equal(a, b) != 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) == 0
+ !ether_addr_equal(a, b)
@@
expression a,b;
@@
- ether_addr_equal(a, b) != 0
+ ether_addr_equal(a, b)
@@
expression a,b;
@@
- !!ether_addr_equal(a, b)
+ ether_addr_equal(a, b)
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-05-08 18:56:49 +00:00
|
|
|
if (ether_addr_equal(p->br->dev->dev_addr, dest))
|
2005-04-16 22:20:36 +00:00
|
|
|
skb->pkt_type = PACKET_HOST;
|
|
|
|
|
2010-03-23 03:07:21 +00:00
|
|
|
NF_HOOK(NFPROTO_BRIDGE, NF_BR_PRE_ROUTING, skb, skb->dev, NULL,
|
2005-04-16 22:20:36 +00:00
|
|
|
br_handle_frame_finish);
|
2007-03-21 20:42:06 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
drop:
|
|
|
|
kfree_skb(skb);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2011-03-12 03:14:39 +00:00
|
|
|
return RX_HANDLER_CONSUMED;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|