2005-04-16 22:20:36 +00:00
|
|
|
#
|
|
|
|
|
# Multimedia device configuration
|
|
|
|
|
#
|
|
|
|
|
|
2009-05-19 01:00:34 +00:00
|
|
|
menuconfig MEDIA_SUPPORT
|
|
|
|
|
tristate "Multimedia support"
|
2007-05-10 13:45:57 +00:00
|
|
|
depends on HAS_IOMEM
|
2009-05-19 01:00:34 +00:00
|
|
|
help
|
2012-05-28 11:17:47 +00:00
|
|
|
If you want to use Webcams, Video grabber devices and/or TV devices
|
2009-05-19 01:00:34 +00:00
|
|
|
enable this option and other options below.
|
2012-05-28 11:17:47 +00:00
|
|
|
Additional info and docs are available on the web at
|
|
|
|
|
<http://linuxtv.org>
|
2009-05-19 01:00:34 +00:00
|
|
|
|
|
|
|
|
if MEDIA_SUPPORT
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-30 00:38:44 +00:00
|
|
|
comment "Multimedia core support"
|
|
|
|
|
|
2012-05-28 11:17:47 +00:00
|
|
|
#
|
|
|
|
|
# Multimedia support - automatically enable V4L2 and DVB core
|
|
|
|
|
#
|
|
|
|
|
config MEDIA_CAMERA_SUPPORT
|
|
|
|
|
bool "Cameras/video grabbers support"
|
|
|
|
|
---help---
|
|
|
|
|
Enable support for webcams and video grabbers.
|
|
|
|
|
|
|
|
|
|
Say Y when you have a webcam or a video capture grabber board.
|
|
|
|
|
|
|
|
|
|
config MEDIA_ANALOG_TV_SUPPORT
|
|
|
|
|
bool "Analog TV support"
|
|
|
|
|
---help---
|
|
|
|
|
Enable analog TV support.
|
|
|
|
|
|
|
|
|
|
Say Y when you have a TV board with analog support or with a
|
|
|
|
|
hybrid analog/digital TV chipset.
|
|
|
|
|
|
|
|
|
|
Note: There are several DVB cards that are based on chips that
|
|
|
|
|
support both analog and digital TV. Disabling this option
|
|
|
|
|
will disable support for them.
|
|
|
|
|
|
|
|
|
|
config MEDIA_DIGITAL_TV_SUPPORT
|
|
|
|
|
bool "Digital TV support"
|
|
|
|
|
---help---
|
|
|
|
|
Enable digital TV support.
|
|
|
|
|
|
|
|
|
|
Say Y when you have a board with digital support or a board with
|
|
|
|
|
hybrid digital TV and analog TV.
|
|
|
|
|
|
|
|
|
|
config MEDIA_RADIO_SUPPORT
|
|
|
|
|
bool "AM/FM radio receivers/transmitters support"
|
|
|
|
|
---help---
|
|
|
|
|
Enable AM/FM radio support.
|
|
|
|
|
|
|
|
|
|
Additional info and docs are available on the web at
|
|
|
|
|
<http://linuxtv.org>
|
|
|
|
|
|
|
|
|
|
Say Y when you have a board with radio support.
|
|
|
|
|
|
|
|
|
|
Note: There are several TV cards that are based on chips that
|
|
|
|
|
support radio reception. Disabling this option will
|
|
|
|
|
disable support for them.
|
|
|
|
|
|
2014-07-13 00:43:12 +00:00
|
|
|
config MEDIA_SDR_SUPPORT
|
|
|
|
|
bool "Software defined radio support"
|
|
|
|
|
---help---
|
|
|
|
|
Enable software defined radio support.
|
|
|
|
|
|
|
|
|
|
Say Y when you have a software defined radio device.
|
|
|
|
|
|
2012-07-06 12:12:59 +00:00
|
|
|
config MEDIA_RC_SUPPORT
|
2012-05-28 11:17:47 +00:00
|
|
|
bool "Remote Controller support"
|
|
|
|
|
depends on INPUT
|
|
|
|
|
---help---
|
|
|
|
|
Enable support for Remote Controllers on Linux. This is
|
|
|
|
|
needed in order to support several video capture adapters,
|
|
|
|
|
standalone IR receivers/transmitters, and RF receivers.
|
|
|
|
|
|
|
|
|
|
Enable this option if you have a video capture board even
|
|
|
|
|
if you don't need IR, as otherwise, you may not be able to
|
|
|
|
|
compile the driver for your adapter.
|
|
|
|
|
|
|
|
|
|
Say Y when you have a TV or an IR device.
|
|
|
|
|
|
2009-12-09 11:39:56 +00:00
|
|
|
#
|
|
|
|
|
# Media controller
|
2012-05-28 11:17:47 +00:00
|
|
|
# Selectable only for webcam/grabbers, as other drivers don't use it
|
2009-12-09 11:39:56 +00:00
|
|
|
#
|
|
|
|
|
|
|
|
|
|
config MEDIA_CONTROLLER
|
2012-10-02 18:17:27 +00:00
|
|
|
bool "Media Controller API"
|
2015-01-02 15:19:51 +00:00
|
|
|
depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT
|
2009-12-09 11:39:56 +00:00
|
|
|
---help---
|
|
|
|
|
Enable the media controller API used to query media devices internal
|
|
|
|
|
topology and configure it dynamically.
|
|
|
|
|
|
|
|
|
|
This API is mostly used by camera interfaces in embedded platforms.
|
|
|
|
|
|
2015-01-02 15:19:51 +00:00
|
|
|
config MEDIA_CONTROLLER_DVB
|
2015-05-06 14:26:13 +00:00
|
|
|
bool "Enable Media controller for DVB (EXPERIMENTAL)"
|
2015-01-02 15:19:51 +00:00
|
|
|
depends on MEDIA_CONTROLLER
|
Kconfig: disable Media Controller for DVB
Since when we start discussions about the usage Media Controller for
complex hardware, one thing become clear: the way it is, MC fails to
map anything different than capture/output/m2m video-only streaming.
The point is that MC has entities named as devnodes, but the only
devnode used (before the DVB patches) is MEDIA_ENT_T_DEVNODE_V4L.
Due to the way MC got implemented, however, this entity actually
doesn't represent the devnode, but the hardware I/O engine that
receives data via DMA.
By coincidence, such DMA is associated with the V4L device node
on webcam hardware, but this is not true even for other V4L2
devices. For example, on USB hardware, the DMA is done via the
USB controller. The data passes though a in-kernel filter that
strips off the URB headers. Other V4L2 devices like radio may not
even have DMA. When it have, the DMA is done via ALSA, and not
via the V4L devnode.
In other words, MC is broken as a whole, but tagging it as BROKEN
right now would do more harm than good.
So, instead, let's mark, for now, the DVB part as broken and
block all new changes to MC while we fix this mess, whith
we hopefully will do for the next Kernel version.
Requested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-06-16 09:26:59 +00:00
|
|
|
depends on BROKEN
|
2015-01-02 15:19:51 +00:00
|
|
|
---help---
|
|
|
|
|
Enable the media controller API support for DVB.
|
|
|
|
|
|
|
|
|
|
This is currently experimental.
|
|
|
|
|
|
2008-04-30 00:38:44 +00:00
|
|
|
#
|
2012-05-28 11:17:47 +00:00
|
|
|
# Video4Linux support
|
|
|
|
|
# Only enables if one of the V4L2 types (ATV, webcam, radio) is selected
|
2008-04-30 00:38:44 +00:00
|
|
|
#
|
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
config VIDEO_DEV
|
2012-05-28 11:17:47 +00:00
|
|
|
tristate
|
|
|
|
|
depends on MEDIA_SUPPORT
|
2014-07-13 00:43:12 +00:00
|
|
|
depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
|
2012-05-28 11:17:47 +00:00
|
|
|
default y
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-05-21 09:04:24 +00:00
|
|
|
config VIDEO_V4L2_SUBDEV_API
|
2012-10-02 18:17:27 +00:00
|
|
|
bool "V4L2 sub-device userspace API"
|
|
|
|
|
depends on VIDEO_DEV && MEDIA_CONTROLLER
|
2010-05-21 09:04:24 +00:00
|
|
|
---help---
|
|
|
|
|
Enables the V4L2 sub-device pad-level userspace API used to configure
|
|
|
|
|
video format, size and frame rate between hardware blocks.
|
|
|
|
|
|
|
|
|
|
This API is mostly used by camera interfaces in embedded platforms.
|
|
|
|
|
|
2012-08-14 19:07:25 +00:00
|
|
|
source "drivers/media/v4l2-core/Kconfig"
|
|
|
|
|
|
2008-04-30 00:38:44 +00:00
|
|
|
#
|
|
|
|
|
# DVB Core
|
2012-05-28 11:17:47 +00:00
|
|
|
# Only enables if one of DTV is selected
|
2008-04-30 00:38:44 +00:00
|
|
|
#
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-30 00:38:44 +00:00
|
|
|
config DVB_CORE
|
2012-05-28 11:17:47 +00:00
|
|
|
tristate
|
|
|
|
|
depends on MEDIA_SUPPORT
|
|
|
|
|
depends on MEDIA_DIGITAL_TV_SUPPORT
|
|
|
|
|
default y
|
2008-04-30 00:38:44 +00:00
|
|
|
select CRC32
|
2007-08-28 00:59:35 +00:00
|
|
|
|
2011-05-23 12:43:35 +00:00
|
|
|
config DVB_NET
|
|
|
|
|
bool "DVB Network Support"
|
|
|
|
|
default (NET && INET)
|
2011-06-10 10:43:26 +00:00
|
|
|
depends on NET && INET && DVB_CORE
|
2011-05-23 12:43:35 +00:00
|
|
|
help
|
2011-06-16 19:06:56 +00:00
|
|
|
This option enables DVB Network Support which is a part of the DVB
|
|
|
|
|
standard. It is used, for example, by automatic firmware updates used
|
|
|
|
|
on Set-Top-Boxes. It can also be used to access the Internet via the
|
|
|
|
|
DVB card, if the network provider supports it.
|
2011-05-23 12:43:35 +00:00
|
|
|
|
2011-06-16 19:06:56 +00:00
|
|
|
You may want to disable the network support on embedded devices. If
|
|
|
|
|
unsure say Y.
|
2011-05-23 12:43:35 +00:00
|
|
|
|
2012-12-27 16:43:41 +00:00
|
|
|
# This Kconfig option is used by both PCI and USB drivers
|
|
|
|
|
config TTPCI_EEPROM
|
[media] Fix build when drivers are builtin and frontend modules
There are a large number of reports that the media build is
not compiling when some drivers are compiled as builtin, while
the needed frontends are compiled as module.
On the last one of such reports:
From: kbuild test robot <fengguang.wu@intel.com>
Subject: saa7134-dvb.c:undefined reference to `zl10039_attach'
The .config file has:
CONFIG_VIDEO_SAA7134=y
CONFIG_VIDEO_SAA7134_DVB=y
# CONFIG_MEDIA_ATTACH is not set
CONFIG_DVB_ZL10039=m
And it produces all those errors:
drivers/built-in.o: In function `set_type':
tuner-core.c:(.text+0x2f263e): undefined reference to `tea5767_attach'
tuner-core.c:(.text+0x2f273e): undefined reference to `tda9887_attach'
drivers/built-in.o: In function `tuner_probe':
tuner-core.c:(.text+0x2f2d20): undefined reference to `tea5767_autodetection'
drivers/built-in.o: In function `av7110_attach':
av7110.c:(.text+0x330bda): undefined reference to `ves1x93_attach'
av7110.c:(.text+0x330bf7): undefined reference to `stv0299_attach'
av7110.c:(.text+0x330c63): undefined reference to `tda8083_attach'
av7110.c:(.text+0x330d09): undefined reference to `ves1x93_attach'
av7110.c:(.text+0x330d33): undefined reference to `tda8083_attach'
av7110.c:(.text+0x330d5d): undefined reference to `stv0297_attach'
av7110.c:(.text+0x330dbe): undefined reference to `stv0299_attach'
drivers/built-in.o: In function `tuner_attach_dtt7520x':
ngene-cards.c:(.text+0x3381cb): undefined reference to `dvb_pll_attach'
drivers/built-in.o: In function `demod_attach_lg330x':
ngene-cards.c:(.text+0x33828a): undefined reference to `lgdt330x_attach'
drivers/built-in.o: In function `demod_attach_stv0900':
ngene-cards.c:(.text+0x3383d5): undefined reference to `stv090x_attach'
drivers/built-in.o: In function `cineS2_probe':
ngene-cards.c:(.text+0x338b7f): undefined reference to `drxk_attach'
drivers/built-in.o: In function `configure_tda827x_fe':
saa7134-dvb.c:(.text+0x346ae7): undefined reference to `tda10046_attach'
drivers/built-in.o: In function `dvb_init':
saa7134-dvb.c:(.text+0x347283): undefined reference to `mt352_attach'
saa7134-dvb.c:(.text+0x3472cd): undefined reference to `mt352_attach'
saa7134-dvb.c:(.text+0x34731c): undefined reference to `tda10046_attach'
saa7134-dvb.c:(.text+0x34733c): undefined reference to `tda10046_attach'
saa7134-dvb.c:(.text+0x34735c): undefined reference to `tda10046_attach'
saa7134-dvb.c:(.text+0x347378): undefined reference to `tda10046_attach'
saa7134-dvb.c:(.text+0x3473db): undefined reference to `tda10046_attach'
drivers/built-in.o:saa7134-dvb.c:(.text+0x347502): more undefined references to `tda10046_attach' follow
drivers/built-in.o: In function `dvb_init':
saa7134-dvb.c:(.text+0x347812): undefined reference to `mt352_attach'
saa7134-dvb.c:(.text+0x347951): undefined reference to `mt312_attach'
saa7134-dvb.c:(.text+0x3479a9): undefined reference to `mt312_attach'
>> saa7134-dvb.c:(.text+0x3479c1): undefined reference to `zl10039_attach'
This is happening because a builtin module can't use directly a symbol
found on a module. By enabling CONFIG_MEDIA_ATTACH, the configuration
becomes valid, as dvb_attach() macro loads the module if needed, making
the symbol available to the builtin module.
While this bug started to appear after the patches that use IS_DEFINED
macro (like changeset 7b34be71db533f3e0cf93d53cf62d036cdb5418a), this
bug is a way ancient than that.
The thing is that, before the IS_DEFINED() patches, the logic used to be:
&& defined(MODULE))
struct dvb_frontend *zl10039_attach(struct dvb_frontend *fe,
u8 i2c_addr,
struct i2c_adapter *i2c);
static inline struct dvb_frontend *zl10039_attach(struct dvb_frontend *fe,
u8 i2c_addr,
struct i2c_adapter *i2c)
{
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
return NULL;
}
The above code, with the .config file used, was evoluting to FALSE
(instead of TRUE as it should be, as CONFIG_DVB_ZL10039 is 'm'),
and were adding the static inline code at saa7134-dvb, instead
of the external call. So, while it weren't producing any compilation
error, the code weren't working either.
So, as the overhead for using CONFIG_MEDIA_ATTACH is minimal, just
enable it, if MODULES is defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2013-06-20 13:35:53 +00:00
|
|
|
tristate
|
|
|
|
|
depends on I2C
|
|
|
|
|
default n
|
2012-12-27 16:43:41 +00:00
|
|
|
|
2012-08-14 19:07:25 +00:00
|
|
|
source "drivers/media/dvb-core/Kconfig"
|
|
|
|
|
|
2012-07-06 12:12:59 +00:00
|
|
|
comment "Media drivers"
|
2010-11-10 02:00:14 +00:00
|
|
|
source "drivers/media/rc/Kconfig"
|
2007-08-23 19:37:49 +00:00
|
|
|
|
2008-04-30 00:38:44 +00:00
|
|
|
#
|
2012-08-14 19:23:43 +00:00
|
|
|
# V4L platform/mem2mem drivers
|
2008-04-30 00:38:44 +00:00
|
|
|
#
|
2007-06-25 18:42:01 +00:00
|
|
|
|
2012-06-14 19:35:56 +00:00
|
|
|
source "drivers/media/usb/Kconfig"
|
2012-08-20 13:02:05 +00:00
|
|
|
source "drivers/media/pci/Kconfig"
|
|
|
|
|
source "drivers/media/platform/Kconfig"
|
2012-06-14 19:36:01 +00:00
|
|
|
source "drivers/media/mmc/Kconfig"
|
2012-08-20 13:02:05 +00:00
|
|
|
source "drivers/media/radio/Kconfig"
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-06-14 19:35:55 +00:00
|
|
|
comment "Supported FireWire (IEEE 1394) Adapters"
|
|
|
|
|
depends on DVB_CORE && FIREWIRE
|
|
|
|
|
source "drivers/media/firewire/Kconfig"
|
|
|
|
|
|
2012-08-20 13:02:05 +00:00
|
|
|
# Common driver options
|
2012-06-14 19:35:58 +00:00
|
|
|
source "drivers/media/common/Kconfig"
|
|
|
|
|
|
2012-12-22 10:48:58 +00:00
|
|
|
comment "Media ancillary drivers (tuners, sensors, i2c, frontends)"
|
|
|
|
|
|
2012-08-20 13:02:05 +00:00
|
|
|
#
|
|
|
|
|
# Ancillary drivers (tuners, i2c, frontends)
|
|
|
|
|
#
|
|
|
|
|
|
2012-08-20 17:48:02 +00:00
|
|
|
config MEDIA_SUBDRV_AUTOSELECT
|
2012-12-22 10:48:58 +00:00
|
|
|
bool "Autoselect ancillary drivers (tuners, sensors, i2c, frontends)"
|
2014-07-13 00:43:12 +00:00
|
|
|
depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_CAMERA_SUPPORT || MEDIA_SDR_SUPPORT
|
[media] subdev autoselect only works if I2C and I2C_MUX is selected
As reported by the kbuild test robot <fengguang.wu@intel.com>:
> warning: (VIDEO_EM28XX_DVB) selects DVB_M88DS3103 which has unmet direct dependencies (MEDIA_SUPPORT && DVB_CORE && I2C && I2C_MUX)
> drivers/built-in.o: In function `m88ds3103_release':
> >> m88ds3103.c:(.text+0x1ab1af): undefined reference to `i2c_del_mux_adapter'
> drivers/built-in.o: In function `m88ds3103_attach':
> >> (.text+0x1ab342): undefined reference to `i2c_add_mux_adapter'
There are 3 possible ways to fix it:
1) make em28xx dependent on I2C_MUX.
That sounds wrong, as the em28xx bridge doesn't have i2c muxes on it,
and just one frontend has.
Well, subdevs could eventually be converted to, instead of using dvb
i2c gate control, to use i2c mux support.
That makes sense, but it takes time and lots of effort. Not sure if
this will happen anytime soon.
2) MEDIA_SUBDRV_AUTOSELECT can be dependent of I2C and I2C_MUX.
That means that users will need to manually enable I2C_MUX on some
distributions. Not sure about others, but, on Fedora, this option is
disabled.
So, it can end by generating a number of complains from users
that their devices suddenly stopped working after a Kernel upgrade,
at least until all distros that ship Kernels with I2C_MUX enabled.
3) if MEDIA_SUBDRV_AUTOSELECT is selected, it will select I2C and I2C_MUX.
Of course, MEDIA_SUBDRV_AUTOSELECT will need to inherit all dependencies
that I2C and I2C_MUX have (only HAS_IOMEM).
The disadvantage is that, if new dependencies are added on I2C, they'll
also need to be added here.
As the hole idea of autoselect is to let the user not bother about whatever
frontend/tuner is used by a driver, IMHO, (3) is the better solution.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
2013-12-21 07:42:11 +00:00
|
|
|
depends on HAS_IOMEM
|
|
|
|
|
select I2C
|
|
|
|
|
select I2C_MUX
|
2012-08-20 17:48:02 +00:00
|
|
|
default y
|
|
|
|
|
help
|
2012-12-22 10:48:58 +00:00
|
|
|
By default, a media driver auto-selects all possible ancillary
|
|
|
|
|
devices such as tuners, sensors, video encoders/decoders and
|
|
|
|
|
frontends, that are used by any of the supported devices.
|
2012-08-20 17:48:02 +00:00
|
|
|
|
|
|
|
|
This is generally the right thing to do, except when there
|
2012-10-17 19:09:23 +00:00
|
|
|
are strict constraints with regards to the kernel size,
|
|
|
|
|
like on embedded systems.
|
2012-08-20 17:48:02 +00:00
|
|
|
|
2012-10-17 19:09:23 +00:00
|
|
|
Use this option with care, as deselecting ancillary drivers which
|
|
|
|
|
are, in fact, necessary will result in the lack of the needed
|
|
|
|
|
functionality for your device (it may not tune or may not have
|
2012-12-22 10:48:58 +00:00
|
|
|
the needed demodulators).
|
2012-08-20 17:48:02 +00:00
|
|
|
|
|
|
|
|
If unsure say Y.
|
|
|
|
|
|
[media] Fix build when drivers are builtin and frontend modules
There are a large number of reports that the media build is
not compiling when some drivers are compiled as builtin, while
the needed frontends are compiled as module.
On the last one of such reports:
From: kbuild test robot <fengguang.wu@intel.com>
Subject: saa7134-dvb.c:undefined reference to `zl10039_attach'
The .config file has:
CONFIG_VIDEO_SAA7134=y
CONFIG_VIDEO_SAA7134_DVB=y
# CONFIG_MEDIA_ATTACH is not set
CONFIG_DVB_ZL10039=m
And it produces all those errors:
drivers/built-in.o: In function `set_type':
tuner-core.c:(.text+0x2f263e): undefined reference to `tea5767_attach'
tuner-core.c:(.text+0x2f273e): undefined reference to `tda9887_attach'
drivers/built-in.o: In function `tuner_probe':
tuner-core.c:(.text+0x2f2d20): undefined reference to `tea5767_autodetection'
drivers/built-in.o: In function `av7110_attach':
av7110.c:(.text+0x330bda): undefined reference to `ves1x93_attach'
av7110.c:(.text+0x330bf7): undefined reference to `stv0299_attach'
av7110.c:(.text+0x330c63): undefined reference to `tda8083_attach'
av7110.c:(.text+0x330d09): undefined reference to `ves1x93_attach'
av7110.c:(.text+0x330d33): undefined reference to `tda8083_attach'
av7110.c:(.text+0x330d5d): undefined reference to `stv0297_attach'
av7110.c:(.text+0x330dbe): undefined reference to `stv0299_attach'
drivers/built-in.o: In function `tuner_attach_dtt7520x':
ngene-cards.c:(.text+0x3381cb): undefined reference to `dvb_pll_attach'
drivers/built-in.o: In function `demod_attach_lg330x':
ngene-cards.c:(.text+0x33828a): undefined reference to `lgdt330x_attach'
drivers/built-in.o: In function `demod_attach_stv0900':
ngene-cards.c:(.text+0x3383d5): undefined reference to `stv090x_attach'
drivers/built-in.o: In function `cineS2_probe':
ngene-cards.c:(.text+0x338b7f): undefined reference to `drxk_attach'
drivers/built-in.o: In function `configure_tda827x_fe':
saa7134-dvb.c:(.text+0x346ae7): undefined reference to `tda10046_attach'
drivers/built-in.o: In function `dvb_init':
saa7134-dvb.c:(.text+0x347283): undefined reference to `mt352_attach'
saa7134-dvb.c:(.text+0x3472cd): undefined reference to `mt352_attach'
saa7134-dvb.c:(.text+0x34731c): undefined reference to `tda10046_attach'
saa7134-dvb.c:(.text+0x34733c): undefined reference to `tda10046_attach'
saa7134-dvb.c:(.text+0x34735c): undefined reference to `tda10046_attach'
saa7134-dvb.c:(.text+0x347378): undefined reference to `tda10046_attach'
saa7134-dvb.c:(.text+0x3473db): undefined reference to `tda10046_attach'
drivers/built-in.o:saa7134-dvb.c:(.text+0x347502): more undefined references to `tda10046_attach' follow
drivers/built-in.o: In function `dvb_init':
saa7134-dvb.c:(.text+0x347812): undefined reference to `mt352_attach'
saa7134-dvb.c:(.text+0x347951): undefined reference to `mt312_attach'
saa7134-dvb.c:(.text+0x3479a9): undefined reference to `mt312_attach'
>> saa7134-dvb.c:(.text+0x3479c1): undefined reference to `zl10039_attach'
This is happening because a builtin module can't use directly a symbol
found on a module. By enabling CONFIG_MEDIA_ATTACH, the configuration
becomes valid, as dvb_attach() macro loads the module if needed, making
the symbol available to the builtin module.
While this bug started to appear after the patches that use IS_DEFINED
macro (like changeset 7b34be71db533f3e0cf93d53cf62d036cdb5418a), this
bug is a way ancient than that.
The thing is that, before the IS_DEFINED() patches, the logic used to be:
&& defined(MODULE))
struct dvb_frontend *zl10039_attach(struct dvb_frontend *fe,
u8 i2c_addr,
struct i2c_adapter *i2c);
static inline struct dvb_frontend *zl10039_attach(struct dvb_frontend *fe,
u8 i2c_addr,
struct i2c_adapter *i2c)
{
printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
return NULL;
}
The above code, with the .config file used, was evoluting to FALSE
(instead of TRUE as it should be, as CONFIG_DVB_ZL10039 is 'm'),
and were adding the static inline code at saa7134-dvb, instead
of the external call. So, while it weren't producing any compilation
error, the code weren't working either.
So, as the overhead for using CONFIG_MEDIA_ATTACH is minimal, just
enable it, if MODULES is defined.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2013-06-20 13:35:53 +00:00
|
|
|
config MEDIA_ATTACH
|
|
|
|
|
bool
|
|
|
|
|
depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT
|
|
|
|
|
depends on MODULES
|
|
|
|
|
default MODULES
|
|
|
|
|
|
2012-08-20 13:02:05 +00:00
|
|
|
source "drivers/media/i2c/Kconfig"
|
2012-08-20 17:48:02 +00:00
|
|
|
source "drivers/media/tuners/Kconfig"
|
2012-08-20 13:02:05 +00:00
|
|
|
source "drivers/media/dvb-frontends/Kconfig"
|
|
|
|
|
|
2009-05-19 01:00:34 +00:00
|
|
|
endif # MEDIA_SUPPORT
|
